Software Público Brasileiro

mentioned in issue #33

I'm missing a test for this method.

I would put this verification inside the createAccount method... also, it makes testing easier.

Added 42 new commits:

4fe8f447 - [WIP] Ticket #76: Recent activities block
734ad25f - [WIP] Ticket #76: Recent activities block: Tests, CSS and templates infrastructu…
e2745129 - Ticket #76: Adding missing templates and wrapping up
7f3632f7 - Merge branch 'master' into recent-activities
0e0e1268 - Added skins support when release a BUILD on dist directory
a2cd2949 - Remove commented code
965b4c33 - Merge branch 'skin-build-dist' into 'master'
886e0841 - Adds support for setting layout template from api
02560aee - Merge branch 'layout_support' into 'master'
14be48aa - Fix 'scss' skin path and 'angular-default' theme verification error
c4688bc6 - added readme for the theme
2f22ab31 - Merge branch 'skin-check' into 'master'
3a1d52ef - Added skin folder structure + skin and theme validation
6be9287d - Fix gramatical and text mistakes
66c3e417 - improve readme.md
e5ab24c7 - Merge branch 'skin-check' into 'master'
39ae284a - New UI for search field
8a083fd6 - Merge branch 'search-ui' into 'master'
d63e35f0 - Adding temporary fix to export button spacing
0b078626 - Merge branch 'export-comment-fix-button' into 'master'
24a44ec4 - Fixed design mode state
c3feee1a - Fixed tests
976d69f6 - Fixed custom component edit buttons state
e02d6ae5 - Fixed design mode service auth lifecycle
9ab71161 - Fixed design mode service auth lifecycle
ade7c078 - Merge branch 'fix-edit-mode-state' into 'master'
3bc8e5e6 - Fix jslint whitespaces warnings
7e29958e - Simple css :hover fix to search navbar icon
a61cb0f5 - Merge branch 'search-ui' into 'master'
8690849b - correções sugeridas no merge request !39
a4e6d1f3 - Fix master rebase @Inject() values
8f52051e - First implementation of 'Config Layout bar'
0a0686be - Refactor the 'ProfileToolbarComponent' to a new concept using 'ConfigBarComponen…
61a0811c - Configbar yellow skin change + minor sass refactory
f74c41d2 - Merge branch 'design-mode' into 'master'
011ca4fd - Change translation of new discussion button
207be9ec - Adds account register module
b7edb563 - Refactor of the account register component to uses service and restangular instead.
ebe4676d - Fixing registration - it is working now
bee74edc - add redirect to home in case of succeded signup
8863d03b - Added notification when user is created
8d9d623e - Added welcome message for translation on signup

Reassigned to @mfdeveloper

Added 2 new commits:

8e4d0b18 - Refactory html template + new environment service property
abcac913 - Added environment fields and ngMessages form validation

mentioned in issue #131

Milestone changed to 2016.07

Added 1 new commit:

a7fe2119 - Added the ng.ui.bootstrap typescript definitions

Added 1 new commit:

6b66bf91 - Added the modal to show environment terms of use text

Added 1 new commit:

ad92f9cf - Added module 'angular-password' to check password confir match

Added 1 new commit:

48884124 - Added unit tests and minor refactories

@daniela e @caiosba Finalizei as funcionalidades principais que visualizamos importante para o funcionamento do registro de usuário. No entanto, existem ainda algumas melhorias a serem realizadas:

Validar o formulário e exibir os campos com problemas de validação ao clicar no campo de submit

Atualmente, a validação ocorre somente ao mudar o foco dos campos que possuem algum pré-requisito

Adicionar testes unitários no arquivo register.component.spec.ts para os métodos singup(), isInvalid(field), e openTerms() de RegisterComponent. Houve um problema ao verificar se o serviço de notificação havia sido chamado com o método success() no teste unitário, que deve ser verificado + para frente
Verificar no servidor se o usuário informado já existe após a digitação ou após tirar foco do campo username

Uma vez que o projeto ligado ao Noosfero que atuamos está em "pausa" a partir de hoje (22/07/2016), essas alterações devem ser feitas em um outro momento, em uma outra issue/MR.

Added 18 new commits:

8784fe3c - Ticket #116: Better display of recent activities
1e4736a4 - added events-hub service
b3953cbd - improving adding a base interface EventsHubKnownEventNames
332c24ec - added changes to allow pass string[] or EventsHubKnownEventNames to EventsHubService constructor
328a7a82 - some small refactoring on class naming and changed to allow EVENTS_HUB_KNOW_EVEN…
fb1e923a - Merge branch 'events-hub' into 'master'
3d2172f3 - Adds account register module
bc91225e - Refactor of the account register component to uses service and restangular instead.
42443554 - Fixing registration - it is working now
503976b5 - add redirect to home in case of succeded signup
e10ddb2a - Added notification when user is created
716c2a26 - Added welcome message for translation on signup
74b67520 - Refactory html template + new environment service property
64b0a116 - Added environment fields and ngMessages form validation
4c25e839 - Added the ng.ui.bootstrap typescript definitions
015b68e2 - Added the modal to show environment terms of use text
224b593d - Added module 'angular-password' to check password confir match
a4dac9ec - Added unit tests and minor refactories

Added 1 new commit:

b4a0a739 - Fix rebase with master adjusts

mentioned in commit 64000ab5a564b9ee11a757d634c2ec1698838746

mentioned in issue #131

mentioned in merge request !57

	1	+import { Injectable, Inject } from "ng-forward";
	2	+import {RestangularService} from "./restangular_service";
	3	+
	4	+@Injectable()
	5	+@Inject("Restangular")
	6	+export class RegisterService {
	7	+ constructor(private Restangular: restangular.IService) {
	8	+ this.Restangular = Restangular;
	9	+ }
	10	+
	11	+ createAccount(user: noosfero.User): ng.IPromise<noosfero.RestResult<noosfero.User>> {
1		Link here Caio Almeida @caiosba 2016-07-01 13:20:51 UTC I'm missing a test for this method. Write Preview I'm missing a test for this method. Choose File ... File name... Cancel

	7	+ templateUrl: 'app/account/register-component.html',
	8	+ providers: [
	9	+ provide('registerService', { useClass: RegisterService })
	10	+ ]
	11	+})
	12	+
	13	+@Inject("$state", RegisterService, NotificationService)
	14	+export class RegisterComponent {
	15	+ @Input() account: any;
	16	+
	17	+ constructor(private $state: ng.ui.IStateService, public registerService: RegisterService, private notificationService: NotificationService) {
	18	+ this.account = {};
	19	+ }
	20	+
	21	+ signup() {
	22	+ if (this.account.password === this.account.password_confirmation) {
1		Link here Caio Almeida @caiosba 2016-07-01 13:21:24 UTC I would put this verification inside the `createAccount` method... also, it makes testing easier. Write Preview I would put this verification inside the `createAccount` method... also, it makes testing easier. Choose File ... File name... Cancel

Software Público Brasileiro

Merge Request #47

Register page

Merged by Michel Felipe 2016-07-22 18:35:09 UTC

Merge Request #47

How to merge

Register page

Merged by Michel Felipe 2016-07-22 18:35:09 UTC $('.time_ago').timeago().tooltip()

Merged by Michel Felipe 2016-07-22 18:35:09 UTC