Merge Request #58

← To merge requests From upload-profile-photo into master
Merged
noosfero-themes/angular-theme!58
Created by Carlos Purificação

Upload profile photo

Assignee: Michel Felipe
Milestone: 2016.07

Merged by Michel Felipe

Source branch has been removed
Commits (4)
2 participants
participa serpro
  • 2c5c4299d62769e3da7d432cd2823dd6?s=40&d=identicon
    Link here  
    Carlos Purificação @carloseugenio

    mentioned in issue #111

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    Reassigned to @mfdeveloper

    Choose File ...   File name...
    Cancel
    • Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/image.component.spec.ts
      34 + providers: [
      35 + helpers.createProviderToValue("PersonService", personService),
      36 + helpers.createProviderToValue("$uibModal", helpers.mocks.$modal),
      37 + helpers.createProviderToValue("$scope", scope)
      38 + ]
      39 + });
      40 + helper = new ComponentTestHelper<ProfileImageComponent>(cls, done);
      41 + });
      42 +
      43 + it("set modal instance when select files modal", () => {
      44 + helper.component['$uibModal'].open = jasmine.createSpy("open");
      45 + helper.component.fileSelected("file", []);
      46 + expect(helper.component['$uibModal'].open).toHaveBeenCalled();
      47 + });
      48 +
      49 + /*
    1
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/profile/image/image.component.ts
      52 + templateUrl: 'app/profile/image/profile-image-editor.html',
      53 + controller: ProfileImageEditorComponent,
      54 + controllerAs: 'ctrl',
      55 + scope: this.$scope,
      56 + bindToController: true,
      57 + backdrop: 'static',
      58 + resolve: {
      59 + picFile: this.picFile,
      60 + profile: this.profile,
      61 + personService: this.personService
      62 + }
      63 + });
      64 + }
      65 + }
      66 +
      67 + private _showCamera: boolean = false;
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      Estamos utilizando essa nomenclatura de prefixar atributos privados com "_" em outros componentes do projeto? Caso contrário, talvez seja importante padronizar

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/image.html
    2   - <img ng-if="ctrl.profile.image" ng-src="{{ctrl.profile.image.url}}" class="img-responsive profile-image">
    3   - <i ng-if="!ctrl.profile.image" class="fa {{ctrl.defaultIcon}} fa-5x profile-image"></i>
    4   -</span>
      1 +<div id="profile-image-container" style="">
      2 + <div class="profile-image-wrap" title="{{ctrl.profile.name}}" ng-mouseenter="ctrl.showChange(true)" ng-mouseleave="ctrl.showChange(false)">
      3 + <img ng-if="ctrl.profile.image" ng-src="{{ctrl.profile.image.url}}" class="img-responsive profile-image">
      4 + <i ng-if="!ctrl.profile.image" class="fa {{ctrl.defaultIcon}} fa-5x profile-image"></i>
      5 + <div ng-if="ctrl.editable" class="upload-camera-container">
      6 + <i id="camera" class="fa fa-camera upload-camera" aria-hidden="true"></i>
      7 + </div>
      8 + <div ng-if="ctrl.editable" id="select-photo-container" name="select-photo-container" class="select-photo-container container" ng-class="ctrl.editClass">
      9 + <a id="upload-container" class="upload-container" href="#" rel="dialog" role="button">
      10 + <!-- The upload button hidden behind the camera -->
      11 + <div class="upload-button" ngf-select="ctrl.fileSelected($file)"
      12 + ngf-pattern="'image/*'" ngf-accept="'image/*'"
      13 + ngf-max-size="20MB" ngf-resize="{width: 100, height: 100}"
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      Esses parâmetros: ngf-max-size, ngf-accept e etc, deveriam ser atributos do componente ou até mesmo de um serviço nao? Dessa forma, esses valores poderiam ser configurados pelo componente ConfigBarComponent visualmente pelo admin do ambiente :)

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/profile/image/image.scss
    5 5 background-clip: padding-box;
    6 6 margin-bottom: 15px;
    7 7 }
      8 +
      9 +.profile-image-wrap {
      10 + display: inline;
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper (Edited )

      Este seletor possui exatamente a mesma regra css que #profile-image-container? Se sim, eles deveriam ser agrupados em uma mesma declaração, ou utilizado o @extend do sass para herança.

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/image.scss
      25 +
      26 +.upload-camera-container {
      27 + text-align: left;
      28 + position: absolute;
      29 + z-index: 5;
      30 +}
      31 +
      32 +.upload-camera {
      33 + color: white;
      34 + position: absolute;
      35 + transition: all .3s cubic-bezier(.175, .885, .32, 1.275);
      36 + opacity: 1;
      37 +}
      38 +
      39 +.select-photo-container {
      40 + //overflow: hidden;
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper (Edited )

      Essa regra comentada deve ser removida?

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/image.scss
      46 + transition: top .13s ease-out;
      47 +}
      48 +
      49 +#upload-container {
      50 + position: relative;
      51 + text-decoration: none;
      52 +}
      53 +
      54 +.upload-container a:hover {
      55 + text-decoration: none;
      56 +}
      57 +
      58 +.upload-button {
      59 + -webkit-font-smoothing: antialiased;
      60 + color: #fff;
      61 + //word-wrap: break-word;
    1
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/profile/image/image.scss
      39 +.select-photo-container {
      40 + //overflow: hidden;
      41 + position: absolute;
      42 + z-index: -1;
      43 + background: #000;
      44 + background: rgba(0, 0, 0, .6);
      45 + background: linear-gradient(transparent, rgba(0, 0, 0, .6) 70%, rgba(0, 0, 0, .6) 100%);
      46 + transition: top .13s ease-out;
      47 +}
      48 +
      49 +#upload-container {
      50 + position: relative;
      51 + text-decoration: none;
      52 +}
      53 +
      54 +.upload-container a:hover {
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper (Edited )

      Utilize o seletor & para referenciar o pai. È uma boa prática de uso para seletores do tipo :hover, :after, :focus.

      Observe a documentação em: http://sass-lang.com/documentation/file.SASS_REFERENCE.html#parent-selector

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/profile/image/image.scss
      44 + background: rgba(0, 0, 0, .6);
      45 + background: linear-gradient(transparent, rgba(0, 0, 0, .6) 70%, rgba(0, 0, 0, .6) 100%);
      46 + transition: top .13s ease-out;
      47 +}
      48 +
      49 +#upload-container {
      50 + position: relative;
      51 + text-decoration: none;
      52 +}
      53 +
      54 +.upload-container a:hover {
      55 + text-decoration: none;
      56 +}
      57 +
      58 +.upload-button {
      59 + -webkit-font-smoothing: antialiased;
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper (Edited )

      Utilizar o prefixo -webkit somente para font-smoothing não funciona no Firefox por exemplo. Estes seletores CSS3 que possuem prefixos de browsers, estamos utilizando como padrão no projeto a criação de um @mixin dentro do arquivo _mixins.scss, contendo as diversas formas e seus prefixos de regras CSS3. Após isso, basta incluir de forma explicita com @import "caminho/mixin" e utilizar o mixin dentro do seu seletor!!

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/profile/image/image.scss
      61 + //word-wrap: break-word;
      62 +}
      63 +
      64 +.upload-container {
      65 + color:#fff;
      66 + display: block;
      67 + overflow: hidden;
      68 + position: relative;
      69 + text-align: left;
      70 + min-width: 89px;
      71 +}
      72 +
      73 +.cropArea {
      74 + background: #E4E4E4;
      75 + overflow: hidden;
      76 + width:300px;
    1
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/profile/image/image.scss
      75 + overflow: hidden;
      76 + width:300px;
      77 + height:150px;
      78 +}
      79 +
      80 +.crop-area {
      81 + display: none;
      82 +}
      83 +
      84 +form .progress {
      85 + line-height: 15px;
      86 +}
      87 +
      88 +.progress {
      89 + display: inline-block;
      90 + width: 100px;
    1
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/profile-image-editor.component.ts 0 → 100644
      1 +import {StateConfig, Component, Input, Output, Inject, provide} from 'ng-forward';
      2 +import {TranslateProfile} from "../../shared/pipes/translate-profile.filter";
      3 +import {PersonService} from "../../../lib/ng-noosfero-api/http/person.service";
      4 +
      5 +export class ProfileImageEditorComponent {
      6 +
      7 + activities: any;
      8 + croppedDataUrl: string;
      9 + static $inject = ["picFile", "profile", "personService", "$uibModalInstance"];
      10 +
      11 + constructor(public picFile: any, public profile: noosfero.Profile, public personService: PersonService,
      12 + public $uibModalInstance: any) {
      13 + }
      14 +
      15 + uploadImage(dataUrl: any, name: any) {
      16 + let base64_image_json = this.getBase64ImageJson(dataUrl, name);
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      O padrão de nomenclatura que estamos utilizando de variáveis geralmente é cammelCase. Algum motivo em especial para utilizar com underscore?

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/profile-image-editor.component.ts 0 → 100644
      7 + activities: any;
      8 + croppedDataUrl: string;
      9 + static $inject = ["picFile", "profile", "personService", "$uibModalInstance"];
      10 +
      11 + constructor(public picFile: any, public profile: noosfero.Profile, public personService: PersonService,
      12 + public $uibModalInstance: any) {
      13 + }
      14 +
      15 + uploadImage(dataUrl: any, name: any) {
      16 + let base64_image_json = this.getBase64ImageJson(dataUrl, name);
      17 + this.personService.uploadImage(this.profile, base64_image_json).then( (result: any) => {
      18 + this.$uibModalInstance.close(name);
      19 + });
      20 + }
      21 +
      22 + getBase64ImageJson(dataUrl: any, name: any) {
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      Pq este método está sem definição de tipo de retorno? Algum motivo especifico?

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/profile-image-editor.component.ts 0 → 100644
      17 + this.personService.uploadImage(this.profile, base64_image_json).then( (result: any) => {
      18 + this.$uibModalInstance.close(name);
      19 + });
      20 + }
      21 +
      22 + getBase64ImageJson(dataUrl: any, name: any) {
      23 + let data = this.getData(dataUrl);
      24 + let image_name = this.getImageName(name);
      25 + return {
      26 + tempfile: data,
      27 + filename: image_name,
      28 + type: this.picFile.type
      29 + };
      30 + }
      31 +
      32 + getImageName(name: any) {
    1
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/profile-image-editor.component.ts 0 → 100644
      1 +import {StateConfig, Component, Input, Output, Inject, provide} from 'ng-forward';
      2 +import {TranslateProfile} from "../../shared/pipes/translate-profile.filter";
      3 +import {PersonService} from "../../../lib/ng-noosfero-api/http/person.service";
      4 +
      5 +export class ProfileImageEditorComponent {
      6 +
      7 + activities: any;
      8 + croppedDataUrl: string;
      9 + static $inject = ["picFile", "profile", "personService", "$uibModalInstance"];
      10 +
      11 + constructor(public picFile: any, public profile: noosfero.Profile, public personService: PersonService,
      12 + public $uibModalInstance: any) {
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      Recentemente foi adicionado ao projeto uma definição de typescript para um namespace do angular-bootstrap. Agora é possível adicionar um tipo para tudo que envolve o $uibModal. Para instâncias do modal, utilize o tipo: ng.ui.bootstrap.IModalServiceInstance;

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/profile/image/image.component.spec.ts
      29 + let properties = { profile: { custom_footer: "footer" } };
      30 + let cls = createClass({
      31 + template: htmlTemplate,
      32 + directives: [ProfileImageComponent],
      33 + properties: properties,
      34 + providers: [
      35 + helpers.createProviderToValue("PersonService", personService),
      36 + helpers.createProviderToValue("$uibModal", helpers.mocks.$modal),
      37 + helpers.createProviderToValue("$scope", scope)
      38 + ]
      39 + });
      40 + helper = new ComponentTestHelper<ProfileImageComponent>(cls, done);
      41 + });
      42 +
      43 + it("set modal instance when select files modal", () => {
      44 + helper.component['$uibModal'].open = jasmine.createSpy("open");
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      Acesse o $uibModal diretamente como uma propriedade. Algo como: helper.component.$uibModal. Para isso, o atributo precisa ser público, ou possuir um get/set através de Acessors do typescript.

      Documentação: https://www.typescriptlang.org/docs/handbook/classes.html

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/image.component.ts
    30 33 */
    31 34 defaultIcon: string;
    32 35  
      36 + @Input() editable: boolean;
      37 +
      38 + @Input() editClass: string;
      39 +
      40 + picFile: any;
      41 + croppedDataUrl: any;
      42 + modalInstance: any;
      43 +
      44 + constructor(private personService: PersonService, private $uibModal: any, private $scope: ng.IScope) {
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      Agora é possível adicionar o tipo do modal para ng.ui.bootstrap.IModalService. Substitua o any por esse tipo.

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/lib/ng-noosfero-api/http/person.service.ts
    28 28 p.catch(this.getHandleErrorFunction<noosfero.RestResult<any>>(deferred));
    29 29 return deferred.promise;
    30 30 }
      31 +
      32 + uploadImage(profile: noosfero.Profile, base64_image_json: any) {
      33 + let headers = { 'Content-Type': 'application/json' };
      34 + let deferred = this.$q.defer<noosfero.RestResult<noosfero.Profile>>();
      35 + // TODO dynamically copy the selected attributes to update
      36 + let attributesToUpdate: any = {
      37 + person: { image_builder: base64_image_json }
    1
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/lib/ng-noosfero-api/http/person.service.ts
    28 28 p.catch(this.getHandleErrorFunction<noosfero.RestResult<any>>(deferred));
    29 29 return deferred.promise;
    30 30 }
      31 +
      32 + uploadImage(profile: noosfero.Profile, base64_image_json: any) {
      33 + let headers = { 'Content-Type': 'application/json' };
      34 + let deferred = this.$q.defer<noosfero.RestResult<noosfero.Profile>>();
      35 + // TODO dynamically copy the selected attributes to update
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper (Edited )

      Esse TODO foi realizado? Senão, talvez seja interessante adicionar um comentário neste MR explicando o que falta ser feito, para criarmos uma issue para essa modificação, se de fato for necessário :)

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/profile-image-editor.html 0 → 100644
      6 + <div ngf-drop ng-model="ctrl.picFile" ngf-pattern="image/*" class="cropArea">
      7 + <img-crop image="ctrl.picFile | ngfDataUrl" area-type="square"
      8 + result-image="ctrl.croppedDataUrl" ng-init="ctrl.croppedDataUrl=''">
      9 + </img-crop>
      10 + </div>
      11 + <div>
      12 + <img ng-src="{{ctrl.croppedDataUrl}}" />
      13 + </div>
      14 + <span class="progress" ng-show="progress >= 0">
      15 + <div style="width: {{progress" ng-bind="progress + '%'"></div>
      16 + </span> <span ng-show="ctrl.result">Upload Successful</span> <span class="err"
      17 + ng-show="ctrl.errorMsg">{{errorMsg}}</span>
      18 + </form>
      19 +
      20 + <div class="actions">
      21 + <button type="submit" class="btn btn-default" ng-click="ctrl.uploadImage(ctrl.croppedDataUrl, ctrl.picFile.name)">Upload</button>
    1
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/image/profile-image-editor.component.spec.ts 0 → 100644
      16 + let modal = helpers.mocks.$modal;
      17 + let modalInstance = jasmine.createSpyObj("$uibModalInstance", ["close"]);
      18 + let picFile = { type: "png" };
      19 + let $q: ng.IQService;
      20 + let personServiceMock: any;
      21 + let $rootScope: ng.IRootScopeService;
      22 +
      23 + beforeEach(inject((_$q_: ng.IQService, _$rootScope_: ng.IRootScopeService) => {
      24 + $q = _$q_;
      25 + $rootScope = _$rootScope_;
      26 + }));
      27 +
      28 + let comp = new ProfileImageEditorComponent(picFile, this.profile, personServiceMock, modalInstance);
      29 +
      30 + it("get data", done => {
      31 + let testDataUrl = "data:image/png;base64," + expectedData;
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      Mova esta variável para o describe, afim de reutilizá-la entre todos os testes, para evitar essa duplicidade de código

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/profile/info/profile-info.scss 0 → 100644
      1 +.profile-info .upload-camera-container {
      2 + top: 55%;
      3 + left: 39px;
      4 +}
      5 +
      6 +.profile-info-editable {
      7 + top: 51%;
      8 + width: 103px;
      9 + height: 28px;
      10 +}
      11 +
      12 +.profile-info-editable .upload-button {
    1
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/profile/info/profile-info.scss 0 → 100644
      1 +.profile-info .upload-camera-container {
      2 + top: 55%;
      3 + left: 39px;
      4 +}
      5 +
      6 +.profile-info-editable {
      7 + top: 51%;
      8 + width: 103px;
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      È interessante que esses valores de width, height, top e etc estejam em variáveis no topo do arquivo .scss

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/profile/image/image.scss
      65 + color:#fff;
      66 + display: block;
      67 + overflow: hidden;
      68 + position: relative;
      69 + text-align: left;
      70 + min-width: 89px;
      71 +}
      72 +
      73 +.cropArea {
      74 + background: #E4E4E4;
      75 + overflow: hidden;
      76 + width:300px;
      77 + height:150px;
      78 +}
      79 +
      80 +.crop-area {
    1
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    Realize um git rebase com o branch [master] para dirimir os conflitos!

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    Added 42 new commits:

    • 8784fe3c - Ticket #116: Better display of recent activities
    • 1e4736a4 - added events-hub service
    • b3953cbd - improving adding a base interface EventsHubKnownEventNames
    • 332c24ec - added changes to allow pass string[] or EventsHubKnownEventNames to EventsHubService constructor
    • 328a7a82 - some small refactoring on class naming and changed to allow EVENTS_HUB_KNOW_EVEN…
    • fb1e923a - Merge branch 'events-hub' into 'master'
    • 3d2172f3 - Adds account register module
    • bc91225e - Refactor of the account register component to uses service and restangular instead.
    • 42443554 - Fixing registration - it is working now
    • 503976b5 - add redirect to home in case of succeded signup
    • e10ddb2a - Added notification when user is created
    • 716c2a26 - Added welcome message for translation on signup
    • 74b67520 - Refactory html template + new environment service property
    • 64b0a116 - Added environment fields and ngMessages form validation
    • 4c25e839 - Added the ng.ui.bootstrap typescript definitions
    • 015b68e2 - Added the modal to show environment terms of use text
    • 224b593d - Added module 'angular-password' to check password confir match
    • a4dac9ec - Added unit tests and minor refactories
    • b4a0a739 - Fix rebase with master adjusts
    • 64000ab5 - Merge branch 'register_page' into 'master'
    • 26ff5335 - Change txt navbar menuitem from 'Novo Artigo' to 'Novo post' on pt.json
    • d3bba43c - Ticket #118: Profile images block
    • 6596b7af - adding scrap activity in profile timeline
    • e80a93b4 - change scrap timeline visualization
    • de08c0f6 - Merge branch 'add_scrap_in_timeline' into 'master'
    • 7309dec7 - Add button to join in community
    • f3cb9503 - Merge branch 'join-community' into 'master'
    • 4d167676 - Add component to display tasks in menu
    • 917544be - Add component to list tasks
    • 07f15849 - Add accept/reject buttons to task list
    • 45183e9d - Add tests to task components
    • 118eeb9d - List roles when accept add member tasks
    • 0354c769 - Accept parameters when accept/reject tasks
    • 7205a81d - Emit and subscribe to events for task accept/reject
    • 917a672d - Translate tasks messages
    • 1adb5479 - Use .checkbox-nice in accept member task
    • 6fca41b5 - Refactor methods to close task
    • d6d5bae0 - Create interface for AddMemberTask
    • a1375e04 - Merge branch 'tasks' into 'master'
    • 07858dff - Initial implementation
    • ccf7dc63 - Added upload image to person service
    • c132a4a9 - Upload image initial and tests
    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    Added 1 new commit:

    • 338aae2e - Minor refactory and sintax adjusts
    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    mentioned in commit 71d22bf6b7875e5a4e6242669ffdceca4f2fb2a9

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    mentioned in issue #111

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper (Edited )

    Este merge request foi aceito, mas necessita das seguintes melhorias/ajustes:

    1. O botão de Upload photo que está sendo exibido no :hover seu container, está com a exibição intermitente. A depender do tamanho da imagem contida no bloco profile-image, o :hover funciona de forma correta ou não.

    2. Ajustes de responsividade. Talvez seja interessante avaliar se este elemento HTML (Exibido ao passar o mouse) é realmente a melhor forma

    3. Refatorar os arquivos .sass envolvidos

      Pode depender das definições dos itens 1 e 2

    4. Exibir feedback para o usuário quando um erro ocorrer no upload da imagem (tamanho excedido, formato inválido, erro no servidor ao requisitar a API e etc...)

    5. Verificar permissões: Não exibir o botão de upload ao acessar o profile de um outro usuário

    Importante criar uma outra issue contendo estes ajustes

    Choose File ...   File name...
    Cancel