apps_controller_spec.rb
11.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
require 'spec_helper'
describe AppsController do
it_requires_authentication
it_requires_admin_privileges :for => {:new => :get, :edit => :get, :create => :post, :update => :put, :destroy => :delete}
let(:admin) { Fabricate(:admin) }
let(:user) { Fabricate(:user) }
let(:watcher) { Fabricate(:user_watcher, :app => app, :user => user) }
let(:unwatched_app) { Fabricate(:app) }
let(:app) { unwatched_app }
let(:watched_app1) do
a = Fabricate(:app)
Fabricate(:user_watcher, :user => user, :app => a)
a
end
let(:watched_app2) do
a = Fabricate(:app)
Fabricate(:user_watcher, :user => user, :app => a)
a
end
let(:err) do
Fabricate(:err, :problem => problem)
end
let(:notice) do
Fabricate(:notice, :err => err)
end
let(:problem) do
Fabricate(:problem, :app => app)
end
let(:problem_resolved) { Fabricate(:problem_resolved, :app => app) }
describe "GET /apps" do
context 'when logged in as an admin' do
it 'finds all apps' do
sign_in admin
unwatched_app && watched_app1 && watched_app2
get :index
expect(controller.apps.entries).to eq App.all.sort.entries
end
end
context 'when logged in as a regular user' do
it 'finds apps the user is watching' do
sign_in(user)
watched_app1 && watched_app2 && unwatched_app
get :index
expect(controller.apps).to include(watched_app1, watched_app2)
expect(controller.apps).to_not include(unwatched_app)
end
end
end
describe "GET /apps/:id" do
context 'logged in as an admin' do
before(:each) do
sign_in admin
end
it 'finds the app' do
get :show, :id => app.id
expect(controller.app).to eq app
end
it "should not raise errors for app with err without notices" do
err
expect{ get :show, :id => app.id }.to_not raise_error
end
it "should list atom feed successfully" do
get :show, :id => app.id, :format => "atom"
expect(response).to be_success
end
context "pagination" do
before(:each) do
35.times { Fabricate(:err, :problem => Fabricate(:problem, :app => app)) }
end
it "should have default per_page value for user" do
get :show, :id => app.id
expect(controller.problems.to_a.size).to eq User::PER_PAGE
end
it "should be able to override default per_page value" do
admin.update_attribute :per_page, 10
get :show, :id => app.id
expect(controller.problems.to_a.size).to eq 10
end
end
context 'with resolved errors' do
before(:each) do
problem_resolved && problem
end
context 'and no params' do
it 'shows only unresolved problems' do
get :show, :id => app.id
expect(controller.problems.size).to eq 1
end
end
context 'and all_problems=true params' do
it 'shows all errors' do
get :show, :id => app.id, :all_errs => true
expect(controller.problems.size).to eq 2
end
end
end
context 'with environment filters' do
before(:each) do
environments = ['production', 'test', 'development', 'staging']
20.times do |i|
Fabricate(:problem, :app => app, :environment => environments[i % environments.length])
end
end
context 'no params' do
it 'shows errs for all environments' do
get :show, :id => app.id
expect(controller.problems.size).to eq 20
end
end
context 'environment production' do
it 'shows errs for just production' do
get :show, :id => app.id, :environment => 'production'
expect(controller.problems.size).to eq 5
end
end
context 'environment staging' do
it 'shows errs for just staging' do
get :show, :id => app.id, :environment => 'staging'
expect(controller.problems.size).to eq 5
end
end
context 'environment development' do
it 'shows errs for just development' do
get :show, :id => app.id, :environment => 'development'
expect(controller.problems.size).to eq 5
end
end
context 'environment test' do
it 'shows errs for just test' do
get :show, :id => app.id, :environment => 'test'
expect(controller.problems.size).to eq 5
end
end
end
end
context 'logged in as a user' do
it 'finds the app if the user is watching it' do
watcher
sign_in user
get :show, :id => app.id
expect(controller.app).to eq app
end
it 'does not find the app if the user is not watching it' do
sign_in Fabricate(:user)
app = Fabricate(:app)
expect{
get :show, :id => app.id
}.to raise_error(Mongoid::Errors::DocumentNotFound)
end
end
end
context 'logged in as an admin' do
before do
sign_in admin
end
describe "GET /apps/new" do
it 'instantiates a new app with a prebuilt watcher' do
get :new
expect(controller.app).to be_a(App)
expect(controller.app).to be_new_record
expect(controller.app.watchers).to_not be_empty
end
it "should copy attributes from an existing app" do
@app = Fabricate(:app, :name => "do not copy",
:github_repo => "test/example")
get :new, :copy_attributes_from => @app.id
expect(controller.app).to be_a(App)
expect(controller.app).to be_new_record
expect(controller.app.name).to be_blank
expect(controller.app.github_repo).to eq "test/example"
end
end
describe "GET /apps/:id/edit" do
it 'finds the correct app' do
app = Fabricate(:app)
get :edit, :id => app.id
expect(controller.app).to eq app
end
end
describe "POST /apps" do
before do
@app = Fabricate(:app)
App.stub(:new).and_return(@app)
end
context "when the create is successful" do
before do
expect(@app).to receive(:save).and_return(true)
end
it "should redirect to the app page" do
post :create, :app => {}
expect(response).to redirect_to(app_path(@app))
end
it "should display a message" do
post :create, :app => {}
expect(request.flash[:success]).to match(/success/)
end
end
end
describe "PUT /apps/:id" do
before do
@app = Fabricate(:app)
end
context "when the update is successful" do
it "should redirect to the app page" do
put :update, :id => @app.id, :app => {}
expect(response).to redirect_to(app_path(@app))
end
it "should display a message" do
put :update, :id => @app.id, :app => {}
expect(request.flash[:success]).to match(/success/)
end
end
context "changing name" do
it "should redirect to app page" do
id = @app.id
put :update, :id => id, :app => {:name => "new name"}
expect(response).to redirect_to(app_path(id))
end
end
context "when the update is unsuccessful" do
it "should render the edit page" do
put :update, :id => @app.id, :app => { :name => '' }
expect(response).to render_template(:edit)
end
end
context "changing email_at_notices" do
before do
Errbit::Config.per_app_email_at_notices = true
end
it "should parse legal csv values" do
put :update, :id => @app.id, :app => { :email_at_notices => '1, 4, 7,8, 10' }
@app.reload
expect(@app.email_at_notices).to eq [1, 4, 7, 8, 10]
end
context "failed parsing of CSV" do
it "should set the default value" do
@app = Fabricate(:app, :email_at_notices => [1, 2, 3, 4])
put :update, :id => @app.id, :app => { :email_at_notices => 'asdf, -1,0,foobar,gd00,0,abc' }
@app.reload
expect(@app.email_at_notices).to eq Errbit::Config.email_at_notices
end
it "should display a message" do
put :update, :id => @app.id, :app => { :email_at_notices => 'qwertyuiop' }
expect(request.flash[:error]).to match(/Couldn't parse/)
end
end
end
context "setting up issue tracker", :cur => true do
context "unknown tracker type" do
before(:each) do
put :update, :id => @app.id, :app => { :issue_tracker_attributes => {
:type => 'unknown', :project_id => '1234', :api_token => '123123', :account => 'myapp'
} }
@app.reload
end
it "should not create issue tracker" do
expect(@app.issue_tracker_configured?).to eq false
end
end
IssueTracker.subclasses.each do |tracker_klass|
context tracker_klass do
it "should save tracker params" do
params = tracker_klass::Fields.inject({}){|hash,f| hash[f[0]] = "test_value"; hash }
params[:ticket_properties] = "card_type = defect" if tracker_klass == MingleTracker
params[:type] = tracker_klass.to_s
put :update, :id => @app.id, :app => {:issue_tracker_attributes => params}
@app.reload
tracker = @app.issue_tracker
expect(tracker).to be_a(tracker_klass)
tracker_klass::Fields.each do |field, field_info|
case field
when :ticket_properties
expect(tracker.send(field.to_sym)).to eq 'card_type = defect'
else
expect(tracker.send(field.to_sym)).to eq 'test_value'
end
end
end
it "should show validation notice when sufficient params are not present" do
# Leave out one required param
# TODO. previous test was not relevant because one params can be enough. So put noone
params = {:type => tracker_klass.to_s }
put :update, :id => @app.id, :app => {:issue_tracker_attributes => params}
@app.reload
expect(@app.issue_tracker_configured?).to eq false
end
end
end
end
end
describe "DELETE /apps/:id" do
before do
@app = Fabricate(:app)
end
it "should find the app" do
delete :destroy, :id => @app.id
expect(controller.app).to eq @app
end
it "should destroy the app" do
expect(@app).to receive(:destroy)
delete :destroy, :id => @app.id
end
it "should display a message" do
delete :destroy, :id => @app.id
expect(request.flash[:success]).to match(/success/)
end
it "should redirect to the apps page" do
delete :destroy, :id => @app.id
expect(response).to redirect_to(apps_path)
end
end
end
describe "POST /apps/:id/regenerate_api_key" do
context "like watcher" do
before do
sign_in watcher.user
end
it 'redirect to root with flash error' do
post :regenerate_api_key, :id => 'foo'
expect(request).to redirect_to root_path
end
end
context "like admin" do
before do
sign_in admin
end
it 'redirect_to app view' do
expect do
post :regenerate_api_key, :id => app.id
expect(request).to redirect_to edit_app_path(app)
end.to change { app.api_key }
end
end
end
end