show a breakdown of messages and tenants for

problems as well (as browsers)

show a breakdown of messages and tenants for
problems as well (as browsers)
Bob Lail
1 parent 5e7a9de8
Showing 2 changed files with 41 additions and 10 deletions Show diff stats
app/helpers/application_helper.rb
app/views/notices/_summary.html.haml
 module ApplicationHelper
-
-  def user_agent_graph(error)
-    tallies = tally(error.notices) {|notice| pretty_user_agent(notice.user_agent)}
-    create_percentage_table(tallies, :total => error.notices.count)
+  
+  
+  
+  def message_graph(problem)
+    create_percentage_table_for(problem) {|notice| notice.message}
   end
-
+  
+  
+  
+  def user_agent_graph(problem)
+    create_percentage_table_for(problem) {|notice| pretty_user_agent(notice.user_agent)}
+  end
+  
   def pretty_user_agent(user_agent)
     (user_agent.nil? || user_agent.none?) ? "N/A" : "#{user_agent.browser} #{user_agent.version}"
   end
-
+  
+  
+  
+  def tenant_graph(problem)
+    create_percentage_table_for(problem) {|notice| get_host(notice.request['url'])}
+  end
+  
+  def get_host(url)
+    uri = url && URI.parse(url)
+    uri.blank? ? "N/A" : uri.host
+  end
+  
+  
+  
+  def create_percentage_table_for(problem, &block)
+    tallies = tally(problem.notices, &block)
+    create_percentage_table_from_tallies(tallies, :total => problem.notices.count)
+  end
+  
   def tally(collection, &block)
     collection.inject({}) do |tallies, item|
       value = yield item
@@ -16,18 +41,21 @@ module ApplicationHelper
       tallies
     end
   end
-
-  def create_percentage_table(tallies, options={})
+  
+  def create_percentage_table_from_tallies(tallies, options={})
     total   = (options[:total] || total_from_tallies(tallies))
     percent = 100.0 / total.to_f
     rows    = tallies.map {|value, count| [(count.to_f * percent), value]} \
                      .sort {|a, b| a[0] <=> b[0]}
     render :partial => "errs/tally_table", :locals => {:rows => rows}
   end
-
+  
+  
   def total_from_tallies(tallies)
     tallies.values.inject(0) {|sum, n| sum + n}
   end
   private :total_from_tallies
+  
+  
 end
  
@@ -2,7 +2,7 @@
   %table.summary
     %tr
       %th Message
-      %td.main.nowrap= notice.message
+      %td.main.nowrap= message_graph(notice.problem)
     - if notice.request['url'].present?
       %tr
         %th URL
@@ -19,3 +19,6 @@
     %tr
       %th Browser
       %td= user_agent_graph(notice.problem)
+    %tr
+      %th Tenant
+      %td= tenant_graph(notice.problem)
1	1	module ApplicationHelper
2		-
3		- def user_agent_graph(error)
4		- tallies = tally(error.notices) {\|notice\| pretty_user_agent(notice.user_agent)}
5		- create_percentage_table(tallies, :total => error.notices.count)
	2	+
	3	+
	4	+
	5	+ def message_graph(problem)
	6	+ create_percentage_table_for(problem) {\|notice\| notice.message}
6	7	end
7		-
	8	+
	9	+
	10	+
	11	+ def user_agent_graph(problem)
	12	+ create_percentage_table_for(problem) {\|notice\| pretty_user_agent(notice.user_agent)}
	13	+ end
	14	+
8	15	def pretty_user_agent(user_agent)
9	16	(user_agent.nil? \|\| user_agent.none?) ? "N/A" : "#{user_agent.browser} #{user_agent.version}"
10	17	end
11		-
	18	+
	19	+
	20	+
	21	+ def tenant_graph(problem)
	22	+ create_percentage_table_for(problem) {\|notice\| get_host(notice.request['url'])}
	23	+ end
	24	+
	25	+ def get_host(url)
	26	+ uri = url && URI.parse(url)
	27	+ uri.blank? ? "N/A" : uri.host
	28	+ end
	29	+
	30	+
	31	+
	32	+ def create_percentage_table_for(problem, &block)
	33	+ tallies = tally(problem.notices, &block)
	34	+ create_percentage_table_from_tallies(tallies, :total => problem.notices.count)
	35	+ end
	36	+
12	37	def tally(collection, &block)
13	38	collection.inject({}) do \|tallies, item\|
14	39	value = yield item
...	...	@@ -16,18 +41,21 @@ module ApplicationHelper
16	41	tallies
17	42	end
18	43	end
19		-
20		- def create_percentage_table(tallies, options={})
	44	+
	45	+ def create_percentage_table_from_tallies(tallies, options={})
21	46	total = (options[:total] \|\| total_from_tallies(tallies))
22	47	percent = 100.0 / total.to_f
23	48	rows = tallies.map {\|value, count\| [(count.to_f * percent), value]} \
24	49	.sort {\|a, b\| a[0] <=> b[0]}
25	50	render :partial => "errs/tally_table", :locals => {:rows => rows}
26	51	end
27		-
	52	+
	53	+
28	54	def total_from_tallies(tallies)
29	55	tallies.values.inject(0) {\|sum, n\| sum + n}
30	56	end
31	57	private :total_from_tallies
	58	+
	59	+
32	60	end
33	61
...	...
...	...	@@ -2,7 +2,7 @@
2	2	%table.summary
3	3	%tr
4	4	%th Message
5		- %td.main.nowrap= notice.message
	5	+ %td.main.nowrap= message_graph(notice.problem)
6	6	- if notice.request['url'].present?
7	7	%tr
8	8	%th URL
...	...	@@ -19,3 +19,6 @@
19	19	%tr
20	20	%th Browser
21	21	%td= user_agent_graph(notice.problem)
	22	+ %tr
	23	+ %th Tenant
	24	+ %td= tenant_graph(notice.problem)
...	...