cache app on notice

Notices always have an app API key when they arrive at Errbit, so it makes sense to cache the app id onto the notice object. This will allow for more efficient refingerprinting and reporting down the road.

cache app on notice
Notices always have an app API key when they arrive at Errbit, so it makes sense to cache the app id onto the notice object. This will allow for more efficient refingerprinting and reporting down the road.
Stephen Crosby
1 parent 8cf20c3e
Showing 4 changed files with 15 additions and 1 deletions Show diff stats
app/models/error_report.rb
app/models/notice.rb
db/migrate/20150926035420_cache_app_on_notice.rb
spec/fabricators/err_fabricator.rb
@@ -65,6 +65,7 @@ class ErrorReport
   def make_notice
     @notice = Notice.new(
+      app: app,
       message: message,
       error_class: error_class,
       backtrace: backtrace,
@@ -12,8 +12,9 @@ class Notice
   field :framework
   field :error_class
   delegate :lines, :to => :backtrace, :prefix => true
-  delegate :app, :problem, :to => :err
+  delegate :problem, :to => :err
+  belongs_to :app
   belongs_to :err
   belongs_to :backtrace, :index => true
@@ -0,0 +1,11 @@
+class CacheAppOnNotice < Mongoid::Migration
+  def self.up
+    Notice.no_timeout.each do |n|
+      n.app_id = n.try(:err).try(:problem).try(:app_id)
+      n.save!
+    end
+  end
+
+  def self.down
+  end
+end
@@ -4,6 +4,7 @@ Fabricator :err do
 end
 Fabricator :notice do
+  app
   err
   message             'FooError: Too Much Bar'
   backtrace
	@@ -65,6 +65,7 @@ class ErrorReport		@@ -65,6 +65,7 @@ class ErrorReport
65		65
66	def make_notice	66	def make_notice
67	@notice = Notice.new(	67	@notice = Notice.new(
		68	+ app: app,
68	message: message,	69	message: message,
69	error_class: error_class,	70	error_class: error_class,
70	backtrace: backtrace,	71	backtrace: backtrace,
@@ -0,0 +1,11 @@		@@ -0,0 +1,11 @@
	1	+class CacheAppOnNotice < Mongoid::Migration
	2	+ def self.up
	3	+ Notice.no_timeout.each do \|n\|
	4	+ n.app_id = n.try(:err).try(:problem).try(:app_id)
	5	+ n.save!
	6	+ end
	7	+ end
	8	+
	9	+ def self.down
	10	+ end
	11	+end
	@@ -4,6 +4,7 @@ Fabricator :err do		@@ -4,6 +4,7 @@ Fabricator :err do
4	end	4	end
5		5
6	Fabricator :notice do	6	Fabricator :notice do
		7	+ app
7	err	8	err
8	message 'FooError: Too Much Bar'	9	message 'FooError: Too Much Bar'
9	backtrace	10	backtrace