Refactored _issue_tracker_fields.html.haml by moving all field information into …

…issue tracker models. This not only keeps the view DRY, but also streamlines the process of creating new issue trackers. Next step is to write a rails generator so that we can run 'rails generate issue_tracker NewIssueTracker'. Also, this commit contains a fix for the apps/edit page, where issue trackers were not being saved correctly.

Refactored _issue_tracker_fields.html.haml by moving all field information into …
…issue tracker models. This not only keeps the view DRY, but also streamlines the process of creating new issue trackers. Next step is to write a rails generator so that we can run 'rails generate issue_tracker NewIssueTracker'. Also, this commit contains a fix for the apps/edit page, where issue trackers were not being saved correctly.
Nathan Broadbent
1 parent 6693dd85
Showing 15 changed files with 204 additions and 188 deletions Show diff stats
app/controllers/apps_controller.rb
app/models/issue_trackers/fogbugz_tracker.rb
app/models/issue_trackers/github_issues_tracker.rb
app/models/issue_trackers/github_tracker.rb
app/models/issue_trackers/lighthouse_tracker.rb
app/models/issue_trackers/mingle_tracker.rb
app/models/issue_trackers/pivotal_labs_tracker.rb
app/models/issue_trackers/redmine_tracker.rb
app/views/apps/_issue_tracker_fields.html.haml
app/views/issue_trackers/github_body.txt.erb
app/views/issue_trackers/github_issues_body.txt.erb
spec/controllers/apps_controller_spec.rb
spec/factories/issue_tracker_factories.rb
spec/models/issue_trackers/github_issues_tracker_spec.rb
spec/models/issue_trackers/github_tracker_spec.rb
@@ -46,7 +46,7 @@ class AppsController &lt; InheritedResources::Base
   protected
     def initialize_subclassed_issue_tracker
       if params[:app][:issue_tracker_attributes] && tracker_type = params[:app][:issue_tracker_attributes][:type]
-        if IssueTracker.subclasses.map(&:to_s).concat(["IssueTracker"]).include?(tracker_type.to_s)
+        if IssueTracker.subclasses.map(&:name).concat(["IssueTracker"]).include?(tracker_type)
           @app.issue_tracker = tracker_type.constantize.new(params[:app][:issue_tracker_attributes])
         end
       end
 class IssueTrackers::FogbugzTracker < IssueTracker
   Label = "fogbugz"
-  RequiredFields = %w(project_id account username password)
+  Fields = [
+    [:project_id, {
+      :label       => "Area Name"
+    }],
+    [:account, {
+      :label       => "FogBugz URL",
+      :placeholder => "abc from http://abc.fogbugz.com/"
+    }],
+    [:username, {
+      :placeholder => "Username/Email for your account"
+    }],
+    [:password, {
+      :placeholder => "Password for your account"
+    }]
+  ]
   def check_params
-    if RequiredFields.detect {|f| self[f].blank? }
+    if Fields.detect {|f| self[f[0]].blank? }
       errors.add :base, 'You must specify your FogBugz Area Name, FogBugz URL, Username, and Password'
     end
   end
@@ -0,0 +1,32 @@
+class IssueTrackers::GithubIssuesTracker < IssueTracker
+  Label = "github"
+  Fields = [
+    [:project_id, {
+      :label       => "Account/Repository",
+      :placeholder => "errbit/errbit from https://github.com/errbit/errbit"
+    }],
+    [:username, {
+      :placeholder => "Your username on Github"
+    }],
+    [:api_token, {
+      :placeholder => "Your Github API Token"
+    }]
+  ]
+
+  def check_params
+    if Fields.detect {|f| self[f[0]].blank? }
+      errors.add :base, 'You must specify your Github repository, username and API Token'
+    end
+  end
+
+  def create_issue(err)
+    client = Octokit::Client.new(:login => username, :token => api_token)
+    issue = client.create_issue(project_id, issue_title(err), body_template.result(binding), options = {})
+    err.update_attribute :issue_link, issue.html_url
+  end
+
+  def body_template
+    @@body_template ||= ERB.new(File.read(Rails.root + "app/views/issue_trackers/github_issues_body.txt.erb").gsub(/^\s*/, ''))
+  end
+end
+
@@ -1,21 +0,0 @@
-class IssueTrackers::GithubTracker < IssueTracker
-  Label = "github"
-  RequiredFields = %w(project_id username api_token)
-
-  def check_params
-    if RequiredFields.detect {|f| self[f].blank? }
-      errors.add :base, 'You must specify your Github repository, username and API token'
-    end
-  end
-
-  def create_issue(err)
-    client = Octokit::Client.new(:login => username, :token => api_token)
-    issue = client.create_issue(project_id, issue_title(err), body_template.result(binding), options = {})
-    err.update_attribute :issue_link, issue.html_url
-  end
-
-  def body_template
-    @@body_template ||= ERB.new(File.read(Rails.root + "app/views/issue_trackers/github_body.txt.erb").gsub(/^\s*/, ''))
-  end
-end
-
 class IssueTrackers::LighthouseTracker < IssueTracker
   Label = "lighthouseapp"
-  RequiredFields = %w(account api_token project_id)
+  Fields = [
+    [:account, {
+      :placeholder => "abc from abc.lighthouseapp.com"
+    }],
+    [:api_token, {
+      :placeholder => "API Token for your account"
+    }],
+    [:project_id, {
+      :placeholder => "Lighthouse project"
+    }]
+  ]
   def check_params
-    if RequiredFields.detect {|f| self[f].blank? }
+    if Fields.detect {|f| self[f[0]].blank? }
       errors.add :base, 'You must specify your Lighthouseapp account, API token and Project ID'
     end
   end
 class IssueTrackers::MingleTracker < IssueTracker
   Label = "mingle"
-  RequiredFields = %w(account project_id username password)
+  Fields = [
+    [:account, {
+      :label       => "Mingle URL",
+      :placeholder => "abc from http://abc.fogbugz.com/"
+    }],
+    [:project_id, {
+      :placeholder => "Mingle project"
+    }],
+    [:ticket_properties, {
+      :label       => "Card Properties (comma separated key=value pairs)",
+      :placeholder => "card_type = Defect, defect_status = Open, priority = Essential"
+    }],
+    [:username, {
+      :label       => "Sign-in name",
+      :placeholder => "Sign-in name for your account"
+    }],
+    [:password, {
+      :placeholder => "Password for your account"
+    }]
+  ]
   def check_params
-    if RequiredFields.detect {|f| self[f].blank? } or !ticket_properties_hash["card_type"]
+    if Fields.detect {|f| self[f[0]].blank? } or !ticket_properties_hash["card_type"]
       errors.add :base, 'You must specify your Mingle URL, Project ID, Card Type (in default card properties), Sign-in name, and Password'
     end
   end
 class IssueTrackers::PivotalLabsTracker < IssueTracker
   Label = "pivotal"
-  RequiredFields = %w(api_token project_id)
+  Fields = [
+    [:api_token, {
+      :placeholder => "API Token for your account"
+    }],
+    [:project_id, {}]
+  ]
   def check_params
-    if RequiredFields.detect {|f| self[f].blank? }
+    if Fields.detect {|f| self[f[0]].blank? }
       errors.add :base, 'You must specify your Pivotal Tracker API token and Project ID'
     end
   end
 class IssueTrackers::RedmineTracker < IssueTracker
   Label = "redmine"
-  RequiredFields = %w(account api_token project_id)
+  Fields = [
+    [:account, {
+      :label       => "Redmine URL",
+      :placeholder => "e.g. http://www.redmine.org/"
+    }],
+    [:api_token, {
+      :placeholder => "API Token for your account"
+    }],
+    [:project_id, {}]
+  ]
   def check_params
-    if RequiredFields.detect {|f| self[f].blank? }
+    if Fields.detect {|f| self[f[0]].blank? }
       errors.add :base, 'You must specify your Redmine URL, API token and Project ID'
     end
   end
@@ -6,76 +6,21 @@
         = label_tag :type_none, :for => label_for_attr(w, 'type_issuetracker'), :class => "label_radio none" do
           = w.radio_button :type, "IssueTracker", 'data-section' => 'none'
           (None)
-        = label_tag :type_github, :for => label_for_attr(w, 'type_githubtracker'), :class => "label_radio github" do
-          = w.radio_button :type, "GithubTracker", 'data-section' => 'github'
-          Github Issues
-        = label_tag :type_lighthouseapp, :for => label_for_attr(w, 'type_lighthousetracker'), :class => "label_radio lighthouseapp" do
-          = w.radio_button :type, "LighthouseTracker", 'data-section' => 'lighthouse'
-          Lighthouse
-        = label_tag :type_redmine, :for => label_for_attr(w, 'type_redminetracker'), :class => "label_radio redmine" do
-          = w.radio_button :type, "RedmineTracker", 'data-section' => 'redmine'
-          Redmine
-        = label_tag :type_pivotal, :for => label_for_attr(w, 'type_pivotallabstracker'), :class => "label_radio pivotal" do
-          = w.radio_button :type, "PivotalLabsTracker", 'data-section' => 'pivotal'
-          Pivotal Tracker
-        = label_tag :type_fogbugz, :for => label_for_attr(w, 'type_fogbugztracker'), :class => "label_radio fogbugz" do
-          = w.radio_button :type, "FogbugzTracker", 'data-section' => 'fogbugz'
-          FogBugz
-        = label_tag :type_mingle, :for => label_for_attr(w, 'type_mingletracker'), :class => "label_radio mingle" do
-          = w.radio_button :type, "MingleTracker", 'data-section' => 'mingle'
-          Mingle
+        - IssueTracker.subclasses.each do |tracker|
+          = label_tag "type_#{tracker::Label}:", :for => label_for_attr(w, "type_#{tracker.name.downcase.gsub(':','')}"), :class => "label_radio #{tracker::Label}" do
+            = w.radio_button :type, tracker.name, 'data-section' => tracker::Label
+            = tracker.name[/::(.*)Tracker/,1].titleize
       %div.tracker_params.none{:class => (w.object && !(w.object.class < IssueTracker)) ? 'chosen' : nil}
         %p When no issue tracker has been configured, you will be able to leave comments on errors.
-      %div.tracker_params.github{:class => w.object.is_a?(GithubTracker) ? 'chosen' : nil}
-        = w.label :project_id, "Account/Repository"
-        = w.text_field :project_id, :placeholder => "errbit/errbit from https://github.com/errbit/errbit"
-        = w.label :username, "Username"
-        = w.text_field :username, :placeholder => "Your username on Github"
-        = w.label :api_token, "Token"
-        = w.text_field :api_token, :placeholder => "Your API Token"
-      %div.tracker_params.lighthouse{:class => w.object.is_a?(LighthouseTracker) ? 'chosen' : nil}
-        = w.label :account, "Account"
-        = w.text_field :account, :placeholder => "abc from abc.lighthouseapp.com"
-        = w.label :api_token, "API token"
-        = w.text_field :api_token, :placeholder => "API Token for your account"
-        = w.label :project_id, "Project ID"
-        = w.text_field :project_id
-      %div.tracker_params.redmine{:class => w.object.is_a?(RedmineTracker) ? 'chosen' : nil}
-        = w.label :account, "Redmine URL"
-        = w.text_field :account, :placeholder => "like http://www.redmine.org/"
-        = w.label :api_token, "API token"
-        = w.text_field :api_token, :placeholder => "API Token for your account"
-        = w.label :project_id, "Project ID"
-        = w.text_field :project_id
-      %div.tracker_params.pivotal{:class => w.object.is_a?(PivotalLabsTracker) ? 'chosen' : nil}
-        = w.label :project_id, "Project ID"
-        = w.text_field :project_id
-        = w.label :api_token, "API token"
-        = w.text_field :api_token, :placeholder => "API Token for your account"
-      %div.tracker_params.fogbugz{:class => w.object.is_a?(FogbugzTracker) ? 'chosen' : nil}
-        = w.label :project_id, "Area Name"
-        = w.text_field :project_id
-        = w.label :account, "FogBugz URL"
-        = w.text_field :account, :placeholder => "abc from http://abc.fogbugz.com/"
-        = w.label :username, 'Username'
-        = w.text_field :username, :placeholder => 'Username/Email for your account'
-        = w.label :password, 'Password'
-        = w.password_field :password, :placeholder => 'Password for your account'
-      %div.tracker_params.mingle{:class => w.object.is_a?(MingleTracker) ? 'chosen' : nil}
-        = w.label :account, "Mingle URL"
-        = w.text_field :account, :placeholder => "http://mingle.yoursite.com/"
-        = w.label :project_id, "Project ID"
-        = w.text_field :project_id
-        = w.label :ticket_properties, "Card Properties (comma separated key=value pairs)"
-        = w.text_field :ticket_properties, :placeholder => "card_type = Defect, defect_status = Open, priority = Essential"
-        = w.label :username, 'Sign-in name'
-        = w.text_field :username, :placeholder => 'Sign-in name for your account'
-        = w.label :password, 'Password'
-        = w.password_field :password, :placeholder => 'Password for your account'
+      - IssueTracker.subclasses.each do |tracker|
+        %div.tracker_params{:class => (w.object.is_a?(tracker) ? 'chosen ' : '') << tracker::Label}
+          - tracker::Fields.each do |field, field_info|
+            = w.label field, field_info[:label] || field.to_s.titleize
+            = w.text_field field, :placeholder => field_info[:placeholder]
       .image_preloader
-        - %w(none github lighthouseapp redmine pivotal fogbugz mingle).each do |tracker|
+        - (IssueTracker.subclasses.map{|t| t::Label } << 'none').each do |tracker|
           = image_tag "#{tracker}_inactive.png"
           = image_tag "#{tracker}_create.png"
@@ -1,45 +0,0 @@
-[See this exception on Errbit](<%= app_err_url err.app, err %> "See this exception on Errbit")
-<% if notice = err.notices.first %>
-# <%= notice.message %> #
-## Summary ##
-<% if notice.request['url'].present? %>
-  ### URL ###
-  [<%= notice.request['url'] %>](<%= notice.request['url'] %>)"
-<% end %>
-### Where ###
-<%= notice.err.where %>
-
-### Occured ###
-<%= notice.created_at.to_s(:micro) %>
-
-### Similar ###
-<%= (notice.err.notices_count - 1).to_s %>
-
-## Params ##
-```
-<%= pretty_hash(notice.params) %>
-```
-
-## Session ##
-```
-<%= pretty_hash(notice.session) %>
-```
-
-## Backtrace ##
-```
-<% for line in notice.backtrace %><%= line['number'] %>:  <%= line['file'].sub(/^\[PROJECT_ROOT\]/, '') %> -> **<%= line['method'] %>**
-<% end %>
-```
-
-## Environment ##
-
-<table>
-<% for key, val in notice.env_vars %>
-  <tr>
-    <td><%= key %>:</td>
-    <td><%= val %></td>
-  </tr>
-<% end %>
-</table>
-<% end %>
-
@@ -0,0 +1,45 @@
+[See this exception on Errbit](<%= app_err_url err.app, err %> "See this exception on Errbit")
+<% if notice = err.notices.first %>
+# <%= notice.message %> #
+## Summary ##
+<% if notice.request['url'].present? %>
+  ### URL ###
+  [<%= notice.request['url'] %>](<%= notice.request['url'] %>)"
+<% end %>
+### Where ###
+<%= notice.err.where %>
+
+### Occured ###
+<%= notice.created_at.to_s(:micro) %>
+
+### Similar ###
+<%= (notice.err.notices_count - 1).to_s %>
+
+## Params ##
+```
+<%= pretty_hash(notice.params) %>
+```
+
+## Session ##
+```
+<%= pretty_hash(notice.session) %>
+```
+
+## Backtrace ##
+```
+<% for line in notice.backtrace %><%= line['number'] %>:  <%= line['file'].sub(/^\[PROJECT_ROOT\]/, '') %> -> **<%= line['method'] %>**
+<% end %>
+```
+
+## Environment ##
+
+<table>
+<% for key, val in notice.env_vars %>
+  <tr>
+    <td><%= key %>:</td>
+    <td><%= val %></td>
+  </tr>
+<% end %>
+</table>
+<% end %>
+
@@ -276,7 +276,7 @@ describe AppsController do
         IssueTracker.subclasses.each do |tracker_klass|
           context tracker_klass do
             it "should save tracker params" do
-              params = tracker_klass::RequiredFields.inject({}){|hash,f| hash[f] = "test_value"; hash }
+              params = tracker_klass::Fields.inject({}){|hash,f| hash[f[0]] = "test_value"; hash }
               params['ticket_properties'] = "card_type = defect" if tracker_klass == MingleTracker
               params['type'] = tracker_klass.to_s
               put :update, :id => @app.id, :app => {:issue_tracker_attributes => params}
@@ -284,14 +284,17 @@ describe AppsController do
               @app.reload
               tracker = @app.issue_tracker
               tracker.should be_a(tracker_klass)
-              tracker_klass::RequiredFields.each do |required|
-                tracker.send(required.to_sym).should == 'test_value'
+              tracker_klass::Fields.each do |field, field_info|
+                case field
+                when :ticket_properties; tracker.send(field.to_sym).should == 'card_type = defect'
+                else tracker.send(field.to_sym).should == 'test_value'
+                end
               end
             end
             it "should show validation notice when sufficient params are not present" do
               # Leave out one required param
-              params = tracker_klass::RequiredFields[1..-1].inject({}){|hash,f| hash[f] = "test_value"; hash }
+              params = tracker_klass::Fields[1..-1].inject({}){|hash,f| hash[f[0]] = "test_value"; hash }
               params['type'] = tracker_klass.to_s
               put :update, :id => @app.id, :app => {:issue_tracker_attributes => params}
@@ -20,7 +20,7 @@ Factory.define :mingle_tracker, :parent =&gt; :issue_tracker, :class =&gt; :mingle_tra
   e.ticket_properties 'card_type = Defect, defect_status = open, priority = essential'
 end
-Factory.define :github_tracker, :parent => :issue_tracker, :class => :github_tracker do |e|
+Factory.define :github_issues_tracker, :parent => :issue_tracker, :class => :github_issues_tracker do |e|
   e.project_id 'test_account/test_project'
   e.username 'test_username'
 end
@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe GithubIssuesTracker do
+  it "should create an issue on Github Issues with err params, and set issue link for err" do
+    notice = Factory :notice
+    tracker = Factory :github_issues_tracker, :app => notice.err.app
+    err = notice.err
+
+    number = 5
+    @issue_link = "https://github.com/#{tracker.project_id}/issues/#{number}"
+    body = <<EOF
+{
+  "issue": {
+    "position": 1.0,
+    "number": #{number},
+    "votes": 0,
+    "created_at": "2010/01/21 13:45:59 -0800",
+    "comments": 0,
+    "body": "Test Body",
+    "title": "Test Issue",
+    "user": "test_user",
+    "state": "open",
+    "html_url": "#{@issue_link}"
+  }
+}
+EOF
+    stub_request(:post, "https://#{tracker.username}%2Ftoken:#{tracker.api_token}@github.com/api/v2/json/issues/open/#{tracker.project_id}").
+      to_return(:status => 201, :headers => {'Location' => @issue_link}, :body => body )
+
+    err.app.issue_tracker.create_issue(err)
+    err.reload
+
+    requested = have_requested(:post, "https://#{tracker.username}%2Ftoken:#{tracker.api_token}@github.com/api/v2/json/issues/open/#{tracker.project_id}")
+    WebMock.should requested.with(:headers => {'Content-Type' => 'application/x-www-form-urlencoded'})
+    WebMock.should requested.with(:body => /title=%5Bproduction%5D%5Bfoo%23bar%5D%20FooError%3A%20Too%20Much%20Bar/)
+    WebMock.should requested.with(:body => /See%20this%20exception%20on%20Errbit/)
+
+    err.issue_link.should == @issue_link
+  end
+end
+
@@ -1,41 +0,0 @@
-require 'spec_helper'
-
-describe GithubTracker do
-  it "should create an issue on Github Issues with err params, and set issue link for err" do
-    notice = Factory :notice
-    tracker = Factory :github_tracker, :app => notice.err.app
-    err = notice.err
-
-    number = 5
-    @issue_link = "https://github.com/#{tracker.project_id}/issues/#{number}"
-    body = <<EOF
-{
-  "issue": {
-    "position": 1.0,
-    "number": #{number},
-    "votes": 0,
-    "created_at": "2010/01/21 13:45:59 -0800",
-    "comments": 0,
-    "body": "Test Body",
-    "title": "Test Issue",
-    "user": "test_user",
-    "state": "open",
-    "html_url": "#{@issue_link}"
-  }
-}
-EOF
-    stub_request(:post, "https://#{tracker.username}%2Ftoken:#{tracker.api_token}@github.com/api/v2/json/issues/open/#{tracker.project_id}").
-      to_return(:status => 201, :headers => {'Location' => @issue_link}, :body => body )
-
-    err.app.issue_tracker.create_issue(err)
-    err.reload
-
-    requested = have_requested(:post, "https://#{tracker.username}%2Ftoken:#{tracker.api_token}@github.com/api/v2/json/issues/open/#{tracker.project_id}")
-    WebMock.should requested.with(:headers => {'Content-Type' => 'application/x-www-form-urlencoded'})
-    WebMock.should requested.with(:body => /title=%5Bproduction%5D%5Bfoo%23bar%5D%20FooError%3A%20Too%20Much%20Bar/)
-    WebMock.should requested.with(:body => /See%20this%20exception%20on%20Errbit/)
-
-    err.issue_link.should == @issue_link
-  end
-end
-
	@@ -46,7 +46,7 @@ class AppsController < InheritedResources::Base		@@ -46,7 +46,7 @@ class AppsController < InheritedResources::Base
46	protected	46	protected
47	def initialize_subclassed_issue_tracker	47	def initialize_subclassed_issue_tracker
48	if params[:app][:issue_tracker_attributes] && tracker_type = params[:app][:issue_tracker_attributes][:type]	48	if params[:app][:issue_tracker_attributes] && tracker_type = params[:app][:issue_tracker_attributes][:type]
49	- if IssueTracker.subclasses.map(&:to_s).concat(["IssueTracker"]).include?(tracker_type.to_s)	49	+ if IssueTracker.subclasses.map(&:name).concat(["IssueTracker"]).include?(tracker_type)
50	@app.issue_tracker = tracker_type.constantize.new(params[:app][:issue_tracker_attributes])	50	@app.issue_tracker = tracker_type.constantize.new(params[:app][:issue_tracker_attributes])
51	end	51	end
52	end	52	end
1	class IssueTrackers::FogbugzTracker < IssueTracker	1	class IssueTrackers::FogbugzTracker < IssueTracker
2	Label = "fogbugz"	2	Label = "fogbugz"
3	- RequiredFields = %w(project_id account username password)	3	+ Fields = [
		4	+ [:project_id, {
		5	+ :label => "Area Name"
		6	+ }],
		7	+ [:account, {
		8	+ :label => "FogBugz URL",
		9	+ :placeholder => "abc from http://abc.fogbugz.com/"
		10	+ }],
		11	+ [:username, {
		12	+ :placeholder => "Username/Email for your account"
		13	+ }],
		14	+ [:password, {
		15	+ :placeholder => "Password for your account"
		16	+ }]
		17	+ ]
4		18
5	def check_params	19	def check_params
6	- if RequiredFields.detect {\|f\| self[f].blank? }	20	+ if Fields.detect {\|f\| self[f[0]].blank? }
7	errors.add :base, 'You must specify your FogBugz Area Name, FogBugz URL, Username, and Password'	21	errors.add :base, 'You must specify your FogBugz Area Name, FogBugz URL, Username, and Password'
8	end	22	end
9	end	23	end
@@ -0,0 +1,32 @@		@@ -0,0 +1,32 @@
	1	+class IssueTrackers::GithubIssuesTracker < IssueTracker
	2	+ Label = "github"
	3	+ Fields = [
	4	+ [:project_id, {
	5	+ :label => "Account/Repository",
	6	+ :placeholder => "errbit/errbit from https://github.com/errbit/errbit"
	7	+ }],
	8	+ [:username, {
	9	+ :placeholder => "Your username on Github"
	10	+ }],
	11	+ [:api_token, {
	12	+ :placeholder => "Your Github API Token"
	13	+ }]
	14	+ ]
	15	+
	16	+ def check_params
	17	+ if Fields.detect {\|f\| self[f[0]].blank? }
	18	+ errors.add :base, 'You must specify your Github repository, username and API Token'
	19	+ end
	20	+ end
	21	+
	22	+ def create_issue(err)
	23	+ client = Octokit::Client.new(:login => username, :token => api_token)
	24	+ issue = client.create_issue(project_id, issue_title(err), body_template.result(binding), options = {})
	25	+ err.update_attribute :issue_link, issue.html_url
	26	+ end
	27	+
	28	+ def body_template
	29	+ @@body_template \|\|= ERB.new(File.read(Rails.root + "app/views/issue_trackers/github_issues_body.txt.erb").gsub(/^\s*/, ''))
	30	+ end
	31	+end
	32	+
	@@ -1,21 +0,0 @@	@@ -1,21 +0,0 @@
1	-class IssueTrackers::GithubTracker < IssueTracker
2	- Label = "github"
3	- RequiredFields = %w(project_id username api_token)
4	-
5	- def check_params
6	- if RequiredFields.detect {\|f\| self[f].blank? }
7	- errors.add :base, 'You must specify your Github repository, username and API token'
8	- end
9	- end
10	-
11	- def create_issue(err)
12	- client = Octokit::Client.new(:login => username, :token => api_token)
13	- issue = client.create_issue(project_id, issue_title(err), body_template.result(binding), options = {})
14	- err.update_attribute :issue_link, issue.html_url
15	- end
16	-
17	- def body_template
18	- @@body_template \|\|= ERB.new(File.read(Rails.root + "app/views/issue_trackers/github_body.txt.erb").gsub(/^\s*/, ''))
19	- end
20	-end
21	-
1	class IssueTrackers::LighthouseTracker < IssueTracker	1	class IssueTrackers::LighthouseTracker < IssueTracker
2	Label = "lighthouseapp"	2	Label = "lighthouseapp"
3	- RequiredFields = %w(account api_token project_id)	3	+ Fields = [
		4	+ [:account, {
		5	+ :placeholder => "abc from abc.lighthouseapp.com"
		6	+ }],
		7	+ [:api_token, {
		8	+ :placeholder => "API Token for your account"
		9	+ }],
		10	+ [:project_id, {
		11	+ :placeholder => "Lighthouse project"
		12	+ }]
		13	+ ]
4		14
5	def check_params	15	def check_params
6	- if RequiredFields.detect {\|f\| self[f].blank? }	16	+ if Fields.detect {\|f\| self[f[0]].blank? }
7	errors.add :base, 'You must specify your Lighthouseapp account, API token and Project ID'	17	errors.add :base, 'You must specify your Lighthouseapp account, API token and Project ID'
8	end	18	end
9	end	19	end
1	class IssueTrackers::MingleTracker < IssueTracker	1	class IssueTrackers::MingleTracker < IssueTracker
2	Label = "mingle"	2	Label = "mingle"
3	- RequiredFields = %w(account project_id username password)	3	+ Fields = [
		4	+ [:account, {
		5	+ :label => "Mingle URL",
		6	+ :placeholder => "abc from http://abc.fogbugz.com/"
		7	+ }],
		8	+ [:project_id, {
		9	+ :placeholder => "Mingle project"
		10	+ }],
		11	+ [:ticket_properties, {
		12	+ :label => "Card Properties (comma separated key=value pairs)",
		13	+ :placeholder => "card_type = Defect, defect_status = Open, priority = Essential"
		14	+ }],
		15	+ [:username, {
		16	+ :label => "Sign-in name",
		17	+ :placeholder => "Sign-in name for your account"
		18	+ }],
		19	+ [:password, {
		20	+ :placeholder => "Password for your account"
		21	+ }]
		22	+ ]
4		23
5	def check_params	24	def check_params
6	- if RequiredFields.detect {\|f\| self[f].blank? } or !ticket_properties_hash["card_type"]	25	+ if Fields.detect {\|f\| self[f[0]].blank? } or !ticket_properties_hash["card_type"]
7	errors.add :base, 'You must specify your Mingle URL, Project ID, Card Type (in default card properties), Sign-in name, and Password'	26	errors.add :base, 'You must specify your Mingle URL, Project ID, Card Type (in default card properties), Sign-in name, and Password'
8	end	27	end
9	end	28	end
	@@ -6,76 +6,21 @@		@@ -6,76 +6,21 @@
6	= label_tag :type_none, :for => label_for_attr(w, 'type_issuetracker'), :class => "label_radio none" do	6	= label_tag :type_none, :for => label_for_attr(w, 'type_issuetracker'), :class => "label_radio none" do
7	= w.radio_button :type, "IssueTracker", 'data-section' => 'none'	7	= w.radio_button :type, "IssueTracker", 'data-section' => 'none'
8	(None)	8	(None)
9	- = label_tag :type_github, :for => label_for_attr(w, 'type_githubtracker'), :class => "label_radio github" do
10	- = w.radio_button :type, "GithubTracker", 'data-section' => 'github'
11	- Github Issues
12	- = label_tag :type_lighthouseapp, :for => label_for_attr(w, 'type_lighthousetracker'), :class => "label_radio lighthouseapp" do
13	- = w.radio_button :type, "LighthouseTracker", 'data-section' => 'lighthouse'
14	- Lighthouse
15	- = label_tag :type_redmine, :for => label_for_attr(w, 'type_redminetracker'), :class => "label_radio redmine" do
16	- = w.radio_button :type, "RedmineTracker", 'data-section' => 'redmine'
17	- Redmine
18	- = label_tag :type_pivotal, :for => label_for_attr(w, 'type_pivotallabstracker'), :class => "label_radio pivotal" do
19	- = w.radio_button :type, "PivotalLabsTracker", 'data-section' => 'pivotal'
20	- Pivotal Tracker
21	- = label_tag :type_fogbugz, :for => label_for_attr(w, 'type_fogbugztracker'), :class => "label_radio fogbugz" do
22	- = w.radio_button :type, "FogbugzTracker", 'data-section' => 'fogbugz'
23	- FogBugz
24	- = label_tag :type_mingle, :for => label_for_attr(w, 'type_mingletracker'), :class => "label_radio mingle" do
25	- = w.radio_button :type, "MingleTracker", 'data-section' => 'mingle'
26	- Mingle	9	+ - IssueTracker.subclasses.each do \|tracker\|
		10	+ = label_tag "type_#{tracker::Label}:", :for => label_for_attr(w, "type_#{tracker.name.downcase.gsub(':','')}"), :class => "label_radio #{tracker::Label}" do
		11	+ = w.radio_button :type, tracker.name, 'data-section' => tracker::Label
		12	+ = tracker.name[/::(.*)Tracker/,1].titleize
27		13
28	%div.tracker_params.none{:class => (w.object && !(w.object.class < IssueTracker)) ? 'chosen' : nil}	14	%div.tracker_params.none{:class => (w.object && !(w.object.class < IssueTracker)) ? 'chosen' : nil}
29	%p When no issue tracker has been configured, you will be able to leave comments on errors.	15	%p When no issue tracker has been configured, you will be able to leave comments on errors.
30	- %div.tracker_params.github{:class => w.object.is_a?(GithubTracker) ? 'chosen' : nil}
31	- = w.label :project_id, "Account/Repository"
32	- = w.text_field :project_id, :placeholder => "errbit/errbit from https://github.com/errbit/errbit"
33	- = w.label :username, "Username"
34	- = w.text_field :username, :placeholder => "Your username on Github"
35	- = w.label :api_token, "Token"
36	- = w.text_field :api_token, :placeholder => "Your API Token"
37	- %div.tracker_params.lighthouse{:class => w.object.is_a?(LighthouseTracker) ? 'chosen' : nil}
38	- = w.label :account, "Account"
39	- = w.text_field :account, :placeholder => "abc from abc.lighthouseapp.com"
40	- = w.label :api_token, "API token"
41	- = w.text_field :api_token, :placeholder => "API Token for your account"
42	- = w.label :project_id, "Project ID"
43	- = w.text_field :project_id
44	- %div.tracker_params.redmine{:class => w.object.is_a?(RedmineTracker) ? 'chosen' : nil}
45	- = w.label :account, "Redmine URL"
46	- = w.text_field :account, :placeholder => "like http://www.redmine.org/"
47	- = w.label :api_token, "API token"
48	- = w.text_field :api_token, :placeholder => "API Token for your account"
49	- = w.label :project_id, "Project ID"
50	- = w.text_field :project_id
51	- %div.tracker_params.pivotal{:class => w.object.is_a?(PivotalLabsTracker) ? 'chosen' : nil}
52	- = w.label :project_id, "Project ID"
53	- = w.text_field :project_id
54	- = w.label :api_token, "API token"
55	- = w.text_field :api_token, :placeholder => "API Token for your account"
56	- %div.tracker_params.fogbugz{:class => w.object.is_a?(FogbugzTracker) ? 'chosen' : nil}
57	- = w.label :project_id, "Area Name"
58	- = w.text_field :project_id
59	- = w.label :account, "FogBugz URL"
60	- = w.text_field :account, :placeholder => "abc from http://abc.fogbugz.com/"
61	- = w.label :username, 'Username'
62	- = w.text_field :username, :placeholder => 'Username/Email for your account'
63	- = w.label :password, 'Password'
64	- = w.password_field :password, :placeholder => 'Password for your account'
65	- %div.tracker_params.mingle{:class => w.object.is_a?(MingleTracker) ? 'chosen' : nil}
66	- = w.label :account, "Mingle URL"
67	- = w.text_field :account, :placeholder => "http://mingle.yoursite.com/"
68	- = w.label :project_id, "Project ID"
69	- = w.text_field :project_id
70	- = w.label :ticket_properties, "Card Properties (comma separated key=value pairs)"
71	- = w.text_field :ticket_properties, :placeholder => "card_type = Defect, defect_status = Open, priority = Essential"
72	- = w.label :username, 'Sign-in name'
73	- = w.text_field :username, :placeholder => 'Sign-in name for your account'
74	- = w.label :password, 'Password'
75	- = w.password_field :password, :placeholder => 'Password for your account'	16	+ - IssueTracker.subclasses.each do \|tracker\|
		17	+ %div.tracker_params{:class => (w.object.is_a?(tracker) ? 'chosen ' : '') << tracker::Label}
		18	+ - tracker::Fields.each do \|field, field_info\|
		19	+ = w.label field, field_info[:label] \|\| field.to_s.titleize
		20	+ = w.text_field field, :placeholder => field_info[:placeholder]
76		21
77	.image_preloader	22	.image_preloader
78	- - %w(none github lighthouseapp redmine pivotal fogbugz mingle).each do \|tracker\|	23	+ - (IssueTracker.subclasses.map{\|t\| t::Label } << 'none').each do \|tracker\|
79	= image_tag "#{tracker}_inactive.png"	24	= image_tag "#{tracker}_inactive.png"
80	= image_tag "#{tracker}_create.png"	25	= image_tag "#{tracker}_create.png"
81		26
	@@ -1,45 +0,0 @@	@@ -1,45 +0,0 @@
1	-[See this exception on Errbit](<%= app_err_url err.app, err %> "See this exception on Errbit")
2	-<% if notice = err.notices.first %>
3	-# <%= notice.message %> #
4	-## Summary ##
5	-<% if notice.request['url'].present? %>
6	- ### URL ###
7	- [<%= notice.request['url'] %>](<%= notice.request['url'] %>)"
8	-<% end %>
9	-### Where ###
10	-<%= notice.err.where %>
11	-
12	-### Occured ###
13	-<%= notice.created_at.to_s(:micro) %>
14	-
15	-### Similar ###
16	-<%= (notice.err.notices_count - 1).to_s %>
17	-
18	-## Params ##
19	-```
20	-<%= pretty_hash(notice.params) %>
21	-```
22	-
23	-## Session ##
24	-```
25	-<%= pretty_hash(notice.session) %>
26	-```
27	-
28	-## Backtrace ##
29	-```
30	-<% for line in notice.backtrace %><%= line['number'] %>: <%= line['file'].sub(/^\[PROJECT_ROOT\]/, '') %> -> <%= line['method'] %>
31	-<% end %>
32	-```
33	-
34	-## Environment ##
35	-
36	-<table>
37	-<% for key, val in notice.env_vars %>
38	- <tr>
39	- <td><%= key %>:</td>
40	- <td><%= val %></td>
41	- </tr>
42	-<% end %>
43	-</table>
44	-<% end %>
45	-
@@ -0,0 +1,45 @@		@@ -0,0 +1,45 @@
	1	+[See this exception on Errbit](<%= app_err_url err.app, err %> "See this exception on Errbit")
	2	+<% if notice = err.notices.first %>
	3	+# <%= notice.message %> #
	4	+## Summary ##
	5	+<% if notice.request['url'].present? %>
	6	+ ### URL ###
	7	+ [<%= notice.request['url'] %>](<%= notice.request['url'] %>)"
	8	+<% end %>
	9	+### Where ###
	10	+<%= notice.err.where %>
	11	+
	12	+### Occured ###
	13	+<%= notice.created_at.to_s(:micro) %>
	14	+
	15	+### Similar ###
	16	+<%= (notice.err.notices_count - 1).to_s %>
	17	+
	18	+## Params ##
	19	+```
	20	+<%= pretty_hash(notice.params) %>
	21	+```
	22	+
	23	+## Session ##
	24	+```
	25	+<%= pretty_hash(notice.session) %>
	26	+```
	27	+
	28	+## Backtrace ##
	29	+```
	30	+<% for line in notice.backtrace %><%= line['number'] %>: <%= line['file'].sub(/^\[PROJECT_ROOT\]/, '') %> -> <%= line['method'] %>
	31	+<% end %>
	32	+```
	33	+
	34	+## Environment ##
	35	+
	36	+<table>
	37	+<% for key, val in notice.env_vars %>
	38	+ <tr>
	39	+ <td><%= key %>:</td>
	40	+ <td><%= val %></td>
	41	+ </tr>
	42	+<% end %>
	43	+</table>
	44	+<% end %>
	45	+
	@@ -20,7 +20,7 @@ Factory.define :mingle_tracker, :parent => :issue_tracker, :class => :mingle_tra		@@ -20,7 +20,7 @@ Factory.define :mingle_tracker, :parent => :issue_tracker, :class => :mingle_tra
20	e.ticket_properties 'card_type = Defect, defect_status = open, priority = essential'	20	e.ticket_properties 'card_type = Defect, defect_status = open, priority = essential'
21	end	21	end
22		22
23	-Factory.define :github_tracker, :parent => :issue_tracker, :class => :github_tracker do \|e\|	23	+Factory.define :github_issues_tracker, :parent => :issue_tracker, :class => :github_issues_tracker do \|e\|
24	e.project_id 'test_account/test_project'	24	e.project_id 'test_account/test_project'
25	e.username 'test_username'	25	e.username 'test_username'
26	end	26	end