added a tally of browsers on which an error occurred to err/summary

Bob Lail
1 parent 49b0fe02
Showing 4 changed files with 71 additions and 2 deletions Show diff stats
app/helpers/application_helper.rb
app/views/errs/_tally_table.html.haml
app/views/notices/_summary.html.haml
public/stylesheets/application.css
 module ApplicationHelper
+  
+  
   def lighthouse_tracker? object
     object.issue_tracker_type == "lighthouseapp"
   end
+  
+  
+  def user_agent_graph(error)
+    tallies = tally(error.notices) {|notice| pretty_user_agent(notice.user_agent)}
+    create_percentage_table(tallies, :total => error.notices.count)
+  end
+  
+  def pretty_user_agent(user_agent)
+    (user_agent.nil? || user_agent.none?) ? "N/A" : "#{user_agent.browser} #{user_agent.version}"
+  end
+  
+  
+  def tally(collection, &block)
+    collection.inject({}) do |tallies, item|
+      value = yield item
+      tallies[value] = (tallies[value] || 0) + 1
+      tallies
+    end
+  end
+  
+  
+  def create_percentage_table(tallies, options={})
+    total   = (options[:total] || total_from_tallies(tallies))
+    percent = 100.0 / total.to_f
+    rows    = tallies.map {|value, count| [(count.to_f * percent), value]} \
+                     .sort {|a, b| a[0] <=> b[0]}
+    render :partial => "errs/tally_table", :locals => {:rows => rows}
+  end
+  
+  
+private
+  
+  
+  def total_from_tallies(tallies)
+    tallies.values.inject(0) {|sum, n| sum + n}
+  end
+  
+  
 end
@@ -0,0 +1,5 @@
+%table.tally
+  - rows.each do |row|
+    %tr
+      %td.percent= number_to_percentage(row[0], :precision => 1)
+      %th.value= row[1]
@@ -15,4 +15,7 @@
       %td= notice.created_at.to_s(:micro)
     %tr
       %th Similar
-      %td= notice.err.notices.count - 1
 \ No newline at end of file
+      %td= notice.err.notices.count - 1
+    %tr
+      %th Browser
+      %td= user_agent_graph(notice.err)
 \ No newline at end of file
@@ -562,7 +562,7 @@ table.errs td.app .environment {
 table.errs td.message a { 
   width: 420px;
   display: block;
-   word-wrap: break-word;
+  word-wrap: break-word;
 }
 table.errs td.message em {
   color: #727272;
@@ -574,6 +574,27 @@ table.errs tr.resolved td &gt; * {
   -webkit-opacity: 0.5;
 }
+/* Tally tables */
+table.tally {
+  border:none;
+}
+table.tally td,
+table.tally th {
+  border:none !important;
+  background:none !important;
+  padding:8px 0 0;
+}
+table.tally tbody tr:first-child td,
+table.tally tbody tr:first-child th {
+  padding-top:0;
+}
+table.tally td.percent {
+  width:4.5em;
+}
+table.tally th.value {
+  text-transform:none;
+}
+
 /* Resolve Errs */
 #action-bar a.resolve {
   background: transparent url(images/icons/thumbs-up.png) 6px 5px no-repeat;
1	module ApplicationHelper	1	module ApplicationHelper
		2	+
		3	+
2	def lighthouse_tracker? object	4	def lighthouse_tracker? object
3	object.issue_tracker_type == "lighthouseapp"	5	object.issue_tracker_type == "lighthouseapp"
4	end	6	end
		7	+
		8	+
		9	+ def user_agent_graph(error)
		10	+ tallies = tally(error.notices) {\|notice\| pretty_user_agent(notice.user_agent)}
		11	+ create_percentage_table(tallies, :total => error.notices.count)
		12	+ end
		13	+
		14	+ def pretty_user_agent(user_agent)
		15	+ (user_agent.nil? \|\| user_agent.none?) ? "N/A" : "#{user_agent.browser} #{user_agent.version}"
		16	+ end
		17	+
		18	+
		19	+ def tally(collection, &block)
		20	+ collection.inject({}) do \|tallies, item\|
		21	+ value = yield item
		22	+ tallies[value] = (tallies[value] \|\| 0) + 1
		23	+ tallies
		24	+ end
		25	+ end
		26	+
		27	+
		28	+ def create_percentage_table(tallies, options={})
		29	+ total = (options[:total] \|\| total_from_tallies(tallies))
		30	+ percent = 100.0 / total.to_f
		31	+ rows = tallies.map {\|value, count\| [(count.to_f * percent), value]} \
		32	+ .sort {\|a, b\| a[0] <=> b[0]}
		33	+ render :partial => "errs/tally_table", :locals => {:rows => rows}
		34	+ end
		35	+
		36	+
		37	+private
		38	+
		39	+
		40	+ def total_from_tallies(tallies)
		41	+ tallies.values.inject(0) {\|sum, n\| sum + n}
		42	+ end
		43	+
		44	+
5	end	45	end
@@ -0,0 +1,5 @@		@@ -0,0 +1,5 @@
	1	+%table.tally
	2	+ - rows.each do \|row\|
	3	+ %tr
	4	+ %td.percent= number_to_percentage(row[0], :precision => 1)
	5	+ %th.value= row[1]
	@@ -562,7 +562,7 @@ table.errs td.app .environment {		@@ -562,7 +562,7 @@ table.errs td.app .environment {
562	table.errs td.message a {	562	table.errs td.message a {
563	width: 420px;	563	width: 420px;
564	display: block;	564	display: block;
565	- word-wrap: break-word;	565	+ word-wrap: break-word;
566	}	566	}
567	table.errs td.message em {	567	table.errs td.message em {
568	color: #727272;	568	color: #727272;
	@@ -574,6 +574,27 @@ table.errs tr.resolved td > * {		@@ -574,6 +574,27 @@ table.errs tr.resolved td > * {
574	-webkit-opacity: 0.5;	574	-webkit-opacity: 0.5;
575	}	575	}
576		576
		577	+/* Tally tables */
		578	+table.tally {
		579	+ border:none;
		580	+}
		581	+table.tally td,
		582	+table.tally th {
		583	+ border:none !important;
		584	+ background:none !important;
		585	+ padding:8px 0 0;
		586	+}
		587	+table.tally tbody tr:first-child td,
		588	+table.tally tbody tr:first-child th {
		589	+ padding-top:0;
		590	+}
		591	+table.tally td.percent {
		592	+ width:4.5em;
		593	+}
		594	+table.tally th.value {
		595	+ text-transform:none;
		596	+}
		597	+
577	/* Resolve Errs */	598	/* Resolve Errs */
578	#action-bar a.resolve {	599	#action-bar a.resolve {
579	background: transparent url(images/icons/thumbs-up.png) 6px 5px no-repeat;	600	background: transparent url(images/icons/thumbs-up.png) 6px 5px no-repeat;