fix spec/model/problem with fabrication_gem

Cyril Mougel
1 parent 2f20b79b
Showing 3 changed files with 55 additions and 57 deletions Show diff stats
spec/fabricators/app_fabricator.rb
spec/fabricators/sequences_fabricator.rb
spec/models/problem_spec.rb
 Fabricator(:app) do
-  name { sequence(:app_name) }
+  name { sequence(:app_name){|n| "App ##{n}"} }
 end
 Fabricator(:app_with_watcher, :from => :app) do
 Fabricate.sequence(:name) {|n| "John #{n} Doe"}
 Fabricate.sequence(:word) {|n| "word#{n}"}
-Fabricate.sequence(:app_name) {|n| "App ##{n}"}
 Fabricate.sequence(:email) {|n| "email#{n}@example.com"}
 Fabricate.sequence(:user_email) {|n| "user.#{n}@example.com"}
@@ -3,16 +3,16 @@ require &#39;spec_helper&#39;
 describe Problem do
   context '#last_notice_at' do
     it "returns the created_at timestamp of the latest notice" do
-      err = Factory(:err)
+      err = Fabricate(:err)
       problem = err.problem
       problem.should_not be_nil
       problem.last_notice_at.should be_nil
-      notice1 = Factory(:notice, :err => err)
+      notice1 = Fabricate(:notice, :err => err)
       problem.last_notice_at.should == notice1.created_at
-      notice2 = Factory(:notice, :err => err)
+      notice2 = Fabricate(:notice, :err => err)
       problem.last_notice_at.should == notice2.created_at
     end
   end
@@ -20,10 +20,10 @@ describe Problem do
   context '#message' do
     it "adding a notice caches its message" do
-      err = Factory(:err)
+      err = Fabricate(:err)
       problem = err.problem
       lambda {
-        Factory(:notice, :err => err, :message => 'ERR 1')
+        Fabricate(:notice, :err => err, :message => 'ERR 1')
       }.should change(problem, :message).from(nil).to('ERR 1')
     end
   end
@@ -32,9 +32,9 @@ describe Problem do
   context 'being created' do
     context 'when the app has err notifications set to false' do
       it 'should not send an email notification' do
-        app = Factory(:app_with_watcher, :notify_on_errs => false)
+        app = Fabricate(:app_with_watcher, :notify_on_errs => false)
         Mailer.should_not_receive(:err_notification)
-        Factory(:problem, :app => app)
+        Fabricate(:problem, :app => app)
       end
     end
   end
@@ -48,7 +48,7 @@ describe Problem do
     end
     it "should be able to be resolved" do
-      problem = Factory(:problem)
+      problem = Fabricate(:problem)
       problem.should_not be_resolved
       problem.resolve!
       problem.reload.should be_resolved
@@ -58,14 +58,14 @@ describe Problem do
   context "resolve!" do
     it "marks the problem as resolved" do
-      problem = Factory(:problem)
+      problem = Fabricate(:problem)
       problem.should_not be_resolved
       problem.resolve!
       problem.should be_resolved
     end
     it "should throw an err if it's not successful" do
-      problem = Factory(:problem)
+      problem = Fabricate(:problem)
       problem.should_not be_resolved
       problem.stub!(:valid?).and_return(false)
       problem.should_not be_valid
@@ -78,8 +78,8 @@ describe Problem do
   context ".merge!" do
     it "collects the Errs from several problems into one and deletes the other problems" do
-      problem1 = Factory(:err).problem
-      problem2 = Factory(:err).problem
+      problem1 = Fabricate(:err).problem
+      problem2 = Fabricate(:err).problem
       problem1.errs.length.should == 1
       problem2.errs.length.should == 1
@@ -93,8 +93,8 @@ describe Problem do
   context "#unmerge!" do
     it "creates a separate problem for each err" do
-      problem1 = Factory(:notice).problem
-      problem2 = Factory(:notice).problem
+      problem1 = Fabricate(:notice).problem
+      problem2 = Fabricate(:notice).problem
       merged_problem = Problem.merge!(problem1, problem2)
       merged_problem.errs.length.should == 2
@@ -103,7 +103,7 @@ describe Problem do
     end
     it "runs smoothly for problem without errs" do
-      expect { Factory(:problem).unmerge! }.not_to raise_error
+      expect { Fabricate(:problem).unmerge! }.not_to raise_error
     end
   end
@@ -111,8 +111,8 @@ describe Problem do
   context "Scopes" do
     context "resolved" do
       it 'only finds resolved Problems' do
-        resolved = Factory(:problem, :resolved => true)
-        unresolved = Factory(:problem, :resolved => false)
+        resolved = Fabricate(:problem, :resolved => true)
+        unresolved = Fabricate(:problem, :resolved => false)
         Problem.resolved.all.should include(resolved)
         Problem.resolved.all.should_not include(unresolved)
       end
@@ -120,8 +120,8 @@ describe Problem do
     context "unresolved" do
       it 'only finds unresolved Problems' do
-        resolved = Factory(:problem, :resolved => true)
-        unresolved = Factory(:problem, :resolved => false)
+        resolved = Fabricate(:problem, :resolved => true)
+        unresolved = Fabricate(:problem, :resolved => false)
         Problem.unresolved.all.should_not include(resolved)
         Problem.unresolved.all.should include(unresolved)
       end
@@ -131,9 +131,9 @@ describe Problem do
   context "notice counter cache" do
     before do
-      @app = Factory(:app)
-      @problem = Factory(:problem, :app => @app)
-      @err = Factory(:err, :problem => @problem)
+      @app = Fabricate(:app)
+      @problem = Fabricate(:problem, :app => @app)
+      @err = Fabricate(:err, :problem => @problem)
     end
     it "#notices_count returns 0 by default" do
@@ -142,12 +142,12 @@ describe Problem do
     it "adding a notice increases #notices_count by 1" do
       lambda {
-        Factory(:notice, :err => @err, :message => 'ERR 1')
+        Fabricate(:notice, :err => @err, :message => 'ERR 1')
       }.should change(@problem, :notices_count).from(0).to(1)
     end
     it "removing a notice decreases #notices_count by 1" do
-      notice1 = Factory(:notice, :err => @err, :message => 'ERR 1')
+      notice1 = Fabricate(:notice, :err => @err, :message => 'ERR 1')
       lambda {
         @err.notices.first.destroy
         @problem.reload
@@ -157,19 +157,18 @@ describe Problem do
   context "#app_name" do
-    before do
-      @app = Factory(:app)
-    end
+    let!(:app) { Fabricate(:app) }
+    let!(:problem) { Fabricate(:problem, :app => app) }
+
+    before { app.reload }
     it "is set when a problem is created" do
-      problem = Factory(:problem, :app => @app)
-      assert_equal @app.name, problem.app_name
+      assert_equal app.name, problem.app_name
     end
     it "is updated when an app is updated" do
-      problem = Factory(:problem, :app => @app)
       lambda {
-        @app.update_attributes!(:name => "Bar App")
+        app.update_attributes!(:name => "Bar App")
         problem.reload
       }.should change(problem, :app_name).to("Bar App")
     end
@@ -178,21 +177,21 @@ describe Problem do
   context "#last_deploy_at" do
     before do
-      @app = Factory(:app)
+      @app = Fabricate(:app)
       @last_deploy = 10.days.ago.localtime.round(0)
-      deploy = Factory(:deploy, :app => @app, :created_at => @last_deploy, :environment => "production")
+      deploy = Fabricate(:deploy, :app => @app, :created_at => @last_deploy, :environment => "production")
     end
     it "is set when a problem is created" do
-      problem = Factory(:problem, :app => @app, :environment => "production")
+      problem = Fabricate(:problem, :app => @app, :environment => "production")
       assert_equal @last_deploy, problem.last_deploy_at
     end
     it "is updated when a deploy is created" do
-      problem = Factory(:problem, :app => @app, :environment => "production")
+      problem = Fabricate(:problem, :app => @app, :environment => "production")
       next_deploy = 5.minutes.ago.localtime.round(0)
       lambda {
-        @deploy = Factory(:deploy, :app => @app, :created_at => next_deploy)
+        @deploy = Fabricate(:deploy, :app => @app, :created_at => next_deploy)
         problem.reload
       }.should change(problem, :last_deploy_at).from(@last_deploy).to(next_deploy)
     end
@@ -200,9 +199,9 @@ describe Problem do
   context "notice messages cache" do
     before do
-      @app = Factory(:app)
-      @problem = Factory(:problem, :app => @app)
-      @err = Factory(:err, :problem => @problem)
+      @app = Fabricate(:app)
+      @problem = Fabricate(:problem, :app => @app)
+      @err = Fabricate(:err, :problem => @problem)
     end
     it "#messages should be empty by default" do
@@ -211,12 +210,12 @@ describe Problem do
     it "adding a notice adds a string to #messages" do
       lambda {
-        Factory(:notice, :err => @err, :message => 'ERR 1')
+        Fabricate(:notice, :err => @err, :message => 'ERR 1')
       }.should change(@problem, :messages).from({}).to({Digest::MD5.hexdigest('ERR 1') => {'value' => 'ERR 1', 'count' => 1}})
     end
     it "removing a notice removes string from #messages" do
-      notice1 = Factory(:notice, :err => @err, :message => 'ERR 1')
+      notice1 = Fabricate(:notice, :err => @err, :message => 'ERR 1')
       lambda {
         @err.notices.first.destroy
         @problem.reload
@@ -226,9 +225,9 @@ describe Problem do
   context "notice hosts cache" do
     before do
-      @app = Factory(:app)
-      @problem = Factory(:problem, :app => @app)
-      @err = Factory(:err, :problem => @problem)
+      @app = Fabricate(:app)
+      @problem = Fabricate(:problem, :app => @app)
+      @err = Fabricate(:err, :problem => @problem)
     end
     it "#hosts should be empty by default" do
@@ -237,12 +236,12 @@ describe Problem do
     it "adding a notice adds a string to #hosts" do
       lambda {
-        Factory(:notice, :err => @err, :request => {'url' => "http://example.com/resource/12"})
+        Fabricate(:notice, :err => @err, :request => {'url' => "http://example.com/resource/12"})
       }.should change(@problem, :hosts).from({}).to({Digest::MD5.hexdigest('example.com') => {'value' => 'example.com', 'count' => 1}})
     end
     it "removing a notice removes string from #hosts" do
-      notice1 = Factory(:notice, :err => @err, :request => {'url' => "http://example.com/resource/12"})
+      notice1 = Fabricate(:notice, :err => @err, :request => {'url' => "http://example.com/resource/12"})
       lambda {
         @err.notices.first.destroy
         @problem.reload
@@ -252,9 +251,9 @@ describe Problem do
   context "notice user_agents cache" do
     before do
-      @app = Factory(:app)
-      @problem = Factory(:problem, :app => @app)
-      @err = Factory(:err, :problem => @problem)
+      @app = Fabricate(:app)
+      @problem = Fabricate(:problem, :app => @app)
+      @err = Fabricate(:err, :problem => @problem)
     end
     it "#user_agents should be empty by default" do
@@ -263,12 +262,12 @@ describe Problem do
     it "adding a notice adds a string to #user_agents" do
       lambda {
-        Factory(:notice, :err => @err, :request => {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'}})
+        Fabricate(:notice, :err => @err, :request => {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'}})
       }.should change(@problem, :user_agents).from({}).to({Digest::MD5.hexdigest('Chrome 10.0.648.204') => {'value' => 'Chrome 10.0.648.204', 'count' => 1}})
     end
     it "removing a notice removes string from #user_agents" do
-      notice1 = Factory(:notice, :err => @err, :request => {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'}})
+      notice1 = Fabricate(:notice, :err => @err, :request => {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'}})
       lambda {
         @err.notices.first.destroy
         @problem.reload
@@ -278,8 +277,8 @@ describe Problem do
   context "comment counter cache" do
     before do
-      @app = Factory(:app)
-      @problem = Factory(:problem, :app => @app)
+      @app = Fabricate(:app)
+      @problem = Fabricate(:problem, :app => @app)
     end
     it "#comments_count returns 0 by default" do
@@ -288,12 +287,12 @@ describe Problem do
     it "adding a comment increases #comments_count by 1" do
       lambda {
-        Factory(:comment, :err => @problem)
+        Fabricate(:comment, :err => @problem)
       }.should change(@problem, :comments_count).from(0).to(1)
     end
     it "removing a comment decreases #comments_count by 1" do
-      comment1 = Factory(:comment, :err => @problem)
+      comment1 = Fabricate(:comment, :err => @problem)
       lambda {
         @problem.reload.comments.first.destroy
         @problem.reload
1	Fabricator(:app) do	1	Fabricator(:app) do
2	- name { sequence(:app_name) }	2	+ name { sequence(:app_name){\|n\| "App ##{n}"} }
3	end	3	end
4		4
5	Fabricator(:app_with_watcher, :from => :app) do	5	Fabricator(:app_with_watcher, :from => :app) do
1	Fabricate.sequence(:name) {\|n\| "John #{n} Doe"}	1	Fabricate.sequence(:name) {\|n\| "John #{n} Doe"}
2	Fabricate.sequence(:word) {\|n\| "word#{n}"}	2	Fabricate.sequence(:word) {\|n\| "word#{n}"}
3	-Fabricate.sequence(:app_name) {\|n\| "App ##{n}"}
4	Fabricate.sequence(:email) {\|n\| "email#{n}@example.com"}	3	Fabricate.sequence(:email) {\|n\| "email#{n}@example.com"}
5	Fabricate.sequence(:user_email) {\|n\| "user.#{n}@example.com"}	4	Fabricate.sequence(:user_email) {\|n\| "user.#{n}@example.com"}
6		5