Added asset_host to generate JavaScript links in backtraces

Nathan Broadbent
1 parent 1ec24d91
Showing 3 changed files with 17 additions and 1 deletions Show diff stats
app/helpers/backtrace_line_helper.rb
app/models/app.rb
app/views/apps/_fields.html.haml
@@ -7,13 +7,24 @@ module BacktraceLineHelper
   private
   def link_to_in_app_source_file(line, text)
     return unless line.in_app?
-    link_to_repo_source_file(line, text) || link_to_issue_tracker_file(line, text)
+    if line.file_name =~ /\.js$/
+      link_to_hosted_javascript(line, text)
+    else
+      link_to_repo_source_file(line, text) ||
+      link_to_issue_tracker_file(line, text)
+    end
   end
   def link_to_repo_source_file(line, text)
     link_to_github(line, text) || link_to_bitbucket(line, text)
   end
+  def link_to_hosted_javascript(line, text)
+    if line.app.asset_host?
+      link_to(text, "#{line.app.asset_host}/#{line.file_relative}", :target => '_blank')
+    end
+  end
+
   def link_to_external_source_file(text)
     text
   end
@@ -7,6 +7,7 @@ class App
   field :api_key
   field :github_repo
   field :bitbucket_repo
+  field :asset_host
   field :repository_branch
   field :resolve_errs_on_deploy, :type => Boolean, :default => false
   field :notify_all_users, :type => Boolean, :default => false
@@ -13,6 +13,10 @@
 %div
   = f.label :bitbucket_repo
   = f.text_field :bitbucket_repo, :placeholder => "errbit/errbit from https://bitbucket.org/errbit/errbit"
+%div
+  = f.label :asset_host
+  %em Used to generate links for JavaScript errors
+  = f.text_field :asset_host, :placeholder => "e.g. https://assets.example.com"
 %fieldset
   %legend Notifications