Commit 482518e535cf9ffc75d89180a59f9c4c849cc9b1
1 parent
8a7183a3
Exists in
master
and in
1 other branch
Extract some test from controller/noticess to error_report
Showing
2 changed files
with
25 additions
and
26 deletions
Show diff stats
spec/controllers/notices_controller_spec.rb
@@ -27,32 +27,6 @@ describe NoticesController do | @@ -27,32 +27,6 @@ describe NoticesController do | ||
27 | response.body.should match(%r{<url[^>]*>(.+)#{locate_path(notice.id)}</url>}) | 27 | response.body.should match(%r{<url[^>]*>(.+)#{locate_path(notice.id)}</url>}) |
28 | end | 28 | end |
29 | 29 | ||
30 | - it "should transform xml <va> tags to hashes correctly" do | ||
31 | - pending # TODO, need to be test on ErrorReport model | ||
32 | - # XML: <var key="SCRIPT_NAME"/> | ||
33 | - notice.env_vars.should have_key('SCRIPT_NAME') | ||
34 | - notice.env_vars['SCRIPT_NAME'].should be_nil # blank ends up nil | ||
35 | - | ||
36 | - # XML representation: | ||
37 | - # <var key="rack.session.options"> | ||
38 | - # <var key="secure">false</var> | ||
39 | - # <var key="httponly">true</var> | ||
40 | - # <var key="path">/</var> | ||
41 | - # <var key="expire_after"/> | ||
42 | - # <var key="domain"/> | ||
43 | - # <var key="id"/> | ||
44 | - # </var> | ||
45 | - expected = { | ||
46 | - 'secure' => 'false', | ||
47 | - 'httponly' => 'true', | ||
48 | - 'path' => '/', | ||
49 | - 'expire_after' => nil, | ||
50 | - 'domain' => nil, | ||
51 | - 'id' => nil | ||
52 | - } | ||
53 | - notice.env_vars.should have_key('rack_session_options') | ||
54 | - notice.env_vars['rack_session_options'].should eql(expected) | ||
55 | - end | ||
56 | end | 30 | end |
57 | 31 | ||
58 | it "generates a notice from xml in a data param [POST]" do | 32 | it "generates a notice from xml in a data param [POST]" do |
spec/models/error_report_spec.rb
@@ -67,6 +67,31 @@ describe ErrorReport do | @@ -67,6 +67,31 @@ describe ErrorReport do | ||
67 | subject.user_attributes['email'].should == 'mr.bean@example.com' | 67 | subject.user_attributes['email'].should == 'mr.bean@example.com' |
68 | subject.user_attributes['username'].should == 'mrbean' | 68 | subject.user_attributes['username'].should == 'mrbean' |
69 | end | 69 | end |
70 | + it 'valid env_vars' do | ||
71 | + # XML: <var key="SCRIPT_NAME"/> | ||
72 | + subject.env_vars.should have_key('SCRIPT_NAME') | ||
73 | + subject.env_vars['SCRIPT_NAME'].should be_nil # blank ends up nil | ||
74 | + | ||
75 | + # XML representation: | ||
76 | + # <var key="rack.session.options"> | ||
77 | + # <var key="secure">false</var> | ||
78 | + # <var key="httponly">true</var> | ||
79 | + # <var key="path">/</var> | ||
80 | + # <var key="expire_after"/> | ||
81 | + # <var key="domain"/> | ||
82 | + # <var key="id"/> | ||
83 | + # </var> | ||
84 | + expected = { | ||
85 | + 'secure' => 'false', | ||
86 | + 'httponly' => 'true', | ||
87 | + 'path' => '/', | ||
88 | + 'expire_after' => nil, | ||
89 | + 'domain' => nil, | ||
90 | + 'id' => nil | ||
91 | + } | ||
92 | + subject.env_vars.should have_key('rack_session_options') | ||
93 | + subject.env_vars['rack_session_options'].should eql(expected) | ||
94 | + end | ||
70 | end | 95 | end |
71 | 96 | ||
72 | it 'save a notice assignes to err' do | 97 | it 'save a notice assignes to err' do |