Merge pull request #301 from lest/patch-1

call super instead of read_attribute

Merge pull request #301 from lest/patch-1
call super instead of read_attribute
Vasiliy Ermolovich
2 parents 6c8532e8 2943c197
Showing 2 changed files with 8 additions and 5 deletions Show diff stats
app/models/notice.rb
spec/models/notice_spec.rb
@@ -64,7 +64,7 @@ class Notice
   end
   def request
-    read_attribute(:request) || {}
+    super || {}
   end
   def url
 require 'spec_helper'
 describe Notice do
-
-
   context 'validations' do
     it 'requires a backtrace' do
       notice = Fabricate.build(:notice, :backtrace => nil)
@@ -23,7 +21,6 @@ describe Notice do
     end
   end
-
   describe "key sanitization" do
     before do
       @hash = { "some.key" => { "$nested.key" => {"$Path" => "/", "some$key" => "key"}}}
@@ -38,7 +35,6 @@ describe Notice do
     end
   end
-
   describe "user agent" do
     it "should be parsed and human-readable" do
       notice = Fabricate.build(:notice, :request => {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'}})
@@ -80,4 +76,11 @@ describe Notice do
       notice.host.should == 'N/A'
     end
   end
+
+  describe "request" do
+    it "returns empty hash if not set" do
+      notice = Notice.new
+      notice.request.should == {}
+    end
+  end
 end
	@@ -64,7 +64,7 @@ class Notice		@@ -64,7 +64,7 @@ class Notice
64	end	64	end
65		65
66	def request	66	def request
67	- read_attribute(:request) \|\| {}	67	+ super \|\| {}
68	end	68	end
69		69
70	def url	70	def url