Run unmerge smoothly on problem which migration form err was incorrect.

Nick Recobra
1 parent fbd103d2
Showing 2 changed files with 9 additions and 6 deletions Show diff stats
app/models/problem.rb
spec/models/problem_spec.rb
@@ -76,7 +76,9 @@ class Problem
   end
   def unmerge!
-    [self] + errs[1..-1].map(&:id).map do |err_id|
+    problem_errs = errs.to_a
+    problem_errs.shift
+    [self] + problem_errs.map(&:id).map do |err_id|
       err = Err.find(err_id)
       app.problems.create.tap do |new_problem|
         err.update_attribute(:problem_id, new_problem.id)
@@ -98,11 +98,12 @@ describe Problem do
       merged_problem = Problem.merge!(problem1, problem2)
       merged_problem.errs.length.should == 2
-      lambda {
-        problems = merged_problem.unmerge!
-        problems.length.should == 2
-        merged_problem.errs(true).length.should == 1
-      }.should change(Problem, :count).by(1)
+      expect { merged_problem.unmerge! }.to change(Problem, :count).by(1)
+      merged_problem.errs(true).length.should == 1
+    end
+
+    it "runs smoothly for problem without errs" do
+      expect { Factory(:problem).unmerge! }.not_to raise_error
     end
   end