v3 API allow notifier in the context hash

According to @zefer, the notifier can be passed in the context hash as well as the top level when creating a notice through the JSON api. https://github.com/airbrake/airbrake-js/pull/174#issuecomment-164918928

v3 API allow notifier in the context hash
According to @zefer, the notifier can be passed in the context hash as well as the top level when creating a notice through the JSON api. https://github.com/airbrake/airbrake-js/pull/174#issuecomment-164918928
Stephen Crosby
1 parent 9feadde1
Showing 3 changed files with 33 additions and 12 deletions Show diff stats
README.md
lib/airbrake_api/v3/notice_parser.rb
spec/lib/airbrake_api/v3/notice_parser_spec.rb
@@ -249,10 +249,6 @@ Airbrake.setProject(&quot;ERRBIT API KEY&quot;, &quot;ERRBIT API KEY&quot;);
 Airbrake.setHost("http://errbit.yourdomain.com");
 ```
-NOTE: Errbit is known to work with airbrake-js v0.5.2. Newer versions of
-will not work until we figure out how to deal with:
-https://github.com/airbrake/airbrake-js/pull/174#issuecomment-164918928
-
 Plugins and Integrations
 ------------------------
 You can extend Errbit by adding Ruby gems and plugins which are typically gems.
@@ -9,18 +9,20 @@ module AirbrakeApi
         @params = params || {}
       end
-      def report
-        attributes = {
+      def attributes
+        {
           error_class:        error['type'],
           message:            error['message'],
           backtrace:          backtrace,
           request:            request,
           server_environment: server_environment,
           api_key:            params['key'].present? ? params['key'] : params['project_id'],
-          notifier:           params['notifier'],
+          notifier:           context['notifier'] || params['notifier'],
           user_attributes:    user_attributes
         }
+      end
+      def report
         ErrorReport.new(attributes)
       end
 describe AirbrakeApi::V3::NoticeParser do
   let(:app) { Fabricate(:app) }
+  let(:notifier_params) do
+    {
+      'name'    => 'notifiername',
+      'version' => 'notifierversion',
+      'url'     => 'notifierurl'
+    }
+  end
   it 'raises error when errors attribute is missing' do
     expect do
-      AirbrakeApi::V3::NoticeParser.new({}).report
+      described_class.new({}).report
     end.to raise_error(AirbrakeApi::ParamsError)
     expect do
-      AirbrakeApi::V3::NoticeParser.new('errors' => []).report
+      described_class.new('errors' => []).report
     end.to raise_error(AirbrakeApi::ParamsError)
   end
   it 'parses JSON payload and returns ErrorReport' do
     params = build_params(key: app.api_key)
-    report = AirbrakeApi::V3::NoticeParser.new(params).report
+    report = described_class.new(params).report
     notice = report.generate_notice!
     expect(report.error_class).to eq('Error')
@@ -37,7 +44,7 @@ describe AirbrakeApi::V3::NoticeParser do
   it 'parses JSON payload when api_key is missing but project_id is present' do
     params = build_params(key: nil, project_id: app.api_key)
-    report = AirbrakeApi::V3::NoticeParser.new(params).report
+    report = described_class.new(params).report
     expect(report).to be_valid
   end
@@ -46,7 +53,7 @@ describe AirbrakeApi::V3::NoticeParser do
     params = JSON.parse(json)
     params['key'] = app.api_key
-    report = AirbrakeApi::V3::NoticeParser.new(params).report
+    report = described_class.new(params).report
     report.generate_notice!
     expect(report.error_class).to eq('Error')
@@ -54,6 +61,22 @@ describe AirbrakeApi::V3::NoticeParser do
     expect(report.backtrace.lines.size).to eq(0)
   end
+  it 'takes the notifier from root' do
+    parser = described_class.new(
+      'errors'      => ['MyError'],
+      'notifier'    => notifier_params,
+      'environment' => {})
+    expect(parser.attributes[:notifier]).to eq(notifier_params)
+  end
+
+  it 'takes the notifier from the context' do
+    parser = described_class.new(
+      'errors'      => ['MyError'],
+      'context'     => { 'notifier' => notifier_params },
+      'environment' => {})
+    expect(parser.attributes[:notifier]).to eq(notifier_params)
+  end
+
   def build_params(options = {})
     json = Rails.root.join('spec', 'fixtures', 'api_v3_request.json').read
     data = JSON.parse(json)