Download as
Browse Code »

Commit 5bd5350bd2a458a1134266bfe59ec358ad6a6809

Authored by Laust Rud Jacobsen
1 parent bf4b315e
Exists in master and in 1 other branch production

Rubocop: newline between method defs

Showing 5 changed files with 7 additions and 12 deletions   Show diff stats
.rubocop.yml
  Diff comments   View file @5bd5350
... ... @@ -8,3 +8,6 @@ AllCops:
8 8 # returns nil
9 9 Rails/FindBy:
10 10 Enabled: false
  11 +
  12 +Style/EmptyLineBetweenDefs:
  13 + AllowAdjacentOneLineDefs: true
... ...
.rubocop_todo.yml
  Diff comments   View file @5bd5350
... ... @@ -147,18 +147,6 @@ Style/EachWithObject:
147 147 - 'app/models/notice_fingerprinter.rb'
148 148 - 'lib/recurse.rb'
149 149  
150   -# Offense count: 14
151   -# Cop supports --auto-correct.
152   -# Configuration parameters: AllowAdjacentOneLineDefs.
153   -Style/EmptyLineBetweenDefs:
154   - Exclude:
155   - - 'app/controllers/apps_controller.rb'
156   - - 'app/controllers/users_controller.rb'
157   - - 'app/models/notification_service.rb'
158   - - 'spec/decorators/issue_tracker_decorator_spec.rb'
159   - - 'spec/decorators/issue_tracker_type_decorator_spec.rb'
160   - - 'spec/views/problems/show.html.haml_spec.rb'
161   -
162 150 # Offense count: 22
163 151 # Cop supports --auto-correct.
164 152 # Configuration parameters: AllowForAlignment.
... ...
app/controllers/apps_controller.rb
  Diff comments   View file @5bd5350
... ... @@ -43,6 +43,7 @@ class AppsController < ApplicationController
43 43 }
44 44  
45 45 def index; end
  46 +
46 47 def show
47 48 app
48 49 end
... ...
spec/decorators/issue_tracker_decorator_spec.rb
  Diff comments   View file @5bd5350
... ... @@ -3,6 +3,7 @@ describe IssueTrackerDecorator do
3 3 klass = Class.new(ErrbitPlugin::IssueTracker) {
4 4 def self.label; 'fake'; end
5 5 def self.note; 'a note'; end
  6 +
6 7 def self.fields
7 8 {
8 9 :foo => {:label => 'foo'},
... ...
spec/decorators/issue_tracker_type_decorator_spec.rb
  Diff comments   View file @5bd5350
... ... @@ -3,12 +3,14 @@ describe IssueTrackerDecorator do
3 3 klass = Class.new(ErrbitPlugin::IssueTracker) do
4 4 def self.label; 'fake'; end
5 5 def self.note; 'a note'; end
  6 +
6 7 def self.fields
7 8 {
8 9 :foo => {:label => 'foo'},
9 10 :bar => {:label => 'bar'}
10 11 }
11 12 end
  13 +
12 14 def self.icons
13 15 {
14 16 one: ['text/plain', 'all your base are belong to us'],
... ...