Error Email: add similar count to subject

It's pretty useful when visually scanning the messages in my inbox to see the count in the subject instead of having to open the email. The relative importance of an email roughly scales with similar_count, so it's a fairly important piece of info.

Error Email: add similar count to subject
It's pretty useful when visually scanning the messages in my inbox to see the count in the subject instead of having to open the email. The relative importance of an email roughly scales with similar_count, so it's a fairly important piece of info.
Daniel Beardsley
1 parent 34a4b8a1
Showing 2 changed files with 9 additions and 1 deletions Show diff stats
app/mailers/mailer.rb
spec/mailers/mailer_spec.rb
@@ -12,8 +12,11 @@ class Mailer &lt; ActionMailer::Base
     @notice   = notice
     @app      = notice.app
+    count = @notice.similar_count
+    count = count > 1 ? "(#{count}) " : ""
+
     mail :to      => @app.notification_recipients,
-         :subject => "[#{@app.name}][#{@notice.environment_name}] #{@notice.message.truncate(50)}"
+         :subject => "#{count}[#{@app.name}][#{@notice.environment_name}] #{@notice.message.truncate(50)}"
   end
   def deploy_notification(deploy)
@@ -10,6 +10,7 @@ describe Mailer do
     before do
       notice.backtrace.lines.last.update_attributes(:file => "[PROJECT_ROOT]/path/to/file.js")
       notice.app.update_attributes :asset_host => "http://example.com"
+      notice.problem.update_attributes :notices_count => 3
       @email = Mailer.err_notification(notice).deliver
     end
@@ -30,6 +31,10 @@ describe Mailer do
       @email.should have_body_text('<a href="http://example.com/path/to/file.js" target="_blank">path/to/file.js')
     end
+    it "should have the error count in the subject" do
+      @email.subject.should =~ /^\(3\) /
+    end
+
     context 'with a very long message' do
       let(:notice)  { Fabricate(:notice, :message => 6.times.collect{|a| "0123456789" }.join('')) }
       it "should truncate the long message" do