Rubocop: use trailing dots when invocations cross multiple lines

This allows code to be copy/pasted into the console for easy experimentation and spelunking.

Rubocop: use trailing dots when invocations cross multiple lines
This allows code to be copy/pasted into the console for easy experimentation and spelunking.
Laust Rud Jacobsen
1 parent dba2a9eb
Showing 8 changed files with 36 additions and 38 deletions Show diff stats
.rubocop.yml
.rubocop_todo.yml
app/controllers/problems_controller.rb
app/controllers/site_config_controller.rb
app/decorators/backtrace_line_decorator.rb
app/helpers/application_helper.rb
spec/controllers/api/v3/notices_controller_spec.rb
spec/models/notice_observer_spec.rb
@@ -29,6 +29,10 @@ Style/AccessModifierIndentation:
 Style/AlignParameters:
   EnforcedStyle: with_fixed_indentation
+Style/DotPosition:
+  # Support code copy/paste into console
+  EnforcedStyle: trailing
+
 Style/IndentHash:
   EnforcedStyle: consistent
@@ -115,12 +115,6 @@ Style/ConstantName:
 Style/Documentation:
   Enabled: false
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/DotPosition:
-  Enabled: false
-
 # Offense count: 5
 Style/EachWithObject:
   Exclude:
@@ -32,11 +32,11 @@ class ProblemsController &lt; ApplicationController
   }
   expose(:problems) {
-    pro = Problem
-      .for_apps(app_scope)
-      .in_env(params_environement)
-      .all_else_unresolved(all_errs)
-      .ordered_by(params_sort, params_order)
+    pro = Problem.
+      for_apps(app_scope).
+      in_env(params_environement).
+      all_else_unresolved(all_errs).
+      ordered_by(params_sort, params_order)
     if request.format == :html
       pro.page(params[:page]).per(current_user.per_page)
@@ -48,8 +48,8 @@ class ProblemsController &lt; ApplicationController
   def index; end
   def show
-    @notices = problem.object.notices.reverse_ordered
-      .page(params[:notice]).per(1)
+    @notices = problem.object.notices.reverse_ordered.
+      page(params[:notice]).per(1)
     @notice  = NoticeDecorator.new @notices.first
     @comment = Comment.new
   end
@@ -13,10 +13,10 @@ class SiteConfigController &lt; ApplicationController
   end
   private def filtered_update_params
-    params
-      .require(:site_config)
-      .require(:notice_fingerprinter_attributes)
-      .permit(
+    params.
+      require(:site_config).
+      require(:notice_fingerprinter_attributes).
+      permit(
         :error_class,
         :message,
         :backtrace_lines,
@@ -44,9 +44,9 @@ class BacktraceLineDecorator &lt; Draper::Decorator
   end
   def decorated_path
-    path
-      .sub(Backtrace::IN_APP_PATH, '')
-      .sub(Backtrace::GEMS_PATH, "<strong>\\1</strong>")
+    path.
+      sub(Backtrace::IN_APP_PATH, '').
+      sub(Backtrace::GEMS_PATH, "<strong>\\1</strong>")
   end
 private
@@ -56,8 +56,8 @@ module ApplicationHelper
   def create_percentage_table_from_tallies(tallies, options = {})
     total   = (options[:total] || total_from_tallies(tallies))
     percent = 100.0 / total.to_f
-    rows    = tallies.map {|value, count| [(count.to_f * percent), value]} \
-                     .sort {|a, b| b[0] <=> a[0]}
+    rows    = tallies.map {|value, count| [(count.to_f * percent), value]}. \
+                     sort {|a, b| b[0] <=> a[0]}
     render "problems/tally_table", :rows => rows
   end
@@ -22,8 +22,8 @@ describe Api::V3::NoticesController, type: :controller do
   end
   it 'responds with 400 when request attributes are not valid' do
-    allow_any_instance_of(AirbrakeApi::V3::NoticeParser)
-      .to receive(:report).and_raise(AirbrakeApi::ParamsError)
+    allow_any_instance_of(AirbrakeApi::V3::NoticeParser).
+      to receive(:report).and_raise(AirbrakeApi::ParamsError)
     post :create, project_id: 'ID'
     expect(response.status).to eq(400)
     expect(response.body).to eq('Invalid request')
@@ -94,8 +94,8 @@ describe &quot;Callback on Notice&quot;, type: &#39;model&#39; do
       err.problem.update_attributes notices_count: 99
       err.problem.resolve!
-      expect(Mailer).to receive(:err_notification)
-        .and_return(double('email', :deliver_now => true))
+      expect(Mailer).to receive(:err_notification).
+        and_return(double('email', :deliver_now => true))
       ErrorReport.new(notice_attrs).generate_notice!
     end
@@ -118,10 +118,10 @@ describe &quot;Callback on Notice&quot;, type: &#39;model&#39; do
     it 'sends email' do
       error_report = ErrorReport.new(notice_attrs)
-      expect(error_report.app.notification_service)
-        .to receive(:create_notification).and_raise(ArgumentError)
-      expect(Mailer)
-        .to receive(:err_notification).and_return(double(:deliver_now => true))
+      expect(error_report.app.notification_service).
+        to receive(:create_notification).and_raise(ArgumentError)
+      expect(Mailer).
+        to receive(:err_notification).and_return(double(:deliver_now => true))
       error_report.generate_notice!
     end
@@ -153,8 +153,8 @@ describe &quot;Callback on Notice&quot;, type: &#39;model&#39; do
     it 'creates a hipchat notification' do
       error_report = ErrorReport.new(notice_attrs)
-      expect(error_report.app.notification_service)
-        .to receive(:create_notification)
+      expect(error_report.app.notification_service).
+        to receive(:create_notification)
       error_report.generate_notice!
     end
   end
@@ -171,16 +171,16 @@ describe &quot;Callback on Notice&quot;, type: &#39;model&#39; do
     it "should create a campfire notification on first notice" do
       error_report = ErrorReport.new(notice_attrs)
-      expect(error_report.app.notification_service)
-        .to receive(:create_notification)
+      expect(error_report.app.notification_service).
+        to receive(:create_notification)
       error_report.generate_notice! # one
     end
     it "should create a campfire notification on second notice" do
       ErrorReport.new(notice_attrs).generate_notice! # one
       error_report = ErrorReport.new(notice_attrs)
-      expect(error_report.app.notification_service)
-        .to receive(:create_notification)
+      expect(error_report.app.notification_service).
+        to receive(:create_notification)
       error_report.generate_notice! # two
     end
@@ -188,8 +188,8 @@ describe &quot;Callback on Notice&quot;, type: &#39;model&#39; do
       ErrorReport.new(notice_attrs).generate_notice! # one
       ErrorReport.new(notice_attrs).generate_notice! # two
       error_report = ErrorReport.new(notice_attrs)
-      expect(error_report.app.notification_service)
-        .to_not receive(:create_notification)
+      expect(error_report.app.notification_service).
+        to_not receive(:create_notification)
       error_report.generate_notice! # three
     end
   end
	@@ -115,12 +115,6 @@ Style/ConstantName:		@@ -115,12 +115,6 @@ Style/ConstantName:
115	Style/Documentation:	115	Style/Documentation:
116	Enabled: false	116	Enabled: false
117		117
118	-# Offense count: 9
119	-# Cop supports --auto-correct.
120	-# Configuration parameters: EnforcedStyle, SupportedStyles.
121	-Style/DotPosition:
122	- Enabled: false
123	-
124	# Offense count: 5	118	# Offense count: 5
125	Style/EachWithObject:	119	Style/EachWithObject:
126	Exclude:	120	Exclude: