Fix more tests

Arthur Neves
1 parent 5cc81085
Showing 6 changed files with 14 additions and 16 deletions Show diff stats
spec/controllers/problems_controller_spec.rb
spec/errbit_plugin/mock_issue_tracker.rb
spec/fabricators/issue_tracker_fabricator.rb
spec/models/issue_spec.rb
spec/models/problem_spec.rb
spec/views/problems/show.html.haml_spec.rb
@@ -275,7 +275,7 @@ describe ProblemsController do
       end
       it "should redirect to problem page" do
-        expect(response).to redirect_to( app_problem_path(problem.app, problem) )
+        expect(response).to redirect_to(app_problem_path(problem.app, problem))
         expect(flash[:error]).to be_blank
       end
     end
@@ -27,10 +27,9 @@ module ErrbitPlugin
     end
     def errors
-      errors = {}
-      errors[:foo] = 'foo is required' unless options[:foo]
-      errors[:bar] = 'bar is required' unless options[:bar]
-
+      errors = []
+      errors << [:foo, 'foo is required'] unless options[:foo]
+      errors << [:bar, 'bar is required'] unless options[:bar]
       errors
     end
@@ -44,5 +43,3 @@ module ErrbitPlugin
     def comments_allowed?; false; end
   end
 end
-
-ErrbitPlugin::Registry.add_issue_tracker(ErrbitPlugin::MockIssueTracker)
@@ -4,6 +4,5 @@ Fabricator :issue_tracker do
     :foo => 'one',
     :bar => 'two'
   }}
-
   app
 end
@@ -7,6 +7,11 @@ describe Issue do
   let(:problem) { notice.problem }
   let(:notice)  { Fabricate(:notice) }
   let(:user)    { Fabricate(:admin) }
+  let(:issue_tracker) do
+    Fabricate(:issue_tracker).tap do |t|
+      t.instance_variable_set(:@tracker, ErrbitPlugin::MockIssueTracker.new(t.options))
+    end
+  end
   context "when app has no issue tracker" do
     let(:title) { "Foo" }
@@ -26,7 +31,6 @@ describe Issue do
   end
   context "when has no title" do
-    let(:tracker) { Fabricate(:issue_tracker) }
     let(:body) { "barrr" }
     pending "returns an error" do
@@ -34,7 +38,6 @@ describe Issue do
   end
   context "when has no body" do
-    let(:tracker) { Fabricate(:issue_tracker) }
     let(:title) { "Foo" }
     pending "returns an error" do
@@ -42,7 +45,6 @@ describe Issue do
   end
   context "when app has a issue tracker" do
-    let(:issue_tracker) { Fabricate(:issue_tracker) }
     let(:title) { "Foo" }
     let(:body) { "barrr" }
@@ -391,7 +391,9 @@ describe Problem do
       context "with issue_tracker valid associate to app" do
         let(:issue_tracker) do
-          Fabricate(:issue_tracker)
+          Fabricate(:issue_tracker).tap do |t|
+            t.instance_variable_set(:@tracker, ErrbitPlugin::MockIssueTracker.new(t.options))
+          end
         end
         it 'return the issue_tracker label' do
@@ -4,15 +4,13 @@ describe &quot;problems/show.html.haml&quot; do
   let(:problem) { Fabricate(:problem) }
   let(:comment) { Fabricate(:comment) }
   let(:pivotal_tracker) {
-    Class.new(ErrbitPlugin::IssueTracker) do
+    Class.new(ErrbitPlugin::MockIssueTracker) do
       def self.label; 'pivotal'; end
-      def initialize(options); end
       def configured?; true; end
     end
   }
   let(:github_tracker) {
-    Class.new(ErrbitPlugin::IssueTracker) do
-      def initialize(options); end
+    Class.new(ErrbitPlugin::MockIssueTracker) do
       def label; 'github'; end
       def configured?; true; end
     end
	@@ -275,7 +275,7 @@ describe ProblemsController do		@@ -275,7 +275,7 @@ describe ProblemsController do
275	end	275	end
276		276
277	it "should redirect to problem page" do	277	it "should redirect to problem page" do
278	- expect(response).to redirect_to( app_problem_path(problem.app, problem) )	278	+ expect(response).to redirect_to(app_problem_path(problem.app, problem))
279	expect(flash[:error]).to be_blank	279	expect(flash[:error]).to be_blank
280	end	280	end
281	end	281	end
	@@ -4,6 +4,5 @@ Fabricator :issue_tracker do		@@ -4,6 +4,5 @@ Fabricator :issue_tracker do
4	:foo => 'one',	4	:foo => 'one',
5	:bar => 'two'	5	:bar => 'two'
6	}}	6	}}
7	-
8	app	7	app
9	end	8	end