Merge pull request #271 from martinciu/backtrace-extraction

Backtrace extraction

Merge pull request #271 from martinciu/backtrace-extraction
Backtrace extraction
Nathan Broadbent
2 parents f1f109f7 cfc8f4f9
Showing 26 changed files with 297 additions and 148 deletions Show diff stats
app/helpers/backtrace_helper.rb
app/helpers/backtrace_line_helper.rb
app/helpers/notices_helper.rb
app/models/backtrace.rb
app/models/backtrace_line.rb
app/models/backtrace_line_normalizer.rb
app/models/error_report.rb
app/models/notice.rb
app/views/issue_trackers/fogbugz_body.txt.erb
app/views/issue_trackers/github_issues_body.txt.erb
app/views/issue_trackers/lighthouseapp_body.txt.erb
app/views/issue_trackers/pivotal_body.txt.erb
app/views/issue_trackers/textile_body.txt.erb
app/views/mailer/err_notification.html.haml
app/views/mailer/err_notification.text.erb
app/views/notices/_atom_entry.html.haml
app/views/notices/_backtrace_line.html.haml
app/views/problems/show.html.haml
db/migrate/20121003223358_extract_backtraces.rb
db/migrate/20121005142110_regenerate_err_fingerprints.rb
@@ -0,0 +1,16 @@
+module BacktraceHelper
+  # Group lines into sections of in-app files and external files
+  # (An implementation of Enumerable#chunk so we don't break 1.8.7 support.)
+  def grouped_lines(lines)
+    line_groups = []
+    lines.each do |line|
+      in_app = line.in_app?
+      if line_groups.last && line_groups.last[0] == in_app
+        line_groups.last[1] << line
+      else
+        line_groups << [in_app, [line]]
+      end
+    end
+    line_groups
+  end
+end
@@ -0,0 +1,38 @@
+module BacktraceLineHelper
+  def link_to_source_file(line, &block)
+    text = capture_haml(&block)
+    line.in_app? ? link_to_in_app_source_file(line, text) : link_to_external_source_file(text)
+  end
+
+  private
+  def link_to_in_app_source_file(line, text)
+    link_to_repo_source_file(line, text) || link_to_issue_tracker_file(line, text)
+  end
+
+  def link_to_repo_source_file(line, text)
+    link_to_github(line, text) || link_to_bitbucket(line, text)
+  end
+
+  def link_to_external_source_file(text)
+    text
+  end
+
+  def link_to_github(line, text = nil)
+    return unless line.app.github_repo?
+    href = "%s#L%s" % [line.app.github_url_to_file(line.file), line.number]
+    link_to(text || line.file_name, href, :target => '_blank')
+  end
+
+  def link_to_bitbucket(line, text = nil)
+    return unless line.app.bitbucket_repo?
+    href = "%s#cl-%s" % [line.app.bitbucket_url_to_file(line.file), line.number]
+    link_to(text || line.file_name, href, :target => '_blank')
+  end
+
+  def link_to_issue_tracker_file(line, text = nil)
+    return unless line.app.issue_tracker && line.app.issue_tracker.respond_to?(:url_to_file)
+    href = line.app.issue_tracker.url_to_file(line.file, line.number)
+    link_to(text || line.file_name, href, :target => '_blank')
+  end
+
+end
 # encoding: utf-8
 module NoticesHelper
-  def in_app_backtrace_line?(line)
-    !!(line['file'] =~ %r{^\[PROJECT_ROOT\]/(?!(vendor))})
-  end
-
   def notice_atom_summary(notice)
     render "notices/atom_entry.html.haml", :notice => notice
   end
-
-  def link_to_source_file(app, line, &block)
-    text = capture_haml(&block)
-    if in_app_backtrace_line?(line)
-      return link_to_github(app, line, text) if app.github_repo?
-      return link_to_bitbucket(app, line, text) if app.bitbucket_repo?
-      if app.issue_tracker && app.issue_tracker.respond_to?(:url_to_file)
-        # Return link to file on tracker if issue tracker supports this
-        return link_to_issue_tracker_file(app, line, text)
-      end
-    end
-    text
-  end
-
-  def filepath_parts(file)
-    [file.split('/').last, file.gsub('[PROJECT_ROOT]', '')]
-  end
-
-  def link_to_github(app, line, text = nil)
-    file_name, file_path = filepath_parts(line['file'])
-    href = "%s#L%s" % [app.github_url_to_file(file_path), line['number']]
-    link_to(text || file_name, href, :target => '_blank')
-  end
-
-  def link_to_bitbucket(app, line, text = nil)
-    file_name, file_path = filepath_parts(line['file'])
-    href = "%s#cl-%s" % [app.bitbucket_url_to_file(file_path), line['number']]
-    link_to(text || file_name, href, :target => '_blank')
-  end
-
-  def link_to_issue_tracker_file(app, line, text = nil)
-    file_name, file_path = filepath_parts(line['file'])
-    href = app.issue_tracker.url_to_file(file_path, line['number'])
-    link_to(text || file_name, href, :target => '_blank')
-  end
-
-  # Group lines into sections of in-app files and external files
-  # (An implementation of Enumerable#chunk so we don't break 1.8.7 support.)
-  def grouped_lines(lines)
-    line_groups = []
-    lines.each do |line|
-      in_app = in_app_backtrace_line?(line)
-      if line_groups.last && line_groups.last[0] == in_app
-        line_groups.last[1] << line
-      else
-        line_groups << [in_app, [line]]
-      end
-    end
-    line_groups
-  end
-
-  def path_for_backtrace_line(line)
-    path = File.dirname(line['file'])
-    return '' if path == '.'
-    # Remove [PROJECT_ROOT]
-    path.gsub!('[PROJECT_ROOT]/', '')
-    # Make gem name bold if starts with [GEM_ROOT]/gems
-    path.gsub!(/\[GEM_ROOT\]\/gems\/([^\/]+)/, "<strong>\\1</strong>")
-    (path << '/').html_safe
-  end
-
-  def file_for_backtrace_line(line)
-    file = File.basename(line['file'])
-  end
 end
@@ -0,0 +1,36 @@
+class Backtrace
+  include Mongoid::Document
+  include Mongoid::Timestamps
+
+  field :fingerprint
+  index :fingerprint
+
+  has_many :notices
+  has_one :notice
+
+  embeds_many :lines, :class_name => "BacktraceLine"
+
+  after_initialize :generate_fingerprint
+
+  delegate :app, :to => :notice
+
+  def self.find_or_create(attributes = {})
+    new(attributes).similar || create(attributes)
+  end
+
+  def similar
+    Backtrace.first(:conditions => { :fingerprint => fingerprint } )
+  end
+
+  def raw=(raw)
+    raw.each do |raw_line|
+      lines << BacktraceLine.new(BacktraceLineNormalizer.new(raw_line).call)
+    end
+  end
+
+  private
+  def generate_fingerprint
+    self.fingerprint = Digest::SHA1.hexdigest(lines.map(&:to_s).join)
+  end
+
+end
@@ -0,0 +1,42 @@
+class BacktraceLine
+  include Mongoid::Document
+  IN_APP_PATH = %r{^\[PROJECT_ROOT\]\/(?!(vendor))}
+  GEMS_PATH   = %r{\[GEM_ROOT\]\/gems\/([^\/]+)}
+
+  field :number, :type => Integer
+  field :file
+  field :method
+
+  embedded_in :backtrace
+
+  scope :in_app, where(:file => IN_APP_PATH)
+
+  delegate :app, :to => :backtrace
+
+  def to_s
+    "#{file}:#{number}"
+  end
+
+  def in_app?
+    !!(file =~ IN_APP_PATH)
+  end
+
+  def path
+    File.dirname(file).gsub(/^\.$/, '') + "/"
+  end
+
+  def file_relative
+    file.to_s.sub(IN_APP_PATH, '')
+  end
+
+  def file_name
+    File.basename file
+  end
+
+  def decorated_path
+    path.sub(BacktraceLine::IN_APP_PATH, '').
+      sub(BacktraceLine::GEMS_PATH, "<strong>\\1</strong>")
+  end
+
+end
+
@@ -0,0 +1,19 @@
+class BacktraceLineNormalizer
+  def initialize(raw_line)
+    @raw_line = raw_line
+  end
+
+  def call
+    @raw_line.merge 'file' => normalized_file, 'method' => normalized_method
+  end
+
+  private
+  def normalized_file
+    @raw_line['file'].blank? ? "[unknown source]" :  @raw_line['file'].to_s.gsub(/\[PROJECT_ROOT\]\/.*\/ruby\/[0-9.]+\/gems/, '[GEM_ROOT]/gems')
+  end
+
+  def normalized_method
+    @raw_line['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
+  end
+
+end
@@ -2,7 +2,7 @@ require &#39;digest/sha1&#39;
 require 'hoptoad_notifier'
 class ErrorReport
-  attr_reader :error_class, :message, :backtrace, :request, :server_environment, :api_key, :notifier, :user_attributes, :current_user
+  attr_reader :error_class, :message, :request, :server_environment, :api_key, :notifier, :user_attributes, :current_user
   def initialize(xml_or_attributes)
     @attributes = (xml_or_attributes.is_a?(String) ? Hoptoad.parse_xml!(xml_or_attributes) : xml_or_attributes).with_indifferent_access
@@ -29,11 +29,15 @@ class ErrorReport
     @app ||= App.find_by_api_key!(api_key)
   end
+  def backtrace
+    @normalized_backtrace ||= Backtrace.find_or_create(:raw => @backtrace)
+  end
+
   def generate_notice!
     notice = Notice.new(
       :message => message,
       :error_class => error_class,
-      :backtrace => backtrace,
+      :backtrace_id => backtrace.id,
       :request => request,
       :server_environment => server_environment,
       :notifier => notifier,
@@ -55,7 +59,7 @@ class ErrorReport
   private
   def fingerprint_source
     {
-      :backtrace => normalized_backtrace.to_s,
+      :backtrace => backtrace.id,
       :error_class => error_class,
       :component => component,
       :action => action,
@@ -64,11 +68,5 @@ class ErrorReport
     }
   end
-  def normalized_backtrace
-    backtrace[0...3].map do |trace|
-      trace.merge 'method' => trace['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
-    end
-  end
-
 end
@@ -6,15 +6,17 @@ class Notice
   include Mongoid::Timestamps
   field :message
-  field :backtrace, :type => Array
   field :server_environment, :type => Hash
   field :request, :type => Hash
   field :notifier, :type => Hash
   field :user_attributes, :type => Hash
   field :current_user, :type => Hash
   field :error_class
+  delegate :lines, :to => :backtrace, :prefix => true
+  delegate :app, :to => :err
   belongs_to :err
+  belongs_to :backtrace, :index => true
   index :created_at
   index(
     [
@@ -90,17 +92,8 @@ class Notice
     request['session'] || {}
   end
-  # Backtrace containing only files from the app itself (ignore gems)
-  def app_backtrace
-    backtrace.select { |l| l && l['file'] && l['file'].include?("[PROJECT_ROOT]") }
-  end
-
-  def backtrace
-    # If gems are vendored into project, treat vendored gem dir as [GEM_ROOT]
-    (read_attribute(:backtrace) || []).map do |line|
-      # Changes "[PROJECT_ROOT]/rubygems/ruby/1.9.1/gems" to "[GEM_ROOT]/gems"
-      line.merge 'file' => line['file'].to_s.gsub(/\[PROJECT_ROOT\]\/.*\/ruby\/[0-9.]+\/gems/, '[GEM_ROOT]/gems')
-    end
+  def in_app_backtrace_lines
+    backtrace_lines.in_app
   end
   protected
@@ -129,8 +122,6 @@ class Notice
     [:server_environment, :request, :notifier].each do |h|
       send("#{h}=",sanitize_hash(send(h)))
     end
-    # Set unknown backtrace files
-    read_attribute(:backtrace).each{|line| line['file'] = "[unknown source]" if line['file'].blank? }
   end
   def sanitize_hash(h)
@@ -19,8 +19,8 @@
   <%= pretty_hash(notice.session) %>
   Backtrace
-  <% for line in notice.backtrace %>
-    <%= line['number'] %>:  <%= line['file'].to_s.sub(/^\[PROJECT_ROOT\]/, '') %>
+  <% for line in notice.backtrace_lines %>
+    <%= line.number %>:  <%= line.file_relative %>
   <% end %>
   Environment
@@ -27,7 +27,7 @@
 ## Backtrace ##
 ```
-<% for line in notice.backtrace %><%= line['number'] %>:  <%= line['file'].to_s.sub(/^\[PROJECT_ROOT\]/, '') %> -> **<%= line['method'] %>**
+<% for line in notice.backtrace_lines %><%= line.number %>:  <%= line.file_relative %> -> **<%= line.method %>**
 <% end %>
 ```
@@ -23,7 +23,7 @@
   ## Backtrace ##
   <code>
-  <% for line in notice.backtrace %><%= line['number'] %>:  <%= line['file'].to_s.sub(/^\[PROJECT_ROOT\]/, '') %> -> **<%= line['method'] %>**
+  <% for line in notice.backtrace_lines %><%= line.number %>:  <%= line.file_relative %> -> **<%= line.method %>**
   <% end %>
   </code>
@@ -12,6 +12,6 @@ See this exception on Errbit: &lt;%= app_problem_url problem.app, problem %&gt;
     <%= pretty_hash notice.session %>
     Backtrace:
-    <%= notice.backtrace[0..4].map { |line| "#{line['number']}: #{line['file'].to_s.sub(/^\[PROJECT_ROOT\]/, '')} -> *#{line['method']}*" }.join "\n" %>
+    <%= notice.backtrace_lines[0..4].map { |line| "#{line.number}: #{line.file_relative} -> *#{line.method}*" }.join "\n" %>
 <% end %>
@@ -32,7 +32,7 @@ h2. Session
 h2. Backtrace
 | Line | File | Method |
-<% for line in notice.backtrace %>| <%= line['number'] %> | <%= line['file'].to_s.sub(/^\[PROJECT_ROOT\]/, '') %> | *<%= line['method'] %>* |
+<% for line in notice.backtrace_lines %>| <%= line.number %> | <%= line.file_relative %> | *<%= line.method %>* |
 <% end %>
 h2. Environment
@@ -27,16 +27,15 @@
               %p.heading WHERE:
               %p.monospace
                 = @notice.where
-              - if (app_backtrace = @notice.app_backtrace).any?
-                - app_backtrace.map {|l| "#{l['file']}:#{l['number']}" }.each do |line|
-                  %p.backtrace= line
+              - @notice.in_app_backtrace_lines.each do |line|
+                %p.backtrace= line
                 %br
               %p.heading URL:
               %p.monospace
                 - if @notice.request['url'].present?
                   = link_to @notice.request['url'], @notice.request['url']
               %p.heading BACKTRACE:
-              - @notice.backtrace.map {|l| l ? "#{l['file']}:#{l['number']}" : nil }.compact.each do |line|
+              - @notice.backtrace_lines.each do |line|
                 %p.backtrace= line
               %br
@@ -14,7 +14,7 @@ WHERE:
 <%= @notice.where %>
-<% @notice.app_backtrace.map {|l| "#{l['file']}:#{l['number']}" }.each do |line| %>
+<% @notice.in_app_backtrace_lines.each do |line| %>
   <%= line %>
 <% end %>
@@ -26,7 +26,7 @@ URL:
 BACKTRACE:
-<% @notice.backtrace.map {|l| l ? "#{l['file']}:#{l['number']}" : nil }.compact.each do |line| %>
+<% @notice.backtrace_lines.each do |line| %>
   <%= line %>
 <% end %>
@@ -22,13 +22,13 @@
 %h3 Backtrace
 %table
-  - for line in notice.backtrace
+  - for line in notice.backtrace_lines
     %tr
       %td
-        = "#{line['number']}:"
+        = "#{line.number}:"
         &nbsp;&nbsp;
       %td
-        = raw "#{h line['file'].sub(/^\[PROJECT_ROOT\]/, '')} -> #{content_tag :strong, h(line['method'])}"
+        = raw "#{h line.file_relative} -> #{content_tag :strong, h(line.method)}"
 %h3 Environment
 %table
-%tr{:class => defined?(row_class) ? row_class : nil}
-  %td.line{:class => (in_app_backtrace_line?(line) ? 'in-app' : nil)}
-    = link_to_source_file(@app, line) do
-      %span.path>= path_for_backtrace_line(line)
-      %span.file>=  file_for_backtrace_line(line)
-      - if line['number'].present?
-        %span.number>= ":#{line['number']}"
+%tr{:class => defined?(row_class) && row_class}
+  %td.line{:class => line.in_app? && 'in-app' }
+    = link_to_source_file(line) do
+      %span.path>=raw line.decorated_path
+      %span.file>= line.file_name
+      - if line.number.present?
+        %span.number>= ":#{line.number}"
     &rarr;
-    %span.method= line['method']
+    %span.method= line.method
@@ -68,7 +68,7 @@
   #backtrace
     %h3 Backtrace
-    = render 'notices/backtrace', :lines => @notice.backtrace
+    = render 'notices/backtrace', :lines => @notice.backtrace_lines
   - if @notice.user_attributes.present?
     #user_attributes
@@ -0,0 +1,15 @@
+class ExtractBacktraces < Mongoid::Migration
+  def self.up
+    say "It could take long time (hours if you have many Notices)"
+    Notice.unscoped.all.each do |notice|
+      backtrace = Backtrace.find_or_create(:raw => notice['backtrace'])
+      notice.backtrace = backtrace
+      notice['backtrace'] = nil
+      notice.save!
+    end
+    say "run `db.repairDatabase()` (in mongodb console) to recover deleted space"
+  end
+
+  def self.down
+  end
+end
@@ -0,0 +1,19 @@
+class RegenerateErrFingerprints < Mongoid::Migration
+  def self.up
+    Err.all.each do |err|
+      fingerprint_source = {
+        :backtrace   => err.notices.first.backtrace_id,
+        :error_class => err.error_class,
+        :component   => err.component,
+        :action      => err.action,
+        :environment => err.environment,
+        :api_key     => err.app.api_key
+      }
+      fingerprint = Digest::SHA1.hexdigest(fingerprint_source.to_s)
+      err.update_attribute(:fingerprint, fingerprint)
+    end
+  end
+
+  def self.down
+  end
+end
@@ -9,19 +9,19 @@ end
 Fabricator :notice do
   err!
   message             'FooError: Too Much Bar'
-  backtrace           { random_backtrace }
+  backtrace!
   server_environment  { {'environment-name' => 'production'} }
   request             {{ 'component' => 'foo', 'action' => 'bar' }}
   notifier            {{ 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' }}
 end
-def random_backtrace
-  backtrace = []
-  99.times {|t| backtrace << {
-    'number'  => rand(999),
-    'file'    => "/path/to/file/#{SecureRandom.hex(4)}.rb",
-    'method'  => ActiveSupport.methods.shuffle.first
-  }}
-  backtrace
+Fabricator :backtrace do
+  fingerprint "fingerprint"
+  lines(:count => 99) { Fabricate.build(:backtrace_line) }
 end
+Fabricator :backtrace_line do
+  number { rand(999) }
+  file { "/path/to/file/#{SecureRandom.hex(4)}.rb" }
+  method(:method) { ActiveSupport.methods.shuffle.first }
+end
@@ -200,8 +200,8 @@ describe App do
     it 'captures the backtrace' do
       @notice = App.report_error!(@xml)
-      @notice.backtrace.size.should == 73
-      @notice.backtrace.last['file'].should == '[GEM_ROOT]/bin/rake'
+      @notice.backtrace_lines.size.should == 73
+      @notice.backtrace_lines.last['file'].should == '[GEM_ROOT]/bin/rake'
     end
     it 'captures the server_environment' do
@@ -228,7 +228,7 @@ describe App do
     it "should handle params with only a single line of backtrace" do
       xml = Rails.root.join('spec','fixtures','hoptoad_test_notice_with_one_line_of_backtrace.xml').read
       lambda { @notice = App.report_error!(xml) }.should_not raise_error
-      @notice.backtrace.length.should == 1
+      @notice.backtrace_lines.length.should == 1
     end
     it 'captures the current_user' do
@@ -238,7 +238,7 @@ describe App do
       @notice.current_user['email'].should == 'mr.bean@example.com'
       @notice.current_user['username'].should == 'mrbean'
     end
- 
+
   end
@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe BacktraceLineNormalizer do
+  subject { described_class.new(raw_line).call }
+
+  describe "sanitize file" do
+    let(:raw_line) { { 'number' => rand(999), 'file' => nil, 'method' => ActiveSupport.methods.shuffle.first.to_s } }
+
+    it "should replace nil file with [unknown source]" do
+      subject['file'].should == "[unknown source]"
+    end
+
+  end
+end
@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe Backtrace do
+  subject { described_class.new }
+
+  its(:fingerprint) { should be_present }
+
+  describe "#similar" do
+    context "no similar backtrace" do
+      its(:similar) { should be_nil }
+    end
+
+    context "similar backtrace exist" do
+      let!(:similar_backtrace) { Fabricate(:backtrace, :fingerprint => fingerprint) }
+      let(:fingerprint) { "fingerprint" }
+
+      before { subject.stub(:fingerprint => fingerprint) }
+
+      its(:similar) { should == similar_backtrace }
+    end
+  end
+
+  describe "find_or_create" do
+    subject { described_class.find_or_create(attributes) }
+    let(:attributes) { mock :attributes }
+    let(:backtrace) { mock :backtrace }
+
+    before { described_class.stub(:new => backtrace) }
+
+    context "no similar backtrace" do
+      before { backtrace.stub(:similar => nil) }
+      it "create new backtrace" do
+        described_class.should_receive(:create).with(attributes)
+
+        described_class.find_or_create(attributes)
+      end
+    end
+
+    context "similar backtrace exist" do
+      let(:similar_backtrace) { mock :similar_backtrace }
+      before { backtrace.stub(:similar => similar_backtrace) }
+
+      it { should == similar_backtrace }
+    end
+  end
+end
@@ -46,6 +46,7 @@ describe NoticeObserver do
   describe "should send a notification if a notification service is configured" do
     let(:app) { Fabricate(:app, :email_at_notices => [1], :notification_service => Fabricate(:campfire_notification_service))}
     let(:err) { Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 100)) }
+    let(:backtrace) { Fabricate(:backtrace) }
     before do
       Errbit::Config.per_app_email_at_notices = true
@@ -59,13 +60,14 @@ describe NoticeObserver do
       app.notification_service.should_receive(:create_notification)
       Notice.create!(:err => err, :message => 'FooError: Too Much Bar', :server_environment => {'environment-name' => 'production'},
-                     :backtrace => [{ :error => 'Le Broken' }], :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
+                     :backtrace => backtrace, :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
     end
   end
   describe "should not send a notification if a notification service is not configured" do
     let(:app) { Fabricate(:app, :email_at_notices => [1], :notification_service => Fabricate(:notification_service))}
     let(:err) { Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 100)) }
+    let(:backtrace) { Fabricate(:backtrace) }
     before do
       Errbit::Config.per_app_email_at_notices = true
@@ -79,7 +81,7 @@ describe NoticeObserver do
       app.notification_service.should_not_receive(:create_notification)
       Notice.create!(:err => err, :message => 'FooError: Too Much Bar', :server_environment => {'environment-name' => 'production'},
-                     :backtrace => [{ :error => 'Le Broken' }], :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
+                     :backtrace => backtrace, :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
     end
   end
@@ -1,18 +0,0 @@
-require 'spec_helper'
-
-describe "notices/_backtrace.html.haml" do
-  describe 'missing file in backtrace' do
-    let(:notice) do
-      backtrace = { 'number' => rand(999), 'file' => nil, 'method' => ActiveSupport.methods.shuffle.first }
-      Fabricate(:notice, :backtrace => [backtrace])
-    end
-
-    it "should replace nil file with [unknown source]" do
-      assign :app, notice.err.app
-
-      render "notices/backtrace", :lines => notice.backtrace
-      rendered.should match(/\[unknown source\]/)
-    end
-  end
-end
-
@@ -0,0 +1,16 @@		@@ -0,0 +1,16 @@
	1	+module BacktraceHelper
	2	+ # Group lines into sections of in-app files and external files
	3	+ # (An implementation of Enumerable#chunk so we don't break 1.8.7 support.)
	4	+ def grouped_lines(lines)
	5	+ line_groups = []
	6	+ lines.each do \|line\|
	7	+ in_app = line.in_app?
	8	+ if line_groups.last && line_groups.last[0] == in_app
	9	+ line_groups.last[1] << line
	10	+ else
	11	+ line_groups << [in_app, [line]]
	12	+ end
	13	+ end
	14	+ line_groups
	15	+ end
	16	+end
@@ -0,0 +1,38 @@		@@ -0,0 +1,38 @@
	1	+module BacktraceLineHelper
	2	+ def link_to_source_file(line, &block)
	3	+ text = capture_haml(&block)
	4	+ line.in_app? ? link_to_in_app_source_file(line, text) : link_to_external_source_file(text)
	5	+ end
	6	+
	7	+ private
	8	+ def link_to_in_app_source_file(line, text)
	9	+ link_to_repo_source_file(line, text) \|\| link_to_issue_tracker_file(line, text)
	10	+ end
	11	+
	12	+ def link_to_repo_source_file(line, text)
	13	+ link_to_github(line, text) \|\| link_to_bitbucket(line, text)
	14	+ end
	15	+
	16	+ def link_to_external_source_file(text)
	17	+ text
	18	+ end
	19	+
	20	+ def link_to_github(line, text = nil)
	21	+ return unless line.app.github_repo?
	22	+ href = "%s#L%s" % [line.app.github_url_to_file(line.file), line.number]
	23	+ link_to(text \|\| line.file_name, href, :target => '_blank')
	24	+ end
	25	+
	26	+ def link_to_bitbucket(line, text = nil)
	27	+ return unless line.app.bitbucket_repo?
	28	+ href = "%s#cl-%s" % [line.app.bitbucket_url_to_file(line.file), line.number]
	29	+ link_to(text \|\| line.file_name, href, :target => '_blank')
	30	+ end
	31	+
	32	+ def link_to_issue_tracker_file(line, text = nil)
	33	+ return unless line.app.issue_tracker && line.app.issue_tracker.respond_to?(:url_to_file)
	34	+ href = line.app.issue_tracker.url_to_file(line.file, line.number)
	35	+ link_to(text \|\| line.file_name, href, :target => '_blank')
	36	+ end
	37	+
	38	+end
1	# encoding: utf-8	1	# encoding: utf-8
2	module NoticesHelper	2	module NoticesHelper
3	- def in_app_backtrace_line?(line)
4	- !!(line['file'] =~ %r{^\[PROJECT_ROOT\]/(?!(vendor))})
5	- end
6	-
7	def notice_atom_summary(notice)	3	def notice_atom_summary(notice)
8	render "notices/atom_entry.html.haml", :notice => notice	4	render "notices/atom_entry.html.haml", :notice => notice
9	end	5	end
10	-
11	- def link_to_source_file(app, line, &block)
12	- text = capture_haml(&block)
13	- if in_app_backtrace_line?(line)
14	- return link_to_github(app, line, text) if app.github_repo?
15	- return link_to_bitbucket(app, line, text) if app.bitbucket_repo?
16	- if app.issue_tracker && app.issue_tracker.respond_to?(:url_to_file)
17	- # Return link to file on tracker if issue tracker supports this
18	- return link_to_issue_tracker_file(app, line, text)
19	- end
20	- end
21	- text
22	- end
23	-
24	- def filepath_parts(file)
25	- [file.split('/').last, file.gsub('[PROJECT_ROOT]', '')]
26	- end
27	-
28	- def link_to_github(app, line, text = nil)
29	- file_name, file_path = filepath_parts(line['file'])
30	- href = "%s#L%s" % [app.github_url_to_file(file_path), line['number']]
31	- link_to(text \|\| file_name, href, :target => '_blank')
32	- end
33	-
34	- def link_to_bitbucket(app, line, text = nil)
35	- file_name, file_path = filepath_parts(line['file'])
36	- href = "%s#cl-%s" % [app.bitbucket_url_to_file(file_path), line['number']]
37	- link_to(text \|\| file_name, href, :target => '_blank')
38	- end
39	-
40	- def link_to_issue_tracker_file(app, line, text = nil)
41	- file_name, file_path = filepath_parts(line['file'])
42	- href = app.issue_tracker.url_to_file(file_path, line['number'])
43	- link_to(text \|\| file_name, href, :target => '_blank')
44	- end
45	-
46	- # Group lines into sections of in-app files and external files
47	- # (An implementation of Enumerable#chunk so we don't break 1.8.7 support.)
48	- def grouped_lines(lines)
49	- line_groups = []
50	- lines.each do \|line\|
51	- in_app = in_app_backtrace_line?(line)
52	- if line_groups.last && line_groups.last[0] == in_app
53	- line_groups.last[1] << line
54	- else
55	- line_groups << [in_app, [line]]
56	- end
57	- end
58	- line_groups
59	- end
60	-
61	- def path_for_backtrace_line(line)
62	- path = File.dirname(line['file'])
63	- return '' if path == '.'
64	- # Remove [PROJECT_ROOT]
65	- path.gsub!('[PROJECT_ROOT]/', '')
66	- # Make gem name bold if starts with [GEM_ROOT]/gems
67	- path.gsub!(/\[GEM_ROOT\]\/gems\/([^\/]+)/, "<strong>\\1</strong>")
68	- (path << '/').html_safe
69	- end
70	-
71	- def file_for_backtrace_line(line)
72	- file = File.basename(line['file'])
73	- end
74	end	6	end
75		7
@@ -0,0 +1,36 @@		@@ -0,0 +1,36 @@
	1	+class Backtrace
	2	+ include Mongoid::Document
	3	+ include Mongoid::Timestamps
	4	+
	5	+ field :fingerprint
	6	+ index :fingerprint
	7	+
	8	+ has_many :notices
	9	+ has_one :notice
	10	+
	11	+ embeds_many :lines, :class_name => "BacktraceLine"
	12	+
	13	+ after_initialize :generate_fingerprint
	14	+
	15	+ delegate :app, :to => :notice
	16	+
	17	+ def self.find_or_create(attributes = {})
	18	+ new(attributes).similar \|\| create(attributes)
	19	+ end
	20	+
	21	+ def similar
	22	+ Backtrace.first(:conditions => { :fingerprint => fingerprint } )
	23	+ end
	24	+
	25	+ def raw=(raw)
	26	+ raw.each do \|raw_line\|
	27	+ lines << BacktraceLine.new(BacktraceLineNormalizer.new(raw_line).call)
	28	+ end
	29	+ end
	30	+
	31	+ private
	32	+ def generate_fingerprint
	33	+ self.fingerprint = Digest::SHA1.hexdigest(lines.map(&:to_s).join)
	34	+ end
	35	+
	36	+end
@@ -0,0 +1,42 @@		@@ -0,0 +1,42 @@
	1	+class BacktraceLine
	2	+ include Mongoid::Document
	3	+ IN_APP_PATH = %r{^\[PROJECT_ROOT\]\/(?!(vendor))}
	4	+ GEMS_PATH = %r{\[GEM_ROOT\]\/gems\/([^\/]+)}
	5	+
	6	+ field :number, :type => Integer
	7	+ field :file
	8	+ field :method
	9	+
	10	+ embedded_in :backtrace
	11	+
	12	+ scope :in_app, where(:file => IN_APP_PATH)
	13	+
	14	+ delegate :app, :to => :backtrace
	15	+
	16	+ def to_s
	17	+ "#{file}:#{number}"
	18	+ end
	19	+
	20	+ def in_app?
	21	+ !!(file =~ IN_APP_PATH)
	22	+ end
	23	+
	24	+ def path
	25	+ File.dirname(file).gsub(/^\.$/, '') + "/"
	26	+ end
	27	+
	28	+ def file_relative
	29	+ file.to_s.sub(IN_APP_PATH, '')
	30	+ end
	31	+
	32	+ def file_name
	33	+ File.basename file
	34	+ end
	35	+
	36	+ def decorated_path
	37	+ path.sub(BacktraceLine::IN_APP_PATH, '').
	38	+ sub(BacktraceLine::GEMS_PATH, "<strong>\\1</strong>")
	39	+ end
	40	+
	41	+end
	42	+
@@ -0,0 +1,19 @@		@@ -0,0 +1,19 @@
	1	+class BacktraceLineNormalizer
	2	+ def initialize(raw_line)
	3	+ @raw_line = raw_line
	4	+ end
	5	+
	6	+ def call
	7	+ @raw_line.merge 'file' => normalized_file, 'method' => normalized_method
	8	+ end
	9	+
	10	+ private
	11	+ def normalized_file
	12	+ @raw_line['file'].blank? ? "[unknown source]" : @raw_line['file'].to_s.gsub(/\[PROJECT_ROOT\]\/.*\/ruby\/[0-9.]+\/gems/, '[GEM_ROOT]/gems')
	13	+ end
	14	+
	15	+ def normalized_method
	16	+ @raw_line['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
	17	+ end
	18	+
	19	+end
	@@ -27,7 +27,7 @@		@@ -27,7 +27,7 @@
27		27
28	## Backtrace ##	28	## Backtrace ##
29	```	29	```
30	-<% for line in notice.backtrace %><%= line['number'] %>: <%= line['file'].to_s.sub(/^\[PROJECT_ROOT\]/, '') %> -> <%= line['method'] %>	30	+<% for line in notice.backtrace_lines %><%= line.number %>: <%= line.file_relative %> -> <%= line.method %>
31	<% end %>	31	<% end %>
32	```	32	```
33		33
	@@ -23,7 +23,7 @@		@@ -23,7 +23,7 @@
23		23
24	## Backtrace ##	24	## Backtrace ##
25	<code>	25	<code>
26	- <% for line in notice.backtrace %><%= line['number'] %>: <%= line['file'].to_s.sub(/^\[PROJECT_ROOT\]/, '') %> -> <%= line['method'] %>	26	+ <% for line in notice.backtrace_lines %><%= line.number %>: <%= line.file_relative %> -> <%= line.method %>
27	<% end %>	27	<% end %>
28	</code>	28	</code>
29		29
	@@ -12,6 +12,6 @@ See this exception on Errbit: <%= app_problem_url problem.app, problem %>		@@ -12,6 +12,6 @@ See this exception on Errbit: <%= app_problem_url problem.app, problem %>
12	<%= pretty_hash notice.session %>	12	<%= pretty_hash notice.session %>
13		13
14	Backtrace:	14	Backtrace:
15	- <%= notice.backtrace[0..4].map { \|line\| "#{line['number']}: #{line['file'].to_s.sub(/^\[PROJECT_ROOT\]/, '')} -> #{line['method']}" }.join "\n" %>	15	+ <%= notice.backtrace_lines[0..4].map { \|line\| "#{line.number}: #{line.file_relative} -> #{line.method}" }.join "\n" %>
16	<% end %>	16	<% end %>
17		17
	@@ -32,7 +32,7 @@ h2. Session		@@ -32,7 +32,7 @@ h2. Session
32	h2. Backtrace	32	h2. Backtrace
33		33
34	\| Line \| File \| Method \|	34	\| Line \| File \| Method \|
35	-<% for line in notice.backtrace %>\| <%= line['number'] %> \| <%= line['file'].to_s.sub(/^\[PROJECT_ROOT\]/, '') %> \| <%= line['method'] %> \|	35	+<% for line in notice.backtrace_lines %>\| <%= line.number %> \| <%= line.file_relative %> \| <%= line.method %> \|
36	<% end %>	36	<% end %>
37		37
38	h2. Environment	38	h2. Environment