refactor and reorganize after mongoid5 upgrade

Stephen Crosby
1 parent 912600bb
Showing 15 changed files with 533 additions and 403 deletions Show diff stats
app/interactors/resolved_problem_clearer.rb
app/models/app.rb
app/models/deploy.rb
app/models/error_report.rb
app/models/notice.rb
app/models/notification_service.rb
app/models/problem.rb
config/mongo.rb
spec/fabricators/err_fabricator.rb
spec/interactors/resolved_problem_clearer_spec.rb
spec/models/error_report_spec.rb
spec/models/notice_observer_spec.rb
spec/models/notice_spec.rb
spec/models/problem_spec.rb
spec/spec_helper.rb
@@ -27,6 +27,6 @@ class ResolvedProblemClearer
   end
   def repair_database
-    Mongoid.default_session.command :repairDatabase => 1
+    Mongoid.default_client.command :repairDatabase => 1
   end
 end
@@ -58,7 +58,11 @@ class App
     Err.where(
       :fingerprint => attrs[:fingerprint]
     ).first || (
-      problem = problems.create!(attrs.slice(:error_class, :environment))
+      problem = problems.create!(
+        error_class: attrs[:error_class],
+        environment: attrs[:environment],
+        app_name: name
+      )
       problem.errs.create!(attrs.slice(:fingerprint, :problem_id))
     )
   end
@@ -180,7 +184,9 @@ class App
   protected
     def store_cached_attributes_on_problems
-      problems.each(&:cache_app_attributes)
+      Problem.where(:app_id => id).update_all(
+        app_name: name
+      )
     end
     def generate_api_key
@@ -33,7 +33,9 @@ class Deploy
     end
     def store_cached_attributes_on_problems
-      Problem.where(:app_id => app.id).each(&:cache_app_attributes)
+      Problem.where(:app_id => app.id).update_all(
+        last_deploy_at: created_at
+      )
     end
     def deliver_email
@@ -15,8 +15,16 @@ require &#39;hoptoad_notifier&#39;
 # * <tt>:notifier</tt> - information to identify the source of the error report
 #
 class ErrorReport
-  attr_reader :error_class, :message, :request, :server_environment, :api_key,
-              :notifier, :user_attributes, :framework, :notice
+  attr_reader :api_key
+  attr_reader :error_class
+  attr_reader :framework
+  attr_reader :message
+  attr_reader :notice
+  attr_reader :notifier
+  attr_reader :problem
+  attr_reader :request
+  attr_reader :server_environment
+  attr_reader :user_attributes
   cattr_accessor :fingerprint_strategy do
     Fingerprint::Sha1
@@ -70,42 +78,16 @@ class ErrorReport
   # Update problem cache with information about this notice
   def cache_attributes_on_problem
-    # increment notice count
-    message_digest = Digest::MD5.hexdigest(@notice.message)
-    host_digest = Digest::MD5.hexdigest(@notice.host)
-    user_agent_digest = Digest::MD5.hexdigest(@notice.user_agent_string)
-
-    @problem = Problem.where("_id" => @error.problem_id).find_one_and_update(
-      '$set' => {
-        'app_name' => app.name,
-        'environment' => @notice.environment_name,
-        'error_class' => @notice.error_class,
-        'last_notice_at' => @notice.created_at,
-        'message' => @notice.message,
-        'resolved' => false,
-        'resolved_at' => nil,
-        'where' => @notice.where,
-        "messages.#{message_digest}.value" => @notice.message,
-        "hosts.#{host_digest}.value" => @notice.host,
-        "user_agents.#{user_agent_digest}.value" => @notice.user_agent_string,
-      },
-      '$inc' => {
-        'notices_count' => 1,
-        "messages.#{message_digest}.count" => 1,
-        "hosts.#{host_digest}.count" => 1,
-        "user_agents.#{user_agent_digest}.count" => 1,
-      }
-    )
-  end
+    @problem = Problem.cache_notice(@error.problem_id, @notice)
-  def similar_count
-    @similar_count ||= @problem.notices_count
+    # cache_notice returns the old problem, so the count is one higher
+    @similar_count = @problem.notices_count + 1
   end
   # Send email notification if needed
   def email_notification
     return false unless app.emailable?
-    return false unless app.email_at_notices.include?(similar_count)
+    return false unless app.email_at_notices.include?(@similar_count)
     Mailer.err_notification(@notice).deliver
   rescue => e
     HoptoadNotifier.notify(e)
@@ -113,7 +95,7 @@ class ErrorReport
   def should_notify?
     app.notification_service.notify_at_notices.include?(0) ||
-      app.notification_service.notify_at_notices.include?(similar_count)
+      app.notification_service.notify_at_notices.include?(@similar_count)
   end
   # Launch all notification define on the app associate to this notice
@@ -21,7 +21,7 @@ class Notice
   index(:err_id => 1, :created_at => 1, :_id => 1)
   before_save :sanitize
-  before_destroy :decrease_counter_cache, :remove_cached_attributes_from_problem
+  before_destroy :problem_recache
   validates_presence_of :backtrace_id, :server_environment, :notifier
@@ -124,12 +124,8 @@ class Notice
   protected
-  def decrease_counter_cache
-    problem.inc(notices_count: -1) if err
-  end
-
-  def remove_cached_attributes_from_problem
-    problem.remove_cached_notice_attributes(self) if err
+  def problem_recache
+    problem.uncache_notice(self)
   end
   def sanitize
@@ -26,7 +26,7 @@ class NotificationService
   else
     Fields = []
   end
-       
+
   def notify_at_notices
     Errbit::Config.per_app_notify_at_notices ? super : Errbit::Config.notify_at_notices
   end
@@ -6,8 +6,15 @@ class Problem
   include Mongoid::Document
   include Mongoid::Timestamps
-  field :last_notice_at, :type => DateTime, :default => Proc.new { Time.now }
-  field :first_notice_at, :type => DateTime, :default => Proc.new { Time.now }
+  CACHED_NOTICE_ATTRIBUTES = {
+    messages: :message,
+    hosts: :host,
+    user_agents: :user_agent_string
+  }.freeze
+
+
+  field :last_notice_at, :type => ActiveSupport::TimeWithZone, :default => Proc.new { Time.now }
+  field :first_notice_at, :type => ActiveSupport::TimeWithZone, :default => Proc.new { Time.now }
   field :last_deploy_at, :type => Time
   field :resolved, :type => Boolean, :default => false
   field :resolved_at, :type => Time
@@ -63,6 +70,83 @@ class Problem
     env.present? ? where(:environment => env) : scoped
   end
+  def self.cache_notice(id, notice)
+    # increment notice count
+    message_digest = Digest::MD5.hexdigest(notice.message)
+    host_digest = Digest::MD5.hexdigest(notice.host)
+    user_agent_digest = Digest::MD5.hexdigest(notice.user_agent_string)
+
+    Problem.where('_id' => id).find_one_and_update(
+      '$set' => {
+        'environment' => notice.environment_name,
+        'error_class' => notice.error_class,
+        'last_notice_at' => notice.created_at.utc,
+        'message' => notice.message,
+        'resolved' => false,
+        'resolved_at' => nil,
+        'where' => notice.where,
+        "messages.#{message_digest}.value" => notice.message,
+        "hosts.#{host_digest}.value" => notice.host,
+        "user_agents.#{user_agent_digest}.value" => notice.user_agent_string,
+      },
+      '$inc' => {
+        'notices_count' => 1,
+        "messages.#{message_digest}.count" => 1,
+        "hosts.#{host_digest}.count" => 1,
+        "user_agents.#{user_agent_digest}.count" => 1,
+      }
+    )
+  end
+
+  def uncache_notice(notice)
+    last_notice = notices.last
+
+    atomically do |doc|
+      doc.set(
+        'environment' => last_notice.environment_name,
+        'error_class' => last_notice.error_class,
+        'last_notice_at' => last_notice.created_at,
+        'message' => last_notice.message,
+        'where' => last_notice.where,
+        'notices_count' => notices_count.to_i > 1 ? notices_count - 1 : 0
+      )
+
+      CACHED_NOTICE_ATTRIBUTES.each do |k,v|
+        digest = Digest::MD5.hexdigest(notice.send(v))
+        field = "#{k}.#{digest}"
+
+        if (doc[k].try(:[], digest).try(:[], :count)).to_i > 1
+          doc.inc("#{field}.count" => -1)
+        else
+          doc.unset(field)
+        end
+      end
+    end
+  end
+
+  def recache
+    CACHED_NOTICE_ATTRIBUTES.each do |k,v|
+      # clear all cached attributes
+      send("#{k}=", {})
+
+      # find only notices related to this problem
+      Notice.collection.find.aggregate([
+        { "$match" => { err_id: { "$in" => err_ids } } },
+        { "$group" => { _id: "$#{v}", count: {"$sum" => 1} } }
+      ]).each do |agg|
+        next if agg[:_id] == nil
+
+        send(k)[Digest::MD5.hexdigest(agg[:_id])] = {
+          value: agg[:_id],
+          count: agg[:count]
+        }
+      end
+    end
+
+    self.notices_count = Notice.where({ err_id: { "$in" => err_ids }}).count
+    save
+  end
+
   def url
     Rails.application.routes.url_helpers.app_problem_url(app, self,
       :host => Errbit::Config.host,
@@ -98,16 +182,21 @@ class Problem
   def unmerge!
     attrs = {:error_class => error_class, :environment => environment}
     problem_errs = errs.to_a
-    problem_errs.shift
-    [self] + problem_errs.map(&:id).map do |err_id|
-      err = Err.find(err_id)
-      app.problems.create(attrs).tap do |new_problem|
-        err.update_attribute(:problem_id, new_problem.id)
-        new_problem.reset_cached_attributes
-      end
+
+    # associate and return all the problems
+    new_problems = [self]
+
+    # create new problems for each err that needs one
+    (problem_errs[1..-1] || []).each do |err|
+      new_problems << app.problems.create(attrs)
+      err.update_attribute(:problem, new_problems.last)
     end
-  end
+    # recache each new problem
+    new_problems.each(&:recache)
+
+    new_problems
+  end
   def self.ordered_by(sort, order)
     case sort
@@ -124,11 +213,6 @@ class Problem
     where(:first_notice_at.lte => date_range.end).where("$or" => [{:resolved_at => nil}, {:resolved_at.gte => date_range.begin}])
   end
-
-  def reset_cached_attributes
-    ProblemUpdaterCache.new(self).update
-  end
-
   def cache_app_attributes
     if app
       self.app_name = app.name
@@ -140,14 +224,6 @@ class Problem
     self.message = self.message[0, 1000] if self.message
   end
-  def remove_cached_notice_attributes(notice)
-    update_attributes!(
-      :messages    => attribute_count_descrease(:messages, notice.message),
-      :hosts       => attribute_count_descrease(:hosts, notice.host),
-      :user_agents => attribute_count_descrease(:user_agents, notice.user_agent_string)
-    )
-  end
-
   def issue_type
     # Return issue_type if configured, but fall back to detecting app's issue tracker
     attributes['issue_type'] ||=
-Mongoid.logger.level = Logger.const_get Errbit::Config.log_level.upcase
+log_level = Logger.const_get Errbit::Config.log_level.upcase
+
+Mongoid.logger.level = log_level
+Mongo::Logger.level = log_level
 Mongoid.configure do |config|
   uri = if Errbit::Config.mongo_url == 'mongodb://localhost'
@@ -10,6 +10,11 @@ Fabricator :notice do
   server_environment  { {'environment-name' => 'production'} }
   request             {{ 'component' => 'foo', 'action' => 'bar' }}
   notifier            {{ 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' }}
+
+  after_create do
+    Problem.cache_notice(err.problem_id, self)
+    problem.reload
+  end
 end
 Fabricator :backtrace do
@@ -19,16 +19,16 @@ describe ResolvedProblemClearer do
         }
       end
       it 'not repair database' do
-        allow(Mongoid.default_session).to receive(:command).and_call_original
-        expect(Mongoid.default_session).to_not receive(:command).with({:repairDatabase => 1})
+        allow(Mongoid.default_client).to receive(:command).and_call_original
+        expect(Mongoid.default_client).to_not receive(:command).with({:repairDatabase => 1})
         resolved_problem_clearer.execute
       end
     end
     context "with problem resolve" do
       before do
-        allow(Mongoid.default_session).to receive(:command).and_call_original
-        allow(Mongoid.default_session).to receive(:command).with({:repairDatabase => 1})
+        allow(Mongoid.default_client).to receive(:command).and_call_original
+        allow(Mongoid.default_client).to receive(:command).with({:repairDatabase => 1})
         problems.first.resolve!
         problems.second.resolve!
       end
@@ -44,7 +44,7 @@ describe ResolvedProblemClearer do
       end
       it 'repair database' do
-        expect(Mongoid.default_session).to receive(:command).with({:repairDatabase => 1})
+        expect(Mongoid.default_client).to receive(:command).with({:repairDatabase => 1})
         resolved_problem_clearer.execute
       end
     end
@@ -17,259 +17,312 @@ module Airbrake
 end
 describe ErrorReport do
-  context "with notice without line of backtrace" do
-    let(:xml){
-      Rails.root.join('spec','fixtures','hoptoad_test_notice.xml').read
-    }
-
-    let(:error_report) {
-      ErrorReport.new(xml)
-    }
-
-    let!(:app) {
-      Fabricate(
-        :app,
-        :api_key => 'APIKEY'
-      )
-    }
-
-    describe "#app" do
-      it 'find the good app' do
-        expect(error_report.app).to eq app
-      end
+  let(:xml){
+    Rails.root.join('spec','fixtures','hoptoad_test_notice.xml').read
+  }
+
+  let(:error_report) {
+    ErrorReport.new(xml)
+  }
+
+  let!(:app) {
+    Fabricate(
+      :app,
+      :api_key => 'APIKEY'
+    )
+  }
+
+  describe "#app" do
+    it 'find the good app' do
+      expect(error_report.app).to eq app
     end
+  end
-    describe "#backtrace" do
-      it 'should have valid backtrace' do
-        expect(error_report.backtrace).to be_valid
-      end
+  describe "#backtrace" do
+    it 'should have valid backtrace' do
+      expect(error_report.backtrace).to be_valid
     end
+  end
-    describe "#fingerprint_strategy" do
-      it "should be possible to change how fingerprints are generated" do
-        def error_report.fingerprint_strategy
-          Class.new do
-            def self.generate(*args)
-              'fingerprintzzz'
-            end
+  describe "#fingerprint_strategy" do
+    it "should be possible to change how fingerprints are generated" do
+      def error_report.fingerprint_strategy
+        Class.new do
+          def self.generate(*args)
+            'fingerprintzzz'
           end
         end
-
-        expect(error_report.error.fingerprint).to eq('fingerprintzzz')
       end
+
+      expect(error_report.error.fingerprint).to eq('fingerprintzzz')
     end
+  end
-    describe "#generate_notice!" do
-      it "save a notice" do
+  describe "#generate_notice!" do
+    it "save a notice" do
+      expect {
+        error_report.generate_notice!
+      }.to change {
+        app.reload.problems.count
+      }.by(1)
+    end
+
+    context "with notice generate by Airbrake gem" do
+      let(:xml) { Airbrake::Notice.new(
+        :exception => Exception.new,
+        :api_key => 'APIKEY',
+        :project_root => Rails.root
+      ).to_xml }
+      it 'save a notice' do
         expect {
           error_report.generate_notice!
         }.to change {
           app.reload.problems.count
         }.by(1)
       end
+    end
-      context "with notice generate by Airbrake gem" do
-        let(:xml) { Airbrake::Notice.new(
-          :exception => Exception.new,
-          :api_key => 'APIKEY',
-          :project_root => Rails.root
-        ).to_xml }
-        it 'save a notice' do
-          expect {
-            error_report.generate_notice!
-          }.to change {
-            app.reload.problems.count
-          }.by(1)
-        end
-      end
+    describe "notice create" do
+      before { error_report.generate_notice! }
+      subject { error_report.notice }
+      its(:message) { 'HoptoadTestingException: Testing hoptoad via "rake hoptoad:test". If you can see this, it works.' }
+      its(:framework) { should == 'Rails: 3.2.11' }
-      describe "notice create" do
-        before { error_report.generate_notice! }
-        subject { error_report.notice }
-        its(:message) { 'HoptoadTestingException: Testing hoptoad via "rake hoptoad:test". If you can see this, it works.' }
-        its(:framework) { should == 'Rails: 3.2.11' }
+      it 'has complete backtrace' do
+        expect(subject.backtrace_lines.size).to eq 73
+        expect(subject.backtrace_lines.last['file']).to eq '[GEM_ROOT]/bin/rake'
+      end
-        it 'has complete backtrace' do
-          expect(subject.backtrace_lines.size).to eq 73
-          expect(subject.backtrace_lines.last['file']).to eq '[GEM_ROOT]/bin/rake'
-        end
-        it 'has server_environement' do
-          expect(subject.server_environment['environment-name']).to eq 'development'
-        end
+      it 'has server_environement' do
+        expect(subject.server_environment['environment-name']).to eq 'development'
+      end
-        it 'has request' do
-          expect(subject.request['url']).to eq 'http://example.org/verify/cupcake=fistfight&lovebird=doomsayer'
-          expect(subject.request['params']['controller']).to eq 'application'
-        end
+      it 'has request' do
+        expect(subject.request['url']).to eq 'http://example.org/verify/cupcake=fistfight&lovebird=doomsayer'
+        expect(subject.request['params']['controller']).to eq 'application'
+      end
-        it 'has notifier' do
-          expect(subject.notifier['name']).to eq 'Hoptoad Notifier'
-        end
+      it 'has notifier' do
+        expect(subject.notifier['name']).to eq 'Hoptoad Notifier'
+      end
-        it 'get user_attributes' do
-          expect(subject.user_attributes['id']).to eq '123'
-          expect(subject.user_attributes['name']).to eq 'Mr. Bean'
-          expect(subject.user_attributes['email']).to eq 'mr.bean@example.com'
-          expect(subject.user_attributes['username']).to eq 'mrbean'
-        end
+      it 'get user_attributes' do
+        expect(subject.user_attributes['id']).to eq '123'
+        expect(subject.user_attributes['name']).to eq 'Mr. Bean'
+        expect(subject.user_attributes['email']).to eq 'mr.bean@example.com'
+        expect(subject.user_attributes['username']).to eq 'mrbean'
+      end
-        it 'valid env_vars' do
-          # XML: <var key="SCRIPT_NAME"/>
-          expect(subject.env_vars).to have_key('SCRIPT_NAME')
-          expect(subject.env_vars['SCRIPT_NAME']).to be_nil # blank ends up nil
-
-          # XML representation:
-          # <var key="rack.session.options">
-          #   <var key="secure">false</var>
-          #   <var key="httponly">true</var>
-          #   <var key="path">/</var>
-          #   <var key="expire_after"/>
-          #   <var key="domain"/>
-          #   <var key="id"/>
-          # </var>
-          expected = {
-            'secure'        => 'false',
-            'httponly'      => 'true',
-            'path'          => '/',
-            'expire_after'  => nil,
-            'domain'        => nil,
-            'id'            => nil
-          }
-          expect(subject.env_vars).to have_key('rack_session_options')
-          expect(subject.env_vars['rack_session_options']).to eql(expected)
-        end
+      it 'valid env_vars' do
+        # XML: <var key="SCRIPT_NAME"/>
+        expect(subject.env_vars).to have_key('SCRIPT_NAME')
+        expect(subject.env_vars['SCRIPT_NAME']).to be_nil # blank ends up nil
+
+        # XML representation:
+        # <var key="rack.session.options">
+        #   <var key="secure">false</var>
+        #   <var key="httponly">true</var>
+        #   <var key="path">/</var>
+        #   <var key="expire_after"/>
+        #   <var key="domain"/>
+        #   <var key="id"/>
+        # </var>
+        expected = {
+          'secure'        => 'false',
+          'httponly'      => 'true',
+          'path'          => '/',
+          'expire_after'  => nil,
+          'domain'        => nil,
+          'id'            => nil
+        }
+        expect(subject.env_vars).to have_key('rack_session_options')
+        expect(subject.env_vars['rack_session_options']).to eql(expected)
       end
     end
+  end
-    it 'save a notice assignes to err' do
+  describe '#cache_attributes_on_problem' do
+    it 'sets the latest notice properties on the problem' do
       error_report.generate_notice!
-      expect(error_report.notice.err).to be_a(Err)
+      problem = error_report.problem.reload
+      notice = error_report.notice.reload
+
+      expect(problem.environment).to eq('development')
+      expect(problem.error_class).to eq('HoptoadTestingException')
+      expect(problem.last_notice_at).to eq(notice.created_at)
+      expect(problem.message).to eq(notice.message)
+      expect(problem.where).to eq(notice.where)
     end
-    it 'memoize the notice' do
-      expect {
-        error_report.generate_notice!
-        error_report.generate_notice!
-      }.to change {
-        Notice.count
-      }.by(1)
+    it 'unresolves the problem' do
+      error_report.generate_notice!
+      problem = error_report.problem
+      problem.update(
+        resolved_at: Time.now,
+        resolved: true
+      )
+
+      error_report = ErrorReport.new(xml)
+      error_report.generate_notice!
+      problem.reload
+
+      expect(problem.resolved_at).to be(nil)
+      expect(problem.resolved).to be(false)
     end
-    it 'find the correct err for the notice' do
-      err = Fabricate(:err, :problem => Fabricate(:problem, :resolved => true))
+    it 'caches notice counts' do
+      error_report.generate_notice!
+      problem = error_report.problem
+      problem.reload
+
+      expect(problem.notices_count).to be(1)
+      expect(problem.user_agents['382b0f5185773fa0f67a8ed8056c7759']['count']).to be(1)
+      expect(problem.messages['9449f087eee0499e2d9029ae3dacaf53']['count']).to be(1)
+      expect(problem.hosts['1bdf72e04d6b50c82a48c7e4dd38cc69']['count']).to be(1)
+    end
-      allow(error_report).to receive(:fingerprint).and_return(err.fingerprint)
+    it 'increments notice counts' do
+      error_report.generate_notice!
+      error_report = ErrorReport.new(xml)
+      error_report.generate_notice!
+      problem = error_report.problem
+      problem.reload
-      expect {
-        error_report.generate_notice!
-      }.to change {
-        error_report.error.resolved?
-      }.from(true).to(false)
+      expect(problem.notices_count).to be(2)
+      expect(problem.user_agents['382b0f5185773fa0f67a8ed8056c7759']['count']).to be(2)
+      expect(problem.messages['9449f087eee0499e2d9029ae3dacaf53']['count']).to be(2)
+      expect(problem.hosts['1bdf72e04d6b50c82a48c7e4dd38cc69']['count']).to be(2)
     end
+  end
-    context "with notification service configured" do
-      before do
-        app.notify_on_errs = true
-        app.watchers.build(:email => 'foo@example.com')
-        app.save
-      end
-      it 'send email' do
-        notice = error_report.generate_notice!
-        email = ActionMailer::Base.deliveries.last
-        expect(email.to).to include(app.watchers.first.email)
-        expect(email.subject).to include(notice.message.truncate(50))
-        expect(email.subject).to include("[#{app.name}]")
-        expect(email.subject).to include("[#{notice.environment_name}]")
-      end
+  it 'save a notice assignes to err' do
+    error_report.generate_notice!
+    expect(error_report.notice.err).to be_a(Err)
+  end
-      context "with xml without request section" do
-        let(:xml){
-          Rails.root.join('spec','fixtures','hoptoad_test_notice_without_request_section.xml').read
-        }
-        it "save a notice" do
-          expect {
-            error_report.generate_notice!
-          }.to change {
-            app.reload.problems.count
-          }.by(1)
-        end
+  it 'memoize the notice' do
+    expect {
+      error_report.generate_notice!
+      error_report.generate_notice!
+    }.to change {
+      Notice.count
+    }.by(1)
+  end
+
+  it 'find the correct err for the notice' do
+    err = Fabricate(:err, :problem => Fabricate(:problem, :resolved => true))
+
+    allow(error_report).to receive(:fingerprint).and_return(err.fingerprint)
+
+    expect {
+      error_report.generate_notice!
+    }.to change {
+      error_report.error.resolved?
+    }.from(true).to(false)
+  end
+
+  context "with notification service configured" do
+    before do
+      app.notify_on_errs = true
+      app.watchers.build(:email => 'foo@example.com')
+      app.save
+    end
+    it 'send email' do
+      notice = error_report.generate_notice!
+      email = ActionMailer::Base.deliveries.last
+      expect(email.to).to include(app.watchers.first.email)
+      expect(email.subject).to include(notice.message.truncate(50))
+      expect(email.subject).to include("[#{app.name}]")
+      expect(email.subject).to include("[#{notice.environment_name}]")
+    end
+
+    context "with xml without request section" do
+      let(:xml){
+        Rails.root.join('spec','fixtures','hoptoad_test_notice_without_request_section.xml').read
+      }
+      it "save a notice" do
+        expect {
+          error_report.generate_notice!
+        }.to change {
+          app.reload.problems.count
+        }.by(1)
       end
+    end
-      context "with xml with only a single line of backtrace" do
-        let(:xml){
-          Rails.root.join('spec','fixtures','hoptoad_test_notice_with_one_line_of_backtrace.xml').read
-        }
-        it "save a notice" do
-          expect {
-            error_report.generate_notice!
-          }.to change {
-            app.reload.problems.count
-          }.by(1)
-        end
+    context "with xml with only a single line of backtrace" do
+      let(:xml){
+        Rails.root.join('spec','fixtures','hoptoad_test_notice_with_one_line_of_backtrace.xml').read
+      }
+      it "save a notice" do
+        expect {
+          error_report.generate_notice!
+        }.to change {
+          app.reload.problems.count
+        }.by(1)
       end
     end
+  end
-    describe "#valid?" do
-      context "with valid error report" do
-        it "return true" do
-          expect(error_report.valid?).to be true
-        end
+  describe "#valid?" do
+    context "with valid error report" do
+      it "return true" do
+        expect(error_report.valid?).to be true
       end
-      context "with not valid api_key" do
-        before do
-          App.where(:api_key => app.api_key).delete_all
-        end
-        it "return false" do
-          expect(error_report.valid?).to be false
-        end
+    end
+    context "with not valid api_key" do
+      before do
+        App.where(:api_key => app.api_key).delete_all
+      end
+      it "return false" do
+        expect(error_report.valid?).to be false
       end
     end
+  end
-    describe "#notice" do
-      context "before generate_notice!" do
-        it 'return nil' do
-          expect(error_report.notice).to be nil
-        end
+  describe "#notice" do
+    context "before generate_notice!" do
+      it 'return nil' do
+        expect(error_report.notice).to be nil
       end
+    end
-      context "after generate_notice!" do
-        before do
-          error_report.generate_notice!
-        end
-
-        it 'return the notice' do
-          expect(error_report.notice).to be_a Notice
-        end
+    context "after generate_notice!" do
+      before do
+        error_report.generate_notice!
+      end
+      it 'return the notice' do
+        expect(error_report.notice).to be_a Notice
       end
+
     end
+  end
-    describe "#should_keep?" do
-      context "with current app version not set" do
-        before do
-          error_report.app.current_app_version = nil
-          error_report.server_environment['app-version'] = '1.0'
-        end
+  describe "#should_keep?" do
+    context "with current app version not set" do
+      before do
+        error_report.app.current_app_version = nil
+        error_report.server_environment['app-version'] = '1.0'
+      end
-        it "return true" do
-          expect(error_report.should_keep?).to be true
-        end
+      it "return true" do
+        expect(error_report.should_keep?).to be true
       end
+    end
-      context "with current app version set" do
-        before do
-          error_report.app.current_app_version = '1.0'
-        end
+    context "with current app version set" do
+      before do
+        error_report.app.current_app_version = '1.0'
+      end
-        it "return true if current or newer" do
-          error_report.server_environment['app-version'] = '1.0'
-          expect(error_report.should_keep?).to be true
-        end
+      it "return true if current or newer" do
+        error_report.server_environment['app-version'] = '1.0'
+        expect(error_report.should_keep?).to be true
+      end
-        it "return false if older" do
-          error_report.server_environment['app-version'] = '0.9'
-          expect(error_report.should_keep?).to be false
-        end
+      it "return false if older" do
+        error_report.server_environment['app-version'] = '0.9'
+        expect(error_report.should_keep?).to be false
       end
     end
   end
 describe "Callback on Notice", type: 'model' do
-  describe "email notifications (configured individually for each app)" do
+  let(:notice_attrs_for) do
+    ->(api_key) do
+      {
+        error_class: "HoptoadTestingException",
+        message: "some message",
+        backtrace: [
+          {
+            "number"=>"425",
+            "file"=>"[GEM_ROOT]/callbacks.rb",
+            "method"=>"__callbacks"
+          }
+        ],
+        request: { "component" => "application" },
+        server_environment: {
+          "project-root" => "/path/to/sample/project",
+          "environment-name" => "development"
+        },
+        api_key: api_key,
+        notifier: {
+          "name"=>"Hoptoad Notifier",
+          "version"=>"2.3.2",
+          "url"=>"http://hoptoadapp.com"
+        },
+        framework: "Rails: 3.2.11"
+      }
+    end
+  end
+
+  describe 'email notifications (configured individually for each app)' do
+    let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
     custom_thresholds = [2, 4, 8, 16, 32, 64]
+    let(:app) do
+      Fabricate(:app_with_watcher, email_at_notices: custom_thresholds)
+    end
     before do
       Errbit::Config.per_app_email_at_notices = true
-      @app = Fabricate(:app_with_watcher, :email_at_notices => custom_thresholds)
-      @err = Fabricate(:err, :problem => Fabricate(:problem, :app => @app))
+      error_report = ErrorReport.new(notice_attrs)
+      error_report.generate_notice!
+      @problem = error_report.notice.err.problem
     end
-    after do
-      Errbit::Config.per_app_email_at_notices = false
-    end
+    after { Errbit::Config.per_app_email_at_notices = false }
     custom_thresholds.each do |threshold|
       it "sends an email notification after #{threshold} notice(s)" do
-        allow(@err.problem).to receive(:notices_count).and_return(threshold)
+        # set to just before the threshold
+        @problem.update_attributes notices_count: threshold - 1
+
         expect(Mailer).to receive(:err_notification).
           and_return(double('email', :deliver => true))
-        Fabricate(:notice, :err => @err)
+
+        error_report = ErrorReport.new(notice_attrs)
+        error_report.generate_notice!
       end
     end
-  end
-  describe "email notifications for a resolved issue" do
-    before do
-      Errbit::Config.per_app_email_at_notices = true
-      @app = Fabricate(:app_with_watcher, :email_at_notices => [1])
-      @err = Fabricate(:err, :problem => Fabricate(:problem, :app => @app, :notices_count => 100))
-    end
+    it "doesn't email after 5 notices" do
+      @problem.update_attributes notices_count: 5
-    after do
-      Errbit::Config.per_app_email_at_notices = false
-    end
+      expect(Mailer).to_not receive(:err_notification)
-    it "should send email notification after 1 notice since an error has been resolved" do
-      @err.problem.resolve!
-      expect(Mailer).to receive(:err_notification).
-        and_return(double('email', :deliver => true))
-      Fabricate(:notice, :err => @err)
+      error_report = ErrorReport.new(notice_attrs)
+      error_report.generate_notice!
     end
-    it 'self notify if mailer failed' do
-      @err.problem.resolve!
-      expect(Mailer).to receive(:err_notification).
-        and_raise(ArgumentError)
+
+    it 'notify self if mailer fails' do
+      expect(Mailer).to receive(:err_notification).and_raise(ArgumentError)
       expect(HoptoadNotifier).to receive(:notify)
-      Fabricate(:notice, :err => @err)
+      ErrorReport.new(notice_attrs).generate_notice!
     end
   end
-  describe "should send a notification if a notification service is configured with defaults" do
-    let(:app) { Fabricate(:app, :email_at_notices => [1], :notification_service => Fabricate(:campfire_notification_service))}
-    let(:err) { Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 100)) }
-    let(:backtrace) { Fabricate(:backtrace) }
-
-    before do
-      Errbit::Config.per_app_email_at_notices = true
+  describe 'email notifications for resolved issues' do
+    let(:notification_service) { Fabricate(:campfire_notification_service) }
+    let(:app) do
+      Fabricate(
+        :app_with_watcher,
+        notify_on_errs: true,
+        email_at_notices: [1,100]
+      )
     end
+    let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
-    after do
-      Errbit::Config.per_app_email_at_notices = false
-    end
+    before { Errbit::Config.per_app_email_at_notices = true }
+    after { Errbit::Config.per_app_email_at_notices = false }
-    it "should create a campfire notification" do
-      expect(app.notification_service).to receive(:create_notification)
+    it 'sends email the first time after the error is resolved' do
+      error_report = ErrorReport.new(notice_attrs)
+      error_report.generate_notice!
+      err = error_report.notice.err
-      Notice.create!(:err => err, :message => 'FooError: Too Much Bar', :server_environment => {'environment-name' => 'production'},
-                     :backtrace => backtrace, :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
-    end
-  end
+      err.problem.update_attributes notices_count: 99
+      err.problem.resolve!
-  describe "send a notification if a notification service is configured with defaults but failed" do
-    let(:app) { Fabricate(:app_with_watcher,
-                          :notify_on_errs => true,
-                          :email_at_notices => [1, 100], :notification_service => Fabricate(:campfire_notification_service))}
-    let(:err) { Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 99)) }
-    let(:backtrace) { Fabricate(:backtrace) }
+      expect(Mailer).to receive(:err_notification)
+        .and_return(double('email', :deliver => true))
-    before do
-      Errbit::Config.per_app_email_at_notices = true
+      ErrorReport.new(notice_attrs).generate_notice!
     end
+  end
-    after do
-      Errbit::Config.per_app_email_at_notices = false
+  describe 'send email when notification service is configured but fails' do
+    let(:notification_service) {Fabricate(:campfire_notification_service)}
+    let(:app) do
+      Fabricate(
+        :app_with_watcher,
+        notify_on_errs: true,
+        notification_service: notification_service
+      )
     end
+    let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
+
+    before { Errbit::Config.per_app_notify_at_notices = true }
+    after { Errbit::Config.per_app_notify_at_notices = false }
+
+    it 'sends email' do
+      error_report = ErrorReport.new(notice_attrs)
-    it "send email" do
-      expect(app.notification_service).to receive(:create_notification).and_raise(ArgumentError)
-      expect(Mailer).to receive(:err_notification).and_return(double(:deliver => true))
+      expect(error_report.app.notification_service)
+        .to receive(:create_notification).and_raise(ArgumentError)
+      expect(Mailer)
+        .to receive(:err_notification).and_return(double(:deliver => true))
-      Notice.create!(:err => err, :message => 'FooError: Too Much Bar', :server_environment => {'environment-name' => 'production'},
-                     :backtrace => backtrace, :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
+      error_report.generate_notice!
     end
   end
-  describe "should not send a notification if a notification service is not configured" do
-    let(:app) { Fabricate(:app, :email_at_notices => [1], :notification_service => Fabricate(:notification_service))}
-    let(:err) { Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 100)) }
-    let(:backtrace) { Fabricate(:backtrace) }
+  describe 'should not send a notification if a notification service is not' \
+           'configured' do
-    before do
-      Errbit::Config.per_app_email_at_notices = true
-    end
+    let(:notification_service) { Fabricate(:notification_service) }
+    let(:app) { Fabricate(:app, notification_service: notification_service )}
+    let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
-    after do
-      Errbit::Config.per_app_email_at_notices = false
-    end
+    before { Errbit::Config.per_app_notify_at_notices = true }
+    after { Errbit::Config.per_app_notify_at_notices = false }
     it "should not create a campfire notification" do
-      expect(app.notification_service).to_not receive(:create_notification)
-
-      Notice.create!(:err => err, :message => 'FooError: Too Much Bar', :server_environment => {'environment-name' => 'production'},
-                     :backtrace => backtrace, :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
+      error_report = ErrorReport.new(notice_attrs)
+      expect(error_report.app.notification_service).to_not receive(:create_notification)
+      error_report.generate_notice!
     end
   end
   describe 'hipcat notifications' do
-    let(:app) { Fabricate(:app, :email_at_notices => [1], :notification_service => Fabricate(:hipchat_notification_service))}
-    let(:err) { Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 100)) }
+    let(:notification_service) { Fabricate(:hipchat_notification_service) }
+    let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
+    let(:app) { Fabricate(:app, notification_service: notification_service) }
-    before do
-      Errbit::Config.per_app_email_at_notices = true
-    end
-
-    after do
-      Errbit::Config.per_app_email_at_notices = false
-    end
+    before { Errbit::Config.per_app_notify_at_notices = true }
+    after { Errbit::Config.per_app_notify_at_notices = false }
     it 'creates a hipchat notification' do
-      expect(app.notification_service).to receive(:create_notification)
-
-      Fabricate(:notice, :err => err)
+      error_report = ErrorReport.new(notice_attrs)
+      expect(error_report.app.notification_service)
+        .to receive(:create_notification)
+      error_report.generate_notice!
     end
   end
   describe "should send a notification at desired intervals" do
-    let(:app) { Fabricate(:app, :email_at_notices => [1], :notification_service => Fabricate(:campfire_notification_service, :notify_at_notices => [1,2]))}
-    let(:backtrace) { Fabricate(:backtrace) }
-
-    before do
-      Errbit::Config.per_app_email_at_notices = true
+    let(:notification_service) do
+      Fabricate(:campfire_notification_service, notify_at_notices: [1,2])
     end
+    let(:app) { Fabricate(:app, notification_service: notification_service) }
+    let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
-    after do
-      Errbit::Config.per_app_email_at_notices = false
-    end
+    before { Errbit::Config.per_app_notify_at_notices = true }
+    after { Errbit::Config.per_app_notify_at_notices = false }
     it "should create a campfire notification on first notice" do
-      err = Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 1))
-      expect(app.notification_service).to receive(:create_notification)
-
-      Notice.create!(:err => err, :message => 'FooError: Too Much Bar', :server_environment => {'environment-name' => 'production'},
-                     :backtrace => backtrace, :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
+      error_report = ErrorReport.new(notice_attrs)
+      expect(error_report.app.notification_service)
+        .to receive(:create_notification)
+      error_report.generate_notice! # one
     end
     it "should create a campfire notification on second notice" do
-      err = Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 1))
-      expect(app.notification_service).to receive(:create_notification)
-
-      Notice.create!(:err => err, :message => 'FooError: Too Much Bar', :server_environment => {'environment-name' => 'production'},
-                     :backtrace => backtrace, :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
+      ErrorReport.new(notice_attrs).generate_notice! # one
+      error_report = ErrorReport.new(notice_attrs)
+      expect(error_report.app.notification_service)
+        .to receive(:create_notification)
+      error_report.generate_notice! # two
     end
     it "should not create a campfire notification on third notice" do
-      err = Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 1))
-      expect(app.notification_service).to receive(:create_notification)
-
-      Notice.create!(:err => err, :message => 'FooError: Too Much Bar', :server_environment => {'environment-name' => 'production'},
-                     :backtrace => backtrace, :notifier => { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' })
+      ErrorReport.new(notice_attrs).generate_notice! # one
+      ErrorReport.new(notice_attrs).generate_notice! # two
+      error_report = ErrorReport.new(notice_attrs)
+      expect(error_report.app.notification_service)
+        .to_not receive(:create_notification)
+      error_report.generate_notice! # three
     end
   end
 end
@@ -3,7 +3,7 @@ describe Notice, type: &#39;model&#39; do
     it 'requires a backtrace' do
       notice = Fabricate.build(:notice, :backtrace => nil)
       expect(notice).to_not be_valid
-      expect(notice.errors[:backtrace]).to include("can't be blank")
+      expect(notice.errors[:backtrace_id]).to include("can't be blank")
     end
     it 'requires the server_environment' do
@@ -40,10 +40,10 @@ describe Problem, type: &#39;model&#39; do
       expect(problem).to_not be_nil
       notice1 = Fabricate(:notice, :err => err)
-      expect(problem.last_notice_at).to eq notice1.created_at
+      expect(problem.last_notice_at).to eq notice1.reload.created_at
       notice2 = Fabricate(:notice, :err => err)
-      expect(problem.last_notice_at).to eq notice2.created_at
+      expect(problem.last_notice_at).to eq notice2.reload.created_at
     end
   end
@@ -266,12 +266,6 @@ describe Problem, type: &#39;model&#39; do
       expect(@problem.messages).to eq ({})
     end
-    it "adding a notice adds a string to #messages" do
-      expect {
-        Fabricate(:notice, :err => @err, :message => 'ERR 1')
-      }.to change(@problem, :messages).from({}).to({Digest::MD5.hexdigest('ERR 1') => {'value' => 'ERR 1', 'count' => 1}})
-    end
-
     it "removing a notice removes string from #messages" do
       Fabricate(:notice, :err => @err, :message => 'ERR 1')
       expect {
@@ -299,12 +293,6 @@ describe Problem, type: &#39;model&#39; do
       expect(@problem.hosts).to eq ({})
     end
-    it "adding a notice adds a string to #hosts" do
-      expect {
-        Fabricate(:notice, :err => @err, :request => {'url' => "http://example.com/resource/12"})
-      }.to change(@problem, :hosts).from({}).to({Digest::MD5.hexdigest('example.com') => {'value' => 'example.com', 'count' => 1}})
-    end
-
     it "removing a notice removes string from #hosts" do
       Fabricate(:notice, :err => @err, :request => {'url' => "http://example.com/resource/12"})
       expect {
@@ -325,12 +313,6 @@ describe Problem, type: &#39;model&#39; do
       expect(@problem.user_agents).to eq ({})
     end
-    it "adding a notice adds a string to #user_agents" do
-      expect {
-        Fabricate(:notice, :err => @err, :request => {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'}})
-      }.to change(@problem, :user_agents).from({}).to({Digest::MD5.hexdigest('Chrome 10.0.648.204 (OS X 10.6.7)') => {'value' => 'Chrome 10.0.648.204 (OS X 10.6.7)', 'count' => 1}})
-    end
-
     it "removing a notice removes string from #user_agents" do
       Fabricate(:notice, :err => @err, :request => {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'}})
       expect {
 # This file is copied to ~/spec when you run 'ruby script/generate rspec'
 # from the project root directory.
-ENV["RAILS_ENV"] ||= 'test'
+ENV["RAILS_ENV"] = 'test'
+ENV["ERRBIT_LOG_LEVEL"] = 'error'
 if ENV['COVERAGE']
   require 'coveralls'
@@ -21,7 +22,6 @@ require File.expand_path(&quot;../../config/environment&quot;, __FILE__)
 require 'rspec/rails'
 require 'rspec/its'
 require 'email_spec'
-require 'database_cleaner'
 require 'xmpp4r'
 require 'xmpp4r/muc'
 require 'mongoid-rspec'
	@@ -27,6 +27,6 @@ class ResolvedProblemClearer		@@ -27,6 +27,6 @@ class ResolvedProblemClearer
27	end	27	end
28		28
29	def repair_database	29	def repair_database
30	- Mongoid.default_session.command :repairDatabase => 1	30	+ Mongoid.default_client.command :repairDatabase => 1
31	end	31	end
32	end	32	end
	@@ -26,7 +26,7 @@ class NotificationService		@@ -26,7 +26,7 @@ class NotificationService
26	else	26	else
27	Fields = []	27	Fields = []
28	end	28	end
29	-	29	+
30	def notify_at_notices	30	def notify_at_notices
31	Errbit::Config.per_app_notify_at_notices ? super : Errbit::Config.notify_at_notices	31	Errbit::Config.per_app_notify_at_notices ? super : Errbit::Config.notify_at_notices
32	end	32	end
	@@ -6,8 +6,15 @@ class Problem		@@ -6,8 +6,15 @@ class Problem
6	include Mongoid::Document	6	include Mongoid::Document
7	include Mongoid::Timestamps	7	include Mongoid::Timestamps
8		8
9	- field :last_notice_at, :type => DateTime, :default => Proc.new { Time.now }
10	- field :first_notice_at, :type => DateTime, :default => Proc.new { Time.now }	9	+ CACHED_NOTICE_ATTRIBUTES = {
		10	+ messages: :message,
		11	+ hosts: :host,
		12	+ user_agents: :user_agent_string
		13	+ }.freeze
		14	+
		15	+
		16	+ field :last_notice_at, :type => ActiveSupport::TimeWithZone, :default => Proc.new { Time.now }
		17	+ field :first_notice_at, :type => ActiveSupport::TimeWithZone, :default => Proc.new { Time.now }
11	field :last_deploy_at, :type => Time	18	field :last_deploy_at, :type => Time
12	field :resolved, :type => Boolean, :default => false	19	field :resolved, :type => Boolean, :default => false
13	field :resolved_at, :type => Time	20	field :resolved_at, :type => Time
	@@ -63,6 +70,83 @@ class Problem		@@ -63,6 +70,83 @@ class Problem
63	env.present? ? where(:environment => env) : scoped	70	env.present? ? where(:environment => env) : scoped
64	end	71	end
65		72
		73	+ def self.cache_notice(id, notice)
		74	+ # increment notice count
		75	+ message_digest = Digest::MD5.hexdigest(notice.message)
		76	+ host_digest = Digest::MD5.hexdigest(notice.host)
		77	+ user_agent_digest = Digest::MD5.hexdigest(notice.user_agent_string)
		78	+
		79	+ Problem.where('_id' => id).find_one_and_update(
		80	+ '$set' => {
		81	+ 'environment' => notice.environment_name,
		82	+ 'error_class' => notice.error_class,
		83	+ 'last_notice_at' => notice.created_at.utc,
		84	+ 'message' => notice.message,
		85	+ 'resolved' => false,
		86	+ 'resolved_at' => nil,
		87	+ 'where' => notice.where,
		88	+ "messages.#{message_digest}.value" => notice.message,
		89	+ "hosts.#{host_digest}.value" => notice.host,
		90	+ "user_agents.#{user_agent_digest}.value" => notice.user_agent_string,
		91	+ },
		92	+ '$inc' => {
		93	+ 'notices_count' => 1,
		94	+ "messages.#{message_digest}.count" => 1,
		95	+ "hosts.#{host_digest}.count" => 1,
		96	+ "user_agents.#{user_agent_digest}.count" => 1,
		97	+ }
		98	+ )
		99	+ end
		100	+
		101	+ def uncache_notice(notice)
		102	+ last_notice = notices.last
		103	+
		104	+ atomically do \|doc\|
		105	+ doc.set(
		106	+ 'environment' => last_notice.environment_name,
		107	+ 'error_class' => last_notice.error_class,
		108	+ 'last_notice_at' => last_notice.created_at,
		109	+ 'message' => last_notice.message,
		110	+ 'where' => last_notice.where,
		111	+ 'notices_count' => notices_count.to_i > 1 ? notices_count - 1 : 0
		112	+ )
		113	+
		114	+ CACHED_NOTICE_ATTRIBUTES.each do \|k,v\|
		115	+ digest = Digest::MD5.hexdigest(notice.send(v))
		116	+ field = "#{k}.#{digest}"
		117	+
		118	+ if (doc[k].try(:[], digest).try(:[], :count)).to_i > 1
		119	+ doc.inc("#{field}.count" => -1)
		120	+ else
		121	+ doc.unset(field)
		122	+ end
		123	+ end
		124	+ end
		125	+ end
		126	+
		127	+ def recache
		128	+ CACHED_NOTICE_ATTRIBUTES.each do \|k,v\|
		129	+ # clear all cached attributes
		130	+ send("#{k}=", {})
		131	+
		132	+ # find only notices related to this problem
		133	+ Notice.collection.find.aggregate([
		134	+ { "$match" => { err_id: { "$in" => err_ids } } },
		135	+ { "$group" => { _id: "$#{v}", count: {"$sum" => 1} } }
		136	+ ]).each do \|agg\|
		137	+ next if agg[:_id] == nil
		138	+
		139	+ send(k)[Digest::MD5.hexdigest(agg[:_id])] = {
		140	+ value: agg[:_id],
		141	+ count: agg[:count]
		142	+ }
		143	+ end
		144	+ end
		145	+
		146	+ self.notices_count = Notice.where({ err_id: { "$in" => err_ids }}).count
		147	+ save
		148	+ end
		149	+
66	def url	150	def url
67	Rails.application.routes.url_helpers.app_problem_url(app, self,	151	Rails.application.routes.url_helpers.app_problem_url(app, self,
68	:host => Errbit::Config.host,	152	:host => Errbit::Config.host,
	@@ -98,16 +182,21 @@ class Problem		@@ -98,16 +182,21 @@ class Problem
98	def unmerge!	182	def unmerge!
99	attrs = {:error_class => error_class, :environment => environment}	183	attrs = {:error_class => error_class, :environment => environment}
100	problem_errs = errs.to_a	184	problem_errs = errs.to_a
101	- problem_errs.shift
102	- [self] + problem_errs.map(&:id).map do \|err_id\|
103	- err = Err.find(err_id)
104	- app.problems.create(attrs).tap do \|new_problem\|
105	- err.update_attribute(:problem_id, new_problem.id)
106	- new_problem.reset_cached_attributes
107	- end	185	+
		186	+ # associate and return all the problems
		187	+ new_problems = [self]
		188	+
		189	+ # create new problems for each err that needs one
		190	+ (problem_errs[1..-1] \|\| []).each do \|err\|
		191	+ new_problems << app.problems.create(attrs)
		192	+ err.update_attribute(:problem, new_problems.last)
108	end	193	end
109	- end
110		194
		195	+ # recache each new problem
		196	+ new_problems.each(&:recache)
		197	+
		198	+ new_problems
		199	+ end
111		200
112	def self.ordered_by(sort, order)	201	def self.ordered_by(sort, order)
113	case sort	202	case sort
	@@ -124,11 +213,6 @@ class Problem		@@ -124,11 +213,6 @@ class Problem
124	where(:first_notice_at.lte => date_range.end).where("$or" => [{:resolved_at => nil}, {:resolved_at.gte => date_range.begin}])	213	where(:first_notice_at.lte => date_range.end).where("$or" => [{:resolved_at => nil}, {:resolved_at.gte => date_range.begin}])
125	end	214	end
126		215
127	-
128	- def reset_cached_attributes
129	- ProblemUpdaterCache.new(self).update
130	- end
131	-
132	def cache_app_attributes	216	def cache_app_attributes
133	if app	217	if app
134	self.app_name = app.name	218	self.app_name = app.name
	@@ -140,14 +224,6 @@ class Problem		@@ -140,14 +224,6 @@ class Problem
140	self.message = self.message[0, 1000] if self.message	224	self.message = self.message[0, 1000] if self.message
141	end	225	end
142		226
143	- def remove_cached_notice_attributes(notice)
144	- update_attributes!(
145	- :messages => attribute_count_descrease(:messages, notice.message),
146	- :hosts => attribute_count_descrease(:hosts, notice.host),
147	- :user_agents => attribute_count_descrease(:user_agents, notice.user_agent_string)
148	- )
149	- end
150	-
151	def issue_type	227	def issue_type
152	# Return issue_type if configured, but fall back to detecting app's issue tracker	228	# Return issue_type if configured, but fall back to detecting app's issue tracker
153	attributes['issue_type'] \|\|=	229	attributes['issue_type'] \|\|=
1	-Mongoid.logger.level = Logger.const_get Errbit::Config.log_level.upcase	1	+log_level = Logger.const_get Errbit::Config.log_level.upcase
		2	+
		3	+Mongoid.logger.level = log_level
		4	+Mongo::Logger.level = log_level
2		5
3	Mongoid.configure do \|config\|	6	Mongoid.configure do \|config\|
4	uri = if Errbit::Config.mongo_url == 'mongodb://localhost'	7	uri = if Errbit::Config.mongo_url == 'mongodb://localhost'
	@@ -3,7 +3,7 @@ describe Notice, type: 'model' do		@@ -3,7 +3,7 @@ describe Notice, type: 'model' do
3	it 'requires a backtrace' do	3	it 'requires a backtrace' do
4	notice = Fabricate.build(:notice, :backtrace => nil)	4	notice = Fabricate.build(:notice, :backtrace => nil)
5	expect(notice).to_not be_valid	5	expect(notice).to_not be_valid
6	- expect(notice.errors[:backtrace]).to include("can't be blank")	6	+ expect(notice.errors[:backtrace_id]).to include("can't be blank")
7	end	7	end
8		8
9	it 'requires the server_environment' do	9	it 'requires the server_environment' do