Adding file not found handling

If there is no problem for the requested id the api will now correctly return a 404 status.

Adding file not found handling
If there is no problem for the requested id the api will now correctly return a 404 status.
Callum Dryden
1 parent f719e97e
Showing 3 changed files with 12 additions and 4 deletions Show diff stats
app/controllers/api/v1/problems_controller.rb
app/models/problem.rb
spec/controllers/api/v1/problems_controller_spec.rb
@@ -4,11 +4,15 @@ class Api::V1::ProblemsController &lt; ApplicationController
   def show
     result = benchmark("[api/v1/problems_controller/show] query time") do
-      problem = Problem.only(FIELDS).find(params[:id])
-      problem.as_json(include: {errs: { include: :notices}})
+      begin
+        problem = Problem.only(FIELDS).find(params[:id])
+        problem.as_json(include: {errs: { include: :notices}})
+      rescue Mongoid::Errors::DocumentNotFound
+        head :not_found
+        return false
+      end
     end
-
     respond_to do |format|
       format.any(:html, :json) { render :json => result } # render JSON if no extension specified on path
       format.xml  { render :xml  => result }
@@ -50,7 +50,6 @@ class Problem
   validates_presence_of :last_notice_at, :first_notice_at
-
   def self.all_else_unresolved(fetch_all)
     if fetch_all
       all
@@ -24,6 +24,11 @@ describe Api::V1::ProblemsController do
         get :show, :auth_token => @user.authentication_token, :format => "json", :id => requested_problem.id
         expect( response.body ).to eq(requested_problem.to_json(include: {errs: { include: :notices}}))
       end
+
+      it "returns a 404 if the problem cannot be found" do
+        get :show, :auth_token => @user.authentication_token, :format => "json", :id => 'IdontExist'
+        expect( response.status ).to eq(404)
+      end
     end
     describe "GET /api/v1/problems" do
	@@ -50,7 +50,6 @@ class Problem		@@ -50,7 +50,6 @@ class Problem
50		50
51	validates_presence_of :last_notice_at, :first_notice_at	51	validates_presence_of :last_notice_at, :first_notice_at
52		52
53	-
54	def self.all_else_unresolved(fetch_all)	53	def self.all_else_unresolved(fetch_all)
55	if fetch_all	54	if fetch_all
56	all	55	all