Merge branch 'thoughtworks_mingle'

Conflicts: app/helpers/application_helper.rb app/views/apps/_fields.html.haml

Merge branch 'thoughtworks_mingle'
Conflicts: app/helpers/application_helper.rb app/views/apps/_fields.html.haml
Nathan Broadbent
2 parents e79cae05 8367790f
Showing 10 changed files with 164 additions and 29 deletions Show diff stats
app/helpers/application_helper.rb
app/models/app.rb
app/models/issue_tracker.rb
app/views/apps/_fields.html.haml
config/initializers/issue_trackers.rb
lib/issue_trackers/mingle.rb
public/stylesheets/application.css
spec/controllers/apps_controller_spec.rb
spec/controllers/errs_controller_spec.rb
spec/factories/issue_tracker_factories.rb
 module ApplicationHelper
-
-  def lighthouse_tracker? object
-    object.issue_tracker_type == "lighthouseapp"
-  end
-
   def user_agent_graph(error)
     tallies = tally(error.notices) {|notice| pretty_user_agent(notice.user_agent)}
     create_percentage_table(tallies, :total => error.notices.count)
@@ -39,16 +34,11 @@ module ApplicationHelper
     object.issue_tracker_type == "none"
   end
-  def redmine_tracker? object
-    object.issue_tracker_type == "redmine"
-  end
-
-  def pivotal_tracker? object
-    object.issue_tracker_type == "pivotal"
+  %w(lighthouseapp redmine pivotal fogbugz mingle).each do |tracker|
+    define_method("#{tracker}_tracker?".to_sym) do |object|
+      object.issue_tracker_type == tracker
+    end
   end
-  def fogbugz_tracker? object
-    object.issue_tracker_type == 'fogbugz'
-  end
 end
@@ -36,7 +36,7 @@ class App
   accepts_nested_attributes_for :watchers, :allow_destroy => true,
     :reject_if => proc { |attrs| attrs[:user_id].blank? && attrs[:email].blank? }
   accepts_nested_attributes_for :issue_tracker, :allow_destroy => true,
-    :reject_if => proc { |attrs| !%w(none lighthouseapp redmine pivotal fogbugz).include?(attrs[:issue_tracker_type]) }
+    :reject_if => proc { |attrs| !%w(none lighthouseapp redmine pivotal fogbugz mingle).include?(attrs[:issue_tracker_type]) }
   # Mongoid Bug: find(id) on association proxies returns an Enumerator
   def self.find_by_id!(app_id)
@@ -12,6 +12,7 @@ class IssueTracker
   field :account, :type => String
   field :api_token, :type => String
   field :project_id, :type => String
+  field :ticket_properties, :type => String
   field :username, :type => String
   field :password, :type => String
   field :issue_tracker_type, :type => String, :default => 'none'
@@ -26,6 +27,17 @@ class IssueTracker
       create_pivotal_issue err
     when 'fogbugz'
       create_fogbugz_issue err
+    when 'mingle'
+      create_mingle_issue err
+    end
+  end
+
+  def ticket_properties_hash
+    # Parses 'key=value, key2=value2' from user input into a ruby hash.
+    self.ticket_properties.split(",").inject({}) do |hash, pair|
+      key, value = pair.split("=").map(&:strip)
+      hash[key] = value
+      hash
     end
   end
@@ -84,29 +96,54 @@ class IssueTracker
     err.update_attribute :issue_link, "https://#{account}.fogbugz.com/default.asp?#{fb_resp['case']['ixBug']}"
   end
+  def create_mingle_issue err
+    properties = ticket_properties_hash
+    basic_auth = account.gsub(/https?:\/\//, "https://#{username}:#{password}@")
+    Mingle.set_site "#{basic_auth}/api/v1/projects/#{project_id}/"
+
+    card = Mingle::Card.new
+    card.card_type_name = properties.delete("card_type")
+    card.name = issue_title(err)
+    card.description = self.class.mingle_body_template.result(binding)
+    properties.each do |property, value|
+      card.send("cp_#{property}=", value)
+    end
+
+    card.save!
+    err.update_attribute :issue_link, URI.parse("#{account}/projects/#{project_id}/cards/#{card.id}").to_s
+  end
+
   def issue_title err
     "[#{ err.environment }][#{ err.where }] #{err.message.to_s.truncate(100)}"
   end
   def check_params
     blank_flag_fields = %w(project_id)
-    if(%w(fogbugz).include?(issue_tracker_type))
+    if %w(fogbugz mingle).include?(issue_tracker_type)
       blank_flag_fields += %w(username password)
     else
       blank_flag_fields << 'api_token'
     end
-    blank_flag_fields << 'account' if(%w(fogbugz lighthouseapp redmine).include?(issue_tracker_type))
+    blank_flag_fields << 'account' if(%w(fogbugz lighthouseapp redmine mingle).include?(issue_tracker_type))
     blank_flags = blank_flag_fields.map {|m| self[m].blank? }
+
+    if issue_tracker_type == "mingle"
+      # Check that mingle was given a 'card_type' in the ticket_properties
+      blank_flags << "card_type" unless ticket_properties_hash["card_type"]
+    end
+
     if blank_flags.any? && !blank_flags.all?
       message = case issue_tracker_type
       when 'lighthouseapp'
-        'You must specify your Lighthouseapp account, api token and project id'
+        'You must specify your Lighthouseapp account, API token and Project ID'
       when 'redmine'
-        'You must specify your Redmine url, api token and project id'
+        'You must specify your Redmine URL, API token and Project ID'
       when 'pivotal'
-        'You must specify your Pivotal Tracker api token and project id'
+        'You must specify your Pivotal Tracker API token and Project ID'
       when 'fogbugz'
         'You must specify your FogBugz Area Name, Username, and Password'
+      when 'mingle'
+        'You must specify your Mingle URL, Project ID, Card Type (in default card properties), Sign-in name, and Password'
       end
       errors.add(:base, message)
     end
@@ -128,6 +165,11 @@ class IssueTracker
     def fogbugz_body_template
       @@fogbugz_body_template ||= ERB.new(File.read(Rails.root + "app/views/errs/fogbugz_body.txt.erb"))
     end
+
+    def mingle_body_template
+      # Mingle also uses textile markup, so the redmine template is perfect.
+      redmine_body_template
+    end
   end
 end
@@ -62,15 +62,17 @@
         = label_tag :issue_tracker_type_pivotal, 'Pivotal Tracker', :for => label_for_attr(w, 'issue_tracker_type_pivotal')
         = w.radio_button :issue_tracker_type, :fogbugz
         = label_tag :issue_tracker_type_fogbugz, 'FogBugz', :for => label_for_attr(w, 'issue_tracker_type_fogbugz')
+        = w.radio_button :issue_tracker_type, :mingle
+        = label_tag :issue_tracker_type_fogbugz, 'Mingle', :for => label_for_attr(w, 'issue_tracker_type_mingle')
       %div.tracker_params.none{:class => no_tracker?(w.object) ? 'chosen' : nil}
         %p When no issue tracker has been configured, you will be able to leave comments on errors.
-      %div.tracker_params.lighthouseapp{:class => lighthouse_tracker?(w.object) ? 'chosen' : nil}
+      %div.tracker_params.lighthouseapp{:class => lighthouseapp_tracker?(w.object) ? 'chosen' : nil}
         = w.label :account, "Account"
         = w.text_field :account, :placeholder => "abc from abc.lighthouseapp.com"
         = w.label :api_token, "API token"
         = w.text_field :api_token, :placeholder => "API Token for your account"
         = w.label :project_id, "Project ID"
-        = w.text_field :project_id, :placeholder => "123 from  abc.lighthouseapp.com/projects/123"
+        = w.text_field :project_id
       %div.tracker_params.redmine{:class => redmine_tracker?(w.object) ? 'chosen' : nil}
         = w.label :account, "Redmine URL"
         = w.text_field :account, :placeholder => "like http://www.redmine.org/"
@@ -88,8 +90,19 @@
         = w.text_field :project_id
         = w.label :account, "FogBugz URL"
         = w.text_field :account, :placeholder => "abc from http://abc.fogbugz.com/"
-        = w.label :username, 'account username'
+        = w.label :username, 'Username'
         = w.text_field :username, :placeholder => 'Username/Email for your account'
-        = w.label :password, 'account password'
+        = w.label :password, 'Password'
+        = w.password_field :password, :placeholder => 'Password for your account'
+      %div.tracker_params.mingle{:class => mingle_tracker?(w.object) ? 'chosen' : nil}
+        = w.label :account, "Mingle URL"
+        = w.text_field :account, :placeholder => "http://mingle.yoursite.com/"
+        = w.label :project_id, "Project ID"
+        = w.text_field :project_id
+        = w.label :ticket_properties, "Card Properties (comma separated key=value pairs)"
+        = w.text_field :ticket_properties, :placeholder => "card_type = Defect, defect_status = Open, priority = Essential"
+        = w.label :username, 'Sign-in name'
+        = w.text_field :username, :placeholder => 'Sign-in name for your account'
+        = w.label :password, 'Password'
         = w.password_field :password, :placeholder => 'Password for your account'
@@ -0,0 +1,2 @@
+require Rails.root.join('lib/issue_trackers/mingle.rb')
+
@@ -0,0 +1,14 @@
+module Mingle
+  class Card < ActiveResource::Base
+    # site template ~> "https://username:password@mingle.example.com/api/v1/projects/:project_id/"
+  end
+  def self.set_site(site)
+    # ActiveResource seems to clone and freeze the @site variable
+    # after the first use. It seems that the only way to change @site
+    # is to drop the subclass, and then reload it.
+    Mingle.send(:remove_const, :Card)
+    load File.join(Rails.root,'lib','issue_trackers','mingle.rb')
+    Mingle::Card.site = site
+  end
+end
+
@@ -525,7 +525,7 @@ a.button.active {
 }
 /* Watchers and Issue Tracker Forms */
-div.nested.watcher .user, div.nested.watcher .email, div.issue_tracker.nested .lighthouseapp, div.issue_tracker.nested .redmine, div.issue_tracker.nested .pivotal, div.issue_tracker.nested .fogbugz {
+div.nested.watcher .user, div.nested.watcher .email, div.issue_tracker.nested .tracker_params {
   display: none;
 }
 div.nested.watcher .choosen, div.nested.issue_tracker .chosen {
@@ -297,7 +297,7 @@ describe AppsController do
             @app.reload
             @app.issue_tracker.should be_nil
-            response.body.should match(/You must specify your Lighthouseapp account, api token and project id/)
+            response.body.should match(/You must specify your Lighthouseapp account, API token and Project ID/)
           end
         end
@@ -322,7 +322,7 @@ describe AppsController do
             @app.reload
             @app.issue_tracker.should be_nil
-            response.body.should match(/You must specify your Redmine url, api token and project id/)
+            response.body.should match(/You must specify your Redmine URL, API token and Project ID/)
           end
         end
@@ -344,7 +344,7 @@ describe AppsController do
             @app.reload
             @app.issue_tracker.should be_nil
-            response.body.should match(/You must specify your Pivotal Tracker api token and project id/)
+            response.body.should match(/You must specify your Pivotal Tracker API token and Project ID/)
           end
         end
@@ -375,6 +375,37 @@ describe AppsController do
             end
           end
         end
+
+        context "mingle" do
+          context 'with correct params' do
+            before do
+              put :update, :id => @app.id, :app => { :issue_tracker_attributes => {
+                :issue_tracker_type => 'mingle', :project_id => 'test', :account => 'http://mingle.example.com',
+                :username => '1234', :password => '123123', :ticket_properties => "card_type = Defect"
+              } }
+              @app.reload
+            end
+
+            subject {@app.issue_tracker}
+            its(:issue_tracker_type) {should == 'mingle'}
+            its(:project_id) {should == 'test'}
+            its(:username) {should == '1234'}
+            its(:password) {should == '123123'}
+          end
+
+          it "should show validation notice when sufficient params are not present" do
+            put :update, :id => @app.id, :app => { :issue_tracker_attributes => {
+              :issue_tracker_type => 'mingle', :project_id => 'test', :account => 'http://mingle.example.com',
+              :username => '1234', :password => '1234', :ticket_properties => "cards_type = Defect"
+            } }
+            @app.reload
+
+            @app.issue_tracker.should be_nil
+            response.body.should match(/You must specify your Mingle URL, Project ID, Card Type \(in default card properties\), Sign-in name, and Password/)
+          end
+        end
+
+
       end
     end
@@ -330,7 +330,7 @@ describe ErrsController do
         end
       end
-      context "redmine tracker" do
+      context "pivotal tracker" do
         let(:notice) { Factory :notice }
         let(:tracker) { Factory :pivotal_tracker, :app => notice.err.app }
         let(:err) { notice.err }
@@ -362,6 +362,40 @@ describe ErrsController do
           err.issue_link.should == @issue_link.sub(/\.xml/, '')
         end
       end
+
+      context "mingle tracker" do
+        let(:notice) { Factory :notice }
+        let(:tracker) { Factory :mingle_tracker, :app => notice.err.app }
+        let(:err) { notice.err }
+
+        before(:each) do
+          number = 5
+          @issue_link = "#{tracker.account}/projects/#{tracker.project_id}/cards/#{number}.xml"
+          @basic_auth = tracker.account.gsub("https://", "https://#{tracker.username}:#{tracker.password}@")
+          body = "<card><id type=\"integer\">#{number}</id></card>"
+          stub_request(:post, "#{@basic_auth}/api/v1/projects/#{tracker.project_id}/cards.xml").
+                       to_return(:status => 201, :headers => {'Location' => @issue_link}, :body => body )
+
+          post :create_issue, :app_id => err.app.id, :id => err.id
+          err.reload
+        end
+
+        it "should make request to Mingle with err params" do
+          requested = have_requested(:post, "#{@basic_auth}/api/v1/projects/#{tracker.project_id}/cards.xml")
+          WebMock.should requested.with(:headers => {'Content-Type' => 'application/xml'})
+          WebMock.should requested.with(:body => /FooError: Too Much Bar/)
+          WebMock.should requested.with(:body => /See this exception on Errbit/)
+          WebMock.should requested.with(:body => /<card-type-name>Defect<\/card-type-name>/)
+        end
+
+        it "should redirect to err page" do
+          response.should redirect_to( app_err_path(err.app, err) )
+        end
+
+        it "should create issue link for err" do
+          err.issue_link.should == @issue_link.sub(/\.xml$/, '')
+        end
+      end
     end
     context "absent issue tracker" do
@@ -17,3 +17,12 @@ end
 Factory.define :pivotal_tracker, :parent => :generic_tracker do |e|
   e.issue_tracker_type 'pivotal'
 end
+
+Factory.define :mingle_tracker, :parent => :generic_tracker do |t|
+  t.issue_tracker_type 'mingle'
+  t.account  "https://mingle.example.com"
+  t.ticket_properties 'card_type = Defect, defect_status = open, priority = essential'
+  t.username "test_user"
+  t.password "test_password"
+end
+
	@@ -36,7 +36,7 @@ class App		@@ -36,7 +36,7 @@ class App
36	accepts_nested_attributes_for :watchers, :allow_destroy => true,	36	accepts_nested_attributes_for :watchers, :allow_destroy => true,
37	:reject_if => proc { \|attrs\| attrs[:user_id].blank? && attrs[:email].blank? }	37	:reject_if => proc { \|attrs\| attrs[:user_id].blank? && attrs[:email].blank? }
38	accepts_nested_attributes_for :issue_tracker, :allow_destroy => true,	38	accepts_nested_attributes_for :issue_tracker, :allow_destroy => true,
39	- :reject_if => proc { \|attrs\| !%w(none lighthouseapp redmine pivotal fogbugz).include?(attrs[:issue_tracker_type]) }	39	+ :reject_if => proc { \|attrs\| !%w(none lighthouseapp redmine pivotal fogbugz mingle).include?(attrs[:issue_tracker_type]) }
40		40
41	# Mongoid Bug: find(id) on association proxies returns an Enumerator	41	# Mongoid Bug: find(id) on association proxies returns an Enumerator
42	def self.find_by_id!(app_id)	42	def self.find_by_id!(app_id)
@@ -0,0 +1,2 @@		@@ -0,0 +1,2 @@
	1	+require Rails.root.join('lib/issue_trackers/mingle.rb')
	2	+
@@ -0,0 +1,14 @@		@@ -0,0 +1,14 @@
	1	+module Mingle
	2	+ class Card < ActiveResource::Base
	3	+ # site template ~> "https://username:password@mingle.example.com/api/v1/projects/:project_id/"
	4	+ end
	5	+ def self.set_site(site)
	6	+ # ActiveResource seems to clone and freeze the @site variable
	7	+ # after the first use. It seems that the only way to change @site
	8	+ # is to drop the subclass, and then reload it.
	9	+ Mingle.send(:remove_const, :Card)
	10	+ load File.join(Rails.root,'lib','issue_trackers','mingle.rb')
	11	+ Mingle::Card.site = site
	12	+ end
	13	+end
	14	+
	@@ -525,7 +525,7 @@ a.button.active {		@@ -525,7 +525,7 @@ a.button.active {
525	}	525	}
526		526
527	/* Watchers and Issue Tracker Forms */	527	/* Watchers and Issue Tracker Forms */
528	-div.nested.watcher .user, div.nested.watcher .email, div.issue_tracker.nested .lighthouseapp, div.issue_tracker.nested .redmine, div.issue_tracker.nested .pivotal, div.issue_tracker.nested .fogbugz {	528	+div.nested.watcher .user, div.nested.watcher .email, div.issue_tracker.nested .tracker_params {
529	display: none;	529	display: none;
530	}	530	}
531	div.nested.watcher .choosen, div.nested.issue_tracker .chosen {	531	div.nested.watcher .choosen, div.nested.issue_tracker .chosen {
	@@ -297,7 +297,7 @@ describe AppsController do		@@ -297,7 +297,7 @@ describe AppsController do
297	@app.reload	297	@app.reload
298		298
299	@app.issue_tracker.should be_nil	299	@app.issue_tracker.should be_nil
300	- response.body.should match(/You must specify your Lighthouseapp account, api token and project id/)	300	+ response.body.should match(/You must specify your Lighthouseapp account, API token and Project ID/)
301	end	301	end
302	end	302	end
303		303
	@@ -322,7 +322,7 @@ describe AppsController do		@@ -322,7 +322,7 @@ describe AppsController do
322	@app.reload	322	@app.reload
323		323
324	@app.issue_tracker.should be_nil	324	@app.issue_tracker.should be_nil
325	- response.body.should match(/You must specify your Redmine url, api token and project id/)	325	+ response.body.should match(/You must specify your Redmine URL, API token and Project ID/)
326	end	326	end
327	end	327	end
328		328
	@@ -344,7 +344,7 @@ describe AppsController do		@@ -344,7 +344,7 @@ describe AppsController do
344	@app.reload	344	@app.reload
345		345
346	@app.issue_tracker.should be_nil	346	@app.issue_tracker.should be_nil
347	- response.body.should match(/You must specify your Pivotal Tracker api token and project id/)	347	+ response.body.should match(/You must specify your Pivotal Tracker API token and Project ID/)
348	end	348	end
349	end	349	end
350		350
	@@ -375,6 +375,37 @@ describe AppsController do		@@ -375,6 +375,37 @@ describe AppsController do
375	end	375	end
376	end	376	end
377	end	377	end
		378	+
		379	+ context "mingle" do
		380	+ context 'with correct params' do
		381	+ before do
		382	+ put :update, :id => @app.id, :app => { :issue_tracker_attributes => {
		383	+ :issue_tracker_type => 'mingle', :project_id => 'test', :account => 'http://mingle.example.com',
		384	+ :username => '1234', :password => '123123', :ticket_properties => "card_type = Defect"
		385	+ } }
		386	+ @app.reload
		387	+ end
		388	+
		389	+ subject {@app.issue_tracker}
		390	+ its(:issue_tracker_type) {should == 'mingle'}
		391	+ its(:project_id) {should == 'test'}
		392	+ its(:username) {should == '1234'}
		393	+ its(:password) {should == '123123'}
		394	+ end
		395	+
		396	+ it "should show validation notice when sufficient params are not present" do
		397	+ put :update, :id => @app.id, :app => { :issue_tracker_attributes => {
		398	+ :issue_tracker_type => 'mingle', :project_id => 'test', :account => 'http://mingle.example.com',
		399	+ :username => '1234', :password => '1234', :ticket_properties => "cards_type = Defect"
		400	+ } }
		401	+ @app.reload
		402	+
		403	+ @app.issue_tracker.should be_nil
		404	+ response.body.should match(/You must specify your Mingle URL, Project ID, Card Type \(in default card properties\), Sign-in name, and Password/)
		405	+ end
		406	+ end
		407	+
		408	+
378	end	409	end
379	end	410	end
380		411
	@@ -330,7 +330,7 @@ describe ErrsController do		@@ -330,7 +330,7 @@ describe ErrsController do
330	end	330	end
331	end	331	end
332		332
333	- context "redmine tracker" do	333	+ context "pivotal tracker" do
334	let(:notice) { Factory :notice }	334	let(:notice) { Factory :notice }
335	let(:tracker) { Factory :pivotal_tracker, :app => notice.err.app }	335	let(:tracker) { Factory :pivotal_tracker, :app => notice.err.app }
336	let(:err) { notice.err }	336	let(:err) { notice.err }
	@@ -362,6 +362,40 @@ describe ErrsController do		@@ -362,6 +362,40 @@ describe ErrsController do
362	err.issue_link.should == @issue_link.sub(/\.xml/, '')	362	err.issue_link.should == @issue_link.sub(/\.xml/, '')
363	end	363	end
364	end	364	end
		365	+
		366	+ context "mingle tracker" do
		367	+ let(:notice) { Factory :notice }
		368	+ let(:tracker) { Factory :mingle_tracker, :app => notice.err.app }
		369	+ let(:err) { notice.err }
		370	+
		371	+ before(:each) do
		372	+ number = 5
		373	+ @issue_link = "#{tracker.account}/projects/#{tracker.project_id}/cards/#{number}.xml"
		374	+ @basic_auth = tracker.account.gsub("https://", "https://#{tracker.username}:#{tracker.password}@")
		375	+ body = "<card><id type=\"integer\">#{number}</id></card>"
		376	+ stub_request(:post, "#{@basic_auth}/api/v1/projects/#{tracker.project_id}/cards.xml").
		377	+ to_return(:status => 201, :headers => {'Location' => @issue_link}, :body => body )
		378	+
		379	+ post :create_issue, :app_id => err.app.id, :id => err.id
		380	+ err.reload
		381	+ end
		382	+
		383	+ it "should make request to Mingle with err params" do
		384	+ requested = have_requested(:post, "#{@basic_auth}/api/v1/projects/#{tracker.project_id}/cards.xml")
		385	+ WebMock.should requested.with(:headers => {'Content-Type' => 'application/xml'})
		386	+ WebMock.should requested.with(:body => /FooError: Too Much Bar/)
		387	+ WebMock.should requested.with(:body => /See this exception on Errbit/)
		388	+ WebMock.should requested.with(:body => /<card-type-name>Defect<\/card-type-name>/)
		389	+ end
		390	+
		391	+ it "should redirect to err page" do
		392	+ response.should redirect_to( app_err_path(err.app, err) )
		393	+ end
		394	+
		395	+ it "should create issue link for err" do
		396	+ err.issue_link.should == @issue_link.sub(/\.xml$/, '')
		397	+ end
		398	+ end
365	end	399	end
366		400
367	context "absent issue tracker" do	401	context "absent issue tracker" do
	@@ -17,3 +17,12 @@ end		@@ -17,3 +17,12 @@ end
17	Factory.define :pivotal_tracker, :parent => :generic_tracker do \|e\|	17	Factory.define :pivotal_tracker, :parent => :generic_tracker do \|e\|
18	e.issue_tracker_type 'pivotal'	18	e.issue_tracker_type 'pivotal'
19	end	19	end
		20	+
		21	+Factory.define :mingle_tracker, :parent => :generic_tracker do \|t\|
		22	+ t.issue_tracker_type 'mingle'
		23	+ t.account "https://mingle.example.com"
		24	+ t.ticket_properties 'card_type = Defect, defect_status = open, priority = essential'
		25	+ t.username "test_user"
		26	+ t.password "test_password"
		27	+end
		28	+