Rubocop: fail preferred over raise

Laust Rud Jacobsen
1 parent 4ef00339
Showing 6 changed files with 6 additions and 17 deletions Show diff stats
.rubocop_todo.yml
app/controllers/notices_controller.rb
app/interactors/problem_merge.rb
app/models/problem.rb
lib/airbrake_api/v3/notice_parser.rb
lib/hoptoad.rb
@@ -242,17 +242,6 @@ Style/Semicolon:
     - 'app/decorators/issue_tracker_type_decorator.rb'
     - 'app/models/notice_fingerprinter.rb'
  
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SignalException:
-  Exclude:
-    - 'app/controllers/notices_controller.rb'
-    - 'app/interactors/problem_merge.rb'
-    - 'app/models/problem.rb'
-    - 'lib/airbrake_api/v3/notice_parser.rb'
-    - 'lib/hoptoad.rb'
-
 # Offense count: 1
 # Configuration parameters: Methods.
 Style/SingleLineBlockParams:
@@ -39,7 +39,7 @@ private
     return @notice_params if @notice_params
     @notice_params = params[:data] || request.raw_post
     if @notice_params.blank?
-      raise ParamsError.new('Need a data params in GET or raw post data')
+      fail ParamsError.new('Need a data params in GET or raw post data')
     end
     @notice_params
   end
@@ -5,7 +5,7 @@ class ProblemMerge
     problems = problems.flatten.uniq
     @merged_problem = problems[0]
     @child_problems = problems[1..-1]
-    raise ArgumentError.new("need almost 2 uniq different problems") if @child_problems.empty?
+    fail ArgumentError.new("need almost 2 uniq different problems") if @child_problems.empty?
   end
   attr_reader :merged_problem, :child_problems
  
@@ -219,7 +219,7 @@ class Problem
     when "last_notice_at" then order_by(["last_notice_at", order])
     when "last_deploy_at" then order_by(["last_deploy_at", order])
     when "count"          then order_by(["notices_count", order])
-    else raise("\"#{sort}\" is not a recognized sort")
+    else fail("\"#{sort}\" is not a recognized sort")
     end
   end
  
@@ -27,7 +27,7 @@ module AirbrakeApi
     private
  
       def error
-        raise AirbrakeApi::ParamsError unless params.key?('errors') && params['errors'].any?
+        fail AirbrakeApi::ParamsError unless params.key?('errors') && params['errors'].any?
         @error ||= params['errors'].first
       end
  
@@ -9,7 +9,7 @@ module Hoptoad
  
   class << self
     def parse_xml!(xml)
-      parsed = ActiveSupport::XmlMini.backend.parse(xml)['notice'] || raise(ApiVersionError)
+      parsed = ActiveSupport::XmlMini.backend.parse(xml)['notice'] || fail(ApiVersionError)
       processor = get_version_processor(parsed['version'])
       processor.process_notice(parsed)
     end
@@ -17,7 +17,7 @@ module Hoptoad
     private def get_version_processor(version)
       case version
       when /2\.[01234]/ then Hoptoad::V2
-      else; raise ApiVersionError
+      else; fail ApiVersionError
       end
     end
   end
...	...	@@ -242,17 +242,6 @@ Style/Semicolon:
242	242	- 'app/decorators/issue_tracker_type_decorator.rb'
243	243	- 'app/models/notice_fingerprinter.rb'
244	244
245		-# Offense count: 6
246		-# Cop supports --auto-correct.
247		-# Configuration parameters: EnforcedStyle, SupportedStyles.
248		-Style/SignalException:
249		- Exclude:
250		- - 'app/controllers/notices_controller.rb'
251		- - 'app/interactors/problem_merge.rb'
252		- - 'app/models/problem.rb'
253		- - 'lib/airbrake_api/v3/notice_parser.rb'
254		- - 'lib/hoptoad.rb'
255		-
256	245	# Offense count: 1
257	246	# Configuration parameters: Methods.
258	247	Style/SingleLineBlockParams:
...	...
...	...	@@ -39,7 +39,7 @@ private
39	39	return @notice_params if @notice_params
40	40	@notice_params = params[:data] \|\| request.raw_post
41	41	if @notice_params.blank?
42		- raise ParamsError.new('Need a data params in GET or raw post data')
	42	+ fail ParamsError.new('Need a data params in GET or raw post data')
43	43	end
44	44	@notice_params
45	45	end
...	...
...	...	@@ -5,7 +5,7 @@ class ProblemMerge
5	5	problems = problems.flatten.uniq
6	6	@merged_problem = problems[0]
7	7	@child_problems = problems[1..-1]
8		- raise ArgumentError.new("need almost 2 uniq different problems") if @child_problems.empty?
	8	+ fail ArgumentError.new("need almost 2 uniq different problems") if @child_problems.empty?
9	9	end
10	10	attr_reader :merged_problem, :child_problems
11	11
...	...
...	...	@@ -219,7 +219,7 @@ class Problem
219	219	when "last_notice_at" then order_by(["last_notice_at", order])
220	220	when "last_deploy_at" then order_by(["last_deploy_at", order])
221	221	when "count" then order_by(["notices_count", order])
222		- else raise("\"#{sort}\" is not a recognized sort")
	222	+ else fail("\"#{sort}\" is not a recognized sort")
223	223	end
224	224	end
225	225
...	...
...	...	@@ -27,7 +27,7 @@ module AirbrakeApi
27	27	private
28	28
29	29	def error
30		- raise AirbrakeApi::ParamsError unless params.key?('errors') && params['errors'].any?
	30	+ fail AirbrakeApi::ParamsError unless params.key?('errors') && params['errors'].any?
31	31	@error \|\|= params['errors'].first
32	32	end
33	33
...	...
...	...	@@ -9,7 +9,7 @@ module Hoptoad
9	9
10	10	class << self
11	11	def parse_xml!(xml)
12		- parsed = ActiveSupport::XmlMini.backend.parse(xml)['notice'] \|\| raise(ApiVersionError)
	12	+ parsed = ActiveSupport::XmlMini.backend.parse(xml)['notice'] \|\| fail(ApiVersionError)
13	13	processor = get_version_processor(parsed['version'])
14	14	processor.process_notice(parsed)
15	15	end
...	...	@@ -17,7 +17,7 @@ module Hoptoad
17	17	private def get_version_processor(version)
18	18	case version
19	19	when /2\.[01234]/ then Hoptoad::V2
20		- else; raise ApiVersionError
	20	+ else; fail ApiVersionError
21	21	end
22	22	end
23	23	end
...	...