Fixed migrations

Nathan Broadbent
1 parent 24958c80
Showing 2 changed files with 22 additions and 12 deletions Show diff stats
app/models/backtrace_line_normalizer.rb
db/migrate/20121005142110_regenerate_err_fingerprints.rb
@@ -9,11 +9,19 @@ class BacktraceLineNormalizer
   private
   def normalized_file
-    @raw_line['file'].blank? ? "[unknown source]" :  @raw_line['file'].to_s.gsub(/\[PROJECT_ROOT\]\/.*\/ruby\/[0-9.]+\/gems/, '[GEM_ROOT]/gems')
+    if @raw_line['file'].blank?
+      "[unknown source]"
+    else
+      @raw_line['file'].to_s.gsub(/\[PROJECT_ROOT\]\/.*\/ruby\/[0-9.]+\/gems/, '[GEM_ROOT]/gems')
+    end
   end
   def normalized_method
-    @raw_line['method'].blank? ? "[unknown method]" : @raw_line['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
+    if @raw_line['method'].blank?
+      "[unknown method]"
+    else
+      @raw_line['method'].to_s.gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
+    end
   end
 end
 class RegenerateErrFingerprints < Mongoid::Migration
   def self.up
     Err.all.each do |err|
-      fingerprint_source = {
-        :backtrace   => err.notices.first.backtrace_id,
-        :error_class => err.error_class,
-        :component   => err.component,
-        :action      => err.action,
-        :environment => err.environment,
-        :api_key     => err.app.api_key
-      }
-      fingerprint = Digest::SHA1.hexdigest(fingerprint_source.to_s)
-      err.update_attribute(:fingerprint, fingerprint)
+      if err.notices.any?
+        fingerprint_source = {
+          :backtrace   => err.notices.first.backtrace_id,
+          :error_class => err.error_class,
+          :component   => err.component,
+          :action      => err.action,
+          :environment => err.environment,
+          :api_key     => err.app.api_key
+        }
+        fingerprint = Digest::SHA1.hexdigest(fingerprint_source.to_s)
+        err.update_attribute(:fingerprint, fingerprint)
+      end
     end
   end