Merge pull request #998 from rud/chore/fix-more-style

Rubocop: whittling down the TODO list

Merge pull request #998 from rud/chore/fix-more-style
Rubocop: whittling down the TODO list
Stephen Crosby
2 parents d1683958 9f9132ff
Showing 72 changed files with 476 additions and 531 deletions Show diff stats
.rubocop.yml
.rubocop_todo.yml
app/controllers/api/v1/notices_controller.rb
app/controllers/api/v1/problems_controller.rb
app/controllers/api/v1/stats_controller.rb
app/controllers/application_controller.rb
app/controllers/apps_controller.rb
app/controllers/deploys_controller.rb
app/controllers/problems_controller.rb
app/controllers/problems_searcher.rb
app/controllers/users_controller.rb
app/decorators/backtrace_line_decorator.rb
app/helpers/application_helper.rb
app/helpers/apps_helper.rb
app/helpers/problems_helper.rb
app/interactors/problem_destroy.rb
app/interactors/resolved_problem_clearer.rb
app/models/app.rb
app/models/comment.rb
app/models/deploy.rb
@@ -23,6 +23,9 @@ Style/IndentationConsistency:
   # modifiers.
   EnforcedStyle: rails
+Style/GuardClause:
+  MinBodyLength: 4
+
 Style/AccessModifierIndentation:
   EnforcedStyle: outdent
@@ -33,6 +36,9 @@ Style/DotPosition:
   # Support code copy/paste into console
   EnforcedStyle: trailing
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
 Style/IndentHash:
   EnforcedStyle: consistent
@@ -46,3 +52,7 @@ Style/SpaceAroundOperators:
     - '=>'
     - '||='
     - 'then'
+
+Style/FileName:
+  Exclude:
+    - 'config/initializers/cve-*.rb'
@@ -41,24 +41,6 @@ Rails/Output:
     - 'app/interactors/problem_recacher.rb'
     - 'db/seeds.rb'
-# Offense count: 12
-# Configuration parameters: Include.
-Rails/Validation:
-  Exclude:
-    - 'app/models/app.rb'
-    - 'app/models/comment.rb'
-    - 'app/models/deploy.rb'
-    - 'app/models/err.rb'
-    - 'app/models/notice.rb'
-    - 'app/models/problem.rb'
-    - 'app/models/user.rb'
-
-# Offense count: 105
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
-Style/BlockDelimiters:
-  Enabled: false
-
 # Offense count: 15
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/ClassAndModuleChildren:
@@ -93,94 +75,6 @@ Style/EachWithObject:
     - 'app/models/notice_fingerprinter.rb'
     - 'lib/recurse.rb'
-# Offense count: 2
-# Configuration parameters: Exclude.
-Style/FileName:
-  Exclude:
-    - 'config/initializers/cve-2013-0156.rb'
-    - 'script/rspec-queue-mongoid.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/FirstParameterIndentation:
-  Exclude:
-    - 'app/models/issue_tracker.rb'
-    - 'spec/decorators/backtrace_decorator_spec.rb'
-    - 'spec/decorators/issue_tracker_type_decorator_spec.rb'
-
-# Offense count: 8
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/FormatString:
-  Exclude:
-    - 'app/decorators/backtrace_line_decorator.rb'
-    - 'app/helpers/problems_helper.rb'
-    - 'spec/views/apps/edit.html.haml_spec.rb'
-    - 'spec/views/problems/show.html.haml_spec.rb'
-    - 'spec/views/users/show.html.haml_spec.rb'
-
-# Offense count: 27
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'app/controllers/api/v1/stats_controller.rb'
-    - 'app/controllers/application_controller.rb'
-    - 'app/controllers/problems_controller.rb'
-    - 'app/models/notice.rb'
-    - 'app/models/user.rb'
-
-# Offense count: 17
-# Cop supports --auto-correct.
-Style/LeadingCommentSpace:
-  Exclude:
-    - 'app/models/notification_services/gtalk_service.rb'
-    - 'spec/controllers/api/v1/notices_controller_spec.rb'
-    - 'spec/controllers/api/v1/problems_controller_spec.rb'
-    - 'spec/models/fabricators_spec.rb'
-    - 'spec/models/notification_service/campfire_service_spec.rb'
-    - 'spec/models/notification_service/gtalk_service_spec.rb'
-    - 'spec/models/notification_service/hoiio_service_spec.rb'
-    - 'spec/models/notification_service/pushover_service_spec.rb'
-
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/MultilineOperationIndentation:
-  Enabled: false
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'app/controllers/api/v1/notices_controller.rb'
-    - 'app/controllers/api/v1/problems_controller.rb'
-    - 'app/controllers/problems_searcher.rb'
-    - 'spec/models/notice_spec.rb'
-
-# Offense count: 1
-# Configuration parameters: Methods.
-Style/SingleLineBlockParams:
-  Exclude:
-    - 'lib/hoptoad/v2.rb'
-
-# Offense count: 11
-# Cop supports --auto-correct.
-Style/SingleSpaceBeforeFirstArg:
-  Exclude:
-    - 'app/models/comment.rb'
-    - 'config/application.rb'
-    - 'spec/fabricators/app_fabricator.rb'
-    - 'spec/fabricators/comment_fabricator.rb'
-    - 'spec/fabricators/notice_fabricator.rb'
-    - 'spec/fabricators/user_fabricator.rb'
-
 # Offense count: 873
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -3,7 +3,7 @@ class Api::V1::NoticesController &lt; ApplicationController
   def index
     query = {}
-    fields = %w{created_at message error_class}
+    fields = %w(created_at message error_class)
     if params.key?(:start_date) && params.key?(:end_date)
       start_date = Time.zone.parse(params[:start_date]).utc
 class Api::V1::ProblemsController < ApplicationController
   respond_to :json, :xml
-  FIELDS = %w{_id app_id app_name environment message where first_notice_at last_notice_at resolved resolved_at notices_count}
+  FIELDS = %w(_id app_id app_name environment message where first_notice_at last_notice_at resolved resolved_at notices_count)
   def show
     result = benchmark("[api/v1/problems_controller/show] query time") do
@@ -25,9 +25,7 @@ class Api::V1::StatsController &lt; ApplicationController
   protected def require_api_key_or_authenticate_user!
     if params[:api_key].present?
-      if (@app = App.where(api_key: params[:api_key]).first)
-        return true
-      end
+      return true if (@app = App.where(api_key: params[:api_key]).first)
     end
     authenticate_user!
@@ -23,10 +23,10 @@ protected
   # Check if the current_user is admin or not and redirect to root url if not
   #
   def require_admin!
-    unless user_signed_in? && current_user.admin?
-      flash[:error] = "Sorry, you don't have permission to do that"
-      redirect_to_root
-    end
+    return if user_signed_in? && current_user.admin?
+
+    flash[:error] = "Sorry, you don't have permission to do that"
+    redirect_to_root
   end
   def redirect_to_root
@@ -41,8 +41,6 @@ protected
     user_token = params[User.token_authentication_key].presence
     user       = user_token && User.find_by(authentication_token: user_token)
-    if user
-      sign_in user, store: false
-    end
+    sign_in user, store: false if user
   end
 end
@@ -8,9 +8,9 @@ class AppsController &lt; ApplicationController
   expose(:app_scope) { App }
-  expose(:apps) {
+  expose(:apps) do
     app_scope.all.sort.map { |app| AppDecorator.new(app) }
-  }
+  end
   expose(:app, ancestor: :app_scope, attributes: :app_params)
@@ -18,11 +18,11 @@ class AppsController &lt; ApplicationController
     AppDecorator.new(app)
   end
-  expose(:all_errs) {
+  expose(:all_errs) do
     params[:all_errs].present?
-  }
+  end
-  expose(:problems) {
+  expose(:problems) do
     if request.format == :atom
       app.problems.unresolved.ordered
     else
@@ -32,15 +32,15 @@ class AppsController &lt; ApplicationController
         params[:environment]
       ).ordered_by(params_sort, params_order).page(params[:page]).per(current_user.per_page)
     end
-  }
+  end
-  expose(:deploys) {
+  expose(:deploys) do
     app.deploys.order_by(:created_at.desc).limit(5)
-  }
+  end
-  expose(:users) {
+  expose(:users) do
     User.all.sort_by { |u| u.name.downcase }
-  }
+  end
   def index; end
@@ -93,13 +93,16 @@ class AppsController &lt; ApplicationController
 protected
   def initialize_subclassed_notification_service
+    notification_type = params[:app].
+      fetch(:notification_service_attributes, {}).
+      fetch(:type, nil)
+    return if notification_type.blank?
+
     # set the app's notification service
-    if params[:app][:notification_service_attributes] && (notification_type = params[:app][:notification_service_attributes][:type])
-      available_notification_classes = [NotificationService] + NotificationService.subclasses
-      notification_class = available_notification_classes.detect { |c| c.name == notification_type }
-      if notification_class.present?
-        app.notification_service = notification_class.new(params[:app][:notification_service_attributes])
-      end
+    available_notification_classes = [NotificationService] + NotificationService.subclasses
+    notification_class = available_notification_classes.detect { |c| c.name == notification_type }
+    if notification_class.present?
+      app.notification_service = notification_class.new(params[:app][:notification_service_attributes])
     end
   end
@@ -112,32 +115,38 @@ protected
   # email_at_notices is edited as a string, and stored as an array.
   def parse_email_at_notices_or_set_default
-    if params[:app] && (val = params[:app][:email_at_notices])
-      # Sanitize negative values, split on comma,
-      # strip, parse as integer, remove all '0's.
-      # If empty, set as default and show an error message.
-      email_at_notices = val.gsub(/-\d+/, "").split(",").map { |v| v.strip.to_i }.reject { |v| v == 0 }
-      if email_at_notices.any?
-        params[:app][:email_at_notices] = email_at_notices
-      else
-        default_array = params[:app][:email_at_notices] = Errbit::Config.email_at_notices
-        flash[:error] = "Couldn't parse your notification frequency. Value was reset to default (#{default_array.join(', ')})."
-      end
+    return if params[:app].blank?
+
+    val = params[:app][:email_at_notices]
+    return if val.blank?
+
+    # Sanitize negative values, split on comma,
+    # strip, parse as integer, remove all '0's.
+    # If empty, set as default and show an error message.
+    email_at_notices = val.gsub(/-\d+/, "").split(",").map { |v| v.strip.to_i }.reject { |v| v == 0 }
+    if email_at_notices.any?
+      params[:app][:email_at_notices] = email_at_notices
+    else
+      default_array = params[:app][:email_at_notices] = Errbit::Config.email_at_notices
+      flash[:error] = "Couldn't parse your notification frequency. Value was reset to default (#{default_array.join(', ')})."
     end
   end
   def parse_notice_at_notices_or_set_default
-    if params[:app][:notification_service_attributes] && (val = params[:app][:notification_service_attributes][:notify_at_notices])
-      # Sanitize negative values, split on comma,
-      # strip, parse as integer, remove all '0's.
-      # If empty, set as default and show an error message.
-      notify_at_notices = val.gsub(/-\d+/, "").split(",").map { |v| v.strip.to_i }
-      if notify_at_notices.any?
-        params[:app][:notification_service_attributes][:notify_at_notices] = notify_at_notices
-      else
-        default_array = params[:app][:notification_service_attributes][:notify_at_notices] = Errbit::Config.notify_at_notices
-        flash[:error] = "Couldn't parse your notification frequency. Value was reset to default (#{default_array.join(', ')})."
-      end
+    return if params[:app][:notification_service_attributes].blank?
+
+    val = params[:app][:notification_service_attributes][:notify_at_notices]
+    return if val.blank?
+
+    # Sanitize negative values, split on comma,
+    # strip, parse as integer, remove all '0's.
+    # If empty, set as default and show an error message.
+    notify_at_notices = val.gsub(/-\d+/, "").split(",").map { |v| v.strip.to_i }
+    if notify_at_notices.any?
+      params[:app][:notification_service_attributes][:notify_at_notices] = notify_at_notices
+    else
+      default_array = params[:app][:notification_service_attributes][:notify_at_notices] = Errbit::Config.notify_at_notices
+      flash[:error] = "Couldn't parse your notification frequency. Value was reset to default (#{default_array.join(', ')})."
     end
   end
@@ -19,15 +19,15 @@ class DeploysController &lt; ApplicationController
 private
   def default_deploy
-    if params[:deploy]
-      {
-        username:    params[:deploy][:local_username],
-        environment: params[:deploy][:rails_env],
-        repository:  params[:deploy][:scm_repository],
-        revision:    params[:deploy][:scm_revision],
-        message:     params[:deploy][:message]
-      }
-    end
+    return if params[:deploy].blank?
+
+    {
+      username:    params[:deploy][:local_username],
+      environment: params[:deploy][:rails_env],
+      repository:  params[:deploy][:scm_repository],
+      revision:    params[:deploy][:scm_revision],
+      message:     params[:deploy][:message]
+    }
   end
   # handle Heroku's HTTP post deployhook format
@@ -11,27 +11,27 @@ class ProblemsController &lt; ApplicationController
     :resolve_several, :unresolve_several, :unmerge_several
   ]
-  expose(:app_scope) {
+  expose(:app_scope) do
     params[:app_id] ? App.where(_id: params[:app_id]) : App.all
-  }
+  end
-  expose(:app) {
+  expose(:app) do
     AppDecorator.new app_scope.find(params[:app_id])
-  }
+  end
-  expose(:problem) {
+  expose(:problem) do
     ProblemDecorator.new app.problems.find(params[:id])
-  }
+  end
-  expose(:all_errs) {
+  expose(:all_errs) do
     params[:all_errs]
-  }
+  end
-  expose(:params_environement) {
+  expose(:params_environement) do
     params[:environment]
-  }
+  end
-  expose(:problems) {
+  expose(:problems) do
     pro = Problem.
       for_apps(app_scope).
       in_env(params_environement).
@@ -43,7 +43,7 @@ class ProblemsController &lt; ApplicationController
     else
       pro
     end
-  }
+  end
   def index; end
@@ -58,9 +58,7 @@ class ProblemsController &lt; ApplicationController
     issue = Issue.new(problem: problem, user: current_user)
     issue.body = render_to_string(*issue.render_body_args)
-    unless issue.save
-      flash[:error] = issue.errors.full_messages.join(', ')
-    end
+    flash[:error] = issue.errors.full_messages.join(', ') unless issue.save
     redirect_to app_problem_path(app, problem)
   end
@@ -138,9 +136,9 @@ class ProblemsController &lt; ApplicationController
   # Redirect :back if no errors selected
   #
   protected def need_selected_problem
-    if err_ids.empty?
-      flash[:notice] = I18n.t('controllers.problems.flash.no_select_problem')
-      redirect_to :back
-    end
+    return if err_ids.any?
+
+    flash[:notice] = I18n.t('controllers.problems.flash.no_select_problem')
+    redirect_to :back
   end
 end
@@ -5,28 +5,28 @@ module ProblemsSearcher
   extend ActiveSupport::Concern
   included do
-    expose(:params_sort) {
-      if %w{app message last_notice_at last_deploy_at count}.member?(params[:sort])
+    expose(:params_sort) do
+      if %w(app message last_notice_at last_deploy_at count).member?(params[:sort])
         params[:sort]
       else
         "last_notice_at"
       end
-    }
+    end
-    expose(:params_order) {
-      if %w{asc desc}.member?(params[:order])
+    expose(:params_order) do
+      if %w(asc desc).member?(params[:order])
         params[:order]
       else
         'desc'
       end
-    }
+    end
-    expose(:selected_problems) {
+    expose(:selected_problems) do
       Array(Problem.find(err_ids))
-    }
+    end
-    expose(:err_ids) {
+    expose(:err_ids) do
       (params[:problems] || []).compact
-    }
+    end
   end
 end
@@ -5,9 +5,9 @@ class UsersController &lt; ApplicationController
   before_action :require_user_edit_priviledges, only: [:edit, :update]
   expose(:user, attributes: :user_params)
-  expose(:users) {
+  expose(:users) do
     User.all.page(params[:page]).per(current_user.per_page)
-  }
+  end
   def index; end
   def new; end
@@ -57,7 +57,7 @@ private
       link_to_hosted_javascript(app, text)
     else
       link_to_repo_source_file(app, text) ||
-      link_to_issue_tracker_file(app, text)
+        link_to_issue_tracker_file(app, text)
     end
   end
@@ -66,20 +66,19 @@ private
   end
   def link_to_hosted_javascript(app, text)
-    if app.asset_host?
-      h.link_to(text, "#{app.asset_host}/#{file_relative}", target: '_blank')
-    end
+    return unless app.asset_host?
+    h.link_to(text, "#{app.asset_host}/#{file_relative}", target: '_blank')
   end
   def link_to_github(app, text = nil)
     return unless app.github_repo?
-    href = "%s#L%s" % [app.github_url_to_file(decorated_path + file_name), number]
+    href = format("%s#L%s", app.github_url_to_file(decorated_path + file_name), number)
     h.link_to(text || file_name, href, target: '_blank')
   end
   def link_to_bitbucket(app, text = nil)
     return unless app.bitbucket_repo?
-    href = "%s#%s-%s" % [app.bitbucket_url_to_file(decorated_path + file_name), file_name, number]
+    href = format("%s#%s-%s", app.bitbucket_url_to_file(decorated_path + file_name), file_name, number)
     h.link_to(text || file_name, href, target: '_blank')
   end
@@ -20,7 +20,7 @@ module ApplicationHelper
   end
   def generate_ical(deploys)
-    RiCal.Calendar { |cal|
+    RiCal.Calendar do |cal|
       deploys.each_with_index do |deploy, idx|
         cal.event do |event|
           event.summary     = "#{idx + 1} #{deploy.repository}"
@@ -31,7 +31,7 @@ module ApplicationHelper
           event.organizer   = deploy.username.to_s
         end
       end
-    }.to_s
+    end.to_s
   end
   def user_agent_graph(problem)
@@ -57,7 +57,7 @@ module ApplicationHelper
     total   = (options[:total] || total_from_tallies(tallies))
     percent = 100.0 / total.to_f
     rows    = tallies.map { |value, count| [(count.to_f * percent), value] }. \
-                     sort { |a, b| b[0] <=> a[0] }
+      sort { |a, b| b[0] <=> a[0] }
     render "problems/tally_table", rows: rows
   end
 module AppsHelper
   def link_to_copy_attributes_from_other_app
-    if App.count > 1
-      html =  link_to('copy settings from another app', '#',
-        class: 'button copy_config')
-      html << select("duplicate", "app",
-        App.all.asc(:name).reject { |a| a == @app }.
-        collect { |p| [p.name, p.id] }, { include_blank: "[choose app]" },
-        class: "choose_other_app", style: "display: none;")
-      return html
-    end
+    return if App.count <= 1
+
+    html = link_to('copy settings from another app', '#',
+      class: 'button copy_config')
+    html << select("duplicate", "app",
+      App.all.asc(:name).reject { |a| a == @app }.
+      collect { |p| [p.name, p.id] }, { include_blank: "[choose app]" },
+      class: "choose_other_app", style: "display: none;")
+    html
   end
   def any_github_repos?
 module ProblemsHelper
   def problem_confirm(action)
-    t('problems.confirm.%s' % action) unless Errbit::Config.confirm_err_actions.eql? false
+    t(format('problems.confirm.%s', action)) unless Errbit::Config.confirm_err_actions.eql? false
   end
   def truncated_problem_message(problem)
-    unless (msg = problem.message).blank?
-      # Truncate & insert invisible chars so that firefox can emulate 'word-wrap: break-word' CSS rule
-      truncate(msg, length: 300, escape: false).scan(/.{1,5}/).map { |s| h(s) }.join("&#8203;").html_safe
-    end
+    msg = problem.message
+    return if msg.blank?
+
+    # Truncate & insert invisible chars so that firefox can emulate
+    # 'word-wrap: break-word' CSS rule
+    truncate(msg, length: 300, escape: false).
+      scan(/.{1,5}/).map { |s| h(s) }.
+      join("&#8203;").html_safe
   end
   def gravatar_tag(email, options = {})
@@ -20,9 +20,9 @@ class ProblemDestroy
   #   the number of problem destroy
   #
   def self.execute(problems)
-    Array(problems).each { |problem|
+    Array(problems).each do |problem|
       ProblemDestroy.new(problem).execute
-    }.count
+    end.count
   end
 private
@@ -5,14 +5,14 @@ class ResolvedProblemClearer
   # Clear all problem already resolved
   #
   def execute
-    nb_problem_resolved.tap { |nb|
+    nb_problem_resolved.tap do |nb|
       if nb > 0
         criteria.each do |problem|
           ProblemDestroy.new(problem).execute
         end
         repair_database
       end
-    }
+    end
   end
 private
@@ -35,9 +35,7 @@ class App
   before_save :normalize_github_repo
   after_update :store_cached_attributes_on_problems
-  validates_presence_of :name, :api_key
-  validates_uniqueness_of :name, allow_blank: true
-  validates_uniqueness_of :api_key, allow_blank: true
+  validates :name, :api_key, presence: true, uniqueness: { allow_blank: true }
   validates_associated :watchers
   validates_associated :notice_fingerprinter
   validate :check_issue_tracker
@@ -154,16 +152,17 @@ class App
   # Copy app attributes from another app.
   def copy_attributes_from(app_id)
-    if (copy_app = App.where(_id: app_id).first)
-      # Copy fields
-      (copy_app.fields.keys - %w(_id name created_at updated_at)).each do |k|
-        send("#{k}=", copy_app.send(k))
-      end
-      # Clone the embedded objects that can be changed via apps/edit (ignore errs & deploys, etc.)
-      %w(watchers issue_tracker notification_service).each do |relation|
-        if (obj = copy_app.send(relation))
-          send("#{relation}=", obj.is_a?(Array) ? obj.map(&:clone) : obj.clone)
-        end
+    copy_app = App.where(_id: app_id).first
+    return if copy_app.blank?
+
+    # Copy fields
+    (copy_app.fields.keys - %w(_id name created_at updated_at)).each do |k|
+      send("#{k}=", copy_app.send(k))
+    end
+    # Clone the embedded objects that can be changed via apps/edit (ignore errs & deploys, etc.)
+    %w(watchers issue_tracker notification_service).each do |relation|
+      if (obj = copy_app.send(relation))
+        send("#{relation}=", obj.is_a?(Array) ? obj.map(&:clone) : obj.clone)
       end
     end
   end
@@ -179,8 +178,8 @@ class App
   # Compare by number of unresolved errs, then problem counts.
   def <=>(other)
     (other.unresolved_count <=> unresolved_count).nonzero? ||
-    (other.problem_count <=> problem_count).nonzero? ||
-    name <=> other.name
+      (other.problem_count <=> problem_count).nonzero? ||
+      name <=> other.name
   end
   def email_at_notices
@@ -204,12 +203,12 @@ protected
   end
   def check_issue_tracker
-    if issue_tracker.present?
-      issue_tracker.valid?
-      issue_tracker.errors.full_messages.each do |error|
-        errors[:base] << error
-      end if issue_tracker.errors
-    end
+    return if issue_tracker.blank?
+
+    issue_tracker.valid?
+    issue_tracker.errors.full_messages.each do |error|
+      errors[:base] << error
+    end if issue_tracker.errors
   end
   def normalize_github_repo
@@ -12,9 +12,10 @@ class Comment
   belongs_to :err, class_name: "Problem"
   belongs_to :user
-  delegate   :app, to: :err
-  validates_presence_of :body
+  delegate :app, to: :err
+
+  validates :body, presence: true
   def deliver_email
     Mailer.comment_notification(self).deliver_now
@@ -16,7 +16,7 @@ class Deploy
   after_create :store_cached_attributes_on_problems
   after_create :deliver_email
-  validates_presence_of :username, :environment
+  validates :username, :environment, presence: true
   def resolve_app_errs
     app.problems.unresolved.in_env(environment).each(&:resolve!)
@@ -14,7 +14,7 @@ class Err
   belongs_to :problem
   has_many :notices, inverse_of: :err, dependent: :destroy
-  validates_presence_of :problem_id, :fingerprint
+  validates :problem_id, :fingerprint, presence: true
   delegate :app, :resolved?, to: :problem
 end
@@ -14,10 +14,12 @@ class IssueTracker
       begin
         klass = ErrbitPlugin::Registry.issue_trackers[type_tracker] || ErrbitPlugin::NoneIssueTracker
         # TODO: we need to find out a better way to pass those config to the issue tracker
-        klass.new(options.merge(
-          github_repo:    app.try(:github_repo),
-          bitbucket_repo: app.try(:bitbucket_repo)
-        ))
+        klass.new(
+          options.merge(
+            github_repo:    app.try(:github_repo),
+            bitbucket_repo: app.try(:bitbucket_repo)
+          )
+        )
       end
   end
@@ -24,7 +24,7 @@ class Notice
   before_save :sanitize
   before_destroy :problem_recache
-  validates_presence_of :backtrace_id, :server_environment, :notifier
+  validates :backtrace_id, :server_environment, :notifier, presence: true
   scope :ordered, -> { order_by(:created_at.asc) }
   scope :reverse_ordered, -> { order_by(:created_at.desc) }
@@ -107,15 +107,11 @@ class Notice
   # TODO: Move on decorator maybe
   #
   def project_root
-    if server_environment
-      server_environment['project-root'] || ''
-    end
+    server_environment['project-root'] || '' if server_environment
   end
   def app_version
-    if server_environment
-      server_environment['app-version'] || ''
-    end
+    server_environment['app-version'] || '' if server_environment
   end
   # filter memory addresses out of object strings
@@ -45,10 +45,10 @@ class NotificationServices::GtalkService &lt; NotificationService
     client.connect(service)
     client.auth(api_token)
-    #has to look like this to be formatted properly in the client
-    message = """#{problem.app.name}
-#{Errbit::Config.protocol}://#{Errbit::Config.host}/apps/#{problem.app.id}
-#{notification_description problem}"""
+    # has to look like this to be formatted properly in the client
+    message = """#{problem.app.name}\n" \
+      "#{Errbit::Config.protocol}://#{Errbit::Config.host}/apps/#{problem.app.id}\n" \
+      "#{notification_description problem}"""
     # post the issue to the xmpp room(s)
     send_to_users(client, message) unless user_id.blank?
@@ -66,7 +66,7 @@ private
   end
   def send_to_muc(client, message)
-    #TODO: set this so that it can send to multiple rooms like users, nb multiple room joins in one send fail randomly so leave as one room for the moment
+    # TODO: set this so that it can send to multiple rooms like users, nb multiple room joins in one send fail randomly so leave as one room for the moment
     muc = Jabber::MUC::SimpleMUCClient.new(client)
     muc.join(room_id + "/errbit")
     muc.send(Jabber::Message.new(room_id, message))
@@ -53,7 +53,8 @@ class Problem
   has_many :errs, inverse_of: :problem, dependent: :destroy
   has_many :comments, inverse_of: :err, dependent: :destroy
-  validates_presence_of :environment
+  validates :environment, presence: true
+  validates :last_notice_at, :first_notice_at, presence: true
   before_create :cache_app_attributes
   before_save :truncate_message
@@ -63,8 +64,6 @@ class Problem
   scope :ordered, -> { order_by(:last_notice_at.desc) }
   scope :for_apps, ->(apps) { where(:app_id.in => apps.all.map(&:id)) }
-  validates_presence_of :last_notice_at, :first_notice_at
-
   def self.all_else_unresolved(fetch_all)
     if fetch_all
       all
@@ -38,12 +38,12 @@ class User
   before_save :ensure_authentication_token
-  validates_presence_of :name
-  validates_uniqueness_of :github_login, allow_nil: true
+  validates :name, presence: true
+  validates :github_login, uniqueness: { allow_nil: true }
   if Errbit::Config.user_has_username
     field :username
-    validates_presence_of :username
+    validates :username, presence: true
   end
   def per_page
@@ -67,9 +67,7 @@ class User
   end
   def github_login=(login)
-    if login.is_a?(String) && login.strip.empty?
-      login = nil
-    end
+    login = nil if login.is_a?(String) && login.strip.empty?
     self[:github_login] = login
   end
@@ -37,9 +37,9 @@ module Errbit
     # > rails generate - config
     config.generators do |g|
-      g.orm             :mongoid
+      g.orm :mongoid
       g.template_engine :haml
-      g.test_framework  :rspec, fixture: false
+      g.test_framework :rspec, fixture: false
       g.fixture_replacement :fabrication
     end
@@ -29,9 +29,9 @@ Errbit::Config = Configurator.run(
   mongo_url:                 %w(MONGOLAB_URI MONGOHQ_URL MONGODB_URL MONGO_URL),
   # github
-  github_url:                ['GITHUB_URL', lambda { |values|
+  github_url:                ['GITHUB_URL', lambda do |values|
     values[:github_url].gsub(%r{/*\z}, '')
-  }],
+  end],
   github_authentication:     ['GITHUB_AUTHENTICATION'],
   github_client_id:          ['GITHUB_CLIENT_ID'],
   github_secret:             ['GITHUB_SECRET'],
@@ -40,9 +40,9 @@ Errbit::Config = Configurator.run(
   github_api_url:            ['GITHUB_API_URL'],
   github_site_title:         ['GITHUB_SITE_TITLE'],
-  email_delivery_method:     ['EMAIL_DELIVERY_METHOD', lambda { |values|
+  email_delivery_method:     ['EMAIL_DELIVERY_METHOD', lambda do |values|
     values[:email_delivery_method] && values[:email_delivery_method].to_sym
-  }],
+  end],
   # smtp settings
   smtp_address:              ['SMTP_SERVER'],
@@ -50,10 +50,10 @@ Errbit::Config = Configurator.run(
   smtp_authentication:       ['SMTP_AUTHENTICATION'],
   smtp_user_name:            %w(SMTP_USERNAME SENDGRID_USERNAME),
   smtp_password:             %w(SMTP_PASSWORD SENDGRID_PASSWORD),
-  smtp_domain:               ['SMTP_DOMAIN', 'SENDGRID_DOMAIN', lambda { |values|
+  smtp_domain:               ['SMTP_DOMAIN', 'SENDGRID_DOMAIN', lambda do |values|
     values[:smtp_domain] ||
     (values[:email_from] && values[:email_from].split('@').last) || nil
-  }],
+  end],
   # sendmail settings
   sendmail_location:         ['SENDMAIL_LOCATION'],
@@ -15,7 +15,7 @@ gem install test-queue
 After you just need launch the script with adapting runner of mongoid.
 ```
-./script/rspec-queue-mongoid.rb spec
+./script/rspec_queue_mongoid.rb spec
 ```
 In my case, the complete test suite down to 2min after a 16min long
@@ -22,11 +22,15 @@ module Hoptoad
         elsif node.key?('key')
           { normalize_key(node['key']) => nil }
         else
-          node.inject({}) { |rekeyed, (key, val)| rekeyed.merge(normalize_key(key) => rekey(val)) }
+          node.inject({}) do |rekeyed, (key, val)|
+            rekeyed.merge(normalize_key(key) => rekey(val))
+          end
         end
       when Array
         if node.first.key?('key')
-          node.inject({}) { |rekeyed, keypair| rekeyed.merge(rekey(keypair)) }
+          node.inject({}) do |rekeyed, keypair|
+            rekeyed.merge(rekey(keypair))
+          end
         else
           node.map { |n| rekey(n) }
         end
@@ -6,18 +6,18 @@ HoptoadNotifier.module_eval do
   class << self
     private def send_notice(notice)
       # Log the error internally if we are not in a development environment.
-      if configuration.public?
-        app = App.find_or_initialize_by(name: "Self.Errbit")
-        app.github_repo = "errbit/errbit"
-        app.save!
-        notice.send("api_key=", app.api_key)
+      return unless configuration.public?
-        # Create notice internally.
-        report = ErrorReport.new(notice.to_xml)
-        report.generate_notice!
+      app = App.find_or_initialize_by(name: "Self.Errbit")
+      app.github_repo = "errbit/errbit"
+      app.save!
+      notice.send("api_key=", app.api_key)
-        logger.info "Internal error was logged to 'Self.Errbit' app."
-      end
+      # Create notice internally.
+      report = ErrorReport.new(notice.to_xml)
+      report.generate_notice!
+
+      logger.info "Internal error was logged to 'Self.Errbit' app."
     end
   end
 end
@@ -32,12 +32,13 @@ namespace :errbit do
     def random_backtrace
       backtrace = []
-      99.times {|t|
+      99.times do |t|
         backtrace << {
           'number' => t.hash % 1000,
           'file'   => "/path/to/file.rb",
           'method' => RANDOM_METHODS.sample.to_s
-        }}
+        }
+      end
       backtrace
     end
@@ -1,17 +0,0 @@
-#!/usr/bin/env ruby
-require 'rubygems'
-require 'test_queue'
-require 'bundler'
-Bundler.setup(:default, :development, :test)
-require 'test_queue/runner/rspec'
-
-class MongoidRspecRunner < TestQueue::Runner::RSpec
-  def after_fork(num)
-    super
-    Mongoid.override_database(
-      "#{Mongoid.session(:default).options[:database]}_#{num}"
-    )
-  end
-end
-
-MongoidRspecRunner.new.execute
@@ -0,0 +1,18 @@
+#!/usr/bin/env ruby
+require 'rubygems'
+require 'test_queue'
+require 'test_queue/runner/rspec'
+
+require 'bundler'
+Bundler.setup(:default, :development, :test)
+
+class MongoidRspecRunner < TestQueue::Runner::RSpec
+  def after_fork(num)
+    super
+    Mongoid.override_database(
+      "#{Mongoid.client(:default).options[:database]}_#{num}"
+    )
+  end
+end
+
+MongoidRspecRunner.new.execute
@@ -3,9 +3,9 @@ require &#39;acceptance/acceptance_helper&#39;
 feature "Regeneration api_Key" do
   let(:app) { Fabricate(:app) }
   let(:admin) { Fabricate(:admin) }
-  let(:user) {
+  let(:user) do
     Fabricate(:user_watcher, app: app).user
-  }
+  end
   before do
     app && admin
@@ -16,9 +16,9 @@ feature &quot;Regeneration api_Key&quot; do
     log_in admin
     click_link app.name
     click_link I18n.t('apps.show.edit')
-    expect {
+    expect do
       click_link I18n.t('apps.fields.regenerate_api_key')
-    }.to change {
+    end.to change {
       app.reload.api_key
     }
     click_link I18n.t('shared.navigation.apps')
@@ -36,9 +36,9 @@ end
 feature "Create an application" do
   let(:admin) { Fabricate(:admin) }
-  let(:user) {
+  let(:user) do
     Fabricate(:user_watcher, app: app).user
-  }
+  end
   before do
     admin
@@ -14,7 +14,7 @@ describe Api::V1::NoticesController, type: &#39;controller&#39; do
       it "should return JSON if JSON is requested" do
         get :index, auth_token: @user.authentication_token, format: "json"
-        expect { JSON.load(response.body) }.not_to raise_error #JSON::ParserError)
+        expect { JSON.load(response.body) }.not_to raise_error # JSON::ParserError)
       end
       it "should return XML if XML is requested" do
@@ -24,7 +24,7 @@ describe Api::V1::NoticesController, type: &#39;controller&#39; do
       it "should return JSON by default" do
         get :index, auth_token: @user.authentication_token
-        expect { JSON.load(response.body) }.not_to raise_error #JSON::ParserError)
+        expect { JSON.load(response.body) }.not_to raise_error # JSON::ParserError)
       end
       describe "given a date range" do
@@ -13,7 +13,7 @@ describe Api::V1::ProblemsController, type: &#39;controller&#39; do
       it "should return JSON if JSON is requested" do
         get :show, auth_token: @user.authentication_token, format: "json", id: Problem.first.id
-        expect { JSON.load(response.body) }.not_to raise_error #JSON::ParserError
+        expect { JSON.load(response.body) }.not_to raise_error # JSON::ParserError
       end
       it "should return XML if XML is requested" do
@@ -23,7 +23,7 @@ describe Api::V1::ProblemsController, type: &#39;controller&#39; do
       it "should return JSON by default" do
         get :show, auth_token: @user.authentication_token, id: @problem.id
-        expect { JSON.load(response.body) }.not_to raise_error #JSON::ParserError)
+        expect { JSON.load(response.body) }.not_to raise_error # JSON::ParserError)
       end
       it "should return the correct problem" do
@@ -67,7 +67,7 @@ describe Api::V1::ProblemsController, type: &#39;controller&#39; do
       it "should return JSON if JSON is requested" do
         get :index, auth_token: @user.authentication_token, format: "json"
-        expect { JSON.load(response.body) }.not_to raise_error #JSON::ParserError)
+        expect { JSON.load(response.body) }.not_to raise_error # JSON::ParserError)
       end
       it "should return XML if XML is requested" do
@@ -77,7 +77,7 @@ describe Api::V1::ProblemsController, type: &#39;controller&#39; do
       it "should return JSON by default" do
         get :index, auth_token: @user.authentication_token
-        expect { JSON.load(response.body) }.not_to raise_error #JSON::ParserError)
+        expect { JSON.load(response.body) }.not_to raise_error # JSON::ParserError)
       end
       describe "given a date range" do
@@ -312,9 +312,9 @@ describe AppsController, type: &#39;controller&#39; do
       it "should destroy the app" do
         delete :destroy, id: @app.id
-        expect {
+        expect do
           @app.reload
-        }.to raise_error(Mongoid::Errors::DocumentNotFound)
+        end.to raise_error(Mongoid::Errors::DocumentNotFound)
       end
       it "should display a message" do
@@ -326,10 +326,10 @@ describe ProblemsController, type: &#39;controller&#39; do
       it "should unmerge a merged problem" do
         merged_problem = Problem.merge!(@problem1, @problem2)
         expect(merged_problem.errs.length).to eq 2
-        expect {
+        expect do
           post :unmerge_several, problems: [merged_problem.id.to_s]
           expect(merged_problem.reload.errs.length).to eq 1
-        }.to change(Problem, :count).by(1)
+        end.to change(Problem, :count).by(1)
       end
     end
@@ -370,9 +370,9 @@ describe ProblemsController, type: &#39;controller&#39; do
     context "POST /problems/destroy_several" do
       it "should delete the problems" do
-        expect {
+        expect do
           post :destroy_several, problems: [@problem1.id.to_s]
-        }.to change(Problem, :count).by(-1)
+        end.to change(Problem, :count).by(-1)
       end
     end
@@ -385,9 +385,9 @@ describe ProblemsController, type: &#39;controller&#39; do
       end
       it "destroys all problems" do
-        expect {
+        expect do
           post :destroy_all, app_id: @app.id
-        }.to change(Problem, :count).by(-2)
+        end.to change(Problem, :count).by(-2)
         expect(controller.app).to eq @app
       end
@@ -56,9 +56,9 @@ describe UsersController, type: &#39;controller&#39; do
         end
         it "should not be able to become an admin" do
-          expect {
+          expect do
             put :update, id: user.to_param, user: { admin: true }
-          }.to_not change {
+          end.to_not change {
             user.reload.admin
           }.from(false)
         end
@@ -157,9 +157,9 @@ describe UsersController, type: &#39;controller&#39; do
       end
       context "when the create is unsuccessful" do
-        let(:user) {
+        let(:user) do
           Struct.new(:admin, :attributes).new(true, {})
-        }
+        end
         before do
           expect(User).to receive(:new).and_return(user)
           expect(user).to receive(:save).and_return(false)
@@ -174,9 +174,9 @@ describe UsersController, type: &#39;controller&#39; do
     context "PUT /users/:id" do
       context "when the update is successful" do
-        before {
+        before do
           put :update, id: user.to_param, user: user_params
-        }
+        end
         context "with normal params" do
           let(:user_params) { { name: 'Kermit' } }
@@ -198,10 +198,10 @@ describe UsersController, type: &#39;controller&#39; do
       context "with a destroy success" do
         let(:user_destroy) { double(destroy: true) }
-        before {
+        before do
           expect(UserDestroy).to receive(:new).with(user).and_return(user_destroy)
           delete :destroy, id: user.id
-        }
+        end
         it 'should destroy user' do
           expect(request.flash[:success]).to eq I18n.t('controllers.users.flash.destroy.success', name: user.name)
@@ -210,10 +210,10 @@ describe UsersController, type: &#39;controller&#39; do
       end
       context "with trying destroy himself" do
-        before {
+        before do
           expect(UserDestroy).to_not receive(:new)
           delete :destroy, id: admin.id
-        }
+        end
         it 'should not destroy user' do
           expect(response).to redirect_to(users_path)
@@ -224,12 +224,12 @@ describe UsersController, type: &#39;controller&#39; do
     describe "#user_params" do
       context "with current user not admin" do
-        before {
+        before do
           allow(controller).to receive(:current_user).and_return(user)
           allow(controller).to receive(:params).and_return(
             ActionController::Parameters.new(user_param)
           )
-        }
+        end
         let(:user_param) { { 'user' => { name: 'foo', admin: true } } }
         it 'not have admin field' do
           expect(controller.send(:user_params)).to eq('name' => 'foo')
 describe BacktraceDecorator, type: :decorator do
   let(:backtrace) do
-    described_class.new(Backtrace.new(
-      lines: [
-        { number: 131,
-          file:   '[PROJECT_ROOT]app/controllers/accounts_controller.rb',
-          method: :update_preferences },
-        { number: 61,
-          file:   '[PROJECT_ROOT]app/controllers/application_controller.rb',
-          method: :call },
-        { number: 182,
-          file:   '[GEM_ROOT]activesupport-2.3.18/lib/active_support/callbacks.rb',
-          method: :call },
-        { number: 384,
-          file:   '[PROJECT_ROOT]app/models/account.rb',
-          method: :update_server_tag_scope },
-        { number: 182,
-          file:   '[GEM_ROOT]activesupport-2.3.18/lib/active_support/callbacks.rb',
-          method: :evaluate_method },
-        { number: 23,
-          file:   '/home/rails/library/current/vendor/bundle/ruby/2.1.0/bin/rainbows',
-          method: '<main>' }
-      ]
-    ))
+    described_class.new(
+      Backtrace.new(
+        lines: [
+          { number: 131,
+            file:   '[PROJECT_ROOT]app/controllers/accounts_controller.rb',
+            method: :update_preferences },
+          { number: 61,
+            file:   '[PROJECT_ROOT]app/controllers/application_controller.rb',
+            method: :call },
+          { number: 182,
+            file:   '[GEM_ROOT]activesupport-2.3.18/lib/active_support/callbacks.rb',
+            method: :call },
+          { number: 384,
+            file:   '[PROJECT_ROOT]app/models/account.rb',
+            method: :update_server_tag_scope },
+          { number: 182,
+            file:   '[GEM_ROOT]activesupport-2.3.18/lib/active_support/callbacks.rb',
+            method: :evaluate_method },
+          { number: 23,
+            file:   '/home/rails/library/current/vendor/bundle/ruby/2.1.0/bin/rainbows',
+            method: '<main>' }
+        ]
+      )
+    )
   end
   describe '#grouped_lines' do
 describe IssueTrackerDecorator do
   let(:fake_tracker) do
-    klass = Class.new(ErrbitPlugin::IssueTracker) {
+    klass = Class.new(ErrbitPlugin::IssueTracker) do
       def self.label
         'fake'
       end
@@ -19,7 +19,7 @@ describe IssueTrackerDecorator do
       def configured?
         true
       end
-    }
+    end
     klass.new 'nothing special'
   end
@@ -50,15 +50,21 @@ describe IssueTrackerDecorator do
   describe "#params_class" do
     it 'adds the label in class' do
-      tracker = IssueTrackerDecorator.new(IssueTracker.new(
-        type_tracker: 'none'))
+      tracker = IssueTrackerDecorator.new(
+        IssueTracker.new(type_tracker: 'none')
+      )
       expect(decorator.params_class(tracker)).to eql 'fake'
     end
     it 'adds chosen class if type is same' do
-      expect(decorator.params_class(
-        IssueTracker.new(type_tracker: 'fake').decorate
-      )).to eql 'chosen fake'
+      expect(
+        decorator.
+          params_class(
+            IssueTracker.new(
+              type_tracker: 'fake'
+            ).decorate
+          )
+      ).to eql 'chosen fake'
     end
   end
 end
@@ -4,9 +4,9 @@ Fabricator(:app) do
 end
 Fabricator(:app_with_watcher, from: :app) do
-  watchers(count: 1) { |parent, _i|
+  watchers(count: 1) do |parent, _i|
     Fabricate.build(:watcher, app: parent)
-  }
+  end
 end
 Fabricator(:watcher) do
@@ -22,8 +22,8 @@ end
 Fabricator(:deploy) do
   app
-  username      'clyde.frog'
-  repository    'git@github.com/errbit/errbit.git'
-  environment   'production'
-  revision      { SecureRandom.hex(10) }
+  username 'clyde.frog'
+  repository 'git@github.com/errbit/errbit.git'
+  environment 'production'
+  revision { SecureRandom.hex(10) }
 end
 Fabricator :issue_tracker do
   type_tracker 'mock'
-  options {
+  options do
     {
       foo: 'one',
       bar: 'two'
-    }}
+    }
+  end
   app
 end
 Fabricator :notice do
   app
   err
-  error_class         'FooError'
-  message             'Too Much Bar'
+  error_class 'FooError'
+  message 'Too Much Bar'
   backtrace
   server_environment  { { 'environment-name' => 'production' } }
   request             { { 'component' => 'foo', 'action' => 'bar' } }
@@ -6,19 +6,19 @@ Fabricator(:problem) do
 end
 Fabricator(:problem_with_comments, from: :problem) do
-  after_create { |parent|
+  after_create do |parent|
     3.times do
       Fabricate(:comment, err: parent)
     end
-  }
+  end
 end
 Fabricator(:problem_with_errs, from: :problem) do
-  after_create { |parent|
+  after_create do |parent|
     3.times do
       Fabricate(:err, problem: parent)
     end
-  }
+  end
 end
 Fabricator(:problem_resolved, from: :problem) do
 Fabricator :user do
-  name                  'Clyde Frog'
-  email                 { sequence(:user_email) { |n| "user.#{n}@example.com" } }
-  password              'password'
+  name 'Clyde Frog'
+  email { sequence(:user_email) { |n| "user.#{n}@example.com" } }
+  password 'password'
   password_confirmation 'password'
 end
 describe ProblemDestroy do
-  let(:problem_destroy) {
+  let(:problem_destroy) do
     ProblemDestroy.new(problem)
-  }
+  end
   context "in unit way" do
-    let(:problem) {
+    let(:problem) do
       problem = Problem.new
       allow(problem).to receive(:errs).and_return(double(:criteria, only: [err_1, err_2]))
       allow(problem).to receive(:comments).and_return(double(:criteria, only: [comment_1, comment_2]))
       allow(problem).to receive(:delete)
       problem
-    }
+    end
     let(:err_1) { Err.new }
     let(:err_2) { Err.new }
@@ -4,9 +4,9 @@ describe ProblemMerge do
   describe "#initialize" do
     it 'failed if less than 2 uniq problem pass in args' do
-      expect {
+      expect do
         ProblemMerge.new(problem)
-      }.to raise_error(ArgumentError)
+      end.to raise_error(ArgumentError)
     end
     it 'extract first problem like merged_problem' do
@@ -20,18 +20,18 @@ describe ProblemMerge do
   end
   describe "#merge" do
-    let!(:problem_merge) {
+    let!(:problem_merge) do
       ProblemMerge.new(problem, problem_1)
-    }
+    end
     let(:first_errs) { problem.errs }
     let(:merged_errs) { problem_1.errs }
     let!(:notice) { Fabricate(:notice, err: first_errs.first) }
     let!(:notice_1) { Fabricate(:notice, err: merged_errs.first) }
     it 'delete one of problem' do
-      expect {
+      expect do
         problem_merge.merge
-      }.to change(Problem, :count).by(-1)
+      end.to change(Problem, :count).by(-1)
     end
     it 'move all err in one problem' do
@@ -55,9 +55,9 @@ describe ProblemMerge do
       let!(:comment) { Fabricate(:comment, err: problem) }
       let!(:comment_2) { Fabricate(:comment, err: problem_1, user: comment.user) }
       it 'merge comment' do
-        expect {
+        expect do
           problem_merge.merge
-        }.to change {
+        end.to change {
           problem.comments.size
         }.from(1).to(2)
         expect(comment_2.reload.err).to eq problem
 describe ResolvedProblemClearer do
-  let(:resolved_problem_clearer) {
+  let(:resolved_problem_clearer) do
     ResolvedProblemClearer.new
-  }
+  end
   describe "#execute" do
-    let!(:problems) {
+    let!(:problems) do
       [
         Fabricate(:problem),
         Fabricate(:problem),
         Fabricate(:problem)
       ]
-    }
+    end
     context 'without problem resolved' do
       it 'do nothing' do
-        expect {
+        expect do
           expect(resolved_problem_clearer.execute).to eq 0
-        }.to_not change {
+        end.to_not change {
           Problem.count
         }
       end
@@ -34,9 +34,9 @@ describe ResolvedProblemClearer do
       end
       it 'delete problem resolve' do
-        expect {
+        expect do
           expect(resolved_problem_clearer.execute).to eq 2
-        }.to change {
+        end.to change {
           Problem.count
         }.by(-2)
         expect(Problem.where(_id: problems.first.id).first).to be_nil
 describe UserDestroy do
-  let(:app) {
+  let(:app) do
     Fabricate(
       :app,
       watchers: [
         Fabricate.build(:user_watcher, user: user)
       ])
-  }
+  end
   describe "#destroy" do
     let!(:user) { Fabricate(:user) }
     it 'should delete user' do
-      expect {
+      expect do
         UserDestroy.new(user).destroy
-      }.to change(User, :count)
+      end.to change(User, :count)
     end
     it 'should delete watcher' do
-      expect {
+      expect do
         UserDestroy.new(user).destroy
-      }.to change {
+      end.to change {
         app.reload.watchers.where(user_id: user.id).count
       }.from(1).to(0)
     end
@@ -2,13 +2,13 @@ describe AirbrakeApi::V3::NoticeParser do
   let(:app) { Fabricate(:app) }
   it 'raises error when errors attribute is missing' do
-    expect {
+    expect do
       AirbrakeApi::V3::NoticeParser.new({}).report
-    }.to raise_error(AirbrakeApi::ParamsError)
+    end.to raise_error(AirbrakeApi::ParamsError)
-    expect {
+    expect do
       AirbrakeApi::V3::NoticeParser.new('errors' => []).report
-    }.to raise_error(AirbrakeApi::ParamsError)
+    end.to raise_error(AirbrakeApi::ParamsError)
   end
   it 'parses JSON payload and returns ErrorReport' do
@@ -164,13 +164,13 @@ describe App, type: &#39;model&#39; do
   context '#find_or_create_err!' do
     let(:app) { Fabricate(:app) }
-    let(:conditions) {
+    let(:conditions) do
       {
         error_class: 'Whoops',
         environment: 'production',
         fingerprint: 'some-finger-print'
       }
-    }
+    end
     it 'returns the correct err if one already exists' do
       existing = Fabricate(
@@ -188,23 +188,23 @@ describe App, type: &#39;model&#39; do
     it 'creates a new problem if a matching one does not already exist' do
       expect(Err.where(conditions).first).to be_nil
-      expect {
+      expect do
         app.find_or_create_err!(conditions)
-      }.to change(Problem, :count).by(1)
+      end.to change(Problem, :count).by(1)
     end
     context "without error_class" do
-      let(:conditions) {
+      let(:conditions) do
         {
           environment: 'production',
           fingerprint: 'some-finger-print'
         }
-      }
+      end
       it 'save the err' do
         expect(Err.where(conditions).first).to be_nil
-        expect {
+        expect do
           app.find_or_create_err!(conditions)
-        }.to change(Problem, :count).by(1)
+        end.to change(Problem, :count).by(1)
       end
     end
   end
@@ -215,9 +215,9 @@ describe App, type: &#39;model&#39; do
       expect(App.find_by_api_key!(app.api_key)).to eq app
     end
     it 'raise Mongoid::Errors::DocumentNotFound if not found' do
-      expect {
+      expect do
         App.find_by_api_key!('foo')
-      }.to raise_error(Mongoid::Errors::DocumentNotFound)
+      end.to raise_error(Mongoid::Errors::DocumentNotFound)
     end
   end
 end
@@ -17,18 +17,18 @@ module Airbrake
 end
 describe ErrorReport do
-  let(:xml) {
+  let(:xml) do
     Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice.xml').read
-  }
+  end
   let(:error_report) { ErrorReport.new(xml) }
-  let!(:app) {
+  let!(:app) do
     Fabricate(
       :app,
       api_key: 'APIKEY'
     )
-  }
+  end
   describe "#app" do
     it 'find the good app' do
@@ -44,39 +44,39 @@ describe ErrorReport do
   describe "#generate_notice!" do
     it "save a notice" do
-      expect {
+      expect do
         error_report.generate_notice!
-      }.to change {
+      end.to change {
         app.reload.problems.count
       }.by(1)
     end
     context "with a minimal notice" do
-      let(:xml) {
+      let(:xml) do
         Rails.root.join('spec', 'fixtures', 'minimal_test_notice.xml').read
-      }
+      end
       it 'save a notice' do
-        expect {
+        expect do
           error_report.generate_notice!
-        }.to change {
+        end.to change {
           app.reload.problems.count
         }.by(1)
       end
     end
     context "with notice generate by Airbrake gem" do
-      let(:xml) {
+      let(:xml) do
         Airbrake::Notice.new(
           exception:    Exception.new,
           api_key:      'APIKEY',
           project_root: Rails.root
         ).to_xml
-      }
+      end
       it 'save a notice' do
-        expect {
+        expect do
           error_report.generate_notice!
-        }.to change {
+        end.to change {
           app.reload.problems.count
         }.by(1)
       end
@@ -201,10 +201,10 @@ describe ErrorReport do
   end
   it 'memoize the notice' do
-    expect {
+    expect do
       error_report.generate_notice!
       error_report.generate_notice!
-    }.to change {
+    end.to change {
       Notice.count
     }.by(1)
   end
@@ -213,9 +213,9 @@ describe ErrorReport do
     error_report.generate_notice!
     error_report.problem.resolve!
-    expect {
+    expect do
       ErrorReport.new(xml).generate_notice!
-    }.to change {
+    end.to change {
       error_report.problem.reload.resolved?
     }.from(true).to(false)
   end
@@ -237,26 +237,26 @@ describe ErrorReport do
     end
     context "with xml without request section" do
-      let(:xml) {
+      let(:xml) do
         Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice_without_request_section.xml').read
-      }
+      end
       it "save a notice" do
-        expect {
+        expect do
           error_report.generate_notice!
-        }.to change {
+        end.to change {
           app.reload.problems.count
         }.by(1)
       end
     end
     context "with xml with only a single line of backtrace" do
-      let(:xml) {
+      let(:xml) do
         Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice_with_one_line_of_backtrace.xml').read
-      }
+      end
       it "save a notice" do
-        expect {
+        expect do
           error_report.generate_notice!
-        }.to change {
+        end.to change {
           app.reload.problems.count
         }.by(1)
       end
@@ -5,7 +5,7 @@ Fabrication::Config.fabricator_path.each do |folder|
 end
 describe "Fabrication" do
-  #TODO : when 1.8.7 drop support se directly Symbol#sort
+  # TODO : when 1.8.7 drop support se directly Symbol#sort
   Fabrication.manager.schematics.keys.sort.each do |fabricator_name|
     context "Fabricate(:#{fabricator_name})" do
       subject { Fabricate.build(fabricator_name) }
@@ -5,12 +5,12 @@ describe NotificationServices::CampfireService, type: &#39;model&#39; do
     notification_service = Fabricate :campfire_notification_service, app: notice.app
     problem = notice.problem
-    #campy stubbing
+    # campy stubbing
     campy = double('CampfireService')
     allow(Campy::Room).to receive(:new).and_return(campy)
     allow(campy).to receive(:speak).and_return(true)
-    #assert
+    # assert
     expect(campy).to receive(:speak)
     notification_service.create_notification(problem)
@@ -6,7 +6,7 @@ describe NotificationServices::GtalkService, type: &#39;model&#39; do
     notification_service = Fabricate :gtalk_notification_service, app: notice.app
     problem = notice.problem
-    #gtalk stubbing
+    # gtalk stubbing
     gtalk = double('GtalkService')
     jid = double("jid")
     message = double("message")
@@ -24,7 +24,7 @@ describe NotificationServices::GtalkService, type: &#39;model&#39; do
     expect(Jabber::MUC::SimpleMUCClient).to receive(:new).and_return(gtalk)
     expect(gtalk).to receive(:join).with(notification_service.room_id + "/errbit")
-    #assert
+    # assert
     expect(gtalk).to receive(:send).exactly(2).times.with(message)
     expect(gtalk).to receive(:close)
@@ -97,7 +97,7 @@ describe NotificationServices::GtalkService, type: &#39;model&#39; do
     notification_service = Fabricate :gtalk_notification_service, app: notice.app
     problem = notice.problem
-    #gtalk stubbing
+    # gtalk stubbing
     gtalk = double('GtalkService')
     jid = double("jid")
     message = double("message")
@@ -116,7 +116,7 @@ describe NotificationServices::GtalkService, type: &#39;model&#39; do
     notification_service.user_id = ""
-    #assert
+    # assert
     expect(gtalk).to receive(:send).with(message)
     expect(gtalk).to receive(:close)
@@ -10,7 +10,7 @@ describe NotificationServices::HoiioService, type: &#39;model&#39; do
     allow(Hoi::SMS).to receive(:new).and_return(sms)
     allow(sms).to receive(:send).and_return(true)
-    #assert
+    # assert
     expect(sms).to receive(:send)
     notification_service.create_notification(problem)
@@ -10,7 +10,7 @@ describe NotificationServices::PushoverService, type: &#39;model&#39; do
     allow(Rushover::Client).to receive(:new).and_return(notification)
     allow(notification).to receive(:notify).and_return(true)
-    #assert
+    # assert
     expect(notification).to receive(:notify)
     notification_service.create_notification(problem)
@@ -10,25 +10,25 @@ describe Problem, type: &#39;model&#39; do
   describe "Fabrication" do
     context "Fabricate(:problem)" do
       it 'should have no comment' do
-        expect {
+        expect do
           Fabricate(:problem)
-        }.to_not change(Comment, :count)
+        end.to_not change(Comment, :count)
       end
     end
     context "Fabricate(:problem_with_comments)" do
       it 'should have 3 comments' do
-        expect {
+        expect do
           Fabricate(:problem_with_comments)
-        }.to change(Comment, :count).by(3)
+        end.to change(Comment, :count).by(3)
       end
     end
     context "Fabricate(:problem_with_errs)" do
       it 'should have 3 errs' do
-        expect {
+        expect do
           Fabricate(:problem_with_errs)
-        }.to change(Err, :count).by(3)
+        end.to change(Err, :count).by(3)
       end
     end
   end
@@ -65,9 +65,9 @@ describe Problem, type: &#39;model&#39; do
     it "adding a notice caches its message" do
       err = Fabricate(:err)
       problem = err.problem
-      expect {
+      expect do
         Fabricate(:notice, err: err, message: 'ERR 1')
-      }.to change(problem, :message).from(nil).to('ERR 1')
+      end.to change(problem, :message).from(nil).to('ERR 1')
     end
   end
@@ -132,9 +132,9 @@ describe Problem, type: &#39;model&#39; do
       er.add_on_blank(:resolved)
       allow(problem).to receive(:errors).and_return(er)
       expect(problem).to_not be_valid
-      expect {
+      expect do
         problem.resolve!
-      }.to raise_error(Mongoid::Errors::Validations)
+      end.to raise_error(Mongoid::Errors::Validations)
     end
   end
@@ -201,17 +201,17 @@ describe Problem, type: &#39;model&#39; do
     end
     it "adding a notice increases #notices_count by 1" do
-      expect {
+      expect do
         Fabricate(:notice, err: @err, message: 'ERR 1')
-      }.to change(@problem.reload, :notices_count).from(0).to(1)
+      end.to change(@problem.reload, :notices_count).from(0).to(1)
     end
     it "removing a notice decreases #notices_count by 1" do
       Fabricate(:notice, err: @err, message: 'ERR 1')
-      expect {
+      expect do
         @err.notices.first.destroy
         @problem.reload
-      }.to change(@problem, :notices_count).from(1).to(0)
+      end.to change(@problem, :notices_count).from(1).to(0)
     end
   end
@@ -226,10 +226,10 @@ describe Problem, type: &#39;model&#39; do
     end
     it "is updated when an app is updated" do
-      expect {
+      expect do
         app.update_attributes!(name: "Bar App")
         problem.reload
-      }.to change(problem, :app_name).to("Bar App")
+      end.to change(problem, :app_name).to("Bar App")
     end
   end
@@ -248,10 +248,10 @@ describe Problem, type: &#39;model&#39; do
     it "is updated when a deploy is created" do
       problem = Fabricate(:problem, app: @app, environment: "production")
       next_deploy = 5.minutes.ago
-      expect {
+      expect do
         @deploy = Fabricate(:deploy, app: @app, created_at: next_deploy)
         problem.reload
-      }.to change { problem.last_deploy_at.iso8601 }.
+      end.to change { problem.last_deploy_at.iso8601 }.
         from(@last_deploy.iso8601).
         to(next_deploy.iso8601)
     end
@@ -270,10 +270,10 @@ describe Problem, type: &#39;model&#39; do
     it "removing a notice removes string from #messages" do
       Fabricate(:notice, err: @err, message: 'ERR 1')
-      expect {
+      expect do
         @err.notices.first.destroy
         @problem.reload
-      }.to change(@problem, :messages).from(Digest::MD5.hexdigest('ERR 1') => { 'value' => 'ERR 1', 'count' => 1 }).to({})
+      end.to change(@problem, :messages).from(Digest::MD5.hexdigest('ERR 1') => { 'value' => 'ERR 1', 'count' => 1 }).to({})
     end
     it "removing a notice from the problem with broken counter should not raise an error" do
@@ -297,10 +297,10 @@ describe Problem, type: &#39;model&#39; do
     it "removing a notice removes string from #hosts" do
       Fabricate(:notice, err: @err, request: { 'url' => "http://example.com/resource/12" })
-      expect {
+      expect do
         @err.notices.first.destroy
         @problem.reload
-      }.to change(@problem, :hosts).from(Digest::MD5.hexdigest('example.com') => { 'value' => 'example.com', 'count' => 1 }).to({})
+      end.to change(@problem, :hosts).from(Digest::MD5.hexdigest('example.com') => { 'value' => 'example.com', 'count' => 1 }).to({})
     end
   end
@@ -325,10 +325,10 @@ describe Problem, type: &#39;model&#39; do
           }
         }
       )
-      expect {
+      expect do
         @err.notices.first.destroy
         @problem.reload
-      }.to change(@problem, :user_agents).
+      end.to change(@problem, :user_agents).
         from(
           Digest::MD5.hexdigest('Chrome 10.0.648.204 (OS X 10.6.7)') => {
             'value' => 'Chrome 10.0.648.204 (OS X 10.6.7)', 'count' => 1 }
@@ -347,17 +347,17 @@ describe Problem, type: &#39;model&#39; do
     end
     it "adding a comment increases #comments_count by 1" do
-      expect {
+      expect do
         Fabricate(:comment, err: @problem)
-      }.to change(@problem, :comments_count).from(0).to(1)
+      end.to change(@problem, :comments_count).from(0).to(1)
     end
     it "removing a comment decreases #comments_count by 1" do
       Fabricate(:comment, err: @problem)
-      expect {
+      expect do
         @problem.reload.comments.first.destroy
         @problem.reload
-      }.to change(@problem, :comments_count).from(1).to(0)
+      end.to change(@problem, :comments_count).from(1).to(0)
     end
   end
@@ -420,9 +420,9 @@ describe Problem, type: &#39;model&#39; do
     end
     it 'update the notice_count' do
-      expect {
+      expect do
         problem.recache
-      }.to change {
+      end.to change {
         problem.notices_count
       }.from(0).to(1)
     end
@@ -39,10 +39,10 @@ describe User do
   context "First user" do
     it "should be created this admin access via db:seed" do
-      expect {
+      expect do
         allow($stdout).to receive(:puts).and_return(true)
         require Rails.root.join('db/seeds.rb')
-      }.to change {
+      end.to change {
         User.where(admin: true).count
       }.from(0).to(1)
     end
@@ -5,10 +5,10 @@ describe &quot;Notices management&quot;, type: &#39;request&#39; do
     context "with valide notice" do
       let(:xml) { Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice.xml').read }
       it 'save a new notice' do
-        expect {
+        expect do
           post '/notifier_api/v2/notices', data: xml
           expect(response).to be_success
-        }.to change {
+        end.to change {
           errbit_app.problems.count
         }.by(1)
       end
@@ -17,10 +17,10 @@ describe &quot;Notices management&quot;, type: &#39;request&#39; do
     context "with notice with empty backtrace" do
       let(:xml) { Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice_without_line_of_backtrace.xml').read }
       it 'save a new notice' do
-        expect {
+        expect do
           post '/notifier_api/v2/notices', data: xml
           expect(response).to be_success
-        }.to change {
+        end.to change {
           errbit_app.problems.count
         }.by(1)
       end
@@ -30,21 +30,21 @@ describe &quot;Notices management&quot;, type: &#39;request&#39; do
       let(:errbit_app) { Fabricate(:app) }
       let(:xml) { Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice.xml').read }
       it 'not save a new notice and return 422' do
-        expect {
+        expect do
           post '/notifier_api/v2/notices', data: xml
           expect(response.status).to eq 422
           expect(response.body).to eq "Your API key is unknown"
-        }.to_not change(errbit_app.problems, :count)
+        end.to_not change(errbit_app.problems, :count)
       end
     end
     context "with GET request" do
       let(:xml) { Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice.xml').read }
       it 'save a new notice' do
-        expect {
+        expect do
           get '/notifier_api/v2/notices', data: xml
           expect(response).to be_success
-        }.to change {
+        end.to change {
           errbit_app.problems.count
         }.by(1)
       end
@@ -15,21 +15,31 @@ describe &quot;apps/edit.html.haml&quot;, type: &#39;view&#39; do
     it "should confirm the 'reset' link" do
       render
-      expect(action_bar).to have_selector('a.button[data-confirm="%s"]' % I18n.t('apps.confirm_destroy_all_problems'))
+      expect(action_bar).to have_selector(
+        format(
+          'a.button[data-confirm="%s"]',
+          I18n.t('apps.confirm_destroy_all_problems')
+        )
+      )
     end
     it "should confirm the 'destroy' link" do
       render
-      expect(action_bar).to have_selector('a.button[data-confirm="%s"]' % I18n.t('apps.confirm_delete'))
+      expect(action_bar).to have_selector(
+        format(
+          'a.button[data-confirm="%s"]',
+          I18n.t('apps.confirm_delete')
+        )
+      )
     end
   end
   context "with unvalid app" do
-    let(:app) {
+    let(:app) do
       app = stub_model(App)
       app.errors.add(:base, 'You must specify your')
       app
-    }
+    end
     it 'see the error' do
       render
@@ -21,11 +21,11 @@ describe &quot;apps/new.html.haml&quot;, type: &#39;view&#39; do
   end
   context "with unvalid app" do
-    let(:app) {
+    let(:app) do
       app = stub_model(App)
       app.errors.add(:base, 'You must specify your')
       app
-    }
+    end
     it 'see the error' do
       render
 describe "issue_trackers/issue.md.erb", type: 'view' do
-  let(:problem) {
+  let(:problem) do
     problem = Fabricate(:problem)
     Fabricate(:notice, err: Fabricate(:err, problem: problem))
     problem
-  }
+  end
   before do
     allow(view).to receive(:problem).and_return(ProblemDecorator.new(problem))
 describe "issue_trackers/issue.txt.erb", type: 'view' do
-  let(:problem) {
+  let(:problem) do
     problem = Fabricate(:problem)
     Fabricate(:notice, err: Fabricate(:err, problem: problem))
     problem
-  }
+  end
   before do
     allow(view).to receive(:problem).and_return(
 describe "problems/show.html.haml", type: 'view' do
   let(:problem) { Fabricate(:problem) }
   let(:comment) { Fabricate(:comment) }
-  let(:pivotal_tracker) {
+  let(:pivotal_tracker) do
     Class.new(ErrbitPlugin::MockIssueTracker) do
       def self.label
         'pivotal'
@@ -15,8 +15,8 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
         true
       end
     end
-  }
-  let(:github_tracker) {
+  end
+  let(:github_tracker) do
     Class.new(ErrbitPlugin::MockIssueTracker) do
       def self.label
         'github'
@@ -30,13 +30,13 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
         true
       end
     end
-  }
-  let(:trackers) {
+  end
+  let(:trackers) do
     {
       'github'  => github_tracker,
       'pivotal' => pivotal_tracker
     }
-  }
+  end
   let(:app) { AppDecorator.new(problem.app) }
   before do
@@ -66,13 +66,23 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
     it "should confirm the 'resolve' link by default" do
       render
-      expect(action_bar).to have_selector('a.resolve[data-confirm="%s"]' % I18n.t('problems.confirm.resolve_one'))
+      expect(action_bar).to have_selector(
+        format(
+          'a.resolve[data-confirm="%s"]',
+          I18n.t('problems.confirm.resolve_one')
+        )
+      )
     end
     it "should confirm the 'resolve' link if configuration is unset" do
       allow(Errbit::Config).to receive(:confirm_err_actions).and_return(nil)
       render
-      expect(action_bar).to have_selector('a.resolve[data-confirm="%s"]' % I18n.t('problems.confirm.resolve_one'))
+      expect(action_bar).to have_selector(
+        format(
+          'a.resolve[data-confirm="%s"]',
+          I18n.t('problems.confirm.resolve_one')
+        )
+      )
     end
     it "should not confirm the 'resolve' link if configured not to" do
 describe 'users/edit.html.haml', type: 'view' do
   let(:user) { stub_model(User, name: 'shingara') }
-  before {
+  before do
     allow(view).to receive(:current_user).and_return(user)
     allow(view).to receive(:user).and_return(user)
-  }
+  end
   it 'should have per_page option' do
     render
     expect(rendered).to match(/id="user_per_page"/)
 describe 'users/index.html.haml', type: 'view' do
   let(:user) { stub_model(User) }
-  before {
+  before do
     allow(view).to receive(:current_user).and_return(user)
     allow(view).to receive(:users).and_return(
       Kaminari.paginate_array([user], total_count: 1).page(1)
     )
-  }
+  end
   it 'should see users option' do
     render
     expect(rendered).to match(/class='user_list'/)
 describe 'users/new.html.haml', type: 'view' do
   let(:user) { stub_model(User) }
-  before {
+  before do
     allow(view).to receive(:current_user).and_return(user)
     allow(view).to receive(:user).and_return(user)
-  }
+  end
   it 'should have per_page option' do
     render
     expect(rendered).to match(/id="user_per_page"/)
@@ -53,7 +53,12 @@ describe &#39;users/show.html.haml&#39;, type: &#39;view&#39; do
       it "should confirm the 'resolve' link by default" do
         render
-        expect(view.content_for(:action_bar)).to have_selector('a.delete[data-confirm="%s"]' % I18n.t('.users.confirm_delete'))
+        expect(view.content_for(:action_bar)).to have_selector(
+          format(
+            'a.delete[data-confirm="%s"]',
+            I18n.t('.users.confirm_delete')
+          )
+        )
       end
     end
   end
	@@ -41,24 +41,6 @@ Rails/Output:		@@ -41,24 +41,6 @@ Rails/Output:
41	- 'app/interactors/problem_recacher.rb'	41	- 'app/interactors/problem_recacher.rb'
42	- 'db/seeds.rb'	42	- 'db/seeds.rb'
43		43
44	-# Offense count: 12
45	-# Configuration parameters: Include.
46	-Rails/Validation:
47	- Exclude:
48	- - 'app/models/app.rb'
49	- - 'app/models/comment.rb'
50	- - 'app/models/deploy.rb'
51	- - 'app/models/err.rb'
52	- - 'app/models/notice.rb'
53	- - 'app/models/problem.rb'
54	- - 'app/models/user.rb'
55	-
56	-# Offense count: 105
57	-# Cop supports --auto-correct.
58	-# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
59	-Style/BlockDelimiters:
60	- Enabled: false
61	-
62	# Offense count: 15	44	# Offense count: 15
63	# Configuration parameters: EnforcedStyle, SupportedStyles.	45	# Configuration parameters: EnforcedStyle, SupportedStyles.
64	Style/ClassAndModuleChildren:	46	Style/ClassAndModuleChildren:
	@@ -93,94 +75,6 @@ Style/EachWithObject:		@@ -93,94 +75,6 @@ Style/EachWithObject:
93	- 'app/models/notice_fingerprinter.rb'	75	- 'app/models/notice_fingerprinter.rb'
94	- 'lib/recurse.rb'	76	- 'lib/recurse.rb'
95		77
96	-# Offense count: 2
97	-# Configuration parameters: Exclude.
98	-Style/FileName:
99	- Exclude:
100	- - 'config/initializers/cve-2013-0156.rb'
101	- - 'script/rspec-queue-mongoid.rb'
102	-
103	-# Offense count: 4
104	-# Cop supports --auto-correct.
105	-# Configuration parameters: EnforcedStyle, SupportedStyles.
106	-Style/FirstParameterIndentation:
107	- Exclude:
108	- - 'app/models/issue_tracker.rb'
109	- - 'spec/decorators/backtrace_decorator_spec.rb'
110	- - 'spec/decorators/issue_tracker_type_decorator_spec.rb'
111	-
112	-# Offense count: 8
113	-# Configuration parameters: EnforcedStyle, SupportedStyles.
114	-Style/FormatString:
115	- Exclude:
116	- - 'app/decorators/backtrace_line_decorator.rb'
117	- - 'app/helpers/problems_helper.rb'
118	- - 'spec/views/apps/edit.html.haml_spec.rb'
119	- - 'spec/views/problems/show.html.haml_spec.rb'
120	- - 'spec/views/users/show.html.haml_spec.rb'
121	-
122	-# Offense count: 27
123	-# Configuration parameters: MinBodyLength.
124	-Style/GuardClause:
125	- Enabled: false
126	-
127	-# Offense count: 6
128	-# Cop supports --auto-correct.
129	-# Configuration parameters: MaxLineLength.
130	-Style/IfUnlessModifier:
131	- Exclude:
132	- - 'app/controllers/api/v1/stats_controller.rb'
133	- - 'app/controllers/application_controller.rb'
134	- - 'app/controllers/problems_controller.rb'
135	- - 'app/models/notice.rb'
136	- - 'app/models/user.rb'
137	-
138	-# Offense count: 17
139	-# Cop supports --auto-correct.
140	-Style/LeadingCommentSpace:
141	- Exclude:
142	- - 'app/models/notification_services/gtalk_service.rb'
143	- - 'spec/controllers/api/v1/notices_controller_spec.rb'
144	- - 'spec/controllers/api/v1/problems_controller_spec.rb'
145	- - 'spec/models/fabricators_spec.rb'
146	- - 'spec/models/notification_service/campfire_service_spec.rb'
147	- - 'spec/models/notification_service/gtalk_service_spec.rb'
148	- - 'spec/models/notification_service/hoiio_service_spec.rb'
149	- - 'spec/models/notification_service/pushover_service_spec.rb'
150	-
151	-# Offense count: 10
152	-# Cop supports --auto-correct.
153	-# Configuration parameters: EnforcedStyle, SupportedStyles.
154	-Style/MultilineOperationIndentation:
155	- Enabled: false
156	-
157	-# Offense count: 5
158	-# Cop supports --auto-correct.
159	-# Configuration parameters: PreferredDelimiters.
160	-Style/PercentLiteralDelimiters:
161	- Exclude:
162	- - 'app/controllers/api/v1/notices_controller.rb'
163	- - 'app/controllers/api/v1/problems_controller.rb'
164	- - 'app/controllers/problems_searcher.rb'
165	- - 'spec/models/notice_spec.rb'
166	-
167	-# Offense count: 1
168	-# Configuration parameters: Methods.
169	-Style/SingleLineBlockParams:
170	- Exclude:
171	- - 'lib/hoptoad/v2.rb'
172	-
173	-# Offense count: 11
174	-# Cop supports --auto-correct.
175	-Style/SingleSpaceBeforeFirstArg:
176	- Exclude:
177	- - 'app/models/comment.rb'
178	- - 'config/application.rb'
179	- - 'spec/fabricators/app_fabricator.rb'
180	- - 'spec/fabricators/comment_fabricator.rb'
181	- - 'spec/fabricators/notice_fabricator.rb'
182	- - 'spec/fabricators/user_fabricator.rb'
183	-
184	# Offense count: 873	78	# Offense count: 873
185	# Cop supports --auto-correct.	79	# Cop supports --auto-correct.
186	# Configuration parameters: EnforcedStyle, SupportedStyles.	80	# Configuration parameters: EnforcedStyle, SupportedStyles.
	@@ -3,7 +3,7 @@ class Api::V1::NoticesController < ApplicationController		@@ -3,7 +3,7 @@ class Api::V1::NoticesController < ApplicationController
3		3
4	def index	4	def index
5	query = {}	5	query = {}
6	- fields = %w{created_at message error_class}	6	+ fields = %w(created_at message error_class)
7		7
8	if params.key?(:start_date) && params.key?(:end_date)	8	if params.key?(:start_date) && params.key?(:end_date)
9	start_date = Time.zone.parse(params[:start_date]).utc	9	start_date = Time.zone.parse(params[:start_date]).utc
1	class Api::V1::ProblemsController < ApplicationController	1	class Api::V1::ProblemsController < ApplicationController
2	respond_to :json, :xml	2	respond_to :json, :xml
3	- FIELDS = %w{_id app_id app_name environment message where first_notice_at last_notice_at resolved resolved_at notices_count}	3	+ FIELDS = %w(_id app_id app_name environment message where first_notice_at last_notice_at resolved resolved_at notices_count)
4		4
5	def show	5	def show
6	result = benchmark("[api/v1/problems_controller/show] query time") do	6	result = benchmark("[api/v1/problems_controller/show] query time") do
	@@ -5,9 +5,9 @@ class UsersController < ApplicationController		@@ -5,9 +5,9 @@ class UsersController < ApplicationController
5	before_action :require_user_edit_priviledges, only: [:edit, :update]	5	before_action :require_user_edit_priviledges, only: [:edit, :update]
6		6
7	expose(:user, attributes: :user_params)	7	expose(:user, attributes: :user_params)
8	- expose(:users) {	8	+ expose(:users) do
9	User.all.page(params[:page]).per(current_user.per_page)	9	User.all.page(params[:page]).per(current_user.per_page)
10	- }	10	+ end
11		11
12	def index; end	12	def index; end
13	def new; end	13	def new; end
	@@ -20,7 +20,7 @@ module ApplicationHelper		@@ -20,7 +20,7 @@ module ApplicationHelper
20	end	20	end
21		21
22	def generate_ical(deploys)	22	def generate_ical(deploys)
23	- RiCal.Calendar { \|cal\|	23	+ RiCal.Calendar do \|cal\|
24	deploys.each_with_index do \|deploy, idx\|	24	deploys.each_with_index do \|deploy, idx\|
25	cal.event do \|event\|	25	cal.event do \|event\|
26	event.summary = "#{idx + 1} #{deploy.repository}"	26	event.summary = "#{idx + 1} #{deploy.repository}"
	@@ -31,7 +31,7 @@ module ApplicationHelper		@@ -31,7 +31,7 @@ module ApplicationHelper
31	event.organizer = deploy.username.to_s	31	event.organizer = deploy.username.to_s
32	end	32	end
33	end	33	end
34	- }.to_s	34	+ end.to_s
35	end	35	end
36		36
37	def user_agent_graph(problem)	37	def user_agent_graph(problem)
	@@ -57,7 +57,7 @@ module ApplicationHelper		@@ -57,7 +57,7 @@ module ApplicationHelper
57	total = (options[:total] \|\| total_from_tallies(tallies))	57	total = (options[:total] \|\| total_from_tallies(tallies))
58	percent = 100.0 / total.to_f	58	percent = 100.0 / total.to_f
59	rows = tallies.map { \|value, count\| [(count.to_f * percent), value] }. \	59	rows = tallies.map { \|value, count\| [(count.to_f * percent), value] }. \
60	- sort { \|a, b\| b[0] <=> a[0] }	60	+ sort { \|a, b\| b[0] <=> a[0] }
61	render "problems/tally_table", rows: rows	61	render "problems/tally_table", rows: rows
62	end	62	end
63		63
	@@ -20,9 +20,9 @@ class ProblemDestroy		@@ -20,9 +20,9 @@ class ProblemDestroy
20	# the number of problem destroy	20	# the number of problem destroy
21	#	21	#
22	def self.execute(problems)	22	def self.execute(problems)
23	- Array(problems).each { \|problem\|	23	+ Array(problems).each do \|problem\|
24	ProblemDestroy.new(problem).execute	24	ProblemDestroy.new(problem).execute
25	- }.count	25	+ end.count
26	end	26	end
27		27
28	private	28	private
	@@ -5,14 +5,14 @@ class ResolvedProblemClearer		@@ -5,14 +5,14 @@ class ResolvedProblemClearer
5	# Clear all problem already resolved	5	# Clear all problem already resolved
6	#	6	#
7	def execute	7	def execute
8	- nb_problem_resolved.tap { \|nb\|	8	+ nb_problem_resolved.tap do \|nb\|
9	if nb > 0	9	if nb > 0
10	criteria.each do \|problem\|	10	criteria.each do \|problem\|
11	ProblemDestroy.new(problem).execute	11	ProblemDestroy.new(problem).execute
12	end	12	end
13	repair_database	13	repair_database
14	end	14	end
15	- }	15	+ end
16	end	16	end
17		17
18	private	18	private
	@@ -16,7 +16,7 @@ class Deploy		@@ -16,7 +16,7 @@ class Deploy
16	after_create :store_cached_attributes_on_problems	16	after_create :store_cached_attributes_on_problems
17	after_create :deliver_email	17	after_create :deliver_email
18		18
19	- validates_presence_of :username, :environment	19	+ validates :username, :environment, presence: true
20		20
21	def resolve_app_errs	21	def resolve_app_errs
22	app.problems.unresolved.in_env(environment).each(&:resolve!)	22	app.problems.unresolved.in_env(environment).each(&:resolve!)
	@@ -14,7 +14,7 @@ class Err		@@ -14,7 +14,7 @@ class Err
14	belongs_to :problem	14	belongs_to :problem
15	has_many :notices, inverse_of: :err, dependent: :destroy	15	has_many :notices, inverse_of: :err, dependent: :destroy
16		16
17	- validates_presence_of :problem_id, :fingerprint	17	+ validates :problem_id, :fingerprint, presence: true
18		18
19	delegate :app, :resolved?, to: :problem	19	delegate :app, :resolved?, to: :problem
20	end	20	end
	@@ -37,9 +37,9 @@ module Errbit		@@ -37,9 +37,9 @@ module Errbit
37		37
38	# > rails generate - config	38	# > rails generate - config
39	config.generators do \|g\|	39	config.generators do \|g\|
40	- g.orm :mongoid	40	+ g.orm :mongoid
41	g.template_engine :haml	41	g.template_engine :haml
42	- g.test_framework :rspec, fixture: false	42	+ g.test_framework :rspec, fixture: false
43	g.fixture_replacement :fabrication	43	g.fixture_replacement :fabrication
44	end	44	end
45		45