Rubocop: strip out newlines around block bodies

Laust Rud Jacobsen
1 parent ba41f88b
Showing 19 changed files with 0 additions and 34 deletions Show diff stats
.rubocop_todo.yml
app/controllers/problems_searcher.rb
app/helpers/hash_helper.rb
config/routes.rb
spec/acceptance/app_regenerate_api_key_spec.rb
spec/acceptance/sign_in_with_github_spec.rb
spec/controllers/api/v1/notices_controller_spec.rb
spec/controllers/apps_controller_spec.rb
spec/controllers/notices_controller_spec.rb
spec/controllers/problems_controller_spec.rb
spec/controllers/users_controller_spec.rb
spec/interactors/problem_destroy_spec.rb
spec/models/error_report_spec.rb
spec/models/notice_observer_spec.rb
spec/models/notification_service/gtalk_service_spec.rb
spec/models/notification_service/notification_service_spec.rb
spec/views/apps/new.html.haml_spec.rb
spec/views/problems/show.html.haml_spec.rb
spec/views/users/show.html.haml_spec.rb
@@ -159,12 +159,6 @@ Style/EmptyLineBetweenDefs:
     - 'spec/decorators/issue_tracker_type_decorator_spec.rb'
     - 'spec/views/problems/show.html.haml_spec.rb'
-# Offense count: 28
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/EmptyLinesAroundBlockBody:
-  Enabled: false
-
 # Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -5,7 +5,6 @@ module ProblemsSearcher
   extend ActiveSupport::Concern
   included do
-
     expose(:params_sort) {
       unless %w{app message last_notice_at last_deploy_at count}.member?(params[:sort])
         "last_notice_at"
@@ -29,6 +28,5 @@ module ProblemsSearcher
     expose(:err_ids) {
       (params[:problems] || []).compact
     }
-
   end
 end
@@ -13,7 +13,6 @@ module HashHelper
       pretty += "\n#{' '*nesting*tab_size}"
       pretty += "#{key.inspect} => #{val}"
       pretty += "," unless key == sorted_keys.last
-
     end
     nesting -= 1
     pretty += "\n#{' '*nesting*tab_size}}"
 Rails.application.routes.draw do
-
   devise_for :users, :controllers => { :omniauth_callbacks => "users/omniauth_callbacks" }
   # Hoptoad Notifier Routes
@@ -35,7 +35,6 @@ feature &quot;Regeneration api_Key&quot; do
 end
 feature "Create an application" do
-
   let(:admin) { Fabricate(:admin) }
   let(:user) {
     Fabricate(:user_watcher, :app => app).user
@@ -63,7 +62,6 @@ feature &quot;Create an application&quot; do
     page.has_content?(I18n.t('controllers.apps.flash.update.success'))
     expect(App.where(:name => 'My new app').count).to eq 0
     expect(App.where(:name => 'My new app 2').count).to eq 1
-
   end
   scenario "create an apps with issue tracker and edit it", :js => true do
 require 'acceptance/acceptance_helper'
 feature 'Sign in with GitHub' do
-
   background do
     allow(Errbit::Config).to receive(:github_authentication).and_return(true)
     Fabricate(:user, :github_login => 'nashby')
@@ -28,14 +28,12 @@ describe Api::V1::NoticesController, type: &#39;controller&#39; do
       end
       describe "given a date range" do
-
         it "should return only the notices created during the date range" do
           get :index, {:auth_token => @user.authentication_token, :start_date => "2012-08-01", :end_date => "2012-08-27"}
           expect(response).to be_success
           notices = JSON.load response.body
           expect(notices.length).to eq 3
         end
-
       end
       it "should return all notices" do
@@ -44,7 +42,6 @@ describe Api::V1::NoticesController, type: &#39;controller&#39; do
         notices = JSON.load response.body
         expect(notices.length).to eq 4
       end
-
     end
   end
 end
@@ -330,7 +330,6 @@ describe AppsController, type: &#39;controller&#39; do
   end
   describe "POST /apps/:id/regenerate_api_key" do
-
     context "like watcher" do
       before do
         sign_in watcher.user
@@ -340,7 +339,6 @@ describe AppsController, type: &#39;controller&#39; do
         post :regenerate_api_key, :id => 'foo'
         expect(request).to redirect_to root_path
       end
-
     end
     context "like admin" do
@@ -34,7 +34,6 @@ describe NoticesController, type: &#39;controller&#39; do
           expect(response.body).to match(%r{<id[^>]*>#{notice.id}</id>})
           expect(response.body).to match(%r{<url[^>]*>(.+)#{locate_path(notice.id)}</url>})
         end
-
       end
       it "generates a notice from xml in a data param [POST]" do
@@ -318,7 +318,6 @@ describe ProblemsController, type: &#39;controller&#39; do
     end
     context "POST /problems/unmerge_several" do
-
       it "should require at least one problem" do
         post :unmerge_several, :problems => []
         expect(request.flash[:notice]).to eql I18n.t('controllers.problems.flash.no_select_problem')
@@ -332,11 +331,9 @@ describe ProblemsController, type: &#39;controller&#39; do
           expect(merged_problem.reload.errs.length).to eq 1
         }.to change(Problem, :count).by(1)
       end
-
     end
     context "POST /problems/resolve_several" do
-
       it "should require at least one problem" do
         post :resolve_several, :problems => []
         expect(request.flash[:notice]).to eql I18n.t('controllers.problems.flash.no_select_problem')
@@ -360,7 +357,6 @@ describe ProblemsController, type: &#39;controller&#39; do
     end
     context "POST /problems/unresolve_several" do
-
       it "should require at least one problem" do
         post :unresolve_several, :problems => []
         expect(request.flash[:notice]).to eql I18n.t('controllers.problems.flash.no_select_problem')
@@ -34,7 +34,6 @@ describe UsersController, type: &#39;controller&#39; do
         expect(controller.user).to eq(user)
         expect(response).to render_template 'edit'
       end
-
     end
     context "PUT /users/:other_id" do
@@ -188,7 +187,6 @@ describe UsersController, type: &#39;controller&#39; do
         end
       end
       context "when the update is unsuccessful" do
-
         it "renders the edit page" do
           put :update, :id => user.to_param, :user => {:name => nil}
           expect(response).to render_template(:edit)
@@ -44,7 +44,6 @@ describe ProblemDestroy do
         problem_destroy.execute
       end
     end
-
   end
   context "in integration way" do
@@ -292,7 +292,6 @@ describe ErrorReport do
       it 'return the notice' do
         expect(error_report.notice).to be_a Notice
       end
-
     end
   end
@@ -129,7 +129,6 @@ describe &quot;Callback on Notice&quot;, type: &#39;model&#39; do
   describe 'should not send a notification if a notification service is not' \
            'configured' do
-
     let(:notification_service) { Fabricate(:notification_service) }
     let(:app) { Fabricate(:app, notification_service: notification_service )}
     let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
@@ -88,7 +88,6 @@ describe NotificationServices::GtalkService, type: &#39;model&#39; do
       @notification_service.room_id = ""
       @notification_service.create_notification(@problem)
     end
-
   end
   it "it should send a notification to room only" do
 describe NotificationServices, type: 'model' do
-
   let(:notice) { Fabricate :notice }
   let(:notification_service) { Fabricate :notification_service, :app => notice.app }
   let(:problem) { notice.problem }
@@ -18,7 +18,6 @@ describe &quot;apps/new.html.haml&quot;, type: &#39;view&#39; do
       expect(action_bar).to have_selector('a.button', :text => 'cancel')
     end
-
   end
   context "with unvalid app" do
@@ -104,7 +104,6 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
           render
           expect(view.content_for(:action_bar)).to_not match(/create issue/)
         end
-
       end
       context "with tracker associate on app" do
@@ -138,7 +137,6 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
               render
               expect(view.content_for(:action_bar)).to match(/create issue/)
             end
-
           end
           context "with problem with issue link" do
@@ -55,7 +55,6 @@ describe &#39;users/show.html.haml&#39;, type: &#39;view&#39; do
         render
         expect(view.content_for(:action_bar)).to have_selector('a.delete[data-confirm="%s"]' % I18n.t('.users.confirm_delete'))
       end
-
     end
   end
 end
	@@ -159,12 +159,6 @@ Style/EmptyLineBetweenDefs:		@@ -159,12 +159,6 @@ Style/EmptyLineBetweenDefs:
159	- 'spec/decorators/issue_tracker_type_decorator_spec.rb'	159	- 'spec/decorators/issue_tracker_type_decorator_spec.rb'
160	- 'spec/views/problems/show.html.haml_spec.rb'	160	- 'spec/views/problems/show.html.haml_spec.rb'
161		161
162	-# Offense count: 28
163	-# Cop supports --auto-correct.
164	-# Configuration parameters: EnforcedStyle, SupportedStyles.
165	-Style/EmptyLinesAroundBlockBody:
166	- Enabled: false
167	-
168	# Offense count: 9	162	# Offense count: 9
169	# Cop supports --auto-correct.	163	# Cop supports --auto-correct.
170	# Configuration parameters: EnforcedStyle, SupportedStyles.	164	# Configuration parameters: EnforcedStyle, SupportedStyles.
1	Rails.application.routes.draw do	1	Rails.application.routes.draw do
2	-
3	devise_for :users, :controllers => { :omniauth_callbacks => "users/omniauth_callbacks" }	2	devise_for :users, :controllers => { :omniauth_callbacks => "users/omniauth_callbacks" }
4		3
5	# Hoptoad Notifier Routes	4	# Hoptoad Notifier Routes
1	require 'acceptance/acceptance_helper'	1	require 'acceptance/acceptance_helper'
2		2
3	feature 'Sign in with GitHub' do	3	feature 'Sign in with GitHub' do
4	-
5	background do	4	background do
6	allow(Errbit::Config).to receive(:github_authentication).and_return(true)	5	allow(Errbit::Config).to receive(:github_authentication).and_return(true)
7	Fabricate(:user, :github_login => 'nashby')	6	Fabricate(:user, :github_login => 'nashby')
	@@ -34,7 +34,6 @@ describe NoticesController, type: 'controller' do		@@ -34,7 +34,6 @@ describe NoticesController, type: 'controller' do
34	expect(response.body).to match(%r{<id[^>]*>#{notice.id}</id>})	34	expect(response.body).to match(%r{<id[^>]*>#{notice.id}</id>})
35	expect(response.body).to match(%r{<url[^>]*>(.+)#{locate_path(notice.id)}</url>})	35	expect(response.body).to match(%r{<url[^>]*>(.+)#{locate_path(notice.id)}</url>})
36	end	36	end
37	-
38	end	37	end
39		38
40	it "generates a notice from xml in a data param [POST]" do	39	it "generates a notice from xml in a data param [POST]" do
	@@ -44,7 +44,6 @@ describe ProblemDestroy do		@@ -44,7 +44,6 @@ describe ProblemDestroy do
44	problem_destroy.execute	44	problem_destroy.execute
45	end	45	end
46	end	46	end
47	-
48	end	47	end
49		48
50	context "in integration way" do	49	context "in integration way" do
	@@ -292,7 +292,6 @@ describe ErrorReport do		@@ -292,7 +292,6 @@ describe ErrorReport do
292	it 'return the notice' do	292	it 'return the notice' do
293	expect(error_report.notice).to be_a Notice	293	expect(error_report.notice).to be_a Notice
294	end	294	end
295	-
296	end	295	end
297	end	296	end
298		297
	@@ -129,7 +129,6 @@ describe "Callback on Notice", type: 'model' do		@@ -129,7 +129,6 @@ describe "Callback on Notice", type: 'model' do
129		129
130	describe 'should not send a notification if a notification service is not' \	130	describe 'should not send a notification if a notification service is not' \
131	'configured' do	131	'configured' do
132	-
133	let(:notification_service) { Fabricate(:notification_service) }	132	let(:notification_service) { Fabricate(:notification_service) }
134	let(:app) { Fabricate(:app, notification_service: notification_service )}	133	let(:app) { Fabricate(:app, notification_service: notification_service )}
135	let(:notice_attrs) { notice_attrs_for.call(app.api_key) }	134	let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
	@@ -88,7 +88,6 @@ describe NotificationServices::GtalkService, type: 'model' do		@@ -88,7 +88,6 @@ describe NotificationServices::GtalkService, type: 'model' do
88	@notification_service.room_id = ""	88	@notification_service.room_id = ""
89	@notification_service.create_notification(@problem)	89	@notification_service.create_notification(@problem)
90	end	90	end
91	-
92	end	91	end
93		92
94	it "it should send a notification to room only" do	93	it "it should send a notification to room only" do
1	describe NotificationServices, type: 'model' do	1	describe NotificationServices, type: 'model' do
2	-
3	let(:notice) { Fabricate :notice }	2	let(:notice) { Fabricate :notice }
4	let(:notification_service) { Fabricate :notification_service, :app => notice.app }	3	let(:notification_service) { Fabricate :notification_service, :app => notice.app }
5	let(:problem) { notice.problem }	4	let(:problem) { notice.problem }
	@@ -18,7 +18,6 @@ describe "apps/new.html.haml", type: 'view' do		@@ -18,7 +18,6 @@ describe "apps/new.html.haml", type: 'view' do
18		18
19	expect(action_bar).to have_selector('a.button', :text => 'cancel')	19	expect(action_bar).to have_selector('a.button', :text => 'cancel')
20	end	20	end
21	-
22	end	21	end
23		22
24	context "with unvalid app" do	23	context "with unvalid app" do