Rubocop: fix all uses of !! - replace with thing.present?

Laust Rud Jacobsen
1 parent c8514607
Showing 5 changed files with 10 additions and 18 deletions Show diff stats
.rubocop_todo.yml
Gemfile
app/controllers/apps_controller.rb
app/helpers/apps_helper.rb
app/models/app.rb
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2015-10-12 21:40:48 +0200 using RuboCop version 0.34.2.
+# on 2015-10-12 21:53:36 +0200 using RuboCop version 0.34.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -13,13 +13,13 @@ Metrics/AbcSize:
 # Offense count: 5
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 203
+  Max: 205
 # Offense count: 5
 Metrics/CyclomaticComplexity:
   Max: 11
-# Offense count: 458
+# Offense count: 457
 # Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
   Max: 239
@@ -64,7 +64,7 @@ Style/AlignHash:
     - 'spec/controllers/problems_controller_spec.rb'
     - 'spec/models/problem_spec.rb'
-# Offense count: 7
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/AlignParameters:
@@ -72,7 +72,6 @@ Style/AlignParameters:
     - 'app/helpers/apps_helper.rb'
     - 'app/models/app.rb'
     - 'app/models/notification_services/gtalk_service.rb'
-    - 'app/models/problem.rb'
     - 'config/initializers/devise.rb'
 # Offense count: 105
@@ -146,14 +145,6 @@ Style/Documentation:
 Style/DotPosition:
   Enabled: false
-# Offense count: 6
-Style/DoubleNegation:
-  Exclude:
-    - 'Gemfile'
-    - 'app/controllers/apps_controller.rb'
-    - 'app/helpers/apps_helper.rb'
-    - 'app/models/app.rb'
-
 # Offense count: 5
 Style/EachWithObject:
   Exclude:
@@ -100,7 +100,7 @@ group :test do
 end
 group :heroku, :production do
-  gem 'rails_12factor', require: !!ENV["HEROKU"]
+  gem 'rails_12factor', require: ENV.key?("HEROKU")
   gem 'unicorn', require: false, platform: 'ruby'
 end
@@ -20,7 +20,7 @@ class AppsController &lt; ApplicationController
   end
   expose(:all_errs) {
-    !!params[:all_errs]
+    params[:all_errs].present?
   }
   expose(:problems) {
@@ -45,7 +45,7 @@ module AppsHelper
       @any_github_repos   ||= app.github_repo?
       @any_bitbucket_repos   ||= app.bitbucket_repo?
       @any_issue_trackers ||= app.issue_tracker_configured?
-      @any_deploys        ||= !!app.last_deploy_at
+      @any_deploys        ||= app.last_deploy_at.present?
       @any_notification_services ||= app.notification_service_configured?
     end
   end
@@ -135,11 +135,12 @@ class App
   def issue_tracker_configured?
-    !!issue_tracker && !!(issue_tracker.configured?)
+    issue_tracker.present? && issue_tracker.configured?
   end
   def notification_service_configured?
-    !!(notification_service.class < NotificationService && notification_service.configured?)
+    (notification_service.class < NotificationService) &&
+      notification_service.configured?
   end
	@@ -100,7 +100,7 @@ group :test do		@@ -100,7 +100,7 @@ group :test do
100	end	100	end
101		101
102	group :heroku, :production do	102	group :heroku, :production do
103	- gem 'rails_12factor', require: !!ENV["HEROKU"]	103	+ gem 'rails_12factor', require: ENV.key?("HEROKU")
104	gem 'unicorn', require: false, platform: 'ruby'	104	gem 'unicorn', require: false, platform: 'ruby'
105	end	105	end
106		106
	@@ -20,7 +20,7 @@ class AppsController < ApplicationController		@@ -20,7 +20,7 @@ class AppsController < ApplicationController
20	end	20	end
21		21
22	expose(:all_errs) {	22	expose(:all_errs) {
23	- !!params[:all_errs]	23	+ params[:all_errs].present?
24	}	24	}
25		25
26	expose(:problems) {	26	expose(:problems) {
	@@ -45,7 +45,7 @@ module AppsHelper		@@ -45,7 +45,7 @@ module AppsHelper
45	@any_github_repos \|\|= app.github_repo?	45	@any_github_repos \|\|= app.github_repo?
46	@any_bitbucket_repos \|\|= app.bitbucket_repo?	46	@any_bitbucket_repos \|\|= app.bitbucket_repo?
47	@any_issue_trackers \|\|= app.issue_tracker_configured?	47	@any_issue_trackers \|\|= app.issue_tracker_configured?
48	- @any_deploys \|\|= !!app.last_deploy_at	48	+ @any_deploys \|\|= app.last_deploy_at.present?
49	@any_notification_services \|\|= app.notification_service_configured?	49	@any_notification_services \|\|= app.notification_service_configured?
50	end	50	end
51	end	51	end