Merge pull request #948 from stevecrozz/934_error_on_invalid_xml

refs #934 catch and provide error on invalid xml

Merge pull request #948 from stevecrozz/934_error_on_invalid_xml
refs #934 catch and provide error on invalid xml
Stephen Crosby
2 parents aa2e8315 1cc587c0
Showing 2 changed files with 11 additions and 0 deletions Show diff stats
app/controllers/notices_controller.rb
spec/controllers/notices_controller_spec.rb
@@ -24,6 +24,8 @@ class NoticesController &lt; ApplicationController
     else
       render :text => "Your API key is unknown", :status => 422
     end
+  rescue Nokogiri::XML::SyntaxError
+    render :text => 'The provided XML was not well-formed', :status => 422
   end
  
   # Redirects a notice to the problem page. Useful when using User Information at Airbrake gem.
@@ -7,6 +7,15 @@ describe NoticesController, type: &#39;controller&#39; do
   let(:error_report) { double(:valid? => true, :generate_notice! => true, :notice => notice, :should_keep? => true) }
  
   context 'notices API' do
+    context "with bogus xml" do
+      it "returns an error" do
+        expect(request).to receive(:raw_post).and_return('<r><b>notxml</r>')
+        post :create, :format => :xml
+        expect(response.status).to eq(422)
+        expect(response.body).to eq('The provided XML was not well-formed')
+      end
+    end
+
     context "with all params" do
       before do
         expect(ErrorReport).to receive(:new).with(xml).and_return(error_report)
...	...	@@ -24,6 +24,8 @@ class NoticesController < ApplicationController
24	24	else
25	25	render :text => "Your API key is unknown", :status => 422
26	26	end
	27	+ rescue Nokogiri::XML::SyntaxError
	28	+ render :text => 'The provided XML was not well-formed', :status => 422
27	29	end
28	30
29	31	# Redirects a notice to the problem page. Useful when using User Information at Airbrake gem.
...	...
...	...	@@ -7,6 +7,15 @@ describe NoticesController, type: 'controller' do
7	7	let(:error_report) { double(:valid? => true, :generate_notice! => true, :notice => notice, :should_keep? => true) }
8	8
9	9	context 'notices API' do
	10	+ context "with bogus xml" do
	11	+ it "returns an error" do
	12	+ expect(request).to receive(:raw_post).and_return('<r><b>notxml</r>')
	13	+ post :create, :format => :xml
	14	+ expect(response.status).to eq(422)
	15	+ expect(response.body).to eq('The provided XML was not well-formed')
	16	+ end
	17	+ end
	18	+
10	19	context "with all params" do
11	20	before do
12	21	expect(ErrorReport).to receive(:new).with(xml).and_return(error_report)
...	...