add new tracker icons to problem/show page

Stephen Crosby
1 parent 59fb0d69
Showing 15 changed files with 162 additions and 115 deletions Show diff stats
app/assets/stylesheets/errbit.css.erb
app/controllers/apps_controller.rb
app/controllers/problems_controller.rb
app/decorators/issue_tracker_decorator.rb
app/decorators/issue_tracker_type_decorator.rb
app/helpers/application_helper.rb
app/models/issue_tracker.rb
app/views/apps/_issue_tracker_fields.html.haml
app/views/apps/index.html.haml
app/views/problems/_issue_tracker_links.html.haml
lib/tasks/errbit/demo.rake
spec/controllers/problems_controller_spec.rb
spec/decorators/issue_tracker_decorator_spec.rb
spec/decorators/issue_tracker_type_decorator_spec.rb
spec/views/problems/show.html.haml_spec.rb
@@ -604,6 +604,11 @@ div.notification_service.nested .label_radio input {
   position: absolute; left: -9999px;
 }
+.button-icon {
+  float: left;
+  margin: 5px 0 0 6px;
+}
+
 div.issue_tracker.nested label.r_on, div.issue_tracker.nested label.r_on:hover, div.notification_service.nested label.r_on, div.notification_service.nested label.r_on:hover {
   color: #191919;
 }
@@ -12,7 +12,7 @@ class AppsController &lt; ApplicationController
   }
   expose(:apps) {
-    app_scope.all.sort.to_a
+    app_scope.all.sort.map { |app| AppDecorator.new(app) }
   }
   expose(:app, ancestor: :app_scope, attributes: :app_params)
@@ -12,28 +12,23 @@ class ProblemsController &lt; ApplicationController
     :resolve_several, :unresolve_several, :unmerge_several
   ]
+  expose(:app_scope) {
+    apps = current_user.admin? ? App.all : current_user.apps
+    params[:app_id] ? apps.where(:_id => params[:app_id]) : apps
+  }
+
   expose(:app) {
-    if current_user.admin?
-      App.find(params[:app_id])
-    else
-      current_user.apps.find(params[:app_id])
-    end
+    AppDecorator.new app_scope.find(params[:app_id])
   }
   expose(:problem) {
     app.problems.find(params[:id])
   }
-
   expose(:all_errs) {
     params[:all_errs]
   }
-  expose(:app_scope) {
-    apps = current_user.admin? ? App.all : current_user.apps
-    params[:app_id] ? apps.where(:_id => params[:app_id]) : apps
-  }
-
   expose(:params_environement) {
     params[:environment]
   }
+# Decorates an instance of IssueTracker
 class IssueTrackerDecorator < Draper::Decorator
-
-  def initialize(object, key)
-    @object = object
-    @key = key
-  end
-  attr_reader :key
-
   delegate_all
-  def issue_trackers
-    ErrbitPlugin::Registry.issue_trackers.each do |key, object|
-      yield IssueTrackerDecorator.new(object, key)
-    end
-  end
-
-  def icons
-    tracker_icons = object.icons
-    return unless tracker_icons
-
-    tracker_icons.reduce({}) do |c, (k,v)|
-      c[k] = "data:#{v[0]};base64,#{Base64.encode64(v[1])}"; c
-    end
-  end
-
-  def note
-    object.note.html_safe
+  def type
+    @type ||= IssueTrackerTypeDecorator.new(object.tracker.class)
   end
-
-  def fields
-    object.fields.each do |field, field_info|
-      yield IssueTrackerFieldDecorator.new(field, field_info)
-    end
-  end
-
-  def params_class(tracker)
-    [chosen?(tracker), label].join(" ").strip
-  end
-
-  private
-
-  def chosen?(issue_tracker)
-    key == issue_tracker.type_tracker.to_s ? 'chosen' : ''
-  end
-
 end
@@ -0,0 +1,30 @@
+# Decorates an IssueTracker class
+class IssueTrackerTypeDecorator < Draper::Decorator
+  delegate_all
+
+  # return hash of icons as data URIs
+  def icons
+    return unless object.icons
+
+    object.icons.reduce({}) do |c, (k,v)|
+      c[k] = "data:#{v[0]};base64,#{Base64.encode64(v[1])}"; c
+    end
+  end
+
+  # class name for tracker type form fields
+  #
+  # 'chosen github' or 'bitbucket' for example
+  def params_class(tracker)
+    [object.label == tracker.type_tracker ? 'chosen' : '', label].join(" ").strip
+  end
+
+  def note
+    object.note.html_safe
+  end
+
+  def fields
+    object.fields.each do |field, field_info|
+      yield IssueTrackerFieldDecorator.new(field, field_info)
+    end
+  end
+end
@@ -69,6 +69,12 @@ module ApplicationHelper
     collection.to_a[head_size..-1].to_a
   end
+  def issue_tracker_types
+    ErrbitPlugin::Registry.issue_trackers.map do |_, object|
+      IssueTrackerTypeDecorator.new(object)
+    end
+  end
+
   private
     def total_from_tallies(tallies)
       tallies.values.inject(0) {|sum, n| sum + n}
@@ -14,7 +14,10 @@ class IssueTracker
       begin
         klass = ErrbitPlugin::Registry.issue_trackers[self.type_tracker] || ErrbitPlugin::NoneIssueTracker
         # TODO: we need to find out a better way to pass those config to the issue tracker
-        klass.new(options.merge(github_repo: app.github_repo, bitbucket_repo: app.bitbucket_repo))
+        klass.new(options.merge(
+          github_repo: app.try(:github_repo),
+          bitbucket_repo: app.try(:bitbucket_repo)
+        ))
       end
   end
@@ -3,16 +3,17 @@
   = f.fields_for :issue_tracker do |issue_tracker_form|
     %div.issue_tracker.nested
       %div.choose
-        - issue_tracker_form.object.issue_trackers do |tracker|
-          = issue_tracker_form.label :type_tracker, :class => "label_radio #{tracker.label}", :value => tracker.key do
-            %img.icon{"src" => tracker.icons[:inactive], "data-icon" => tracker.icons}
-            = issue_tracker_form.radio_button :type_tracker, tracker.key, 'data-section' => tracker.label
-            = tracker.label
+        - issue_tracker_types.each do |tracker_type|
+          = issue_tracker_form.label :type_tracker, :class => "label_radio #{tracker_type.label}", :value => tracker_type.label do
+            - icon = tracker_type == issue_tracker_form.object.type ? :create : :inactive
+            %img.icon{"src" => tracker_type.icons[icon], "data-icon" => tracker_type.icons}
+            = issue_tracker_form.radio_button :type_tracker, tracker_type.label, 'data-section' => tracker_type.label
+            = tracker_type.label
-      - issue_tracker_form.object.issue_trackers do |tracker|
-        %div.tracker_params{:class => tracker.params_class(issue_tracker_form.object)}
+      - issue_tracker_types.each do |tracker_type|
+        %div.tracker_params{:class => tracker_type.params_class(issue_tracker_form.object)}
           = issue_tracker_form.fields_for(:options) do |options_form|
-            %p= tracker.note
-            - tracker.fields do |field|
+            %p= tracker_type.note
+            - tracker_type.fields do |field|
               = options_form.label field.key, field.label
               = field.input(options_form, issue_tracker_form.object)
@@ -36,7 +36,7 @@
         - if any_issue_trackers?
           %td.issue_tracker
             - if app.issue_tracker_configured?
-              - tracker_img = image_tag("#{app.issue_tracker.type_tracker}_goto.png")
+              - tracker_img = image_tag(app.issue_tracker.type.icons[:goto])
               - if app.issue_tracker.url
                 = link_to( tracker_img, app.issue_tracker.url )
               - else
 - if app.issue_tracker_configured?
+  - tracker = app.issue_tracker
+  - tracker_type = tracker.type
   - if problem.issue_link.present?
-    %span= link_to 'go to issue', problem.issue_link, :class => "#{problem.issue_type}_goto goto-issue"
+    %span
+      %img.button-icon{"src" => tracker_type.icons[:create]}
+      = link_to 'go to issue', problem.issue_link, :class => "goto-issue"
     = link_to 'unlink issue', unlink_issue_app_problem_path(app, problem), :method => :delete, :data => { :confirm => "Unlink err issues?" }, :class => "unlink-issue"
   - elsif problem.issue_link == "pending"
-    %span.disabled= link_to 'creating...', '#', :class => "#{problem.issue_type}_inactive create-issue"
+    %span.disabled
+      %img.button-icon{"src" => tracker_type.icons[:inactive]}
+      = link_to 'creating...', '#', :class => "create-issue"
     = link_to 'retry', create_issue_app_problem_path(app, problem), :method => :post
   - else
-    %span= link_to 'create issue', create_issue_app_problem_path(app, problem), method: :post, class: "#{app.issue_tracker.type_tracker}_create create-issue"
+    %span
+      %img.button-icon{"src" => tracker_type.icons[:goto]}
+      = link_to 'create issue', create_issue_app_problem_path(app, problem), method: :post, :class => "create-issue"
 namespace :errbit do
-
   desc "Add a demo app & errors to your database (for testing)"
   task :demo => :environment do
+    require 'fabrication'
     app = Fabricate(:app, :name => "Demo App #{Time.now.strftime("%N")}")
@@ -68,5 +68,4 @@ namespace :errbit do
     Fabricate(:notice, :err => Fabricate(:err, :problem => Fabricate(:problem, :app => app)))
     puts "=== Created demo app: '#{app.name}', with example errors."
   end
-
 end
@@ -218,9 +218,7 @@ describe ProblemsController, type: &#39;controller&#39; do
       @err = Fabricate(:err)
     end
-    it 'finds the app and the err' do
-      expect(App).to receive(:find).with(@err.app.id.to_s).and_return(@err.app)
-      expect(@err.app.problems).to receive(:find).and_return(@err.problem)
+    it 'finds the app and the problem' do
       put :resolve, :app_id => @err.app.id, :id => @err.problem.id
       expect(controller.app).to eq @err.app
       expect(controller.problem).to eq @err.problem
 describe IssueTrackerDecorator do
   let(:fake_tracker) do
-    Class.new(ErrbitPlugin::IssueTracker) do
+    klass = Class.new(ErrbitPlugin::IssueTracker) {
       def self.label; 'fake'; end
       def self.note; 'a note'; end
       def self.fields
@@ -11,43 +11,23 @@ describe IssueTrackerDecorator do
       end
       def configured?; true; end
-    end
+    }
+    klass.new 'nothing special'
   end
-  let(:decorator) do
-    IssueTrackerDecorator.new(fake_tracker, 'fake')
+  let(:issue_tracker) do
+    it = IssueTracker.new
+    allow(it).to receive(:tracker).and_return(fake_tracker)
+    it
   end
-  describe "#note" do
-    it 'return the html_safe of Note' do
-      expect(decorator.note).to eql fake_tracker.note
-    end
-  end
-
-  describe "#issue_trackers" do
-    it 'return an array of IssueTrackerDecorator' do
-      decorator.issue_trackers do |it|
-        expect(it).to be_a(IssueTrackerDecorator)
-      end
-    end
-  end
-
-  describe "#fields" do
-    it 'return all Fields define decorate' do
-      decorator.fields do |itf|
-        expect(itf).to be_a(IssueTrackerFieldDecorator)
-        expect([:foo, :bar]).to be_include(itf.object)
-        expect([{:label => 'foo'}, {:label => 'bar'}]).to be_include(itf.field_info)
-      end
-    end
+  let(:decorator) do
+    IssueTrackerDecorator.new(issue_tracker)
   end
-  describe "#params_class" do
-    it 'add the label in class' do
-      expect(decorator.params_class(IssueTracker.new(:type_tracker => 'none'))).to eql 'fake'
-    end
-    it 'add chosen class if _type is same' do
-      expect(decorator.params_class(IssueTracker.new(:type_tracker => 'fake'))).to eql 'chosen fake'
+  describe "#type" do
+    it 'returns decorator for the issue tracker class' do
+      expect(decorator.type.class).to eq(IssueTrackerTypeDecorator)
     end
   end
 end
@@ -0,0 +1,59 @@
+describe IssueTrackerDecorator do
+  let(:fake_tracker_class) do
+    klass = Class.new(ErrbitPlugin::IssueTracker) do
+      def self.label; 'fake'; end
+      def self.note; 'a note'; end
+      def self.fields
+        {
+          :foo => {:label => 'foo'},
+          :bar => {:label => 'bar'}
+        }
+      end
+      def self.icons
+        {
+          one: ['text/plain', 'all your base are belong to us'],
+          two: ['application/xml', '<root></root>'],
+        }
+      end
+    end
+
+    allow(ErrbitPlugin::Registry).to receive(:issue_trackers).and_return({
+      fake: klass
+    })
+
+    klass
+  end
+
+  let(:fake_tracker) { IssueTrackerDecorator.new(fake_tracker_class.new) }
+  let(:decorator) { IssueTrackerTypeDecorator.new(fake_tracker_class) }
+
+  describe "::note" do
+    it 'return the html_safe of Note' do
+      expect(decorator.note).to eql fake_tracker_class.note
+    end
+  end
+
+  describe "#fields" do
+    it 'return all Fields define decorate' do
+      decorator.fields do |itf|
+        expect(itf).to be_a(IssueTrackerFieldDecorator)
+        expect([:foo, :bar]).to be_include(itf.object)
+        expect([{:label => 'foo'}, {:label => 'bar'}]).to be_include(itf.field_info)
+      end
+    end
+  end
+
+  describe "#params_class" do
+    it 'adds the label in class' do
+      tracker = IssueTrackerDecorator.new(IssueTracker.new(
+        type_tracker: 'none'))
+      expect(decorator.params_class(tracker)).to eql 'fake'
+    end
+
+    it 'adds chosen class if type is same' do
+      expect(decorator.params_class(
+        IssueTracker.new(type_tracker: 'fake').decorate
+      )).to eql 'chosen fake'
+    end
+  end
+end
@@ -4,12 +4,14 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
   let(:pivotal_tracker) {
     Class.new(ErrbitPlugin::MockIssueTracker) do
       def self.label; 'pivotal'; end
+      def self.icons; {}; end
       def configured?; true; end
     end
   }
   let(:github_tracker) {
     Class.new(ErrbitPlugin::MockIssueTracker) do
-      def label; 'github'; end
+      def self.label; 'github'; end
+      def self.icons; {}; end
       def configured?; true; end
     end
   }
@@ -19,9 +21,10 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
       'pivotal' => pivotal_tracker
     }
   }
+  let(:app) { AppDecorator.new(problem.app) }
   before do
-    allow(view).to receive(:app).and_return(problem.app)
+    allow(view).to receive(:app).and_return(app)
     allow(view).to receive(:problem).and_return(problem)
     assign :comment, comment
@@ -33,7 +36,11 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
   def with_issue_tracker(tracker, problem)
     allow(ErrbitPlugin::Registry).to receive(:issue_trackers).and_return(trackers)
-    problem.app.issue_tracker = IssueTracker.new :type_tracker => tracker, :options => {:api_token => "token token token", :project_id => "1234"}
+    app.issue_tracker = IssueTrackerDecorator.new(
+      IssueTracker.new :type_tracker => tracker, :options => {
+        :api_token => "token token token",
+        :project_id => "1234"
+      })
   end
   describe "content_for :action_bar" do
@@ -86,7 +93,7 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
         allow(view).to receive(:app).and_return(problem.app)
         render
-        expect(action_bar).to have_selector("span a.github_create.create-issue", text: 'create issue')
+        expect(action_bar).to have_selector("span a.create-issue", text: 'create issue')
       end
       context "without issue tracker associate on app" do
@@ -118,12 +125,7 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
           it 'links to the associated tracker' do
             render
-            expect(view.content_for(:action_bar)).to match(".pivotal_create.create-issue")
-          end
-
-          it 'does not link to github' do
-            render
-            expect(view.content_for(:action_bar)).to_not match(".github_create.create-issue")
+            expect(view.content_for(:action_bar)).to match(".create-issue")
           end
         end
@@ -179,4 +181,3 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
     end
   end
 end
-
	@@ -12,7 +12,7 @@ class AppsController < ApplicationController		@@ -12,7 +12,7 @@ class AppsController < ApplicationController
12	}	12	}
13		13
14	expose(:apps) {	14	expose(:apps) {
15	- app_scope.all.sort.to_a	15	+ app_scope.all.sort.map { \|app\| AppDecorator.new(app) }
16	}	16	}
17		17
18	expose(:app, ancestor: :app_scope, attributes: :app_params)	18	expose(:app, ancestor: :app_scope, attributes: :app_params)
		1	+# Decorates an instance of IssueTracker
1	class IssueTrackerDecorator < Draper::Decorator	2	class IssueTrackerDecorator < Draper::Decorator
2	-
3	- def initialize(object, key)
4	- @object = object
5	- @key = key
6	- end
7	- attr_reader :key
8	-
9	delegate_all	3	delegate_all
10		4
11	- def issue_trackers
12	- ErrbitPlugin::Registry.issue_trackers.each do \|key, object\|
13	- yield IssueTrackerDecorator.new(object, key)
14	- end
15	- end
16	-
17	- def icons
18	- tracker_icons = object.icons
19	- return unless tracker_icons
20	-
21	- tracker_icons.reduce({}) do \|c, (k,v)\|
22	- c[k] = "data:#{v[0]};base64,#{Base64.encode64(v[1])}"; c
23	- end
24	- end
25	-
26	- def note
27	- object.note.html_safe	5	+ def type
		6	+ @type \|\|= IssueTrackerTypeDecorator.new(object.tracker.class)
28	end	7	end
29	-
30	- def fields
31	- object.fields.each do \|field, field_info\|
32	- yield IssueTrackerFieldDecorator.new(field, field_info)
33	- end
34	- end
35	-
36	- def params_class(tracker)
37	- [chosen?(tracker), label].join(" ").strip
38	- end
39	-
40	- private
41	-
42	- def chosen?(issue_tracker)
43	- key == issue_tracker.type_tracker.to_s ? 'chosen' : ''
44	- end
45	-
46	end	8	end
@@ -0,0 +1,30 @@		@@ -0,0 +1,30 @@
	1	+# Decorates an IssueTracker class
	2	+class IssueTrackerTypeDecorator < Draper::Decorator
	3	+ delegate_all
	4	+
	5	+ # return hash of icons as data URIs
	6	+ def icons
	7	+ return unless object.icons
	8	+
	9	+ object.icons.reduce({}) do \|c, (k,v)\|
	10	+ c[k] = "data:#{v[0]};base64,#{Base64.encode64(v[1])}"; c
	11	+ end
	12	+ end
	13	+
	14	+ # class name for tracker type form fields
	15	+ #
	16	+ # 'chosen github' or 'bitbucket' for example
	17	+ def params_class(tracker)
	18	+ [object.label == tracker.type_tracker ? 'chosen' : '', label].join(" ").strip
	19	+ end
	20	+
	21	+ def note
	22	+ object.note.html_safe
	23	+ end
	24	+
	25	+ def fields
	26	+ object.fields.each do \|field, field_info\|
	27	+ yield IssueTrackerFieldDecorator.new(field, field_info)
	28	+ end
	29	+ end
	30	+end
	@@ -69,6 +69,12 @@ module ApplicationHelper		@@ -69,6 +69,12 @@ module ApplicationHelper
69	collection.to_a[head_size..-1].to_a	69	collection.to_a[head_size..-1].to_a
70	end	70	end
71		71
		72	+ def issue_tracker_types
		73	+ ErrbitPlugin::Registry.issue_trackers.map do \|_, object\|
		74	+ IssueTrackerTypeDecorator.new(object)
		75	+ end
		76	+ end
		77	+
72	private	78	private
73	def total_from_tallies(tallies)	79	def total_from_tallies(tallies)
74	tallies.values.inject(0) {\|sum, n\| sum + n}	80	tallies.values.inject(0) {\|sum, n\| sum + n}
	@@ -36,7 +36,7 @@		@@ -36,7 +36,7 @@
36	- if any_issue_trackers?	36	- if any_issue_trackers?
37	%td.issue_tracker	37	%td.issue_tracker
38	- if app.issue_tracker_configured?	38	- if app.issue_tracker_configured?
39	- - tracker_img = image_tag("#{app.issue_tracker.type_tracker}_goto.png")	39	+ - tracker_img = image_tag(app.issue_tracker.type.icons[:goto])
40	- if app.issue_tracker.url	40	- if app.issue_tracker.url
41	= link_to( tracker_img, app.issue_tracker.url )	41	= link_to( tracker_img, app.issue_tracker.url )
42	- else	42	- else
@@ -0,0 +1,59 @@		@@ -0,0 +1,59 @@
	1	+describe IssueTrackerDecorator do
	2	+ let(:fake_tracker_class) do
	3	+ klass = Class.new(ErrbitPlugin::IssueTracker) do
	4	+ def self.label; 'fake'; end
	5	+ def self.note; 'a note'; end
	6	+ def self.fields
	7	+ {
	8	+ :foo => {:label => 'foo'},
	9	+ :bar => {:label => 'bar'}
	10	+ }
	11	+ end
	12	+ def self.icons
	13	+ {
	14	+ one: ['text/plain', 'all your base are belong to us'],
	15	+ two: ['application/xml', '<root></root>'],
	16	+ }
	17	+ end
	18	+ end
	19	+
	20	+ allow(ErrbitPlugin::Registry).to receive(:issue_trackers).and_return({
	21	+ fake: klass
	22	+ })
	23	+
	24	+ klass
	25	+ end
	26	+
	27	+ let(:fake_tracker) { IssueTrackerDecorator.new(fake_tracker_class.new) }
	28	+ let(:decorator) { IssueTrackerTypeDecorator.new(fake_tracker_class) }
	29	+
	30	+ describe "::note" do
	31	+ it 'return the html_safe of Note' do
	32	+ expect(decorator.note).to eql fake_tracker_class.note
	33	+ end
	34	+ end
	35	+
	36	+ describe "#fields" do
	37	+ it 'return all Fields define decorate' do
	38	+ decorator.fields do \|itf\|
	39	+ expect(itf).to be_a(IssueTrackerFieldDecorator)
	40	+ expect([:foo, :bar]).to be_include(itf.object)
	41	+ expect([{:label => 'foo'}, {:label => 'bar'}]).to be_include(itf.field_info)
	42	+ end
	43	+ end
	44	+ end
	45	+
	46	+ describe "#params_class" do
	47	+ it 'adds the label in class' do
	48	+ tracker = IssueTrackerDecorator.new(IssueTracker.new(
	49	+ type_tracker: 'none'))
	50	+ expect(decorator.params_class(tracker)).to eql 'fake'
	51	+ end
	52	+
	53	+ it 'adds chosen class if type is same' do
	54	+ expect(decorator.params_class(
	55	+ IssueTracker.new(type_tracker: 'fake').decorate
	56	+ )).to eql 'chosen fake'
	57	+ end
	58	+ end
	59	+end