Download as
Browse Code »

Commit ab826443b9459aa35a0eef9fd2b99f2fa4bb6078

Authored by Nathan B
2 parents 5e600453 06fd651a
Exists in master and in 1 other branch production

Merge pull request #112 from versapay/master 

Reset notice count when an issue is resolved
Showing 2 changed files with 19 additions and 1 deletions   Show diff stats
app/models/problem.rb
  Diff comments   View file @ab82644
@@ -47,7 +47,7 @@ class Problem @@ -47,7 +47,7 @@ class Problem
47 end 47 end
48 48
49 def resolve! 49 def resolve!
50 - self.update_attributes!(:resolved => true) 50 + self.update_attributes!(:resolved => true, :notices_count => 0)
51 end 51 end
52 52
53 def unresolve! 53 def unresolve!
spec/models/notice_spec.rb
  Diff comments   View file @ab82644
@@ -106,6 +106,24 @@ describe Notice do @@ -106,6 +106,24 @@ describe Notice do
106 end 106 end
107 end 107 end
108 108
  109 + describe "email notifications for a resolved issue" do
109 110
  111 + before do
  112 + Errbit::Config.per_app_email_at_notices = true
  113 + @app = Factory(:app_with_watcher, :email_at_notices => [1])
  114 + @err = Factory(:err, :problem => Factory(:problem, :app => @app, :notices_count => 100))
  115 + end
  116 +
  117 + after do
  118 + Errbit::Config.per_app_email_at_notices = false
  119 + end
  120 +
  121 + it "should send email notification after 1 notice since an error has been resolved" do
  122 + @err.problem.resolve!
  123 + Mailer.should_receive(:err_notification).
  124 + and_return(mock('email', :deliver => true))
  125 + Factory(:notice, :err => @err)
  126 + end
  127 + end
110 end 128 end
111 129