Rubocop: spaces around and within block braces

Laust Rud Jacobsen
1 parent 9725017b
Showing 37 changed files with 67 additions and 79 deletions Show diff stats
.rubocop_todo.yml
app/controllers/apps_controller.rb
app/controllers/problems_searcher.rb
app/controllers/users_controller.rb
app/helpers/application_helper.rb
app/helpers/apps_helper.rb
app/helpers/navigation_helper.rb
app/interactors/problem_destroy.rb
app/models/app.rb
app/models/deploy.rb
app/models/notice.rb
app/models/notification_services/campfire_service.rb
app/models/notification_services/hoiio_service.rb
app/models/notification_services/hubot_service.rb
app/models/notification_services/pushover_service.rb
app/models/notification_services/slack_service.rb
app/models/notification_services/webhook_service.rb
app/models/problem.rb
lib/hoptoad/v2.rb
spec/controllers/apps_controller_spec.rb
@@ -270,18 +270,6 @@ Style/SingleSpaceBeforeFirstArg:
     - 'spec/fabricators/notice_fabricator.rb'
     - 'spec/fabricators/user_fabricator.rb'
  
-# Offense count: 27
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SpaceBeforeBlockBraces:
-  Enabled: false
-
-# Offense count: 75
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-Style/SpaceInsideBlockBraces:
-  Enabled: false
-
 # Offense count: 873
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -39,7 +39,7 @@ class AppsController &lt; ApplicationController
   }
  
   expose(:users) {
-    User.all.sort_by {|u| u.name.downcase }
+    User.all.sort_by { |u| u.name.downcase }
   }
  
   def index; end
@@ -96,7 +96,7 @@ protected
     # set the app's notification service
     if params[:app][:notification_service_attributes] && (notification_type = params[:app][:notification_service_attributes][:type])
       available_notification_classes = [NotificationService] + NotificationService.subclasses
-      notification_class = available_notification_classes.detect{|c| c.name == notification_type}
+      notification_class = available_notification_classes.detect { |c| c.name == notification_type }
       if notification_class.present?
         app.notification_service = notification_class.new(params[:app][:notification_service_attributes])
       end
@@ -116,7 +116,7 @@ protected
       # Sanitize negative values, split on comma,
       # strip, parse as integer, remove all '0's.
       # If empty, set as default and show an error message.
-      email_at_notices = val.gsub(/-\d+/, "").split(",").map{|v| v.strip.to_i }.reject{|v| v == 0}
+      email_at_notices = val.gsub(/-\d+/, "").split(",").map { |v| v.strip.to_i }.reject { |v| v == 0 }
       if email_at_notices.any?
         params[:app][:email_at_notices] = email_at_notices
       else
@@ -131,7 +131,7 @@ protected
       # Sanitize negative values, split on comma,
       # strip, parse as integer, remove all '0's.
       # If empty, set as default and show an error message.
-      notify_at_notices = val.gsub(/-\d+/, "").split(",").map{|v| v.strip.to_i }
+      notify_at_notices = val.gsub(/-\d+/, "").split(",").map { |v| v.strip.to_i }
       if notify_at_notices.any?
         params[:app][:notification_service_attributes][:notify_at_notices] = notify_at_notices
       else
@@ -13,7 +13,7 @@ module ProblemsSearcher
       end
     }
  
-    expose(:params_order){
+    expose(:params_order) {
       unless %w{asc desc}.member?(params[:order])
         'desc'
       else
@@ -65,7 +65,7 @@ protected
   def user_permit_params
     @user_permit_params ||= [:name, :username, :email, :github_login, :per_page, :time_zone]
     @user_permit_params << :admin if current_user.admin? && current_user.id != params[:id]
-    @user_permit_params |= [:password, :password_confirmation] if user_password_params.values.all?{|pa| !pa.blank? }
+    @user_permit_params |= [:password, :password_confirmation] if user_password_params.values.all? { |pa| !pa.blank? }
     @user_permit_params
   end
  
@@ -56,8 +56,8 @@ module ApplicationHelper
   def create_percentage_table_from_tallies(tallies, options = {})
     total   = (options[:total] || total_from_tallies(tallies))
     percent = 100.0 / total.to_f
-    rows    = tallies.map {|value, count| [(count.to_f * percent), value]}. \
-                     sort {|a, b| b[0] <=> a[0]}
+    rows    = tallies.map { |value, count| [(count.to_f * percent), value] }. \
+                     sort { |a, b| b[0] <=> a[0] }
     render "problems/tally_table", :rows => rows
   end
  
@@ -4,8 +4,8 @@ module AppsHelper
       html =  link_to('copy settings from another app', '#',
         :class => 'button copy_config')
       html << select("duplicate", "app",
-        App.all.asc(:name).reject{|a| a == @app }.
-        collect{|p| [p.name, p.id] }, { :include_blank => "[choose app]" },
+        App.all.asc(:name).reject { |a| a == @app }.
+        collect { |p| [p.name, p.id] }, { :include_blank => "[choose app]" },
         { :class => "choose_other_app", :style => "display: none;" })
       return html
     end
@@ -19,7 +19,7 @@ module NavigationHelper
                   matches
                 when Array
                   s = {}
-                  matches.each {|c| s[c] = :all}
+                  matches.each { |c| s[c] = :all }
                   s
                 else
                   { matches => :all }
@@ -20,7 +20,7 @@ class ProblemDestroy
   #   the number of problem destroy
   #
   def self.execute(problems)
-    Array(problems).each{ |problem|
+    Array(problems).each { |problem|
       ProblemDestroy.new(problem).execute
     }.count
   end
@@ -21,7 +21,7 @@ class App
   field :_id,
     type: String,
     pre_processed: true,
-    default: ->{ BSON::ObjectId.new.to_s }
+    default: -> { BSON::ObjectId.new.to_s }
  
   embeds_many :watchers
   embeds_many :deploys
@@ -19,7 +19,7 @@ class Deploy
   validates_presence_of :username, :environment
  
   def resolve_app_errs
-    app.problems.unresolved.in_env(environment).each {|problem| problem.resolve!}
+    app.problems.unresolved.in_env(environment).each { |problem| problem.resolve! }
   end
  
   def short_revision
@@ -26,8 +26,8 @@ class Notice
  
   validates_presence_of :backtrace_id, :server_environment, :notifier
  
-  scope :ordered, ->{ order_by(:created_at.asc) }
-  scope :reverse_ordered, ->{ order_by(:created_at.desc) }
+  scope :ordered, -> { order_by(:created_at.asc) }
+  scope :reverse_ordered, -> { order_by(:created_at.desc) }
   scope :for_errs, Proc.new { |errs|
     where(:err_id.in => errs.all.map(&:id))
   }
@@ -17,7 +17,7 @@ if defined? Campy
     ]
  
     def check_params
-      if FIELDS.detect {|f| self[f[0]].blank? }
+      if FIELDS.detect { |f| self[f[0]].blank? }
         errors.add :base, 'You must specify your Campfire Subdomain, API token and Room ID'
       end
     end
@@ -16,7 +16,7 @@ class NotificationServices::HoiioService &lt; NotificationService
   ]
  
   def check_params
-    if FIELDS.detect {|f| self[f[0]].blank? }
+    if FIELDS.detect { |f| self[f[0]].blank? }
       errors.add :base, 'You must specify your App ID, Access Token and Recipient\'s phone numbers'
     end
   end
@@ -12,7 +12,7 @@ class NotificationServices::HubotService &lt; NotificationService
   ]
  
   def check_params
-    if FIELDS.detect {|f| self[f[0]].blank? }
+    if FIELDS.detect { |f| self[f[0]].blank? }
       errors.add :base, 'You must specify the URL of your hubot'
     end
   end
@@ -12,7 +12,7 @@ class NotificationServices::PushoverService &lt; NotificationService
   ]
  
   def check_params
-    if FIELDS.detect {|f| self[f[0]].blank? }
+    if FIELDS.detect { |f| self[f[0]].blank? }
       errors.add :base, 'You must specify your User Key and Application API Token.'
     end
   end
@@ -8,7 +8,7 @@ class NotificationServices::SlackService &lt; NotificationService
   ]
  
   def check_params
-    if FIELDS.detect {|f| self[f[0]].blank? }
+    if FIELDS.detect { |f| self[f[0]].blank? }
       errors.add :base, "You must specify your Slack Hook url."
     end
   end
@@ -8,7 +8,7 @@ class NotificationServices::WebhookService &lt; NotificationService
   ]
  
   def check_params
-    if FIELDS.detect {|f| self[f[0]].blank? }
+    if FIELDS.detect { |f| self[f[0]].blank? }
       errors.add :base, 'You must specify the URL'
     end
   end
@@ -58,10 +58,10 @@ class Problem
   before_create :cache_app_attributes
   before_save :truncate_message
  
-  scope :resolved, ->{ where(:resolved => true) }
-  scope :unresolved, ->{ where(:resolved => false) }
-  scope :ordered, ->{ order_by(:last_notice_at.desc) }
-  scope :for_apps, lambda {|apps| where(:app_id.in => apps.all.map(&:id))}
+  scope :resolved, -> { where(:resolved => true) }
+  scope :unresolved, -> { where(:resolved => false) }
+  scope :ordered, -> { order_by(:last_notice_at.desc) }
+  scope :for_apps, lambda { |apps| where(:app_id.in => apps.all.map(&:id)) }
  
   validates_presence_of :last_notice_at, :first_notice_at
  
@@ -22,13 +22,13 @@ module Hoptoad
         elsif node.key?('key')
           { normalize_key(node['key']) => nil }
         else
-          node.inject({}) {|rekeyed, (key, val)| rekeyed.merge(normalize_key(key) => rekey(val))}
+          node.inject({}) { |rekeyed, (key, val)| rekeyed.merge(normalize_key(key) => rekey(val)) }
         end
       when Array
         if node.first.key?('key')
-          node.inject({}) {|rekeyed, keypair| rekeyed.merge(rekey(keypair))}
+          node.inject({}) { |rekeyed, keypair| rekeyed.merge(rekey(keypair)) }
         else
-          node.map {|n| rekey(n)}
+          node.map { |n| rekey(n) }
         end
       else
         node
@@ -61,7 +61,7 @@ describe AppsController, type: &#39;controller&#39; do
  
       it "should not raise errors for app with err without notices" do
         err
-        expect{ get :show, :id => app.id }.to_not raise_error
+        expect { get :show, :id => app.id }.to_not raise_error
       end
  
       it "should list atom feed successfully" do
@@ -46,7 +46,7 @@ describe CommentsController, type: &#39;controller&#39; do
       end
  
       it "should delete the comment" do
-        expect(problem.comments.detect{|c| c.id.to_s == comment.id }).to be nil
+        expect(problem.comments.detect { |c| c.id.to_s == comment.id }).to be nil
       end
  
       it "should redirect to problem page" do
@@ -326,7 +326,7 @@ describe ProblemsController, type: &#39;controller&#39; do
       it "should unmerge a merged problem" do
         merged_problem = Problem.merge!(@problem1, @problem2)
         expect(merged_problem.errs.length).to eq 2
-        expect{
+        expect {
           post :unmerge_several, :problems => [merged_problem.id.to_s]
           expect(merged_problem.reload.errs.length).to eq 1
         }.to change(Problem, :count).by(1)
@@ -370,7 +370,7 @@ describe ProblemsController, type: &#39;controller&#39; do
  
     context "POST /problems/destroy_several" do
       it "should delete the problems" do
-        expect{
+        expect {
           post :destroy_several, :problems => [@problem1.id.to_s]
         }.to change(Problem, :count).by(-1)
       end
@@ -20,7 +20,7 @@ describe WatchersController, type: &#39;controller&#39; do
       end
  
       it "should delete the watcher" do
-        expect(app.watchers.detect{|w| w.id.to_s == watcher.id }).to be nil
+        expect(app.watchers.detect { |w| w.id.to_s == watcher.id }).to be nil
       end
  
       it "should redirect to app page" do
 Fabricator(:app) do
-  name { sequence(:app_name){|n| "App ##{n}"} }
+  name { sequence(:app_name) { |n| "App ##{n}" } }
   repository_branch 'master'
 end
  
@@ -12,7 +12,7 @@ end
 Fabricator(:watcher) do
   app
   watcher_type 'email'
-  email { sequence(:email){|n| "email#{n}@example.com"} }
+  email { sequence(:email) { |n| "email#{n}@example.com" } }
 end
  
 Fabricator(:user_watcher, :from => :watcher) do
@@ -4,9 +4,9 @@ Fabricator :notice do
   error_class         'FooError'
   message             'Too Much Bar'
   backtrace
-  server_environment  {{ 'environment-name' => 'production' }}
-  request             {{ 'component' => 'foo', 'action' => 'bar' }}
-  notifier            {{ 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' }}
+  server_environment  { { 'environment-name' => 'production' } }
+  request             { { 'component' => 'foo', 'action' => 'bar' } }
+  notifier            { { 'name' => 'Notifier', 'version' => '1', 'url' => 'http://toad.com' } }
  
   after_create do
     Problem.cache_notice(err.problem_id, self)
@@ -3,7 +3,7 @@ Fabricator :notification_service do
   room_id { sequence :word }
   api_token { sequence :word }
   subdomain { sequence :word }
-  notify_at_notices { sequence { |_a| [0]} }
+  notify_at_notices { sequence { |_a| [0] } }
 end
  
 Fabricator :gtalk_notification_service, :from => :notification_service, :class_name => "NotificationServices::GtalkService" do
-Fabricate.sequence(:name) {|n| "John #{n} Doe"}
-Fabricate.sequence(:word) {|n| "word#{n}"}
+Fabricate.sequence(:name) { |n| "John #{n} Doe" }
+Fabricate.sequence(:word) { |n| "word#{n}" }
 Fabricator :user do
   name                  'Clyde Frog'
-  email                 { sequence(:user_email) {|n| "user.#{n}@example.com"} }
+  email                 { sequence(:user_email) { |n| "user.#{n}@example.com" } }
   password              'password'
   password_confirmation 'password'
 end
@@ -57,7 +57,7 @@ describe ProblemMerge do
       it 'merge comment' do
         expect {
           problem_merge.merge
-        }.to change{
+        }.to change {
           problem.comments.size
         }.from(1).to(2)
         expect(comment_2.reload.err).to eq problem
@@ -17,7 +17,7 @@ describe UserDestroy do
     it 'should delete watcher' do
       expect {
         UserDestroy.new(user).destroy
-      }.to change{
+      }.to change {
         app.reload.watchers.where(:user_id => user.id).count
       }.from(1).to(0)
     end
@@ -85,7 +85,7 @@ describe Mailer do
     end
  
     context 'with a very long message' do
-      let(:notice)  { Fabricate(:notice, :message => 6.times.collect{|_a| "0123456789" }.join('')) }
+      let(:notice)  { Fabricate(:notice, :message => 6.times.collect { |_a| "0123456789" }.join('')) }
       it "should truncate the long message" do
         expect(email.subject).to match(/ \d{47}\.{3}$/)
       end
@@ -99,7 +99,7 @@ describe Mailer do
     let!(:notice) { Fabricate(:notice) }
     let!(:comment) { Fabricate(:comment, :err => notice.problem) }
     let!(:watcher) { Fabricate(:watcher, :app => comment.app) }
-    let(:recipients) { ['recipient@example.com', 'another@example.com']}
+    let(:recipients) { ['recipient@example.com', 'another@example.com'] }
  
     before do
       expect(comment).to receive(:notification_recipients).and_return(recipients)
@@ -17,20 +17,20 @@ describe Deploy, type: &#39;model&#39; do
     context 'when the app has resolve_errs_on_deploy set to false' do
       it 'should not resolve the apps errs' do
         app = Fabricate(:app, :resolve_errs_on_deploy => false)
-        @problems = 3.times.map{Fabricate(:err, :problem => Fabricate(:problem, :resolved => false, :app => app))}
+        @problems = 3.times.map { Fabricate(:err, :problem => Fabricate(:problem, :resolved => false, :app => app)) }
         Fabricate(:deploy, :app => app)
-        expect(app.reload.problems.none?{|problem| problem.resolved?}).to eq true
+        expect(app.reload.problems.none? { |problem| problem.resolved? }).to eq true
       end
     end
  
     context 'when the app has resolve_errs_on_deploy set to true' do
       it 'should resolve the apps errs that were in the same environment' do
         app = Fabricate(:app, :resolve_errs_on_deploy => true)
-        @prod_errs = 3.times.map{Fabricate(:problem, :resolved => false, :app => app, :environment => 'production')}
-        @staging_errs = 3.times.map{Fabricate(:problem, :resolved => false, :app => app, :environment => 'staging')}
+        @prod_errs = 3.times.map { Fabricate(:problem, :resolved => false, :app => app, :environment => 'production') }
+        @staging_errs = 3.times.map { Fabricate(:problem, :resolved => false, :app => app, :environment => 'staging') }
         Fabricate(:deploy, :app => app, :environment => 'production')
-        expect(@prod_errs.all?{|problem| problem.reload.resolved?}).to eq true
-        expect(@staging_errs.all?{|problem| problem.reload.resolved?}).to eq false
+        expect(@prod_errs.all? { |problem| problem.reload.resolved? }).to eq true
+        expect(@staging_errs.all? { |problem| problem.reload.resolved? }).to eq false
       end
     end
   end
@@ -17,7 +17,7 @@ module Airbrake
 end
  
 describe ErrorReport do
-  let(:xml){
+  let(:xml) {
     Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice.xml').read
   }
  
@@ -52,7 +52,7 @@ describe ErrorReport do
     end
  
     context "with a minimal notice" do
-      let(:xml){
+      let(:xml) {
         Rails.root.join('spec', 'fixtures', 'minimal_test_notice.xml').read
       }
  
@@ -237,7 +237,7 @@ describe ErrorReport do
     end
  
     context "with xml without request section" do
-      let(:xml){
+      let(:xml) {
         Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice_without_request_section.xml').read
       }
       it "save a notice" do
@@ -250,7 +250,7 @@ describe ErrorReport do
     end
  
     context "with xml with only a single line of backtrace" do
-      let(:xml){
+      let(:xml) {
         Rails.root.join('spec', 'fixtures', 'hoptoad_test_notice_with_one_line_of_backtrace.xml').read
       }
       it "save a notice" do
@@ -102,7 +102,7 @@ describe &quot;Callback on Notice&quot;, type: &#39;model&#39; do
   end
  
   describe 'send email when notification service is configured but fails' do
-    let(:notification_service) {Fabricate(:campfire_notification_service)}
+    let(:notification_service) { Fabricate(:campfire_notification_service) }
     let(:app) do
       Fabricate(
         :app_with_watcher,
@@ -130,7 +130,7 @@ describe &quot;Callback on Notice&quot;, type: &#39;model&#39; do
   describe 'should not send a notification if a notification service is not' \
            'configured' do
     let(:notification_service) { Fabricate(:notification_service) }
-    let(:app) { Fabricate(:app, notification_service: notification_service)}
+    let(:app) { Fabricate(:app, notification_service: notification_service) }
     let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
  
     before { Errbit::Config.per_app_notify_at_notices = true }
@@ -10,7 +10,7 @@ describe Problem, type: &#39;model&#39; do
   describe "Fabrication" do
     context "Fabricate(:problem)" do
       it 'should have no comment' do
-        expect{
+        expect {
           Fabricate(:problem)
         }.to_not change(Comment, :count)
       end
@@ -18,7 +18,7 @@ describe Problem, type: &#39;model&#39; do
  
     context "Fabricate(:problem_with_comments)" do
       it 'should have 3 comments' do
-        expect{
+        expect {
           Fabricate(:problem_with_comments)
         }.to change(Comment, :count).by(3)
       end
@@ -26,7 +26,7 @@ describe Problem, type: &#39;model&#39; do
  
     context "Fabricate(:problem_with_errs)" do
       it 'should have 3 errs' do
-        expect{
+        expect {
           Fabricate(:problem_with_errs)
         }.to change(Err, :count).by(3)
       end
@@ -280,7 +280,7 @@ describe Problem, type: &#39;model&#39; do
       Fabricate(:notice, :err => @err, :message => 'ERR 1')
       @problem.messages = {}
       @problem.save!
-      expect {@err.notices.first.destroy}.not_to raise_error
+      expect { @err.notices.first.destroy }.not_to raise_error
     end
   end
  
@@ -412,7 +412,7 @@ describe Problem, type: &#39;model&#39; do
     it 'update the notice_count' do
       expect {
         problem.recache
-      }.to change{
+      }.to change {
         problem.notices_count
       }.from(0).to(1)
     end
@@ -30,7 +30,7 @@ require &#39;errbit_plugin/mock_issue_tracker&#39;
  
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 Mongoid::Config.truncate!
 Mongoid::Tasks::Database.create_indexes
 ActionMailer::Base.delivery_method = :test
@@ -113,7 +113,7 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
       end
  
       context "without issue tracker associate on app" do
-        let(:problem){ Problem.new(:new_record => false, :app => app) }
+        let(:problem) { Problem.new(:new_record => false, :app => app) }
         let(:app) { App.new(:new_record => false) }
  
         it 'not see link to create issue' do
@@ -129,7 +129,7 @@ describe &quot;problems/show.html.haml&quot;, type: &#39;view&#39; do
  
         context "with app having github_repo" do
           let(:app) { App.new(:new_record => false, :github_repo => 'foo/bar') }
-          let(:problem){ Problem.new(:new_record => false, :app => app) }
+          let(:problem) { Problem.new(:new_record => false, :app => app) }
  
           before do
             problem.issue_link = nil
...	...	@@ -270,18 +270,6 @@ Style/SingleSpaceBeforeFirstArg:
270	270	- 'spec/fabricators/notice_fabricator.rb'
271	271	- 'spec/fabricators/user_fabricator.rb'
272	272
273		-# Offense count: 27
274		-# Cop supports --auto-correct.
275		-# Configuration parameters: EnforcedStyle, SupportedStyles.
276		-Style/SpaceBeforeBlockBraces:
277		- Enabled: false
278		-
279		-# Offense count: 75
280		-# Cop supports --auto-correct.
281		-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
282		-Style/SpaceInsideBlockBraces:
283		- Enabled: false
284		-
285	273	# Offense count: 873
286	274	# Cop supports --auto-correct.
287	275	# Configuration parameters: EnforcedStyle, SupportedStyles.
...	...
...	...	@@ -39,7 +39,7 @@ class AppsController < ApplicationController
39	39	}
40	40
41	41	expose(:users) {
42		- User.all.sort_by {\|u\| u.name.downcase }
	42	+ User.all.sort_by { \|u\| u.name.downcase }
43	43	}
44	44
45	45	def index; end
...	...	@@ -96,7 +96,7 @@ protected
96	96	# set the app's notification service
97	97	if params[:app][:notification_service_attributes] && (notification_type = params[:app][:notification_service_attributes][:type])
98	98	available_notification_classes = [NotificationService] + NotificationService.subclasses
99		- notification_class = available_notification_classes.detect{\|c\| c.name == notification_type}
	99	+ notification_class = available_notification_classes.detect { \|c\| c.name == notification_type }
100	100	if notification_class.present?
101	101	app.notification_service = notification_class.new(params[:app][:notification_service_attributes])
102	102	end
...	...	@@ -116,7 +116,7 @@ protected
116	116	# Sanitize negative values, split on comma,
117	117	# strip, parse as integer, remove all '0's.
118	118	# If empty, set as default and show an error message.
119		- email_at_notices = val.gsub(/-\d+/, "").split(",").map{\|v\| v.strip.to_i }.reject{\|v\| v == 0}
	119	+ email_at_notices = val.gsub(/-\d+/, "").split(",").map { \|v\| v.strip.to_i }.reject { \|v\| v == 0 }
120	120	if email_at_notices.any?
121	121	params[:app][:email_at_notices] = email_at_notices
122	122	else
...	...	@@ -131,7 +131,7 @@ protected
131	131	# Sanitize negative values, split on comma,
132	132	# strip, parse as integer, remove all '0's.
133	133	# If empty, set as default and show an error message.
134		- notify_at_notices = val.gsub(/-\d+/, "").split(",").map{\|v\| v.strip.to_i }
	134	+ notify_at_notices = val.gsub(/-\d+/, "").split(",").map { \|v\| v.strip.to_i }
135	135	if notify_at_notices.any?
136	136	params[:app][:notification_service_attributes][:notify_at_notices] = notify_at_notices
137	137	else
...	...
...	...	@@ -13,7 +13,7 @@ module ProblemsSearcher
13	13	end
14	14	}
15	15
16		- expose(:params_order){
	16	+ expose(:params_order) {
17	17	unless %w{asc desc}.member?(params[:order])
18	18	'desc'
19	19	else
...	...
...	...	@@ -65,7 +65,7 @@ protected
65	65	def user_permit_params
66	66	@user_permit_params \|\|= [:name, :username, :email, :github_login, :per_page, :time_zone]
67	67	@user_permit_params << :admin if current_user.admin? && current_user.id != params[:id]
68		- @user_permit_params \|= [:password, :password_confirmation] if user_password_params.values.all?{\|pa\| !pa.blank? }
	68	+ @user_permit_params \|= [:password, :password_confirmation] if user_password_params.values.all? { \|pa\| !pa.blank? }
69	69	@user_permit_params
70	70	end
71	71
...	...
...	...	@@ -56,8 +56,8 @@ module ApplicationHelper
56	56	def create_percentage_table_from_tallies(tallies, options = {})
57	57	total = (options[:total] \|\| total_from_tallies(tallies))
58	58	percent = 100.0 / total.to_f
59		- rows = tallies.map {\|value, count\| [(count.to_f * percent), value]}. \
60		- sort {\|a, b\| b[0] <=> a[0]}
	59	+ rows = tallies.map { \|value, count\| [(count.to_f * percent), value] }. \
	60	+ sort { \|a, b\| b[0] <=> a[0] }
61	61	render "problems/tally_table", :rows => rows
62	62	end
63	63
...	...
...	...	@@ -4,8 +4,8 @@ module AppsHelper
4	4	html = link_to('copy settings from another app', '#',
5	5	:class => 'button copy_config')
6	6	html << select("duplicate", "app",
7		- App.all.asc(:name).reject{\|a\| a == @app }.
8		- collect{\|p\| [p.name, p.id] }, { :include_blank => "[choose app]" },
	7	+ App.all.asc(:name).reject { \|a\| a == @app }.
	8	+ collect { \|p\| [p.name, p.id] }, { :include_blank => "[choose app]" },
9	9	{ :class => "choose_other_app", :style => "display: none;" })
10	10	return html
11	11	end
...	...
...	...	@@ -19,7 +19,7 @@ module NavigationHelper
19	19	matches
20	20	when Array
21	21	s = {}
22		- matches.each {\|c\| s[c] = :all}
	22	+ matches.each { \|c\| s[c] = :all }
23	23	s
24	24	else
25	25	{ matches => :all }
...	...
...	...	@@ -20,7 +20,7 @@ class ProblemDestroy
20	20	# the number of problem destroy
21	21	#
22	22	def self.execute(problems)
23		- Array(problems).each{ \|problem\|
	23	+ Array(problems).each { \|problem\|
24	24	ProblemDestroy.new(problem).execute
25	25	}.count
26	26	end
...	...
...	...	@@ -21,7 +21,7 @@ class App
21	21	field :_id,
22	22	type: String,
23	23	pre_processed: true,
24		- default: ->{ BSON::ObjectId.new.to_s }
	24	+ default: -> { BSON::ObjectId.new.to_s }
25	25
26	26	embeds_many :watchers
27	27	embeds_many :deploys
...	...
...	...	@@ -19,7 +19,7 @@ class Deploy
19	19	validates_presence_of :username, :environment
20	20
21	21	def resolve_app_errs
22		- app.problems.unresolved.in_env(environment).each {\|problem\| problem.resolve!}
	22	+ app.problems.unresolved.in_env(environment).each { \|problem\| problem.resolve! }
23	23	end
24	24
25	25	def short_revision
...	...