Refs #913 remove deployment tracking feature

Stephen Crosby
1 parent b07aceec
Showing 34 changed files with 10 additions and 522 deletions Show diff stats
README.md
app/assets/javascripts/apps.show.js
app/assets/stylesheets/errbit.css.erb
app/controllers/apps_controller.rb
app/controllers/deploys_controller.rb
app/controllers/problems_searcher.rb
app/helpers/application_helper.rb
app/helpers/apps_helper.rb
app/mailers/mailer.rb
app/models/app.rb
app/models/deploy.rb
app/models/problem.rb
app/views/apps/_fields.html.haml
app/views/apps/index.html.haml
app/views/apps/show.html.haml
app/views/deploys/_table.html.haml
app/views/deploys/index.html.haml
app/views/deploys/index.ics.haml
app/views/mailer/deploy_notification.html.haml
app/views/mailer/deploy_notification.text.erb
@@ -80,10 +80,6 @@ Configuration
 Errbit configuration is done entirely through environment variables. See
 [configuration](docs/configuration.md)
-Deploy Hooks
--------------
-Errbit can track your application deploys. See [deploy hooks](docs/deploy-hooks.md)
-
 Deployment
 ----------
 See [notes on deployment](docs/deployment.md)
@@ -8,7 +8,4 @@ $(function() {
     $("#repository_div").slideToggle("slow");
   });
-  $("#deploys_toggle").click(function() {
-    $("#deploys_div").slideToggle("slow");
-  });
 });
@@ -619,7 +619,7 @@ table.apps td.name, table.errs td.message { width: 100%; }
 table.apps td { padding: 16px 20px; }
 table.apps th { padding: 10px 20px; }
-table.apps td.issue_tracker, table.apps td.count, table.apps td.deploy {
+table.apps td.issue_tracker, table.apps td.count {
   text-align: center;
 }
 table.apps td.issue_tracker, table.apps td.count {
@@ -631,9 +631,6 @@ td.message .line {
   display:inline-block;
   margin-left:1em;
 }
-td.deploy {
-  white-space: nowrap;
-}
 td.latest {
   white-space: nowrap;
 }
@@ -719,11 +716,6 @@ table.tally th.value {
   text-transform: none;
 }
-/* Deploys table */
-table.deploys td.when {
-  width: 102px;
-}
-
 /* Resolve Errs */
 #action-bar .resolve:before {
   font-family: FontAwesome;
@@ -854,7 +846,7 @@ table.backtrace tr.padding th, table.backtrace tr.padding td {
   padding: 0;
 }
-h3#watchers_toggle, h3#repository_toggle, h3#deploys_toggle {
+h3#watchers_toggle, h3#repository_toggle {
   cursor: pointer;
 }
@@ -862,7 +854,7 @@ span.click_span {
   font-size: 0.7em;
 }
-#deploys_div, #repository_div, #watchers_div {
+#repository_div, #watchers_div {
   display: none;
 }
@@ -34,10 +34,6 @@ class AppsController &lt; ApplicationController
     end
   end
-  expose(:deploys) do
-    app.deploys.order_by(:created_at.desc).limit(5)
-  end
-
   expose(:users) do
     User.all.sort_by { |u| u.name.downcase }
   end
@@ -1,42 +0,0 @@
-class DeploysController < ApplicationController
-  protect_from_forgery except: :create
-
-  skip_before_action :verify_authenticity_token, only: :create
-  skip_before_action :authenticate_user!, only: :create
-
-  def create
-    @app = App.find_by_api_key!(params[:api_key])
-    @deploy = @app.deploys.create!(default_deploy || heroku_deploy)
-    render xml: @deploy
-  end
-
-  def index
-    @app = App.find(params[:app_id])
-    @deploys = Kaminari.paginate_array(@app.deploys.order_by(:created_at.desc)).
-      page(params[:page]).per(10)
-  end
-
-private
-
-  def default_deploy
-    return if params[:deploy].blank?
-
-    {
-      username:    params[:deploy][:local_username],
-      environment: params[:deploy][:rails_env],
-      repository:  params[:deploy][:scm_repository],
-      revision:    params[:deploy][:scm_revision],
-      message:     params[:deploy][:message]
-    }
-  end
-
-  # handle Heroku's HTTP post deployhook format
-  def heroku_deploy
-    {
-      username:    params[:user],
-      environment: params[:rack_env].try(:downcase) || params[:app],
-      repository:  "git@heroku.com:#{params[:app]}.git",
-      revision:    params[:head]
-    }
-  end
-end
@@ -6,7 +6,7 @@ module ProblemsSearcher
   included do
     expose(:params_sort) do
-      if %w(app message last_notice_at last_deploy_at count).member?(params[:sort])
+      if %w(app message last_notice_at count).member?(params[:sort])
         params[:sort]
       else
         "last_notice_at"
@@ -19,21 +19,6 @@ module ApplicationHelper
     end.to_s
   end
-  def generate_ical(deploys)
-    RiCal.Calendar do |cal|
-      deploys.each_with_index do |deploy, idx|
-        cal.event do |event|
-          event.summary     = "#{idx + 1} #{deploy.repository}"
-          event.description = deploy.revision.to_s
-          event.dtstart     = deploy.created_at.utc
-          event.dtend       = deploy.created_at.utc + 60.minutes
-          event.location    = deploy.environment.to_s
-          event.organizer   = deploy.username.to_s
-        end
-      end
-    end.to_s
-  end
-
   def user_agent_graph(problem)
     create_percentage_table_for(problem.user_agents)
   end
@@ -31,19 +31,13 @@ module AppsHelper
     @any_issue_trackers
   end
-  def any_deploys?
-    detect_any_apps_with_attributes if @any_deploys.nil?
-    @any_deploys
-  end
-
   private def detect_any_apps_with_attributes
-    @any_github_repos = @any_issue_trackers = @any_deploys = @any_bitbucket_repos = @any_notification_services = false
+    @any_github_repos = @any_issue_trackers = @any_bitbucket_repos = @any_notification_services = false
     apps.each do |app|
       @any_github_repos          ||= app.github_repo?
       @any_bitbucket_repos       ||= app.bitbucket_repo?
       @any_issue_trackers        ||= app.issue_tracker_configured?
-      @any_deploys               ||= app.last_deploy_at.present?
       @any_notification_services ||= app.notification_service_configured?
     end
   end
@@ -27,19 +27,6 @@ class Mailer &lt; ActionMailer::Base
          subject: "#{count}[#{@app.name}][#{@notice.environment_name}] #{@notice.message.truncate(50)}"
   end
-  def deploy_notification(deploy)
-    @deploy = deploy
-    @app = AppDecorator.new deploy.app
-
-    errbit_headers 'App'             => @app.name,
-                   'Environment'     => @deploy.environment,
-                   'Deploy-Revision' => @deploy.revision,
-                   'Deploy-User'     => @deploy.username
-
-    mail to:      @app.notification_recipients,
-         subject: "[#{@app.name}] Deployed to #{@deploy.environment} by #{@deploy.username}"
-  end
-
   def comment_notification(comment)
     @comment  = comment
     @user     = comment.user
@@ -10,10 +10,8 @@ class App
   field :asset_host
   field :repository_branch
   field :current_app_version
-  field :resolve_errs_on_deploy, type: Boolean, default: false
   field :notify_all_users, type: Boolean, default: false
   field :notify_on_errs, type: Boolean, default: true
-  field :notify_on_deploys, type: Boolean, default: false
   field :email_at_notices, type: Array, default: Errbit::Config.email_at_notices
   # Some legacy apps may have string as key instead of BSON::ObjectID
@@ -24,7 +22,6 @@ class App
     default:       -> { BSON::ObjectId.new.to_s }
   embeds_many :watchers
-  embeds_many :deploys
   embeds_one :issue_tracker, class_name: 'IssueTracker'
   embeds_one :notification_service
   embeds_one :notice_fingerprinter, autobuild: true
@@ -86,11 +83,7 @@ class App
     find_by(api_key: key)
   end
-  def last_deploy_at
-    (last_deploy = deploys.last) && last_deploy.created_at
-  end
-
-  # Legacy apps don't have notify_on_errs and notify_on_deploys params
+  # Legacy apps don't have notify_on_errs param
   def notify_on_errs
     !(super == false)
   end
@@ -100,11 +93,6 @@ class App
     notify_on_errs? && notification_recipients.any?
   end
-  def notify_on_deploys
-    !(super == false)
-  end
-  alias_method :notify_on_deploys?, :notify_on_deploys
-
   def repo_branch
     repository_branch.present? ? repository_branch : 'master'
   end
@@ -159,7 +147,7 @@ class App
     (copy_app.fields.keys - %w(_id name created_at updated_at)).each do |k|
       send("#{k}=", copy_app.send(k))
     end
-    # Clone the embedded objects that can be changed via apps/edit (ignore errs & deploys, etc.)
+    # Clone the embedded objects that can be changed via apps/edit (ignore errs, etc.)
     %w(watchers issue_tracker notification_service).each do |relation|
       if (obj = copy_app.send(relation))
         send("#{relation}=", obj.is_a?(Array) ? obj.map(&:clone) : obj.clone)
@@ -1,46 +0,0 @@
-class Deploy
-  include Mongoid::Document
-  include Mongoid::Timestamps
-
-  field :username
-  field :repository
-  field :environment
-  field :revision
-  field :message
-
-  index(created_at: -1)
-
-  embedded_in :app, inverse_of: :deploys
-
-  after_create :resolve_app_errs, if: :should_resolve_app_errs?
-  after_create :store_cached_attributes_on_problems
-  after_create :deliver_email
-
-  validates :username, :environment, presence: true
-
-  def resolve_app_errs
-    app.problems.unresolved.in_env(environment).each(&:resolve!)
-  end
-
-  def short_revision
-    revision.to_s[0, 7]
-  end
-
-protected
-
-  def should_resolve_app_errs?
-    app.resolve_errs_on_deploy?
-  end
-
-  def store_cached_attributes_on_problems
-    Problem.where(app_id: app.id).update_all(
-      last_deploy_at: created_at
-    )
-  end
-
-  def deliver_email
-    if app.notify_on_deploys? && app.notification_recipients.any?
-      Mailer.deploy_notification(self).deliver_now
-    end
-  end
-end
@@ -14,7 +14,6 @@ class Problem
   field :last_notice_at, type: ActiveSupport::TimeWithZone, default: proc { Time.zone.now }
   field :first_notice_at, type: ActiveSupport::TimeWithZone, default: proc { Time.zone.now }
-  field :last_deploy_at, type: Time
   field :resolved, type: Boolean, default: false
   field :resolved_at, type: Time
   field :issue_link, type: String
@@ -37,7 +36,6 @@ class Problem
   index message: 1
   index last_notice_at: 1
   index first_notice_at: 1
-  index last_deploy_at: 1
   index resolved_at: 1
   index notices_count: 1
@@ -216,17 +214,13 @@ class Problem
     when "app"            then order_by(["app_name", order])
     when "message"        then order_by(["message", order])
     when "last_notice_at" then order_by(["last_notice_at", order])
-    when "last_deploy_at" then order_by(["last_deploy_at", order])
     when "count"          then order_by(["notices_count", order])
     else fail("\"#{sort}\" is not a recognized sort")
     end
   end
   def cache_app_attributes
-    if app
-      self.app_name = app.name
-      self.last_deploy_at = app.last_deploy_at
-    end
+    self.app_name = app.name if app
   end
   def truncate_message
@@ -36,17 +36,10 @@
       .field-helpertext Send a notification every
       = f.text_field :email_at_notices, :value => app_decorate.email_at_notices
       .field-helpertext times an error occurs (comma separated).
-  %div.checkbox
-    = f.check_box :notify_on_deploys
-    = f.label :notify_on_deploys, 'Notify on deploys'
 %div.checkbox
   = f.check_box :notify_all_users
   = f.label :notify_all_users, 'Send notifications to all users'
-%div.checkbox
-  = f.check_box :resolve_errs_on_deploy
-  = f.label :resolve_errs_on_deploy, 'Resolve errs on deploy'
-
 = render "issue_tracker_fields", :f => f
 = render "service_notification_fields", :f => f
@@ -16,8 +16,6 @@
         %th= t('.notify')
       - if any_issue_trackers?
         %th= t('.tracker')
-      - if any_deploys?
-        %th= t('.last_deploy')
       %th=t('.errors')
   %tbody
     - apps.each do |app|
@@ -45,11 +43,6 @@
                 = link_to( tracker_img, app.issue_tracker.url )
               - else
                 = tracker_img
-        - if any_deploys?
-          %td.deploy
-            - if app.last_deploy_at
-              - revision = app.deploys.last.short_revision
-              = link_to( app.last_deploy_at.to_s(:micro) << (revision.present? ? " (#{revision})" : ""), app_deploys_path(app))
         %td.count
           - if app.problem_count > 0
             - unresolved = app.unresolved_count
@@ -7,8 +7,6 @@
     = app.current_app_version
   %strong=t('.errors_caught')
   = app.problems.count
-  %strong=t('.deploy_count')
-  = app.deploys.count
   %strong=t('.api_key')
   = app.api_key
 - content_for :action_bar do
@@ -60,34 +58,6 @@
         %tr
           %td= link_to(app.github_repo, app.github_url, :target => '_blank')
-%h3#deploys_toggle
-  =t('.latest_deploys')
-  %span.click_span=t('.show_hide')
-#deploys_div
-  - if deploys.any?
-    %table.deploys
-      %thead
-        %tr
-          %th=t('.when')
-          %th=t('.environment')
-          %th=t('.who')
-          %th=t('.message')
-          %th=t('.repository')
-          %th=t('.revision')
-
-      %tbody
-        - deploys.each do |deploy|
-          %tr
-            %td.when #{deploy.created_at.to_s(:micro)}
-            %td.environment #{deploy.environment}
-            %td.who #{deploy.username}
-            %td.message #{deploy.message}
-            %td.repository #{deploy.repository}
-            %td.revision #{deploy.short_revision}
-    = link_to t('.all_deploys', :count => app.deploys.count), app_deploys_path(app), :class => 'button'
-  - else
-    %h3=t('.no_deploys')
-
 - if app.problems.any?
   %h3.clear=t('.errors')
   %section
@@ -1,21 +0,0 @@
-%table.errs
-  %thead
-    %tr
-      %th App
-      %th When
-      %th Who
-      %th Message
-      %th Repository
-      %th Revision
-  %tbody
-    - deploys.each do |deploy|
-      %tr
-        %td.app
-          = deploy.app.name
-          %span.environment= deploy.environment
-        %td.latest= deploy.created_at.to_s(:micro)
-        %td.who= deploy.username
-        %td.message= deploy.message
-        %td.repository= deploy.repository
-        %td.revision= deploy.short_revision
-
@@ -1,10 +0,0 @@
-- content_for :title, 'Deploys'
-- content_for :action_bar do
-  - if current_user.authentication_token
-    %span
-      = link_to app_deploys_path(@app, :format => "ics", :auth_token => current_user.authentication_token) do
-        %i.fa.fa-calendar
-        iCal
-= render 'table', :deploys => @deploys
-= paginate @deploys
-
@@ -1 +0,0 @@
-= generate_ical(@app.deploys.order_by(:created_at.asc))
@@ -1,30 +0,0 @@
-%tr
-  %td.section
-    %table(cellpadding="0" cellspacing="0" border="0" align="left")
-      %tbody
-        %tr
-          %td.content(valign="top")
-            %div
-              %p
-                = link_to(@app.name, app_url(@app), :class => "bold")
-                was just deployed to
-                %span.bold= @deploy.environment
-                by
-                %span.bold= @deploy.username + "."
-
-%tr
-  %td.section
-    %table(cellpadding="0" cellspacing="0" border="0" align="left")
-      %tbody
-        %tr
-          %td.content(valign="top")
-            %div
-              %p.heading REVISION:
-              %p= @deploy.revision
-              %p.heading MESSAGE:
-              %p= @deploy.message.blank? ? 'n/a' : @deploy.message
-              %p.heading WHEN:
-              %p= @deploy.created_at.to_s(:rfc822)
-              %p.heading REPOSITORY:
-              %p= @deploy.repository.blank? ? 'n/a' : link_to(nil, @deploy.repository)
-
@@ -1,22 +0,0 @@
-<%= @app.name %> was just deployed to <%= @deploy.environment %> by <%= @deploy.username %>.
-
-
-REVISION:
-
-<%= @deploy.revision %>
-
-
-MESSAGE:
-
-<%= @deploy.message.blank? ? 'n/a' : @deploy.message %>
-
-
-WHEN:
-
-<%= @deploy.created_at.to_s(:rfc822) %>
-
-
-REPOSITORY:
-
-<%= @deploy.repository.blank? ? 'n/a' : @deploy.repository %>
-
@@ -7,7 +7,6 @@
         %th= link_for_sort "App"
         %th= link_for_sort "What &amp; Where".html_safe, "message"
         %th= link_for_sort "Latest", "last_notice_at"
-        %th= link_for_sort "Deploy", "last_deploy_at"
         %th= link_for_sort "Count"
         - if any_issue_links
           %th Issue
@@ -34,7 +33,6 @@
                   %em.commenter= (Errbit::Config.user_has_username ? comment.user.username : comment.user.email).to_s << ":"
                 %em= truncate(comment.body, :length => 100, :separator => ' ')
           %td.latest #{time_ago_in_words(problem.last_notice_at)} ago
-          %td.deploy= problem.last_deploy_at ? problem.last_deploy_at.to_s(:micro) : 'n/a'
           %td.count= link_to problem.notices_count, app_problem_path(problem.app, problem)
           - if any_issue_links
             %td.issue_link
@@ -3,6 +3,6 @@ if Errbit::Config.enforce_ssl
   require 'rack/ssl-enforcer'
   ActionMailer::Base.default_url_options.merge!(protocol: 'https://')
   Rails.application.configure do
-    config.middleware.use Rack::SslEnforcer, except: %r{^/deploys}
+    config.middleware.use Rack::SslEnforcer
   end
 end
@@ -92,7 +92,6 @@ en:
     index:
       notify: Notification Service
       tracker: Tracker
-      last_deploy: Last Deploy
       errors: Errors
       name: Name
       repository: Repository
@@ -103,21 +102,17 @@ en:
     fields:
       regenerate_api_key: "Regenerate API key"
     show:
-      all_deploys: "All Deploys (%{count})"
       all_errs: all errors
       all_users_notified: "All users will be notified when something happens."
       api_key: "API Key:"
       are_you_sure: 'Are you sure?'
       atom_title: "Errbit notices for %{name} at %{host}"
-      deploy_count: "Deploy Count:"
       edit: edit
       environment: Environment
       errors: Errors
       errors_caught: "Errors Caught:"
       github_repo: GitHub Repo
-      latest_deploys: Latest Deploys
       message: Message
-      no_deploys:  No deploys
       no_error_yet: "No errors have been caught yet, make sure you setup your app"
       no_watcher: "Sadly, no one is watching this app"
       repository: Repository
@@ -4,10 +4,8 @@ Rails.application.routes.draw do
   # Hoptoad Notifier Routes
   match '/notifier_api/v2/notices' => 'notices#create', via: [:get, :post]
   get '/locate/:id' => 'notices#locate', :as => :locate
-  post '/deploys.txt' => 'deploys#create'
   resources :notices,   only: [:show]
-  resources :deploys,   only: [:show]
   resources :users do
     member do
       delete :unlink_github
@@ -47,7 +45,6 @@ Rails.application.routes.draw do
         delete :unlink_issue
       end
     end
-    resources :deploys, only: [:index]
     resources :watchers, only: [:destroy, :update]
     member do
       post :regenerate_api_key
@@ -1,47 +0,0 @@
-# Deploy Hooks
-Errbit can track your application deploys if you send a special message to
-Errbit whenever you deploy.
-
-## From heroku
-If you're using heroku, you can add a deploy hook like this:
-~~~bash
-$ heroku addons:add deployhooks:http \
-  --url=http://myerrbit.com/deploys.txt
-~~~
-
-## From the airbrake gem using the rake task
-The airbrake gem comes with a nice rake task for sending deploy hooks. Assuming
-you already have it configured, you can send hooks like this:
-~~~bash
-$ TO=env-name \
-  REVISION=rev-string \
-  REPO=repo-string \
-  USER=user-string \
-  rake airbrake:deploy
-~~~
-
-## From the airbrake gem using capistrano 3
-In your application's Capfile, insert:
-~~~ruby
-require 'airbrake/capistrano3'
-~~~
-
-This will add a new capistrano task named ```airbrake:deploy``` which ends up
-calling ```rake airbrake:deploy``` with the values from your capistrano config.
-You may need to set the ```API_KEY``` environment variable on the target
-application.
-
-## From curl
-Errbit supports sending a message along with your deploy hook. The airbrake gem
-doesn't support this, but you can easily send it along yourself. Here's an
-example using cURL:
-~~~bash
-$ curl https://myerrbit.com/deploys.txt \
-  --data "api_key=406e4374bf508ad0d7732c2d35ed380d" \
-  --data "app_id=cb71ca8429732ba86b90d57c" \
-  --data "deploy[local_username]=user-string" \
-  --data "deploy[rails_env]=env-name" \
-  --data "deploy[scm_repository]=repo-string" \
-  --data "deploy[scm_revision]=rev-string" \
-  --data "deploy[message]=my-message"
-~~~
@@ -75,8 +75,3 @@ Option 3. Clear resolved errors manually:
 ```bash
 heroku run rake errbit:db:clear_resolved
 ```
-
-### Add the deployment hook
-```bash
-heroku addons:create deployhooks:http --url="http://YOUR_ERRBIT_HOST/deploys.txt?api_key=YOUR_API_KEY"
-```
@@ -1,57 +0,0 @@
-describe DeploysController, type: 'controller' do
-  render_views
-
-  context 'POST #create' do
-    before do
-      @params = {
-        'local_username' => 'john.doe',
-        'scm_repository' => 'git@github.com/errbit/errbit.git',
-        'rails_env'      => 'production',
-        'scm_revision'   => '19d77837eef37902cf5df7e4445c85f392a8d0d5',
-        'message'        => 'johns first deploy'
-      }
-      @app = Fabricate(:app_with_watcher, notify_on_deploys: true, api_key: 'APIKEY')
-    end
-
-    it 'finds the app via the api key' do
-      expect(App).to receive(:find_by_api_key!).with('APIKEY').and_return(@app)
-      post :create, deploy: @params, api_key: 'APIKEY'
-    end
-
-    it 'creates a deploy' do
-      expect(App).to receive(:find_by_api_key!).and_return(@app)
-      expect(@app.deploys).to receive(:create!).
-        with(
-          username:    'john.doe',
-          environment: 'production',
-          repository:  'git@github.com/errbit/errbit.git',
-          revision:    '19d77837eef37902cf5df7e4445c85f392a8d0d5',
-          message:     'johns first deploy').and_return(Fabricate(:deploy))
-      post :create, deploy: @params, api_key: 'APIKEY'
-    end
-
-    it 'sends an email notification when configured to do so' do
-      post :create, deploy: @params, api_key: 'APIKEY'
-      email = ActionMailer::Base.deliveries.last
-      expect(email.to).to include(@app.watchers.first.email)
-      expect(email.subject).to eq "[#{@app.name}] Deployed to production by john.doe"
-    end
-  end
-
-  context "GET #index" do
-    before(:each) do
-      @deploy = Fabricate :deploy
-      sign_in Fabricate(:admin)
-      get :index, app_id: @deploy.app.id
-    end
-
-    it "should render successfully" do
-      expect(response).to be_success
-    end
-
-    it "should contain info about existing deploy" do
-      expect(response.body).to match(@deploy.short_revision)
-      expect(response.body).to match(@deploy.app.name)
-    end
-  end
-end
@@ -19,11 +19,3 @@ Fabricator(:user_watcher, from: :watcher) do
   user
   watcher_type 'user'
 end
-
-Fabricator(:deploy) do
-  app
-  username 'clyde.frog'
-  repository 'git@github.com/errbit/errbit.git'
-  environment 'production'
-  revision { SecureRandom.hex(10) }
-end
@@ -3,7 +3,7 @@ describe App, type: &#39;model&#39; do
     it { is_expected.to have_field(:_id).of_type(String) }
     it { is_expected.to have_field(:name).of_type(String) }
     it { is_expected.to have_fields(:api_key, :github_repo, :bitbucket_repo, :asset_host, :repository_branch) }
-    it { is_expected.to have_fields(:resolve_errs_on_deploy, :notify_all_users, :notify_on_errs, :notify_on_deploys).of_type(Mongoid::Boolean) }
+    it { is_expected.to have_fields(:notify_all_users, :notify_on_errs).of_type(Mongoid::Boolean) }
     it { is_expected.to have_field(:email_at_notices).of_type(Array).with_default_value_of(Errbit::Config.email_at_notices) }
   end
@@ -1,18 +0,0 @@
-describe "Callback on Deploy", type: 'model' do
-  context 'when a Deploy is saved' do
-    context 'and the app should notify on deploys' do
-      it 'should send an email notification' do
-        expect(Mailer).to receive(:deploy_notification).
-          and_return(double('email', deliver_now: true))
-        Fabricate(:deploy, app: Fabricate(:app_with_watcher, notify_on_deploys: true))
-      end
-    end
-
-    context 'and the app is not set to notify on deploys' do
-      it 'should not send an email notification' do
-        expect(Mailer).to_not receive(:deploy_notification)
-        Fabricate(:deploy, app: Fabricate(:app_with_watcher, notify_on_deploys: false))
-      end
-    end
-  end
-end
@@ -1,41 +0,0 @@
-describe Deploy, type: 'model' do
-  context 'validations' do
-    it 'requires a username' do
-      deploy = Fabricate.build(:deploy, username: nil)
-      expect(deploy).to_not be_valid
-      expect(deploy.errors[:username]).to include("can't be blank")
-    end
-
-    it 'requires an environment' do
-      deploy = Fabricate.build(:deploy, environment: nil)
-      expect(deploy).to_not be_valid
-      expect(deploy.errors[:environment]).to include("can't be blank")
-    end
-  end
-
-  context 'being created' do
-    context 'when the app has resolve_errs_on_deploy set to false' do
-      it 'should not resolve the apps errs' do
-        app = Fabricate(:app, resolve_errs_on_deploy: false)
-        @problems = 3.times.map { Fabricate(:err, problem: Fabricate(:problem, resolved: false, app: app)) }
-        Fabricate(:deploy, app: app)
-        expect(app.reload.problems.none?(&:resolved?)).to eq true
-      end
-    end
-
-    context 'when the app has resolve_errs_on_deploy set to true' do
-      it 'should resolve the apps errs that were in the same environment' do
-        app = Fabricate(:app, resolve_errs_on_deploy: true)
-        @prod_errs = 3.times.map { Fabricate(:problem, resolved: false, app: app, environment: 'production') }
-        @staging_errs = 3.times.map { Fabricate(:problem, resolved: false, app: app, environment: 'staging') }
-        Fabricate(:deploy, app: app, environment: 'production')
-        expect(@prod_errs.all? { |problem| problem.reload.resolved? }).to eq true
-        expect(@staging_errs.all? { |problem| problem.reload.resolved? }).to eq false
-      end
-    end
-  end
-
-  it "should produce a shortened revision with 7 characters" do
-    expect(Deploy.new(revision: "1234567890abcdef").short_revision).to eq "1234567"
-  end
-end
@@ -233,30 +233,6 @@ describe Problem, type: &#39;model&#39; do
     end
   end
-  context "#last_deploy_at" do
-    before do
-      @app = Fabricate(:app)
-      @last_deploy = 10.days.ago
-      Fabricate(:deploy, app: @app, created_at: @last_deploy, environment: "production")
-    end
-
-    it "is set when a problem is created" do
-      problem = Fabricate(:problem, app: @app, environment: "production")
-      assert_equal @last_deploy, problem.last_deploy_at
-    end
-
-    it "is updated when a deploy is created" do
-      problem = Fabricate(:problem, app: @app, environment: "production")
-      next_deploy = 5.minutes.ago
-      expect do
-        @deploy = Fabricate(:deploy, app: @app, created_at: next_deploy)
-        problem.reload
-      end.to change { problem.last_deploy_at.iso8601 }.
-        from(@last_deploy.iso8601).
-        to(next_deploy.iso8601)
-    end
-  end
-
   context "notice messages cache" do
     before do
       @app = Fabricate(:app)
@@ -1,14 +0,0 @@
-describe "apps/index.html.haml", type: 'view' do
-  before do
-    app = stub_model(App, deploys: [stub_model(Deploy, created_at: Time.zone.now, revision: "123456789abcdef")])
-    allow(view).to receive(:apps).and_return([app])
-    allow(controller).to receive(:current_user).and_return(stub_model(User))
-  end
-
-  describe "deploy column" do
-    it "should show the first 7 characters of the revision in parentheses" do
-      render
-      expect(rendered).to match(/\(1234567\)/)
-    end
-  end
-end
@@ -9,7 +9,6 @@ describe &quot;apps/show.html.haml&quot;, type: &#39;view&#39; do
   before do
     allow(view).to receive(:app).and_return(app)
     allow(view).to receive(:all_errs).and_return(false)
-    allow(view).to receive(:deploys).and_return([])
     allow(controller).to receive(:current_user).and_return(user)
   end
	@@ -8,7 +8,4 @@ $(function() {		@@ -8,7 +8,4 @@ $(function() {
8	$("#repository_div").slideToggle("slow");	8	$("#repository_div").slideToggle("slow");
9	});	9	});
10		10
11	- $("#deploys_toggle").click(function() {
12	- $("#deploys_div").slideToggle("slow");
13	- });
14	});	11	});
	@@ -1,42 +0,0 @@	@@ -1,42 +0,0 @@
1	-class DeploysController < ApplicationController
2	- protect_from_forgery except: :create
3	-
4	- skip_before_action :verify_authenticity_token, only: :create
5	- skip_before_action :authenticate_user!, only: :create
6	-
7	- def create
8	- @app = App.find_by_api_key!(params[:api_key])
9	- @deploy = @app.deploys.create!(default_deploy \|\| heroku_deploy)
10	- render xml: @deploy
11	- end
12	-
13	- def index
14	- @app = App.find(params[:app_id])
15	- @deploys = Kaminari.paginate_array(@app.deploys.order_by(:created_at.desc)).
16	- page(params[:page]).per(10)
17	- end
18	-
19	-private
20	-
21	- def default_deploy
22	- return if params[:deploy].blank?
23	-
24	- {
25	- username: params[:deploy][:local_username],
26	- environment: params[:deploy][:rails_env],
27	- repository: params[:deploy][:scm_repository],
28	- revision: params[:deploy][:scm_revision],
29	- message: params[:deploy][:message]
30	- }
31	- end
32	-
33	- # handle Heroku's HTTP post deployhook format
34	- def heroku_deploy
35	- {
36	- username: params[:user],
37	- environment: params[:rack_env].try(:downcase) \|\| params[:app],
38	- repository: "git@heroku.com:#{params[:app]}.git",
39	- revision: params[:head]
40	- }
41	- end
42	-end
	@@ -6,7 +6,7 @@ module ProblemsSearcher		@@ -6,7 +6,7 @@ module ProblemsSearcher
6		6
7	included do	7	included do
8	expose(:params_sort) do	8	expose(:params_sort) do
9	- if %w(app message last_notice_at last_deploy_at count).member?(params[:sort])	9	+ if %w(app message last_notice_at count).member?(params[:sort])
10	params[:sort]	10	params[:sort]
11	else	11	else
12	"last_notice_at"	12	"last_notice_at"
	@@ -19,21 +19,6 @@ module ApplicationHelper		@@ -19,21 +19,6 @@ module ApplicationHelper
19	end.to_s	19	end.to_s
20	end	20	end
21		21
22	- def generate_ical(deploys)
23	- RiCal.Calendar do \|cal\|
24	- deploys.each_with_index do \|deploy, idx\|
25	- cal.event do \|event\|
26	- event.summary = "#{idx + 1} #{deploy.repository}"
27	- event.description = deploy.revision.to_s
28	- event.dtstart = deploy.created_at.utc
29	- event.dtend = deploy.created_at.utc + 60.minutes
30	- event.location = deploy.environment.to_s
31	- event.organizer = deploy.username.to_s
32	- end
33	- end
34	- end.to_s
35	- end
36	-
37	def user_agent_graph(problem)	22	def user_agent_graph(problem)
38	create_percentage_table_for(problem.user_agents)	23	create_percentage_table_for(problem.user_agents)
39	end	24	end
	@@ -27,19 +27,6 @@ class Mailer < ActionMailer::Base		@@ -27,19 +27,6 @@ class Mailer < ActionMailer::Base
27	subject: "#{count}[#{@app.name}][#{@notice.environment_name}] #{@notice.message.truncate(50)}"	27	subject: "#{count}[#{@app.name}][#{@notice.environment_name}] #{@notice.message.truncate(50)}"
28	end	28	end
29		29
30	- def deploy_notification(deploy)
31	- @deploy = deploy
32	- @app = AppDecorator.new deploy.app
33	-
34	- errbit_headers 'App' => @app.name,
35	- 'Environment' => @deploy.environment,
36	- 'Deploy-Revision' => @deploy.revision,
37	- 'Deploy-User' => @deploy.username
38	-
39	- mail to: @app.notification_recipients,
40	- subject: "[#{@app.name}] Deployed to #{@deploy.environment} by #{@deploy.username}"
41	- end
42	-
43	def comment_notification(comment)	30	def comment_notification(comment)
44	@comment = comment	31	@comment = comment
45	@user = comment.user	32	@user = comment.user
	@@ -1,46 +0,0 @@	@@ -1,46 +0,0 @@
1	-class Deploy
2	- include Mongoid::Document
3	- include Mongoid::Timestamps
4	-
5	- field :username
6	- field :repository
7	- field :environment
8	- field :revision
9	- field :message
10	-
11	- index(created_at: -1)
12	-
13	- embedded_in :app, inverse_of: :deploys
14	-
15	- after_create :resolve_app_errs, if: :should_resolve_app_errs?
16	- after_create :store_cached_attributes_on_problems
17	- after_create :deliver_email
18	-
19	- validates :username, :environment, presence: true
20	-
21	- def resolve_app_errs
22	- app.problems.unresolved.in_env(environment).each(&:resolve!)
23	- end
24	-
25	- def short_revision
26	- revision.to_s[0, 7]
27	- end
28	-
29	-protected
30	-
31	- def should_resolve_app_errs?
32	- app.resolve_errs_on_deploy?
33	- end
34	-
35	- def store_cached_attributes_on_problems
36	- Problem.where(app_id: app.id).update_all(
37	- last_deploy_at: created_at
38	- )
39	- end
40	-
41	- def deliver_email
42	- if app.notify_on_deploys? && app.notification_recipients.any?
43	- Mailer.deploy_notification(self).deliver_now
44	- end
45	- end
46	-end
	@@ -7,8 +7,6 @@		@@ -7,8 +7,6 @@
7	= app.current_app_version	7	= app.current_app_version
8	%strong=t('.errors_caught')	8	%strong=t('.errors_caught')
9	= app.problems.count	9	= app.problems.count
10	- %strong=t('.deploy_count')
11	- = app.deploys.count
12	%strong=t('.api_key')	10	%strong=t('.api_key')
13	= app.api_key	11	= app.api_key
14	- content_for :action_bar do	12	- content_for :action_bar do
	@@ -60,34 +58,6 @@		@@ -60,34 +58,6 @@
60	%tr	58	%tr
61	%td= link_to(app.github_repo, app.github_url, :target => '_blank')	59	%td= link_to(app.github_repo, app.github_url, :target => '_blank')
62		60
63	-%h3#deploys_toggle
64	- =t('.latest_deploys')
65	- %span.click_span=t('.show_hide')
66	-#deploys_div
67	- - if deploys.any?
68	- %table.deploys
69	- %thead
70	- %tr
71	- %th=t('.when')
72	- %th=t('.environment')
73	- %th=t('.who')
74	- %th=t('.message')
75	- %th=t('.repository')
76	- %th=t('.revision')
77	-
78	- %tbody
79	- - deploys.each do \|deploy\|
80	- %tr
81	- %td.when #{deploy.created_at.to_s(:micro)}
82	- %td.environment #{deploy.environment}
83	- %td.who #{deploy.username}
84	- %td.message #{deploy.message}
85	- %td.repository #{deploy.repository}
86	- %td.revision #{deploy.short_revision}
87	- = link_to t('.all_deploys', :count => app.deploys.count), app_deploys_path(app), :class => 'button'
88	- - else
89	- %h3=t('.no_deploys')
90	-
91	- if app.problems.any?	61	- if app.problems.any?
92	%h3.clear=t('.errors')	62	%h3.clear=t('.errors')
93	%section	63	%section
	@@ -1,21 +0,0 @@	@@ -1,21 +0,0 @@
1	-%table.errs
2	- %thead
3	- %tr
4	- %th App
5	- %th When
6	- %th Who
7	- %th Message
8	- %th Repository
9	- %th Revision
10	- %tbody
11	- - deploys.each do \|deploy\|
12	- %tr
13	- %td.app
14	- = deploy.app.name
15	- %span.environment= deploy.environment
16	- %td.latest= deploy.created_at.to_s(:micro)
17	- %td.who= deploy.username
18	- %td.message= deploy.message
19	- %td.repository= deploy.repository
20	- %td.revision= deploy.short_revision
21	-
	@@ -1,10 +0,0 @@	@@ -1,10 +0,0 @@
1	-- content_for :title, 'Deploys'
2	-- content_for :action_bar do
3	- - if current_user.authentication_token
4	- %span
5	- = link_to app_deploys_path(@app, :format => "ics", :auth_token => current_user.authentication_token) do
6	- %i.fa.fa-calendar
7	- iCal
8	-= render 'table', :deploys => @deploys
9	-= paginate @deploys
10	-
	@@ -1 +0,0 @@		@@ -1 +0,0 @@
1	-= generate_ical(@app.deploys.order_by(:created_at.asc))