Merge pull request #299 from lest/patch-1

Cleanup code

Merge pull request #299 from lest/patch-1
Cleanup code
Vasiliy Ermolovich
2 parents 8e95f6c6 64aebf9f
Showing 3 changed files with 4 additions and 6 deletions Show diff stats
app/controllers/apps_controller.rb
app/models/issue_trackers/github_issues_tracker.rb
app/models/notice.rb
@@ -80,7 +80,7 @@ class AppsController &lt; InheritedResources::Base
       end
     end
-  def initialize_subclassed_notification_service
+    def initialize_subclassed_notification_service
       # set the app's notification service
       if params[:app][:notification_service_attributes] && notification_type = params[:app][:notification_service_attributes][:type]
         if NotificationService.subclasses.map(&:name).concat(["NotificationService"]).include?(notification_type)
@@ -35,7 +35,7 @@ if defined? Octokit
       end
       begin
-        issue = client.create_issue(project_id, issue_title(problem), body_template.result(binding).unpack('C*').pack('U*'), options = {})
+        issue = client.create_issue(project_id, issue_title(problem), body_template.result(binding).unpack('C*').pack('U*'))
         problem.update_attributes(
           :issue_link => issue.html_url,
           :issue_type => Label
@@ -54,4 +54,4 @@ if defined? Octokit
       "https://github.com/#{project_id}/issues"
     end
   end
-end
 \ No newline at end of file
+end
@@ -13,7 +13,7 @@ class Notice
   field :current_user, :type => Hash
   field :error_class
   delegate :lines, :to => :backtrace, :prefix => true
-  delegate :app, :to => :err
+  delegate :app, :problem, :to => :err
   belongs_to :err
   belongs_to :backtrace, :index => true
@@ -36,8 +36,6 @@ class Notice
   scope :reverse_ordered, order_by(:created_at.desc)
   scope :for_errs, lambda {|errs| where(:err_id.in => errs.all.map(&:id))}
-  delegate :app, :problem, :to => :err
-
   def user_agent
     agent_string = env_vars['HTTP_USER_AGENT']
     agent_string.blank? ? nil : UserAgent.parse(agent_string)
	@@ -80,7 +80,7 @@ class AppsController < InheritedResources::Base		@@ -80,7 +80,7 @@ class AppsController < InheritedResources::Base
80	end	80	end
81	end	81	end
82		82
83	- def initialize_subclassed_notification_service	83	+ def initialize_subclassed_notification_service
84	# set the app's notification service	84	# set the app's notification service
85	if params[:app][:notification_service_attributes] && notification_type = params[:app][:notification_service_attributes][:type]	85	if params[:app][:notification_service_attributes] && notification_type = params[:app][:notification_service_attributes][:type]
86	if NotificationService.subclasses.map(&:name).concat(["NotificationService"]).include?(notification_type)	86	if NotificationService.subclasses.map(&:name).concat(["NotificationService"]).include?(notification_type)