Strip any query strings from files

Nathan Broadbent
1 parent cab56064
Showing 2 changed files with 22 additions and 8 deletions Show diff stats
app/models/backtrace_line_normalizer.rb
spec/models/backtrace_line_normalizer_spec.rb
@@ -12,7 +12,12 @@ class BacktraceLineNormalizer
     if @raw_line['file'].blank?
       "[unknown source]"
     else
-      @raw_line['file'].to_s.gsub(/\[PROJECT_ROOT\]\/.*\/ruby\/[0-9.]+\/gems/, '[GEM_ROOT]/gems')
+      file = @raw_line['file'].to_s
+      # Detect lines from gem
+      file.gsub!(/\[PROJECT_ROOT\]\/.*\/ruby\/[0-9.]+\/gems/, '[GEM_ROOT]/gems')
+      # Strip any query strings
+      file.gsub!(/\?[^\?]*$/, '')
+      @raw_line['file'] = file
     end
   end
@@ -3,16 +3,25 @@ require &#39;spec_helper&#39;
 describe BacktraceLineNormalizer do
   subject { described_class.new(raw_line).call }
-  describe "sanitize file and method" do
-    let(:raw_line) { { 'number' => rand(999), 'file' => nil, 'method' => nil } }
+  describe "sanitize" do
+    context "unknown file and method" do
+      let(:raw_line) { { 'number' => rand(999), 'file' => nil, 'method' => nil } }
-    it "should replace nil file with [unknown source]" do
-      subject['file'].should == "[unknown source]"
-    end
+      it "should replace nil file with [unknown source]" do
+        subject['file'].should == "[unknown source]"
+      end
-    it "should replace nil method with [unknown method]" do
-      subject['method'].should == "[unknown method]"
+      it "should replace nil method with [unknown method]" do
+        subject['method'].should == "[unknown method]"
+      end
     end
+    context "in app file" do
+      let(:raw_line) { { 'number' => rand(999), 'file' => "[PROJECT_ROOT]/assets/file.js?body=1", 'method' => nil } }
+
+      it "should strip query strings from files" do
+        subject['file'].should == "[PROJECT_ROOT]/assets/file.js"
+      end
+    end
   end
 end