Rubocop: first parameter indentation fix

This unfolds a bit of nesting, hoping the new version is plenty readable

Rubocop: first parameter indentation fix
This unfolds a bit of nesting, hoping the new version is plenty readable
Laust Rud Jacobsen
1 parent 01a41173
Showing 4 changed files with 41 additions and 40 deletions Show diff stats
.rubocop_todo.yml
app/models/issue_tracker.rb
spec/decorators/backtrace_decorator_spec.rb
spec/decorators/issue_tracker_type_decorator_spec.rb
@@ -88,15 +88,6 @@ Style/FileName:
     - 'config/initializers/cve-2013-0156.rb'
     - 'script/rspec-queue-mongoid.rb'
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/FirstParameterIndentation:
-  Exclude:
-    - 'app/models/issue_tracker.rb'
-    - 'spec/decorators/backtrace_decorator_spec.rb'
-    - 'spec/decorators/issue_tracker_type_decorator_spec.rb'
-
 # Offense count: 8
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/FormatString:
@@ -14,10 +14,12 @@ class IssueTracker
       begin
         klass = ErrbitPlugin::Registry.issue_trackers[type_tracker] || ErrbitPlugin::NoneIssueTracker
         # TODO: we need to find out a better way to pass those config to the issue tracker
-        klass.new(options.merge(
-          github_repo:    app.try(:github_repo),
-          bitbucket_repo: app.try(:bitbucket_repo)
-        ))
+        klass.new(
+          options.merge(
+            github_repo:    app.try(:github_repo),
+            bitbucket_repo: app.try(:bitbucket_repo)
+          )
+        )
       end
   end
 describe BacktraceDecorator, type: :decorator do
   let(:backtrace) do
-    described_class.new(Backtrace.new(
-      lines: [
-        { number: 131,
-          file:   '[PROJECT_ROOT]app/controllers/accounts_controller.rb',
-          method: :update_preferences },
-        { number: 61,
-          file:   '[PROJECT_ROOT]app/controllers/application_controller.rb',
-          method: :call },
-        { number: 182,
-          file:   '[GEM_ROOT]activesupport-2.3.18/lib/active_support/callbacks.rb',
-          method: :call },
-        { number: 384,
-          file:   '[PROJECT_ROOT]app/models/account.rb',
-          method: :update_server_tag_scope },
-        { number: 182,
-          file:   '[GEM_ROOT]activesupport-2.3.18/lib/active_support/callbacks.rb',
-          method: :evaluate_method },
-        { number: 23,
-          file:   '/home/rails/library/current/vendor/bundle/ruby/2.1.0/bin/rainbows',
-          method: '<main>' }
-      ]
-    ))
+    described_class.new(
+      Backtrace.new(
+        lines: [
+          { number: 131,
+            file:   '[PROJECT_ROOT]app/controllers/accounts_controller.rb',
+            method: :update_preferences },
+          { number: 61,
+            file:   '[PROJECT_ROOT]app/controllers/application_controller.rb',
+            method: :call },
+          { number: 182,
+            file:   '[GEM_ROOT]activesupport-2.3.18/lib/active_support/callbacks.rb',
+            method: :call },
+          { number: 384,
+            file:   '[PROJECT_ROOT]app/models/account.rb',
+            method: :update_server_tag_scope },
+          { number: 182,
+            file:   '[GEM_ROOT]activesupport-2.3.18/lib/active_support/callbacks.rb',
+            method: :evaluate_method },
+          { number: 23,
+            file:   '/home/rails/library/current/vendor/bundle/ruby/2.1.0/bin/rainbows',
+            method: '<main>' }
+        ]
+      )
+    )
   end
   describe '#grouped_lines' do
@@ -50,15 +50,21 @@ describe IssueTrackerDecorator do
   describe "#params_class" do
     it 'adds the label in class' do
-      tracker = IssueTrackerDecorator.new(IssueTracker.new(
-        type_tracker: 'none'))
+      tracker = IssueTrackerDecorator.new(
+        IssueTracker.new(type_tracker: 'none')
+      )
       expect(decorator.params_class(tracker)).to eql 'fake'
     end
     it 'adds chosen class if type is same' do
-      expect(decorator.params_class(
-        IssueTracker.new(type_tracker: 'fake').decorate
-      )).to eql 'chosen fake'
+      expect(
+        decorator.
+          params_class(
+            IssueTracker.new(
+              type_tracker: 'fake'
+            ).decorate
+          )
+      ).to eql 'chosen fake'
     end
   end
 end
	@@ -88,15 +88,6 @@ Style/FileName:		@@ -88,15 +88,6 @@ Style/FileName:
88	- 'config/initializers/cve-2013-0156.rb'	88	- 'config/initializers/cve-2013-0156.rb'
89	- 'script/rspec-queue-mongoid.rb'	89	- 'script/rspec-queue-mongoid.rb'
90		90
91	-# Offense count: 4
92	-# Cop supports --auto-correct.
93	-# Configuration parameters: EnforcedStyle, SupportedStyles.
94	-Style/FirstParameterIndentation:
95	- Exclude:
96	- - 'app/models/issue_tracker.rb'
97	- - 'spec/decorators/backtrace_decorator_spec.rb'
98	- - 'spec/decorators/issue_tracker_type_decorator_spec.rb'
99	-
100	# Offense count: 8	91	# Offense count: 8
101	# Configuration parameters: EnforcedStyle, SupportedStyles.	92	# Configuration parameters: EnforcedStyle, SupportedStyles.
102	Style/FormatString:	93	Style/FormatString: