Err#fingerprint calculated from many attributes

Marcin Ciunelis
1 parent bdbf3530
Showing 4 changed files with 55 additions and 7 deletions Show diff stats
app/models/app.rb
app/models/err.rb
app/models/error_report.rb
lib/tasks/errbit/database.rake
@@ -74,7 +74,7 @@ class App
   end
  
   def find_or_create_err!(attrs)
-    Err.where(attrs).first || problems.create!.errs.create!(attrs)
+    Err.where(:fingerprint => attrs[:fingerprint]).first || problems.create!.errs.create!(attrs)
   end
  
   # Mongoid Bug: find(id) on association proxies returns an Enumerator
@@ -15,6 +15,7 @@ class Err
   belongs_to :problem
   index :problem_id
   index :error_class
+  index :fingerprint
  
   has_many :notices, :inverse_of => :err, :dependent => :destroy
  
-require 'digest/md5'
+require 'digest/sha1'
 require 'hoptoad_notifier'
  
 class ErrorReport
@@ -10,11 +10,7 @@ class ErrorReport
   end
  
   def fingerprint
-    normalized_backtrace = backtrace[0...3].map do |trace|
-      trace.merge 'method' => trace['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
-    end
-
-    @fingerprint ||= Digest::MD5.hexdigest(normalized_backtrace.to_s)
+    @fingerprint ||= Digest::SHA1.hexdigest(fingerprint_source.to_s)
   end
  
   def rails_env
@@ -53,5 +49,24 @@ class ErrorReport
     err.notices << notice
     notice
   end
+
+  private
+  def fingerprint_source
+    {
+      :backtrace => normalized_backtrace.to_s,
+      :error_class => error_class,
+      :component => component,
+      :action => action,
+      :environment => rails_env,
+      :api_key => api_key
+    }
+  end
+
+  def normalized_backtrace
+    backtrace[0...3].map do |trace|
+      trace.merge 'method' => trace['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
+    end
+  end
+
 end
  
+require 'digest/sha1'
+
 namespace :errbit do
   namespace :db do
  
@@ -21,5 +23,35 @@ namespace :errbit do
       Problem.resolved.each {|problem| problem.destroy }
       puts "=== Cleared #{count} resolved errors from the database." if count > 0
     end
+
+    desc "Regenerate fingerprints"
+    task :regenerate_fingerprints => :environment do
+
+      def normalize_backtrace(backtrace)
+        backtrace[0...3].map do |trace|
+          trace.merge 'method' => trace['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
+        end
+      end
+
+      def fingerprint(source)
+        Digest::SHA1.hexdigest(source.to_s)
+      end
+
+      puts "Regenerating Err fingerprints"
+      Err.create_indexes
+      Err.all.limit(10).each do |err|
+        next if err.notices.count == 0
+        source = {
+          :backtrace => normalize_backtrace(err.notices.first.backtrace).to_s,
+          :error_class => err.error_class,
+          :component => err.component,
+          :action => err.action,
+          :environment => err.environment,
+          :api_key => err.app.api_key
+        }
+        err.update_attributes(:fingerprint => fingerprint(source))
+      end
+    end
+
   end
 end
...	...	@@ -74,7 +74,7 @@ class App
74	74	end
75	75
76	76	def find_or_create_err!(attrs)
77		- Err.where(attrs).first \|\| problems.create!.errs.create!(attrs)
	77	+ Err.where(:fingerprint => attrs[:fingerprint]).first \|\| problems.create!.errs.create!(attrs)
78	78	end
79	79
80	80	# Mongoid Bug: find(id) on association proxies returns an Enumerator
...	...
...	...	@@ -15,6 +15,7 @@ class Err
15	15	belongs_to :problem
16	16	index :problem_id
17	17	index :error_class
	18	+ index :fingerprint
18	19
19	20	has_many :notices, :inverse_of => :err, :dependent => :destroy
20	21
...	...
1		-require 'digest/md5'
	1	+require 'digest/sha1'
2	2	require 'hoptoad_notifier'
3	3
4	4	class ErrorReport
...	...	@@ -10,11 +10,7 @@ class ErrorReport
10	10	end
11	11
12	12	def fingerprint
13		- normalized_backtrace = backtrace[0...3].map do \|trace\|
14		- trace.merge 'method' => trace['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
15		- end
16		-
17		- @fingerprint \|\|= Digest::MD5.hexdigest(normalized_backtrace.to_s)
	13	+ @fingerprint \|\|= Digest::SHA1.hexdigest(fingerprint_source.to_s)
18	14	end
19	15
20	16	def rails_env
...	...	@@ -53,5 +49,24 @@ class ErrorReport
53	49	err.notices << notice
54	50	notice
55	51	end
	52	+
	53	+ private
	54	+ def fingerprint_source
	55	+ {
	56	+ :backtrace => normalized_backtrace.to_s,
	57	+ :error_class => error_class,
	58	+ :component => component,
	59	+ :action => action,
	60	+ :environment => rails_env,
	61	+ :api_key => api_key
	62	+ }
	63	+ end
	64	+
	65	+ def normalized_backtrace
	66	+ backtrace[0...3].map do \|trace\|
	67	+ trace.merge 'method' => trace['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
	68	+ end
	69	+ end
	70	+
56	71	end
57	72
...	...
	1	+require 'digest/sha1'
	2	+
1	3	namespace :errbit do
2	4	namespace :db do
3	5
...	...	@@ -21,5 +23,35 @@ namespace :errbit do
21	23	Problem.resolved.each {\|problem\| problem.destroy }
22	24	puts "=== Cleared #{count} resolved errors from the database." if count > 0
23	25	end
	26	+
	27	+ desc "Regenerate fingerprints"
	28	+ task :regenerate_fingerprints => :environment do
	29	+
	30	+ def normalize_backtrace(backtrace)
	31	+ backtrace[0...3].map do \|trace\|
	32	+ trace.merge 'method' => trace['method'].gsub(/[0-9_]{10,}+/, "__FRAGMENT__")
	33	+ end
	34	+ end
	35	+
	36	+ def fingerprint(source)
	37	+ Digest::SHA1.hexdigest(source.to_s)
	38	+ end
	39	+
	40	+ puts "Regenerating Err fingerprints"
	41	+ Err.create_indexes
	42	+ Err.all.limit(10).each do \|err\|
	43	+ next if err.notices.count == 0
	44	+ source = {
	45	+ :backtrace => normalize_backtrace(err.notices.first.backtrace).to_s,
	46	+ :error_class => err.error_class,
	47	+ :component => err.component,
	48	+ :action => err.action,
	49	+ :environment => err.environment,
	50	+ :api_key => err.app.api_key
	51	+ }
	52	+ err.update_attributes(:fingerprint => fingerprint(source))
	53	+ end
	54	+ end
	55	+
24	56	end
25	57	end
...	...