Order errs/notices base on last notice time

Jared Pace
1 parent 44b8346b
Showing 4 changed files with 16 additions and 8 deletions Show diff stats
app/controllers/errs_controller.rb
app/models/err.rb
app/models/notice.rb
spec/controllers/errs_controller_spec.rb
 class ErrsController < ApplicationController
   def index
-    @errs = Err.unresolved.paginate(:page => params[:page])
+    @errs = Err.unresolved.ordered.paginate(:page => params[:page])
   end
   def show
     @project  = Project.find(params[:project_id])
     @err      = @project.errs.find(params[:id])
-    @notices  = @err.notices.paginate(:page => (params[:notice] || @err.notices.count), :per_page => 1)
+    @notices  = @err.notices.ordered.paginate(:page => (params[:notice] || @err.notices.count), :per_page => 1)
     @notice   = @notices.first
   end
@@ -7,6 +7,7 @@ class Err
   field :action
   field :environment
   field :fingerprint
+  field :last_notice_at, :type => DateTime
   field :resolved, :type => Boolean, :default => false
   referenced_in :project
@@ -16,6 +17,7 @@ class Err
   scope :resolved, where(:resolved => true)
   scope :unresolved, where(:resolved => false)
+  scope :ordered, order_by(:last_notice_at.desc)
   def self.for(attrs)
     project = attrs.delete(:project)
@@ -30,10 +32,6 @@ class Err
     !resolved?
   end
-  def last_notice_at
-    notices.last.try(:created_at)
-  end
-  
   def where
     where = component.dup
     where << "##{action}" if action.present?
@@ -12,10 +12,13 @@ class Notice
   embedded_in :err, :inverse_of => :notices
+  after_create :cache_last_notice_at
   after_create :deliver_notification, :if => :should_notify?
   validates_presence_of :backtrace, :server_environment, :notifier
+  scope :ordered, order_by(:created_at.asc)
+  
   def self.from_xml(hoptoad_xml)
     hoptoad_notice = Hoptoad::V2.parse_xml(hoptoad_xml)
     project = Project.find_by_api_key!(hoptoad_notice['api-key'])
@@ -61,6 +64,10 @@ class Notice
     Mailer.error_notification(self).deliver
   end
+  def cache_last_notice_at
+    err.update_attributes(:last_notice_at => created_at)
+  end
+  
   protected
     def should_notify?
@@ -9,7 +9,9 @@ describe ErrsController do
     it "gets a paginated list of unresolved errors" do
       errors = WillPaginate::Collection.new(1,30)
       3.times { errors << Factory(:err) }
-      Err.should_receive(:unresolved).and_return(mock('proxy', :paginate => errors))
+      Err.should_receive(:unresolved).and_return(
+        mock('proxy', :ordered => mock('proxy', :paginate => errors))
+      )
       get :index
       assigns(:errs).should == errors
     end
@@ -33,7 +35,8 @@ describe ErrsController do
     it "paginates the notices, 1 at a time" do
       Project.stub(:find).with(project.id).and_return(project)
       project.errs.stub(:find).with(err.id).and_return(err)
-      err.notices.should_receive(:paginate).with(:page => 3, :per_page => 1).
+      err.notices.should_receive(:ordered).and_return(proxy = stub('proxy'))
+      proxy.should_receive(:paginate).with(:page => 3, :per_page => 1).
         and_return(WillPaginate::Collection.new(1,1) << err.notices.first)
       get :show, :project_id => project.id, :id => err.id
     end
1	class ErrsController < ApplicationController	1	class ErrsController < ApplicationController
2		2
3	def index	3	def index
4	- @errs = Err.unresolved.paginate(:page => params[:page])	4	+ @errs = Err.unresolved.ordered.paginate(:page => params[:page])
5	end	5	end
6		6
7	def show	7	def show
8	@project = Project.find(params[:project_id])	8	@project = Project.find(params[:project_id])
9	@err = @project.errs.find(params[:id])	9	@err = @project.errs.find(params[:id])
10	- @notices = @err.notices.paginate(:page => (params[:notice] \|\| @err.notices.count), :per_page => 1)	10	+ @notices = @err.notices.ordered.paginate(:page => (params[:notice] \|\| @err.notices.count), :per_page => 1)
11	@notice = @notices.first	11	@notice = @notices.first
12	end	12	end
13		13