Update *from* email to display a valid Flowdock avatar

Flowdock doesn't validate or have some sort of confirmation for email addresses. As long as you know Flow API token you're free to post with any email.

Update from email to display a valid Flowdock avatar
Flowdock doesn't validate or have some sort of confirmation for email addresses. As long as you know Flow API token you're free to post with any email.
Nikita Fedyashev
1 parent 26e089f7
Showing 1 changed file with 1 additions and 1 deletions Show diff stats
app/models/notification_services/flowdock_service.rb
@@ -21,7 +21,7 @@ if defined? Flowdock
     end
  
     def create_notification(problem)
-      flow = Flowdock::Flow.new(:api_token => api_token, :source => "Errbit", :from => {:name => "Errbit", :address => Errbit::Config.email_from})
+      flow = Flowdock::Flow.new(:api_token => api_token, :source => "Errbit", :from => {:name => "Errbit", :address => 'support@flowdock.com'})
       subject = "[#{problem.environment}] #{problem.message.to_s.truncate(100)}"
       url = app_problem_url problem.app, problem
       flow.push_to_team_inbox(:subject => subject, :content => content(problem, url), :project => project_name(problem), :link => url)
...	...	@@ -21,7 +21,7 @@ if defined? Flowdock
21	21	end
22	22
23	23	def create_notification(problem)
24		- flow = Flowdock::Flow.new(:api_token => api_token, :source => "Errbit", :from => {:name => "Errbit", :address => Errbit::Config.email_from})
	24	+ flow = Flowdock::Flow.new(:api_token => api_token, :source => "Errbit", :from => {:name => "Errbit", :address => 'support@flowdock.com'})
25	25	subject = "[#{problem.environment}] #{problem.message.to_s.truncate(100)}"
26	26	url = app_problem_url problem.app, problem
27	27	flow.push_to_team_inbox(:subject => subject, :content => content(problem, url), :project => project_name(problem), :link => url)
...	...