Commit d9624a37a07ba7eca9b76da9fa8b39e52c0e5adf

Authored by Laust Rud Jacobsen
1 parent fcdedb8a
Exists in master and in 1 other branch production

Rubocop: stripping out duplicate empty lines

.rubocop_todo.yml
... ... @@ -159,19 +159,6 @@ Style/EmptyLineBetweenDefs:
159 159 - 'spec/decorators/issue_tracker_type_decorator_spec.rb'
160 160 - 'spec/views/problems/show.html.haml_spec.rb'
161 161  
162   -# Offense count: 12
163   -# Cop supports --auto-correct.
164   -Style/EmptyLines:
165   - Exclude:
166   - - 'app/controllers/api/v1/stats_controller.rb'
167   - - 'app/decorators/issue_tracker_field_decorator.rb'
168   - - 'app/models/app.rb'
169   - - 'app/models/problem.rb'
170   - - 'config/deploy/production.example.rb'
171   - - 'lib/tasks/errbit/demo.rake'
172   - - 'script/rspec-queue-mongoid.rb'
173   - - 'spec/acceptance/app_regenerate_api_key_spec.rb'
174   -
175 162 # Offense count: 28
176 163 # Cop supports --auto-correct.
177 164 # Configuration parameters: EnforcedStyle, SupportedStyles.
... ...
app/controllers/api/v1/stats_controller.rb
... ... @@ -23,7 +23,6 @@ class Api::V1::StatsController < ApplicationController
23 23 end
24 24 end
25 25  
26   -
27 26 protected
28 27  
29 28 def require_api_key_or_authenticate_user!
... ...
app/decorators/issue_tracker_field_decorator.rb
... ... @@ -12,7 +12,6 @@ class IssueTrackerFieldDecorator < Draper::Decorator
12 12 field_info[:label] || object.to_s.titleize
13 13 end
14 14  
15   -
16 15 def input(form, issue_tracker)
17 16 form.send(input_field, key.to_s,
18 17 :placeholder => field_info[:placeholder],
... ...
app/models/app.rb
... ... @@ -89,7 +89,6 @@ class App
89 89 (last_deploy = deploys.last) && last_deploy.created_at
90 90 end
91 91  
92   -
93 92 # Legacy apps don't have notify_on_errs and notify_on_deploys params
94 93 def notify_on_errs
95 94 !(super == false)
... ... @@ -133,7 +132,6 @@ class App
133 132 "#{bitbucket_url}/src/#{repo_branch}/#{file}"
134 133 end
135 134  
136   -
137 135 def issue_tracker_configured?
138 136 issue_tracker.present? && issue_tracker.configured?
139 137 end
... ... @@ -143,7 +141,6 @@ class App
143 141 notification_service.configured?
144 142 end
145 143  
146   -
147 144 def notification_recipients
148 145 if notify_all_users
149 146 (User.all.map(&:email).reject(&:blank?) + watchers.map(&:address)).uniq
... ...
app/models/problem.rb
... ... @@ -12,7 +12,6 @@ class Problem
12 12 user_agents: :user_agent_string
13 13 }.freeze
14 14  
15   -
16 15 field :last_notice_at, :type => ActiveSupport::TimeWithZone, :default => Proc.new { Time.zone.now }
17 16 field :first_notice_at, :type => ActiveSupport::TimeWithZone, :default => Proc.new { Time.zone.now }
18 17 field :last_deploy_at, :type => Time
... ... @@ -186,7 +185,6 @@ class Problem
186 185 !resolved?
187 186 end
188 187  
189   -
190 188 def self.merge!(*problems)
191 189 ProblemMerge.new(problems).merge
192 190 end
... ...
config/deploy/production.example.rb
... ... @@ -8,7 +8,6 @@ role :app, %w(deploy@example.com)
8 8 role :web, %w(deploy@example.com)
9 9 role :db, %w(deploy@example.com)
10 10  
11   -
12 11 # Extended Server Syntax
13 12 # ======================
14 13 # This can be used to drop a more detailed server definition into the
... ... @@ -17,7 +16,6 @@ role :db, %w(deploy@example.com)
17 16  
18 17 server 'example.com', user: 'deploy', roles: %w(web app), my_property: :my_value
19 18  
20   -
21 19 # Custom SSH Options
22 20 # ==================
23 21 # You may pass any option but keep in mind that net/ssh understands a
... ...
lib/tasks/errbit/demo.rake
... ... @@ -64,7 +64,6 @@ namespace :errbit do
64 64 end
65 65 end
66 66  
67   -
68 67 Fabricate(:notice, :err => Fabricate(:err, :problem => Fabricate(:problem, :app => app)))
69 68 puts "=== Created demo app: '#{app.name}', with example errors."
70 69 end
... ...
script/rspec-queue-mongoid.rb
... ... @@ -5,7 +5,6 @@ require 'bundler'
5 5 Bundler.setup(:default, :development, :test)
6 6 require 'test_queue/runner/rspec'
7 7  
8   -
9 8 class MongoidRspecRunner < TestQueue::Runner::RSpec
10 9 def after_fork(num)
11 10 super
... ...
spec/acceptance/app_regenerate_api_key_spec.rb
... ... @@ -55,7 +55,6 @@ feature &quot;Create an application&quot; do
55 55 expect(App.where(:name => 'My new app').count).to eq 1
56 56 expect(App.where(:name => 'My new app 2').count).to eq 0
57 57  
58   -
59 58 click_on I18n.t('shared.navigation.apps')
60 59 click_on 'My new app'
61 60 click_link I18n.t('apps.show.edit')
... ...