Merge pull request #565 from mildavw/master

Treat request URL as CDATA so query string params don't result in invalid XML

Merge pull request #565 from mildavw/master
Treat request URL as CDATA so query string params don't result in invalid XML
Cyril Mougel
2 parents b4fc56cc 929e795a
Showing 3 changed files with 3 additions and 3 deletions Show diff stats
public/javascripts/notifier.js
spec/fixtures/hoptoad_test_notice.xml
spec/models/error_report_spec.rb
@@ -506,7 +506,7 @@ printStackTrace.implementation.prototype = {
                 '<backtrace>{backtrace_lines}</backtrace>' +
             '</error>' +
             '<request>' +
-                '<url>{request_url}</url>' +
+                '<url><![CDATA[{request_url}]]></url>' +
                 '<component>{request_component}</component>' +
                 '<action>{request_action}</action>' +
                 '{request}' +
@@ -87,7 +87,7 @@
     </backtrace>
   </error>
   <request>
-    <url>http://example.org/verify</url>
+    <url><![CDATA[http://example.org/verify/cupcake=fistfight&lovebird=doomsayer]]></url>
     <component>application</component>
     <action>verify</action>
     <params>
@@ -85,7 +85,7 @@ describe ErrorReport do
         end
  
         it 'has request' do
-          subject.request['url'].should == 'http://example.org/verify'
+          subject.request['url'].should == 'http://example.org/verify/cupcake=fistfight&lovebird=doomsayer'
           subject.request['params']['controller'].should == 'application'
         end
...	...	@@ -506,7 +506,7 @@ printStackTrace.implementation.prototype = {
506	506	'<backtrace>{backtrace_lines}</backtrace>' +
507	507	'</error>' +
508	508	'<request>' +
509		- '<url>{request_url}</url>' +
	509	+ '<url><![CDATA[{request_url}]]></url>' +
510	510	'<component>{request_component}</component>' +
511	511	'<action>{request_action}</action>' +
512	512	'{request}' +
...	...
...	...	@@ -87,7 +87,7 @@
87	87	</backtrace>
88	88	</error>
89	89	<request>
90		- <url>http://example.org/verify</url>
	90	+ <url><![CDATA[http://example.org/verify/cupcake=fistfight&lovebird=doomsayer]]></url>
91	91	<component>application</component>
92	92	<action>verify</action>
93	93	<params>
...	...
...	...	@@ -85,7 +85,7 @@ describe ErrorReport do
85	85	end
86	86
87	87	it 'has request' do
88		- subject.request['url'].should == 'http://example.org/verify'
	88	+ subject.request['url'].should == 'http://example.org/verify/cupcake=fistfight&lovebird=doomsayer'
89	89	subject.request['params']['controller'].should == 'application'
90	90	end
91	91
...	...