Add more tests to create_issue action

Arthur Neves
1 parent 37be920a
Showing 2 changed files with 27 additions and 12 deletions Show diff stats
spec/controllers/problems_controller_spec.rb
spec/errbit_plugin/mock_issue_tracker.rb
@@ -257,35 +257,50 @@ describe ProblemsController do
   end
   describe "POST /apps/:app_id/problems/:id/create_issue" do
+    before { sign_in admin }
-    before(:each) do
-      sign_in admin
-    end
-
-    context "successful issue creation" do
+    context "when app has a issue tracker" do
       let(:notice) { Fabricate :notice }
       let(:problem) { notice.problem }
-      let(:issue_tracker) { Fabricate(:issue_tracker) }
+      let(:issue_tracker) do
+        Fabricate(:issue_tracker).tap do |t|
+          t.instance_variable_set(:@tracker, ErrbitPlugin::MockIssueTracker.new(t.options))
+        end
+      end
       before do
         problem.app.issue_tracker = issue_tracker
-        problem.app.save!
+        controller.stub(:problem).and_return(problem)
         controller.stub(:current_user).and_return(admin)
-        post :create_issue, app_id: problem.app.id, id: problem.id
       end
       it "should redirect to problem page" do
+        post :create_issue, app_id: problem.app.id, id: problem.id
         expect(response).to redirect_to(app_problem_path(problem.app, problem))
         expect(flash[:error]).to be_blank
       end
-    end
-    context "error during request to a tracker" do
-      before do
+      it "should save the right title" do
+        post :create_issue, app_id: problem.app.id, id: problem.id
+        title = "[#{ problem.environment }][#{ problem.where }] #{problem.message.to_s.truncate(100)}"
+        line = issue_tracker.tracker.output.shift
+        expect(line[0]).to eq(title)
+      end
+
+      it "should save the right body" do
+        pending
+      end
+
+      it "should update the problem" do
         post :create_issue, app_id: problem.app.id, id: problem.id
+        expect(problem.issue_link).to eq("http://example.com/mock-errbit")
+        expect(problem.issue_type).to eq("mock")
       end
+    end
+    context "when app has no issue tracker" do
       it "should redirect to problem page" do
+        post :create_issue, app_id: problem.app.id, id: problem.id
         expect(response).to redirect_to( app_problem_path(problem.app, problem) )
         expect(flash[:error]).to eql "This app has no issue tracker setup."
       end
@@ -35,7 +35,7 @@ module ErrbitPlugin
     def create_issue(title, body, user)
       @output << [title, body, user]
-      true
+      "http://example.com/mock-errbit"
     end
     def url; ''; end
	@@ -35,7 +35,7 @@ module ErrbitPlugin		@@ -35,7 +35,7 @@ module ErrbitPlugin
35		35
36	def create_issue(title, body, user)	36	def create_issue(title, body, user)
37	@output << [title, body, user]	37	@output << [title, body, user]
38	- true	38	+ "http://example.com/mock-errbit"
39	end	39	end
40		40
41	def url; ''; end	41	def url; ''; end