Rubocop: ensure a space is inside the braces of hash literals

Laust Rud Jacobsen
1 parent 0149f833
Showing 30 changed files with 80 additions and 86 deletions Show diff stats
.rubocop_todo.yml
app/controllers/api/v1/notices_controller.rb
app/controllers/api/v1/problems_controller.rb
app/helpers/apps_helper.rb
app/helpers/navigation_helper.rb
app/models/notification_services/flowdock_service.rb
app/models/notification_services/hubot_service.rb
app/models/notification_services/webhook_service.rb
app/models/problem.rb
lib/hoptoad/v2.rb
lib/tasks/errbit/demo.rake
spec/controllers/api/v1/notices_controller_spec.rb
spec/controllers/api/v1/problems_controller_spec.rb
spec/controllers/apps_controller_spec.rb
spec/controllers/problems_controller_spec.rb
spec/controllers/users/omniauth_callbacks_controller_spec.rb
spec/controllers/users_controller_spec.rb
spec/decorators/issue_tracker_decorator_spec.rb
spec/decorators/issue_tracker_field_decorator.rb
spec/decorators/issue_tracker_type_decorator_spec.rb
@@ -295,12 +295,6 @@ Style/SpaceInsideBrackets:
     - 'spec/lib/configurator_spec.rb'
     - 'spec/models/issue_spec.rb'
-# Offense count: 189
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
-Style/SpaceInsideHashLiteralBraces:
-  Enabled: false
-
 # Offense count: 873
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -8,7 +8,7 @@ class Api::V1::NoticesController &lt; ApplicationController
     if params.key?(:start_date) && params.key?(:end_date)
       start_date = Time.zone.parse(params[:start_date]).utc
       end_date = Time.zone.parse(params[:end_date]).utc
-      query = {:created_at => {"$lte" => end_date, "$gte" => start_date}}
+      query = { :created_at => { "$lte" => end_date, "$gte" => start_date } }
     end
     results = benchmark("[api/v1/notices_controller] query time") do
@@ -24,7 +24,7 @@ class Api::V1::ProblemsController &lt; ApplicationController
     if params.key?(:start_date) && params.key?(:end_date)
       start_date = Time.parse(params[:start_date]).utc
       end_date = Time.parse(params[:end_date]).utc
-      query = {:first_notice_at => {"$lte" => end_date}, "$or" => [{:resolved_at => nil}, {:resolved_at => {"$gte" => start_date}}]}
+      query = { :first_notice_at => { "$lte" => end_date }, "$or" => [{ :resolved_at => nil }, { :resolved_at => { "$gte" => start_date } }] }
     end
     results = benchmark("[api/v1/problems_controller/index] query time") do
@@ -5,8 +5,8 @@ module AppsHelper
         :class => 'button copy_config')
       html << select("duplicate", "app",
         App.all.asc(:name).reject{|a| a == @app }.
-        collect{|p| [ p.name, p.id ] }, {:include_blank => "[choose app]"},
-        {:class => "choose_other_app", :style => "display: none;"})
+        collect{|p| [ p.name, p.id ] }, { :include_blank => "[choose app]" },
+        { :class => "choose_other_app", :style => "display: none;" })
       return html
     end
   end
@@ -22,7 +22,7 @@ module NavigationHelper
                   matches.each {|c| s[c] = :all}
                   s
                 else
-                  {matches => :all}
+                  { matches => :all }
                 end
     active = nil
@@ -21,7 +21,7 @@ if defined? Flowdock
     end
     def create_notification(problem)
-      flow = Flowdock::Flow.new(:api_token => api_token, :source => "Errbit", :from => {:name => "Errbit", :address => ENV['ERRBIT_EMAIL_FROM'] || 'support@flowdock.com'})
+      flow = Flowdock::Flow.new(:api_token => api_token, :source => "Errbit", :from => { :name => "Errbit", :address => ENV['ERRBIT_EMAIL_FROM'] || 'support@flowdock.com' })
       subject = "[#{problem.environment}] #{problem.message.to_s.truncate(100)}"
       url = app_problem_url problem.app, problem
       flow.push_to_team_inbox(:subject => subject, :content => content(problem, url), :project => project_name(problem), :link => url)
@@ -26,6 +26,6 @@ class NotificationServices::HubotService &lt; NotificationService
   end
   def create_notification(problem)
-    HTTParty.post(url, :body => {:message => message_for_hubot(problem), :room => room_id})
+    HTTParty.post(url, :body => { :message => message_for_hubot(problem), :room => room_id })
   end
 end
@@ -14,7 +14,7 @@ class NotificationServices::WebhookService &lt; NotificationService
   end
   def message_for_webhook(problem)
-    {:problem => {:url => problem_url(problem)}.merge(problem.as_json).to_json}
+    { :problem => { :url => problem_url(problem) }.merge(problem.as_json).to_json }
   end
   def create_notification(problem)
@@ -139,7 +139,7 @@ class Problem
       # find only notices related to this problem
       Notice.collection.find.aggregate([
         { "$match" => { err_id: { "$in" => err_ids } } },
-        { "$group" => { _id: "$#{v}", count: {"$sum" => 1} } }
+        { "$group" => { _id: "$#{v}", count: { "$sum" => 1 } } }
       ]).each do |agg|
         send(k)[Digest::MD5.hexdigest(agg[:_id] || 'N/A')] = {
           'value' => agg[:_id] || 'N/A',
@@ -194,7 +194,7 @@ class Problem
   end
   def unmerge!
-    attrs = {:error_class => error_class, :environment => environment}
+    attrs = { :error_class => error_class, :environment => environment }
     problem_errs = errs.to_a
     # associate and return all the problems
@@ -241,7 +241,7 @@ class Problem
   end
   def self.search(value)
-    Problem.where({'$text' => {'$search' => value}})
+    Problem.where({ '$text' => { '$search' => value } })
   end
 private
@@ -12,15 +12,15 @@ module Hoptoad
       case node
       when Hash
         if node.key?('var') && node.key?('key')
-          {normalize_key(node['key']) => rekey(node['var'])}
+          { normalize_key(node['key']) => rekey(node['var']) }
         elsif node.key?('var')
           rekey(node['var'])
         elsif node.key?('__content__') && node.key?('key')
-          {normalize_key(node['key']) => rekey(node['__content__'])}
+          { normalize_key(node['key']) => rekey(node['__content__']) }
         elsif node.key?('__content__')
           rekey(node['__content__'])
         elsif node.key?('key')
-          {normalize_key(node['key']) => nil}
+          { normalize_key(node['key']) => nil }
         else
           node.inject({}) {|rekeyed, (key, val)| rekeyed.merge(normalize_key(key) => rekey(val))}
         end
@@ -52,8 +52,8 @@ namespace :errbit do
             'action' => 'error',
             'url' => "http://example.com/post/#{[111, 222, 333].sample}"
           },
-          :server_environment => {'environment-name' => Rails.env.to_s},
-          :notifier => {:name => "seeds.rb"},
+          :server_environment => { 'environment-name' => Rails.env.to_s },
+          :notifier => { :name => "seeds.rb" },
           :app_user => {
             :id => "1234",
             :username => "jsmith",
@@ -29,7 +29,7 @@ describe Api::V1::NoticesController, type: &#39;controller&#39; do
       describe "given a date range" do
         it "should return only the notices created during the date range" do
-          get :index, {:auth_token => @user.authentication_token, :start_date => "2012-08-01", :end_date => "2012-08-27"}
+          get :index, { :auth_token => @user.authentication_token, :start_date => "2012-08-01", :end_date => "2012-08-27" }
           expect(response).to be_success
           notices = JSON.load response.body
           expect(notices.length).to eq 3
@@ -37,7 +37,7 @@ describe Api::V1::NoticesController, type: &#39;controller&#39; do
       end
       it "should return all notices" do
-        get :index, {:auth_token => @user.authentication_token}
+        get :index, { :auth_token => @user.authentication_token }
         expect(response).to be_success
         notices = JSON.load response.body
         expect(notices.length).to eq 4
@@ -82,7 +82,7 @@ describe Api::V1::ProblemsController, type: &#39;controller&#39; do
       describe "given a date range" do
         it "should return only the problems open during the date range" do
-          get :index, {:auth_token => @user.authentication_token, :start_date => "2012-08-20", :end_date => "2012-08-27"}
+          get :index, { :auth_token => @user.authentication_token, :start_date => "2012-08-20", :end_date => "2012-08-27" }
           expect(response).to be_success
           problems = JSON.load response.body
           expect(problems.length).to eq 2
@@ -90,7 +90,7 @@ describe Api::V1::ProblemsController, type: &#39;controller&#39; do
       end
       it "should return all problems" do
-        get :index, {:auth_token => @user.authentication_token}
+        get :index, { :auth_token => @user.authentication_token }
         expect(response).to be_success
         problems = JSON.load response.body
         expect(problems.length).to eq 4
 describe AppsController, type: 'controller' do
   it_requires_authentication
-  it_requires_admin_privileges :for => {:new => :get, :edit => :get, :create => :post, :update => :put, :destroy => :delete}
+  it_requires_admin_privileges :for => { :new => :get, :edit => :get, :create => :post, :update => :put, :destroy => :delete }
   let(:admin) { Fabricate(:admin) }
   let(:user) { Fabricate(:user) }
@@ -247,7 +247,7 @@ describe AppsController, type: &#39;controller&#39; do
       context "changing name" do
         it "should redirect to app page" do
           id = @app.id
-          put :update, :id => id, :app => {:name => "new name"}
+          put :update, :id => id, :app => { :name => "new name" }
           expect(response).to redirect_to(app_path(id))
         end
       end
@@ -288,7 +288,7 @@ describe AppsController, type: &#39;controller&#39; do
         context "unknown tracker type" do
           before(:each) do
             put :update, :id => @app.id, :app => { :issue_tracker_attributes => {
-              :type_tracker => 'unknown', :options => {:project_id => '1234', :api_token => '123123', :account => 'myapp'}
+              :type_tracker => 'unknown', :options => { :project_id => '1234', :api_token => '123123', :account => 'myapp' }
             } }
             @app.reload
           end
@@ -2,7 +2,7 @@ describe ProblemsController, type: &#39;controller&#39; do
   it_requires_authentication :for => {
     :index => :get, :show => :get, :resolve => :put, :search => :get
   },
-  :params => {:app_id => 'dummyid', :id => 'dummyid'}
+  :params => { :app_id => 'dummyid', :id => 'dummyid' }
   let(:app) { Fabricate(:app) }
   let(:err) { Fabricate(:err, :problem => problem) }
@@ -5,7 +5,7 @@ describe Users::OmniauthCallbacksController, type: &#39;controller&#39; do
     env = {
       "omniauth.auth" => Hashie::Mash.new(
         :provider => 'github',
-        :extra => { :raw_info => { :login => login }},
+        :extra => { :raw_info => { :login => login } },
         :credentials => { :token => token }
       )
     }
@@ -46,47 +46,47 @@ describe UsersController, type: &#39;controller&#39; do
     context "PUT /users/:my_id/id" do
       context "when the update is successful" do
         it "sets a message to display" do
-          put :update, :id => user.to_param, :user => {:name => 'Kermit'}
+          put :update, :id => user.to_param, :user => { :name => 'Kermit' }
           expect(request.flash[:success]).to include('updated')
         end
         it "redirects to the user's page" do
-          put :update, :id => user.to_param, :user => {:name => 'Kermit'}
+          put :update, :id => user.to_param, :user => { :name => 'Kermit' }
           expect(response).to redirect_to(user_path(user))
         end
         it "should not be able to become an admin" do
           expect {
-            put :update, :id => user.to_param, :user => {:admin => true}
+            put :update, :id => user.to_param, :user => { :admin => true }
           }.to_not change {
             user.reload.admin
           }.from(false)
         end
         it "should be able to set per_page option" do
-          put :update, :id => user.to_param, :user => {:per_page => 555}
+          put :update, :id => user.to_param, :user => { :per_page => 555 }
           expect(user.reload.per_page).to eq 555
         end
         it "should be able to set time_zone option" do
-          put :update, :id => user.to_param, :user => {:time_zone => "Warsaw"}
+          put :update, :id => user.to_param, :user => { :time_zone => "Warsaw" }
           expect(user.reload.time_zone).to eq "Warsaw"
         end
         it "should be able to not set github_login option" do
-          put :update, :id => user.to_param, :user => {:github_login => " "}
+          put :update, :id => user.to_param, :user => { :github_login => " " }
           expect(user.reload.github_login).to eq nil
         end
         it "should be able to set github_login option" do
-          put :update, :id => user.to_param, :user => {:github_login => "awesome_name"}
+          put :update, :id => user.to_param, :user => { :github_login => "awesome_name" }
           expect(user.reload.github_login).to eq "awesome_name"
         end
       end
       context "when the update is unsuccessful" do
         it "renders the edit page" do
-          put :update, :id => user.to_param, :user => {:name => nil}
+          put :update, :id => user.to_param, :user => { :name => nil }
           expect(response).to render_template(:edit)
         end
       end
@@ -131,7 +131,7 @@ describe UsersController, type: &#39;controller&#39; do
     context "POST /users" do
       context "when the create is successful" do
-        let(:attrs) { {:user => Fabricate.to_params(:user)} }
+        let(:attrs) { { :user => Fabricate.to_params(:user) } }
         it "sets a message to display" do
           post :create, attrs
@@ -179,7 +179,7 @@ describe UsersController, type: &#39;controller&#39; do
         }
         context "with normal params" do
-          let(:user_params) { {:name => 'Kermit'} }
+          let(:user_params) { { :name => 'Kermit' } }
           it "sets a message to display" do
             expect(request.flash[:success]).to eq I18n.t('controllers.users.flash.update.success', :name => user.reload.name)
             expect(response).to redirect_to(user_path(user))
@@ -188,7 +188,7 @@ describe UsersController, type: &#39;controller&#39; do
       end
       context "when the update is unsuccessful" do
         it "renders the edit page" do
-          put :update, :id => user.to_param, :user => {:name => nil}
+          put :update, :id => user.to_param, :user => { :name => nil }
           expect(response).to render_template(:edit)
         end
       end
@@ -230,14 +230,14 @@ describe UsersController, type: &#39;controller&#39; do
             ActionController::Parameters.new(user_param)
           )
         }
-        let(:user_param) { {'user' => { :name => 'foo', :admin => true }} }
+        let(:user_param) { { 'user' => { :name => 'foo', :admin => true } } }
         it 'not have admin field' do
-          expect(controller.send(:user_params)).to eq({'name' => 'foo'})
+          expect(controller.send(:user_params)).to eq({ 'name' => 'foo' })
         end
         context "with password and password_confirmation empty?" do
-          let(:user_param) { {'user' => { :name => 'foo', 'password' => '', 'password_confirmation' => '' }} }
+          let(:user_param) { { 'user' => { :name => 'foo', 'password' => '', 'password_confirmation' => '' } } }
           it 'not have password and password_confirmation field' do
-            expect(controller.send(:user_params)).to eq({'name' => 'foo'})
+            expect(controller.send(:user_params)).to eq({ 'name' => 'foo' })
           end
         end
       end
@@ -11,8 +11,8 @@ describe IssueTrackerDecorator do
       def self.fields
         {
-          :foo => {:label => 'foo'},
-          :bar => {:label => 'bar'}
+          :foo => { :label => 'foo' },
+          :bar => { :label => 'bar' }
         }
       end
 describe IssueTrackerFieldDecorator do
   describe "#label" do
     it 'return the label of field_info by default' do
-      expect(IssueTrackerFieldDecorator.new(:foo, {:label => 'hello'}).label).to eq 'hello'
+      expect(IssueTrackerFieldDecorator.new(:foo, { :label => 'hello' }).label).to eq 'hello'
     end
     it 'return the key of field if no label define' do
@@ -11,8 +11,8 @@ describe IssueTrackerDecorator do
       def self.fields
         {
-          :foo => {:label => 'foo'},
-          :bar => {:label => 'bar'}
+          :foo => { :label => 'foo' },
+          :bar => { :label => 'bar' }
         }
       end
@@ -45,7 +45,7 @@ describe IssueTrackerDecorator do
       decorator.fields do |itf|
         expect(itf).to be_a(IssueTrackerFieldDecorator)
         expect([:foo, :bar]).to be_include(itf.object)
-        expect([{:label => 'foo'}, {:label => 'bar'}]).to be_include(itf.field_info)
+        expect([{ :label => 'foo' }, { :label => 'bar' }]).to be_include(itf.field_info)
       end
     end
   end
@@ -10,8 +10,8 @@ module ErrbitPlugin
     def self.fields
       {
-        :foo => {:label => 'foo'},
-        :bar => {:label => 'bar'}
+        :foo => { :label => 'foo' },
+        :bar => { :label => 'bar' }
       }
     end
@@ -40,7 +40,7 @@ describe ProblemDestroy do
       end
       it 'delete all notice of associate to this errs' do
-        expect(Notice).to receive(:delete_all).with({:err_id => { '$in' => [err_1.id, err_2.id] }})
+        expect(Notice).to receive(:delete_all).with({ :err_id => { '$in' => [err_1.id, err_2.id] } })
         problem_destroy.execute
       end
     end
@@ -20,7 +20,7 @@ describe ResolvedProblemClearer do
       end
       it 'not repair database' do
         allow(Mongoid.default_client).to receive(:command).and_call_original
-        expect(Mongoid.default_client).to_not receive(:command).with({:repairDatabase => 1})
+        expect(Mongoid.default_client).to_not receive(:command).with({ :repairDatabase => 1 })
         resolved_problem_clearer.execute
       end
     end
@@ -28,7 +28,7 @@ describe ResolvedProblemClearer do
     context "with problem resolve" do
       before do
         allow(Mongoid.default_client).to receive(:command).and_call_original
-        allow(Mongoid.default_client).to receive(:command).with({:repairDatabase => 1})
+        allow(Mongoid.default_client).to receive(:command).with({ :repairDatabase => 1 })
         problems.first.resolve!
         problems.second.resolve!
       end
@@ -44,7 +44,7 @@ describe ResolvedProblemClearer do
       end
       it 'repair database' do
-        expect(Mongoid.default_client).to receive(:command).with({:repairDatabase => 1})
+        expect(Mongoid.default_client).to receive(:command).with({ :repairDatabase => 1 })
         resolved_problem_clearer.execute
       end
     end
@@ -7,7 +7,7 @@ describe AirbrakeApi::V3::NoticeParser do
     }.to raise_error(AirbrakeApi::ParamsError)
     expect {
-      AirbrakeApi::V3::NoticeParser.new({'errors' => []}).report
+      AirbrakeApi::V3::NoticeParser.new({ 'errors' => [] }).report
     }.to raise_error(AirbrakeApi::ParamsError)
   end
@@ -20,7 +20,7 @@ describe AirbrakeApi::V3::NoticeParser do
     expect(report.error_class).to eq('Error')
     expect(report.message).to eq('Error: TestError')
     expect(report.backtrace.lines.size).to eq(9)
-    expect(notice.user_attributes).to include({'Id' => 1, 'Name' => 'John Doe', 'Email' => 'john.doe@example.org', 'Username' => 'john'})
+    expect(notice.user_attributes).to include({ 'Id' => 1, 'Name' => 'John Doe', 'Email' => 'john.doe@example.org', 'Username' => 'john' })
     expect(notice.session).to include('isAdmin' => true)
     expect(notice.params).to include('returnTo' => 'dashboard')
     expect(notice.env_vars).to include(
@@ -21,8 +21,8 @@ describe Notice, type: &#39;model&#39; do
   describe "key sanitization" do
     before do
-      @hash = { "some.key" => { "$nested.key" => {"$Path" => "/", "some$key" => "key"}}}
-      @hash_sanitized = { "some&#46;key" => { "&#36;nested&#46;key" => {"&#36;Path" => "/", "some$key" => "key"}}}
+      @hash = { "some.key" => { "$nested.key" => { "$Path" => "/", "some$key" => "key" } } }
+      @hash_sanitized = { "some&#46;key" => { "&#36;nested&#46;key" => { "&#36;Path" => "/", "some$key" => "key" } } }
     end
     [:server_environment, :request, :notifier].each do |key|
       it "replaces . with &#46; and $ with &#36; in keys used in #{key}" do
@@ -37,7 +37,7 @@ describe Notice, type: &#39;model&#39; do
     let(:notice)  { Fabricate.build(:notice, request: request) }
     context "when it has a request url" do
-      let(:request) { {'url' => "http://example.com/resource/12", 'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0'}} }
+      let(:request) { { 'url' => "http://example.com/resource/12", 'cgi-data' => { 'HTTP_USER_AGENT' => 'Mozilla/5.0' } } }
       it 'has a curl representation' do
         cmd = notice.to_curl
@@ -46,7 +46,7 @@ describe Notice, type: &#39;model&#39; do
     end
     context "when it has not a request url" do
-      let(:request) { {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0'}} }
+      let(:request) { { 'cgi-data' => { 'HTTP_USER_AGENT' => 'Mozilla/5.0' } } }
       it 'has a curl representation' do
         cmd = notice.to_curl
@@ -57,9 +57,9 @@ describe Notice, type: &#39;model&#39; do
   describe "user agent" do
     it "should be parsed and human-readable" do
-      notice = Fabricate.build(:notice, :request => {'cgi-data' => {
+      notice = Fabricate.build(:notice, :request => { 'cgi-data' => {
         'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'
-      }})
+      } })
       expect(notice.user_agent.browser).to eq 'Chrome'
       expect(notice.user_agent.version.to_s).to match(/^10\.0/)
     end
@@ -72,7 +72,7 @@ describe Notice, type: &#39;model&#39; do
   describe "user agent string" do
     it "should be parsed and human-readable" do
-      notice = Fabricate.build(:notice, :request => {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'}})
+      notice = Fabricate.build(:notice, :request => { 'cgi-data' => { 'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16' } })
       expect(notice.user_agent_string).to eq 'Chrome 10.0.648.204 (OS X 10.6.7)'
     end
@@ -84,17 +84,17 @@ describe Notice, type: &#39;model&#39; do
   describe "host" do
     it "returns host if url is valid" do
-      notice = Fabricate.build(:notice, :request => {'url' => "http://example.com/resource/12"})
+      notice = Fabricate.build(:notice, :request => { 'url' => "http://example.com/resource/12" })
       expect(notice.host).to eq 'example.com'
     end
     it "returns 'N/A' when url is not valid" do
-      notice = Fabricate.build(:notice, :request => {'url' => "file:///path/to/some/resource/12"})
+      notice = Fabricate.build(:notice, :request => { 'url' => "file:///path/to/some/resource/12" })
       expect(notice.host).to eq 'N/A'
     end
     it "returns 'N/A' when url is not valid" do
-      notice = Fabricate.build(:notice, :request => {'url' => "some string"})
+      notice = Fabricate.build(:notice, :request => { 'url' => "some string" })
       expect(notice.host).to eq 'N/A'
     end
@@ -6,7 +6,7 @@ describe NotificationServices::HubotService, type: &#39;model&#39; do
     problem = notice.problem
     # faraday stubbing
-    expect(HTTParty).to receive(:post).with(notification_service.api_token, :body => {:message => an_instance_of(String), :room => notification_service.room_id}).and_return(true)
+    expect(HTTParty).to receive(:post).with(notification_service.api_token, :body => { :message => an_instance_of(String), :room => notification_service.room_id }).and_return(true)
     notification_service.create_notification(problem)
   end
@@ -47,7 +47,7 @@ describe NotificationServices::SlackService, type: &#39;model&#39; do
         }
       ]
     }.to_json
-    expect(HTTParty).to receive(:post).with(notification_service.service_url, :body => payload, :headers => {"Content-Type" => "application/json"}).and_return(true)
+    expect(HTTParty).to receive(:post).with(notification_service.service_url, :body => payload, :headers => { "Content-Type" => "application/json" }).and_return(true)
     notification_service.create_notification(problem)
   end
@@ -273,7 +273,7 @@ describe Problem, type: &#39;model&#39; do
       expect {
         @err.notices.first.destroy
         @problem.reload
-      }.to change(@problem, :messages).from({Digest::MD5.hexdigest('ERR 1') => {'value' => 'ERR 1', 'count' => 1}}).to({})
+      }.to change(@problem, :messages).from({ Digest::MD5.hexdigest('ERR 1') => { 'value' => 'ERR 1', 'count' => 1 } }).to({})
     end
     it "removing a notice from the problem with broken counter should not raise an error" do
@@ -296,11 +296,11 @@ describe Problem, type: &#39;model&#39; do
     end
     it "removing a notice removes string from #hosts" do
-      Fabricate(:notice, :err => @err, :request => {'url' => "http://example.com/resource/12"})
+      Fabricate(:notice, :err => @err, :request => { 'url' => "http://example.com/resource/12" })
       expect {
         @err.notices.first.destroy
         @problem.reload
-      }.to change(@problem, :hosts).from({Digest::MD5.hexdigest('example.com') => {'value' => 'example.com', 'count' => 1}}).to({})
+      }.to change(@problem, :hosts).from({ Digest::MD5.hexdigest('example.com') => { 'value' => 'example.com', 'count' => 1 } }).to({})
     end
   end
@@ -316,12 +316,12 @@ describe Problem, type: &#39;model&#39; do
     end
     it "removing a notice removes string from #user_agents" do
-      Fabricate(:notice, :err => @err, :request => {'cgi-data' => {'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16'}})
+      Fabricate(:notice, :err => @err, :request => { 'cgi-data' => { 'HTTP_USER_AGENT' => 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16' } })
       expect {
         @err.notices.first.destroy
         @problem.reload
       }.to change(@problem, :user_agents).from({
-        Digest::MD5.hexdigest('Chrome 10.0.648.204 (OS X 10.6.7)') => {'value' => 'Chrome 10.0.648.204 (OS X 10.6.7)', 'count' => 1}
+        Digest::MD5.hexdigest('Chrome 10.0.648.204 (OS X 10.6.7)') => { 'value' => 'Chrome 10.0.648.204 (OS X 10.6.7)', 'count' => 1 }
       }).to({})
     end
   end
@@ -438,19 +438,19 @@ describe Problem, type: &#39;model&#39; do
       it 'update stats messages' do
         expect(problem.messages).to eq({
-          Digest::MD5.hexdigest(notice.message) => {'value' => notice.message, 'count' => 1}
+          Digest::MD5.hexdigest(notice.message) => { 'value' => notice.message, 'count' => 1 }
         })
       end
       it 'update stats hosts' do
         expect(problem.hosts).to eq({
-          Digest::MD5.hexdigest(notice.host) => {'value' => notice.host, 'count' => 1}
+          Digest::MD5.hexdigest(notice.host) => { 'value' => notice.host, 'count' => 1 }
         })
       end
       it 'update stats user_agents' do
         expect(problem.user_agents).to eq({
-          Digest::MD5.hexdigest(notice.user_agent_string) => {'value' => notice.user_agent_string, 'count' => 1}
+          Digest::MD5.hexdigest(notice.user_agent_string) => { 'value' => notice.user_agent_string, 'count' => 1 }
         })
       end
     end
@@ -478,19 +478,19 @@ describe Problem, type: &#39;model&#39; do
       it 'update stats messages' do
         expect(problem.messages).to eq({
-          Digest::MD5.hexdigest(notice.message) => {'value' => notice.message, 'count' => 3}
+          Digest::MD5.hexdigest(notice.message) => { 'value' => notice.message, 'count' => 3 }
         })
       end
       it 'update stats hosts' do
         expect(problem.hosts).to eq({
-          Digest::MD5.hexdigest(notice.host) => {'value' => notice.host, 'count' => 3}
+          Digest::MD5.hexdigest(notice.host) => { 'value' => notice.host, 'count' => 3 }
         })
       end
       it 'update stats user_agents' do
         expect(problem.user_agents).to eq({
-          Digest::MD5.hexdigest(notice.user_agent_string) => {'value' => notice.user_agent_string, 'count' => 3}
+          Digest::MD5.hexdigest(notice.user_agent_string) => { 'value' => notice.user_agent_string, 'count' => 3 }
         })
       end
     end
@@ -9,7 +9,7 @@ def it_requires_authentication(options = {})
       :update   => :put,
       :destroy  => :delete
     },
-    :params => {:id => '4c6c760494df2a18cc000015'}
+    :params => { :id => '4c6c760494df2a18cc000015' }
   }
   options.reverse_merge!(default_options)
@@ -38,7 +38,7 @@ def it_requires_admin_privileges(options = {})
       :update   => :put,
       :destroy  => :delete
     },
-    :params => {:id => 'dummyid'}
+    :params => { :id => 'dummyid' }
   }
   options.reverse_merge!(default_options)
 describe "notices/_user_attributes.html.haml", type: 'view' do
   describe 'autolink' do
     let(:notice) do
-      user_attributes = { 'foo' => {'bar' => 'http://example.com'} }
+      user_attributes = { 'foo' => { 'bar' => 'http://example.com' } }
       Fabricate(:notice, :user_attributes => user_attributes)
     end
	@@ -295,12 +295,6 @@ Style/SpaceInsideBrackets:		@@ -295,12 +295,6 @@ Style/SpaceInsideBrackets:
295	- 'spec/lib/configurator_spec.rb'	295	- 'spec/lib/configurator_spec.rb'
296	- 'spec/models/issue_spec.rb'	296	- 'spec/models/issue_spec.rb'
297		297
298	-# Offense count: 189
299	-# Cop supports --auto-correct.
300	-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
301	-Style/SpaceInsideHashLiteralBraces:
302	- Enabled: false
303	-
304	# Offense count: 873	298	# Offense count: 873
305	# Cop supports --auto-correct.	299	# Cop supports --auto-correct.
306	# Configuration parameters: EnforcedStyle, SupportedStyles.	300	# Configuration parameters: EnforcedStyle, SupportedStyles.
	@@ -8,7 +8,7 @@ class Api::V1::NoticesController < ApplicationController		@@ -8,7 +8,7 @@ class Api::V1::NoticesController < ApplicationController
8	if params.key?(:start_date) && params.key?(:end_date)	8	if params.key?(:start_date) && params.key?(:end_date)
9	start_date = Time.zone.parse(params[:start_date]).utc	9	start_date = Time.zone.parse(params[:start_date]).utc
10	end_date = Time.zone.parse(params[:end_date]).utc	10	end_date = Time.zone.parse(params[:end_date]).utc
11	- query = {:created_at => {"$lte" => end_date, "$gte" => start_date}}	11	+ query = { :created_at => { "$lte" => end_date, "$gte" => start_date } }
12	end	12	end
13		13
14	results = benchmark("[api/v1/notices_controller] query time") do	14	results = benchmark("[api/v1/notices_controller] query time") do
	@@ -24,7 +24,7 @@ class Api::V1::ProblemsController < ApplicationController		@@ -24,7 +24,7 @@ class Api::V1::ProblemsController < ApplicationController
24	if params.key?(:start_date) && params.key?(:end_date)	24	if params.key?(:start_date) && params.key?(:end_date)
25	start_date = Time.parse(params[:start_date]).utc	25	start_date = Time.parse(params[:start_date]).utc
26	end_date = Time.parse(params[:end_date]).utc	26	end_date = Time.parse(params[:end_date]).utc
27	- query = {:first_notice_at => {"$lte" => end_date}, "$or" => [{:resolved_at => nil}, {:resolved_at => {"$gte" => start_date}}]}	27	+ query = { :first_notice_at => { "$lte" => end_date }, "$or" => [{ :resolved_at => nil }, { :resolved_at => { "$gte" => start_date } }] }
28	end	28	end
29		29
30	results = benchmark("[api/v1/problems_controller/index] query time") do	30	results = benchmark("[api/v1/problems_controller/index] query time") do
	@@ -22,7 +22,7 @@ module NavigationHelper		@@ -22,7 +22,7 @@ module NavigationHelper
22	matches.each {\|c\| s[c] = :all}	22	matches.each {\|c\| s[c] = :all}
23	s	23	s
24	else	24	else
25	- {matches => :all}	25	+ { matches => :all }
26	end	26	end
27		27
28	active = nil	28	active = nil
	@@ -21,7 +21,7 @@ if defined? Flowdock		@@ -21,7 +21,7 @@ if defined? Flowdock
21	end	21	end
22		22
23	def create_notification(problem)	23	def create_notification(problem)
24	- flow = Flowdock::Flow.new(:api_token => api_token, :source => "Errbit", :from => {:name => "Errbit", :address => ENV['ERRBIT_EMAIL_FROM'] \|\| 'support@flowdock.com'})	24	+ flow = Flowdock::Flow.new(:api_token => api_token, :source => "Errbit", :from => { :name => "Errbit", :address => ENV['ERRBIT_EMAIL_FROM'] \|\| 'support@flowdock.com' })
25	subject = "[#{problem.environment}] #{problem.message.to_s.truncate(100)}"	25	subject = "[#{problem.environment}] #{problem.message.to_s.truncate(100)}"
26	url = app_problem_url problem.app, problem	26	url = app_problem_url problem.app, problem
27	flow.push_to_team_inbox(:subject => subject, :content => content(problem, url), :project => project_name(problem), :link => url)	27	flow.push_to_team_inbox(:subject => subject, :content => content(problem, url), :project => project_name(problem), :link => url)
	@@ -26,6 +26,6 @@ class NotificationServices::HubotService < NotificationService		@@ -26,6 +26,6 @@ class NotificationServices::HubotService < NotificationService
26	end	26	end
27		27
28	def create_notification(problem)	28	def create_notification(problem)
29	- HTTParty.post(url, :body => {:message => message_for_hubot(problem), :room => room_id})	29	+ HTTParty.post(url, :body => { :message => message_for_hubot(problem), :room => room_id })
30	end	30	end
31	end	31	end
	@@ -14,7 +14,7 @@ class NotificationServices::WebhookService < NotificationService		@@ -14,7 +14,7 @@ class NotificationServices::WebhookService < NotificationService
14	end	14	end
15		15
16	def message_for_webhook(problem)	16	def message_for_webhook(problem)
17	- {:problem => {:url => problem_url(problem)}.merge(problem.as_json).to_json}	17	+ { :problem => { :url => problem_url(problem) }.merge(problem.as_json).to_json }
18	end	18	end
19		19
20	def create_notification(problem)	20	def create_notification(problem)
	@@ -139,7 +139,7 @@ class Problem		@@ -139,7 +139,7 @@ class Problem
139	# find only notices related to this problem	139	# find only notices related to this problem
140	Notice.collection.find.aggregate([	140	Notice.collection.find.aggregate([
141	{ "$match" => { err_id: { "$in" => err_ids } } },	141	{ "$match" => { err_id: { "$in" => err_ids } } },
142	- { "$group" => { _id: "$#{v}", count: {"$sum" => 1} } }	142	+ { "$group" => { _id: "$#{v}", count: { "$sum" => 1 } } }
143	]).each do \|agg\|	143	]).each do \|agg\|
144	send(k)[Digest::MD5.hexdigest(agg[:_id] \|\| 'N/A')] = {	144	send(k)[Digest::MD5.hexdigest(agg[:_id] \|\| 'N/A')] = {
145	'value' => agg[:_id] \|\| 'N/A',	145	'value' => agg[:_id] \|\| 'N/A',
	@@ -194,7 +194,7 @@ class Problem		@@ -194,7 +194,7 @@ class Problem
194	end	194	end
195		195
196	def unmerge!	196	def unmerge!
197	- attrs = {:error_class => error_class, :environment => environment}	197	+ attrs = { :error_class => error_class, :environment => environment }
198	problem_errs = errs.to_a	198	problem_errs = errs.to_a
199		199
200	# associate and return all the problems	200	# associate and return all the problems
	@@ -241,7 +241,7 @@ class Problem		@@ -241,7 +241,7 @@ class Problem
241	end	241	end
242		242
243	def self.search(value)	243	def self.search(value)
244	- Problem.where({'$text' => {'$search' => value}})	244	+ Problem.where({ '$text' => { '$search' => value } })
245	end	245	end
246		246
247	private	247	private
	@@ -12,15 +12,15 @@ module Hoptoad		@@ -12,15 +12,15 @@ module Hoptoad
12	case node	12	case node
13	when Hash	13	when Hash
14	if node.key?('var') && node.key?('key')	14	if node.key?('var') && node.key?('key')
15	- {normalize_key(node['key']) => rekey(node['var'])}	15	+ { normalize_key(node['key']) => rekey(node['var']) }
16	elsif node.key?('var')	16	elsif node.key?('var')
17	rekey(node['var'])	17	rekey(node['var'])
18	elsif node.key?('__content__') && node.key?('key')	18	elsif node.key?('__content__') && node.key?('key')
19	- {normalize_key(node['key']) => rekey(node['__content__'])}	19	+ { normalize_key(node['key']) => rekey(node['__content__']) }
20	elsif node.key?('__content__')	20	elsif node.key?('__content__')
21	rekey(node['__content__'])	21	rekey(node['__content__'])
22	elsif node.key?('key')	22	elsif node.key?('key')
23	- {normalize_key(node['key']) => nil}	23	+ { normalize_key(node['key']) => nil }
24	else	24	else
25	node.inject({}) {\|rekeyed, (key, val)\| rekeyed.merge(normalize_key(key) => rekey(val))}	25	node.inject({}) {\|rekeyed, (key, val)\| rekeyed.merge(normalize_key(key) => rekey(val))}
26	end	26	end
	@@ -29,7 +29,7 @@ describe Api::V1::NoticesController, type: 'controller' do		@@ -29,7 +29,7 @@ describe Api::V1::NoticesController, type: 'controller' do
29		29
30	describe "given a date range" do	30	describe "given a date range" do
31	it "should return only the notices created during the date range" do	31	it "should return only the notices created during the date range" do
32	- get :index, {:auth_token => @user.authentication_token, :start_date => "2012-08-01", :end_date => "2012-08-27"}	32	+ get :index, { :auth_token => @user.authentication_token, :start_date => "2012-08-01", :end_date => "2012-08-27" }
33	expect(response).to be_success	33	expect(response).to be_success
34	notices = JSON.load response.body	34	notices = JSON.load response.body
35	expect(notices.length).to eq 3	35	expect(notices.length).to eq 3
	@@ -37,7 +37,7 @@ describe Api::V1::NoticesController, type: 'controller' do		@@ -37,7 +37,7 @@ describe Api::V1::NoticesController, type: 'controller' do
37	end	37	end
38		38
39	it "should return all notices" do	39	it "should return all notices" do
40	- get :index, {:auth_token => @user.authentication_token}	40	+ get :index, { :auth_token => @user.authentication_token }
41	expect(response).to be_success	41	expect(response).to be_success
42	notices = JSON.load response.body	42	notices = JSON.load response.body
43	expect(notices.length).to eq 4	43	expect(notices.length).to eq 4