Commit f1f39cdcf1772615e313dbd4d23462fd1f1d676b
1 parent
47b11978
Exists in
master
and in
1 other branch
Rubocop: consistently indenting private/protected with method defs
That's what the majority of the codebase is using, so following that
Showing
12 changed files
with
22 additions
and
36 deletions
Show diff stats
.rubocop_todo.yml
1 | 1 | # This configuration was generated by |
2 | 2 | # `rubocop --auto-gen-config` |
3 | -# on 2015-10-12 09:35:47 +0200 using RuboCop version 0.34.2. | |
3 | +# on 2015-10-12 21:40:12 +0200 using RuboCop version 0.34.2. | |
4 | 4 | # The point is for the user to remove these configuration records |
5 | 5 | # one by one as the offenses are removed from the code base. |
6 | 6 | # Note that changes in the inspected code, or installation of new |
... | ... | @@ -82,12 +82,6 @@ Rails/Validation: |
82 | 82 | - 'app/models/problem.rb' |
83 | 83 | - 'app/models/user.rb' |
84 | 84 | |
85 | -# Offense count: 2 | |
86 | -# Cop supports --auto-correct. | |
87 | -# Configuration parameters: EnforcedStyle, SupportedStyles. | |
88 | -Style/AccessModifierIndentation: | |
89 | - Enabled: false | |
90 | - | |
91 | 85 | # Offense count: 8 |
92 | 86 | # Cop supports --auto-correct. |
93 | 87 | # Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles. |
... | ... | @@ -232,12 +226,11 @@ Style/EmptyLineBetweenDefs: |
232 | 226 | - 'spec/decorators/issue_tracker_type_decorator_spec.rb' |
233 | 227 | - 'spec/views/problems/show.html.haml_spec.rb' |
234 | 228 | |
235 | -# Offense count: 13 | |
229 | +# Offense count: 12 | |
236 | 230 | # Cop supports --auto-correct. |
237 | 231 | Style/EmptyLines: |
238 | 232 | Exclude: |
239 | 233 | - 'app/controllers/api/v1/stats_controller.rb' |
240 | - - 'app/controllers/application_controller.rb' | |
241 | 234 | - 'app/decorators/issue_tracker_field_decorator.rb' |
242 | 235 | - 'app/models/app.rb' |
243 | 236 | - 'app/models/problem.rb' |
... | ... | @@ -246,20 +239,6 @@ Style/EmptyLines: |
246 | 239 | - 'script/rspec-queue-mongoid.rb' |
247 | 240 | - 'spec/acceptance/app_regenerate_api_key_spec.rb' |
248 | 241 | |
249 | -# Offense count: 9 | |
250 | -# Cop supports --auto-correct. | |
251 | -Style/EmptyLinesAroundAccessModifier: | |
252 | - Exclude: | |
253 | - - 'app/controllers/apps_controller.rb' | |
254 | - - 'app/controllers/comments_controller.rb' | |
255 | - - 'app/decorators/backtrace_line_decorator.rb' | |
256 | - - 'app/helpers/application_helper.rb' | |
257 | - - 'app/models/backtrace.rb' | |
258 | - - 'app/models/comment.rb' | |
259 | - - 'lib/hoptoad.rb' | |
260 | - - 'lib/hoptoad/v2.rb' | |
261 | - - 'lib/overrides/hoptoad_notifier/hoptoad_notifier.rb' | |
262 | - | |
263 | 242 | # Offense count: 28 |
264 | 243 | # Cop supports --auto-correct. |
265 | 244 | # Configuration parameters: EnforcedStyle, SupportedStyles. |
... | ... | @@ -377,13 +356,6 @@ Style/IndentationConsistency: |
377 | 356 | - 'app/models/watcher.rb' |
378 | 357 | - 'lib/hoptoad.rb' |
379 | 358 | |
380 | -# Offense count: 1 | |
381 | -# Cop supports --auto-correct. | |
382 | -# Configuration parameters: Width. | |
383 | -Style/IndentationWidth: | |
384 | - Exclude: | |
385 | - - 'app/controllers/notices_controller.rb' | |
386 | - | |
387 | 359 | # Offense count: 6 |
388 | 360 | # Cop supports --auto-correct. |
389 | 361 | Style/Lambda: |
... | ... | @@ -473,9 +445,15 @@ Style/Proc: |
473 | 445 | - 'app/models/problem.rb' |
474 | 446 | |
475 | 447 | # Offense count: 2 |
476 | -# Configuration parameters: SupportedStyles. | |
448 | +# Configuration parameters: EnforcedStyle, SupportedStyles. | |
477 | 449 | Style/RaiseArgs: |
478 | - EnforcedStyle: compact | |
450 | + Enabled: false | |
451 | + | |
452 | +# Offense count: 1 | |
453 | +# Cop supports --auto-correct. | |
454 | +Style/RedundantException: | |
455 | + Exclude: | |
456 | + - 'Gemfile' | |
479 | 457 | |
480 | 458 | # Offense count: 13 |
481 | 459 | # Cop supports --auto-correct. | ... | ... |
app/controllers/application_controller.rb
app/controllers/apps_controller.rb
app/controllers/comments_controller.rb
app/controllers/notices_controller.rb
... | ... | @@ -15,7 +15,7 @@ class NoticesController < ApplicationController |
15 | 15 | if report.should_keep? |
16 | 16 | report.generate_notice! |
17 | 17 | api_xml = report.notice.to_xml(:only => false, :methods => [:id]) do |xml| |
18 | - xml.url locate_url(report.notice.id, :host => Errbit::Config.host) | |
18 | + xml.url locate_url(report.notice.id, :host => Errbit::Config.host) | |
19 | 19 | end |
20 | 20 | render :xml => api_xml |
21 | 21 | else | ... | ... |
app/decorators/backtrace_line_decorator.rb
app/helpers/application_helper.rb
app/models/backtrace.rb
app/models/comment.rb
lib/hoptoad.rb
lib/hoptoad/v2.rb
lib/overrides/hoptoad_notifier/hoptoad_notifier.rb