Commit f3b1aba021b552acb9d3922445255329607df8ce
1 parent
6cf43dc5
Exists in
master
and in
1 other branch
Fixing slack integration
https://github.com/errbit/errbit/commit/28e1148fd14c63b757bbdf7824fc174d236f49d2 changed SlackService notifier to rely only on the service_url, and no longer needing an api_token This apparently broke the form for any newly created app, because a notifier was only considered `configured?` if the api_token was set, which is now impossible to do for slack I wasn't really sure how to go about this, because I'm not very familiar with the codebase yet, but I just thought I'd push the fix I've made on my fork so this can be properly discussed
Showing
1 changed file
with
4 additions
and
0 deletions
Show diff stats
app/models/notification_services/slack_service.rb
| @@ -24,4 +24,8 @@ class NotificationServices::SlackService < NotificationService | @@ -24,4 +24,8 @@ class NotificationServices::SlackService < NotificationService | ||
| 24 | def create_notification(problem) | 24 | def create_notification(problem) |
| 25 | HTTParty.post(service_url, :body => post_payload(problem), :headers => { 'Content-Type' => 'application/json' }) | 25 | HTTParty.post(service_url, :body => post_payload(problem), :headers => { 'Content-Type' => 'application/json' }) |
| 26 | end | 26 | end |
| 27 | + | ||
| 28 | + def configured? | ||
| 29 | + service_url.present? | ||
| 30 | + end | ||
| 27 | end | 31 | end |