fixed fabricators and a terrible type

Ryan Jones
1 parent d6efeeb3
Showing 3 changed files with 13 additions and 16 deletions Show diff stats
app/models/notification_service.rb
spec/fabricators/notification_service_fabricator.rb
spec/models/notice_observer_spec.rb
@@ -5,7 +5,7 @@ class NotificationService
   field :api_token, :type => String
   field :subdomain, :type => String
-  embedded_in :app, :inverse_of => :notfication_service
+  embedded_in :app, :inverse_of => :notification_service
   validate :check_params
-Fabricator(:notification_service) do
+Fabricator :notification_service  do
+  app!
   room_id { sequence :word }
   api_token { sequence :word }
   subdomain { sequence :word }
 end
-Fabricator :campfire_notification_service, :from => :notification_service, :class_name => "NotificationService::CampfireService" do
-  room_id '123456'
-  api_token 'ertj3qh4895oqhfiugs4g74p5w96'
-  subdomain 'waffles'
+%w(campfire).each do |t|
+  Fabricator "#{t}_notification_service".to_sym, :from => :notification_service, :class_name => "NotificationService::#{t.camelcase}Service"
 end
-
@@ -25,7 +25,6 @@ describe NoticeObserver do
   end
   describe "email notifications for a resolved issue" do
-
     before do
       Errbit::Config.per_app_email_at_notices = true
       @app = Fabricate(:app_with_watcher, :email_at_notices => [1])
@@ -44,24 +43,24 @@ describe NoticeObserver do
     end
   end
-  describe "notifications for campfire" do
+  describe "should send a notification if a notification service is configured" do
+    let(:app) { Fabricate(:app, :email_at_notices => [1], :notification_service => Fabricate(:campfire_notification_service)) }
+    let(:err) { Fabricate(:err, :problem => Fabricate(:problem, :app => app, :notices_count => 100)) }
     before do
       Errbit::Config.per_app_email_at_notices = true
-      @app = Fabricate(:app_with_watcher, :email_at_notices => [1], :issue_tracker => Fabricate(:campfire_tracker))
-      @err = Fabricate(:err, :problem => Fabricate(:problem, :app => @app, :notices_count => 100))
     end
     after do
       Errbit::Config.per_app_email_at_notices = false
     end
-    it "should create a campfire issue" do
-      @err.problem.stub(:notices_count).and_return(1)
-      @app.issue_tracker.stub!(:create_issue).and_return(true)
-      @app.issue_tracker.should_receive(:create_issue)
+    it "should create a campfire notification" do
+      err.problem.stub(:notices_count).and_return(1)
+      app.notification_service.stub!(:create_issue).and_return(true)
+      app.notification_service.should_receive(:create_issue)
-      Fabricate(:notice, :err => @err)
+      Fabricate(:notice, :err => err)
     end
   end
	@@ -5,7 +5,7 @@ class NotificationService		@@ -5,7 +5,7 @@ class NotificationService
5	field :api_token, :type => String	5	field :api_token, :type => String
6	field :subdomain, :type => String	6	field :subdomain, :type => String
7		7
8	- embedded_in :app, :inverse_of => :notfication_service	8	+ embedded_in :app, :inverse_of => :notification_service
9		9
10	validate :check_params	10	validate :check_params
11		11