refactor notices view spec

don't use iVars in spec

refactor notices view spec
don't use iVars in spec
Vasiliy Ermolovich
1 parent a18f42dd
Showing 1 changed file with 6 additions and 8 deletions Show diff stats
spec/views/notices/_backtrace.html.haml_spec.rb
@@ -2,17 +2,15 @@ require &#39;spec_helper&#39;
  
 describe "notices/_backtrace.html.haml" do
   describe 'missing file in backtrace' do
-    before do
-      @notice = Fabricate(:notice, :backtrace => [{
-        'number'  => rand(999),
-        'file'    => nil,
-        'method'  => ActiveSupport.methods.shuffle.first
-      }])
-      assign :app, @notice.err.app
+    let(:notice) do
+      backtrace = { 'number' => rand(999), 'file' => nil, 'method' => ActiveSupport.methods.shuffle.first }
+      Fabricate(:notice, :backtrace => [backtrace])
     end
  
     it "should replace nil file with [unknown source]" do
-      render "notices/backtrace", :lines => @notice.backtrace
+      assign :app, notice.err.app
+
+      render "notices/backtrace", :lines => notice.backtrace
       rendered.should match(/\[unknown source\]/)
     end
   end
...	...	@@ -2,17 +2,15 @@ require 'spec_helper'
2	2
3	3	describe "notices/_backtrace.html.haml" do
4	4	describe 'missing file in backtrace' do
5		- before do
6		- @notice = Fabricate(:notice, :backtrace => [{
7		- 'number' => rand(999),
8		- 'file' => nil,
9		- 'method' => ActiveSupport.methods.shuffle.first
10		- }])
11		- assign :app, @notice.err.app
	5	+ let(:notice) do
	6	+ backtrace = { 'number' => rand(999), 'file' => nil, 'method' => ActiveSupport.methods.shuffle.first }
	7	+ Fabricate(:notice, :backtrace => [backtrace])
12	8	end
13	9
14	10	it "should replace nil file with [unknown source]" do
15		- render "notices/backtrace", :lines => @notice.backtrace
	11	+ assign :app, notice.err.app
	12	+
	13	+ render "notices/backtrace", :lines => notice.backtrace
16	14	rendered.should match(/\[unknown source\]/)
17	15	end
18	16	end
...	...