Download as
Browse Code »

Commit 1c1b12d9f9bf0ea1b0d00d1cf7b4d57d2fbabce8

Authored by Carlos Purificação
1 parent 096ea0b2
Exists in staging and in 28 other branches all_pending_tasks_api, api_roles, comments_permissions, elasticsearch, elasticsearch_categories, elasticsearch_filter, elasticsearch_sort, elasticsearch_to_merge, elasticsearch_view, environment-exposes-api, export-comment-api, export_data, external_followers, federation-webfinger, federation_followers, federation_followers_backend, federation_oauth_provider, federation_webfinger, follower_permition, master, master_profile_followers, oauth_external_login, oauth_login, private-scraps, private-scraps-rebase, production, profile_api_improvements, user_mention

Fixed review points

Showing 1 changed file with 9 additions and 2 deletions   Show diff stats
test/api/articles_test.rb
  Diff comments   View file @1c1b12d
... ... @@ -9,8 +9,6 @@ class ArticlesTest < ActiveSupport::TestCase
9 9  
10 10 should 'remove article' do
11 11 article = fast_create(Article, :profile_id => user.person.id, :name => "Some thing")
12   - article = Article.find(article.id)
13   - assert_not_nil article
14 12 delete "/api/v1/articles/#{article.id}?#{params.to_query}"
15 13 json = JSON.parse(last_response.body)
16 14  
... ... @@ -20,6 +18,15 @@ class ArticlesTest < ActiveSupport::TestCase
20 18 assert !Article.exists?(article.id)
21 19 end
22 20  
  21 + should 'not remove article without permission' do
  22 + otherPerson = fast_create(Person, :name => "Other Person")
  23 + article = fast_create(Article, :profile_id => otherPerson.id, :name => "Some thing")
  24 + delete "/api/v1/articles/#{article.id}?#{params.to_query}"
  25 + json = JSON.parse(last_response.body)
  26 + assert_equal 403, last_response.status
  27 + assert Article.exists?(article.id)
  28 + end
  29 +
23 30 should 'list articles' do
24 31 article = fast_create(Article, :profile_id => user.person.id, :name => "Some thing")
25 32 get "/api/v1/articles/?#{params.to_query}"
... ...