Raising 'not found' page while accessing an unexistent topic in a section

(ActionItem1397)

Raising 'not found' page while accessing an unexistent topic in a section
(ActionItem1397)
Rodrigo Souto · Joenio Costa
1 parent 16d7dc3c
Showing 2 changed files with 14 additions and 1 deletions Show diff stats
app/models/doc_section.rb
test/unit/doc_section_test.rb
@@ -5,7 +5,12 @@ class DocSection &lt; DocItem
   end
  
   def find(id)
-    items.find {|item| item.id == id }
+    topic = items.find {|item| item.id == id }
+    if topic
+      topic
+    else
+      raise DocItem::NotFound
+    end
   end
  
   def self.all(language = 'en', force = false)
@@ -97,4 +97,12 @@ class DocSectionTest &lt; ActiveSupport::TestCase
     end
   end
  
+  should 'raise DocTopic::NotFound when trying to find an unexisting topic inside a section' do
+    section = DocSection.all.first
+    assert_raise DocItem::NotFound do
+      section.find('unexisting')
+    end
+  end
+
+
 end
...	...	@@ -5,7 +5,12 @@ class DocSection < DocItem
5	5	end
6	6
7	7	def find(id)
8		- items.find {\|item\| item.id == id }
	8	+ topic = items.find {\|item\| item.id == id }
	9	+ if topic
	10	+ topic
	11	+ else
	12	+ raise DocItem::NotFound
	13	+ end
9	14	end
10	15
11	16	def self.all(language = 'en', force = false)
...	...
...	...	@@ -97,4 +97,12 @@ class DocSectionTest < ActiveSupport::TestCase
97	97	end
98	98	end
99	99
	100	+ should 'raise DocTopic::NotFound when trying to find an unexisting topic inside a section' do
	101	+ section = DocSection.all.first
	102	+ assert_raise DocItem::NotFound do
	103	+ section.find('unexisting')
	104	+ end
	105	+ end
	106	+
	107	+
100	108	end
...	...