Download as
Browse Code »

Commit 49fc73d73ef6815bc02ab44ef6717da8bf574b06

Authored by Larissa Reis
1 parent a36f5919
Exists in staging and in 42 other branches all_pending_tasks_api, api-articles-period, api_roles, caching-rails4, captcha_serpro_plugin, comments_permissions, content-manager-hostspot, elasticsearch, elasticsearch_api, elasticsearch_categories, elasticsearch_filter, elasticsearch_sort, elasticsearch_to_merge, elasticsearch_view, environment-exposes-api, export-comment-api, export-comment-paragraph, export_data, external_followers, federation-webfinger, federation_followers, federation_followers_backend, federation_oauth_provider, federation_webfinger, fix_event_date_issue, fix_notification_email, fix_string_downcase_and_upcase, follower_permition, json_cookie_serializer, login-captcha, master, master_profile_followers, oauth_external_login, oauth_login, private-scraps, private-scraps-rebase, production, production-vendorized, profile_api_improvements, tasks_keep_filter_params, user_mention, webfinger_server

Adds named_scope for easy retrieval of tasks requested by profile

Showing 2 changed files with 16 additions and 1 deletions   Show diff stats
plugins/custom_forms/lib/custom_forms_plugin/membership_survey.rb
  Diff comments   View file @49fc73d
@@ -5,6 +5,8 @@ class CustomFormsPlugin::MembershipSurvey < Task @@ -5,6 +5,8 @@ class CustomFormsPlugin::MembershipSurvey < Task
5 5
6 include CustomFormsPlugin::Helper 6 include CustomFormsPlugin::Helper
7 7
  8 + named_scope :from, lambda {|profile| {:conditions => {:requestor_id => profile.id}}}
  9 +
8 def perform 10 def perform
9 form = CustomFormsPlugin::Form.find(form_id) 11 form = CustomFormsPlugin::Form.find(form_id)
10 answers = build_answers(submission, form) 12 answers = build_answers(submission, form)
plugins/custom_forms/test/unit/custom_forms_plugin/membership_survey_test.rb
  Diff comments   View file @49fc73d
@@ -23,9 +23,22 @@ class CustomFormsPlugin::MembershipSurveyTest < ActiveSupport::TestCase @@ -23,9 +23,22 @@ class CustomFormsPlugin::MembershipSurveyTest < ActiveSupport::TestCase
23 end 23 end
24 24
25 submission = CustomFormsPlugin::Submission.last 25 submission = CustomFormsPlugin::Submission.last
26 - assert_equal submission.answers.count, 1 26 + assert_equal submission.answers.count, 1
27 27
28 answer = submission.answers.first 28 answer = submission.answers.first
29 assert_equal answer.value, 'Jack' 29 assert_equal answer.value, 'Jack'
30 end 30 end
  31 +
  32 + should 'have a named_scope that retrieves all tasks requested by profile' do
  33 + profile = fast_create(Profile)
  34 + person = fast_create(Person)
  35 + form = CustomFormsPlugin::Form.create!(:name => 'Simple Form', :profile => profile)
  36 + task1 = CustomFormsPlugin::MembershipSurvey.create!(:form_id => form.id, :target => person, :requestor => profile)
  37 + task2 = CustomFormsPlugin::MembershipSurvey.create!(:form_id => form.id, :target => person, :requestor => fast_create(Profile))
  38 + scope = CustomFormsPlugin::MembershipSurvey.from(profile)
  39 +
  40 + assert_equal ActiveRecord::NamedScope::Scope, scope.class
  41 + assert_includes scope, task1
  42 + assert_not_includes scope, task2
  43 + end
31 end 44 end