Download as
Browse Code »

Commit 565f45527705fe7a3a911919878e78297098dc9d

Authored by Antonio Terceiro
1 parent f476a761
Exists in staging and in 42 other branches all_pending_tasks_api, api-articles-period, api_roles, caching-rails4, captcha_serpro_plugin, comments_permissions, content-manager-hostspot, elasticsearch, elasticsearch_api, elasticsearch_categories, elasticsearch_filter, elasticsearch_sort, elasticsearch_to_merge, elasticsearch_view, environment-exposes-api, export-comment-api, export-comment-paragraph, export_data, external_followers, federation-webfinger, federation_followers, federation_followers_backend, federation_oauth_provider, federation_webfinger, fix_event_date_issue, fix_notification_email, fix_string_downcase_and_upcase, follower_permition, json_cookie_serializer, login-captcha, master, master_profile_followers, oauth_external_login, oauth_login, private-scraps, private-scraps-rebase, production, production-vendorized, profile_api_improvements, tasks_keep_filter_params, user_mention, webfinger_server

Cosmetics 

  * Explicitly name the "Icon" column
  * Remove annoying scroll from links edition
  * Point the browser to the top of the page. This way when I edit a block
    that is far down I am sent to the place where the popup appears with
    the edit screen

(ActionItem1428)
Showing 3 changed files with 2 additions and 7 deletions   Show diff stats
app/views/box_organizer/_link_list_block.rhtml
  Diff comments   View file @565f455
1 1 <strong><%= _('Links') %></strong>
2 2 <div id='edit-link-list-block'>
3 3 <table id='links' class='noborder'>
4   - <tr><th></th><th><%= _('Name') %></th><th><%= _('Address') %></th></tr>
  4 + <tr><th><%= _('Icon') %></th><th><%= _('Name') %></th><th><%= _('Address') %></th></tr>
5 5 <% for link in @block.links do %>
6 6 <tr>
7 7 <td>
... ...
public/javascripts/lightbox.js
  Diff comments   View file @565f455
... ... @@ -80,6 +80,7 @@ lightbox.prototype = {
80 80 }
81 81 this.hideObjectsAndEmbeds('hidden');
82 82 this.displayLightbox("block");
  83 + window.location.href= "#";
83 84 },
84 85  
85 86 // Ie requires height to 100% and overflow hidden or else you can scroll down past the lightbox
... ...
public/stylesheets/application.css
  Diff comments   View file @565f455
... ... @@ -1514,12 +1514,6 @@ input.disabled {
1514 1514 }
1515 1515  
1516 1516 /* ==> blocks/link-list-block.css <<= */
1517   -
1518   -#edit-link-list-block {
1519   - overflow: auto;
1520   - overflow-x: hidden;
1521   - height: 120px;
1522   -}
1523 1517  
1524 1518 #edit-link-list-block table {
1525 1519 width: 100%;
... ...