ActionItem543: changing default title of blocks

git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@2184 3f533792-8f58-4932-b0fe-aaf55b0a4547

ActionItem543: changing default title of blocks
git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@2184 3f533792-8f58-4932-b0fe-aaf55b0a4547
AntonioTerceiro
1 parent 99872db5
Showing 32 changed files with 112 additions and 40 deletions Show diff stats
app/models/article_block.rb
app/models/block.rb
app/models/communities_block.rb
app/models/enterprises_block.rb
app/models/environment_statistics_block.rb
app/models/favorite_enterprises_block.rb
app/models/friends_block.rb
app/models/main_block.rb
app/models/members_block.rb
app/models/people_block.rb
app/models/products_block.rb
app/models/profile_info_block.rb
app/models/profile_list_block.rb
app/models/recent_documents_block.rb
app/models/tags_block.rb
app/views/box_organizer/_block.rhtml
app/views/box_organizer/edit.rhtml
test/unit/article_block_test.rb
test/unit/block_test.rb
test/unit/communities_block_test.rb
@@ -36,8 +36,4 @@ class ArticleBlock &lt; Block
     @article = obj
   end
-  def editable?
-    true
-  end
-
 end
@@ -47,7 +47,7 @@ class Block &lt; ActiveRecord::Base
   # Is this block editable? (Default to <tt>false</tt>)
   def editable?
-    false
+    true
   end
   # must always return false, except on MainBlock clas.
@@ -63,4 +63,16 @@ class Block &lt; ActiveRecord::Base
     self.class.name.underscore.gsub('_', '-')
   end
+  def default_title
+    ''
+  end
+
+  def title
+    if self[:title].blank?
+      self.default_title
+    else
+      self[:title]
+    end
+  end
+
 end
@@ -4,7 +4,7 @@ class CommunitiesBlock &lt; ProfileListBlock
     _('A block that displays your communities')
   end
-  def title
+  def default_title
     _('Communities')
   end
 class EnterprisesBlock < ProfileListBlock
-  def title
+  def default_title
     _('Enterprises')
   end
@@ -4,6 +4,10 @@ class EnvironmentStatisticsBlock &lt; Block
     _('Statistical overview of your environment.')
   end
+  def default_title
+    _('Statistics for %s') % owner.name
+  end
+
   def content
     users = owner.people.count
     enterprises = owner.enterprises.count
@@ -15,7 +19,7 @@ class EnvironmentStatisticsBlock &lt; Block
       n_('One community', '%{num} communities', communities) % { :num => communities },
     ]
-    block_title(_('Statistics for %s') % owner.name) + content_tag('ul', info.map {|item| content_tag('li', item) }.join("\n"))
+    block_title(title) + content_tag('ul', info.map {|item| content_tag('li', item) }.join("\n"))
   end
 end
 class FavoriteEnterprisesBlock < ProfileListBlock
-  def title
+  def default_title
     _('Favorite Enterprises')
   end
@@ -4,7 +4,7 @@ class FriendsBlock &lt; ProfileListBlock
     _('A block that displays your friends')
   end
-  def title
+  def default_title
     _('Friends')
   end
@@ -12,4 +12,8 @@ class MainBlock &lt; Block
     true
   end
+  def editable?
+    false
+  end
+
 end
@@ -4,7 +4,7 @@ class MembersBlock &lt; ProfileListBlock
     _('A block that displays members.')
   end
-  def title
+  def default_title
     _('Members')
   end
 class PeopleBlock < ProfileListBlock
-  def title
+  def default_title
     _('People')
   end
@@ -4,8 +4,12 @@ class ProductsBlock &lt; Block
   include ActionView::Helpers::UrlHelper
   include ActionController::UrlWriter
+  def default_title
+    _('Products')
+  end
+
   def content
-    block_title(_('Products')) +
+    block_title(title) +
     content_tag(
       'ul',
       products.map {|product| content_tag('li', link_to(product.name, product.url, :style => 'background-image:url(%s)' % ( product.image ? product.image.public_filename(:minor) : '/images/icons-app/product-default-pic-minor.png' )), :class => 'product' )}
@@ -37,8 +41,4 @@ class ProductsBlock &lt; Block
     end
   end
-  def editable?
-    true
-  end
-
 end
@@ -15,4 +15,8 @@ class ProfileInfoBlock &lt; Block
     end
   end
+  def editable?
+    false
+  end
+
 end
@@ -51,7 +51,7 @@ class ProfileListBlock &lt; Block
   end
   # the title of the block. Probably will be overriden in subclasses.
-  def title
+  def default_title
     _('People and Groups')
   end
@@ -4,13 +4,17 @@ class RecentDocumentsBlock &lt; Block
     _('List of recent content')
   end
+  def default_title
+    _('Recent content')
+  end
+
   settings_items :limit
   include ActionController::UrlWriter
   def content
     docs = self.limit.nil? ? owner.recent_documents : owner.recent_documents(self.limit)
-    block_title(_('Recent content')) +
+    block_title(title) +
     content_tag('ul', docs.map {|item| content_tag('li', link_to(item.title, item.url))}.join("\n"))
   end
@@ -8,6 +8,10 @@ class TagsBlock &lt; Block
     _('Block listing content count by tag')
   end
+  def default_title
+    _('tags')
+  end
+
   def help
     _('The tag is created when you add some one to your article. <p/>
        Try to add some tags to some articles and see your tag cloud to grow.')
@@ -17,7 +21,7 @@ class TagsBlock &lt; Block
     tags = owner.tags
     return '' if tags.empty?
-    block_title( _('tags') ) +
+    block_title(title) +
     "\n<div class='tag_cloud'>\n"+
     tag_cloud( owner.tags, :id,
                owner.generate_url(:controller => 'profile', :action => 'tag'),
@@ -0,0 +1 @@
+<!-- empty -->
@@ -2,6 +2,8 @@
 <% form_tag(:action => 'save', :id => @block.id) do %>
+  <%= labelled_form_field(_('Custom title for this block: '), text_field(:block, :title)) %>
+
   <%= render :partial => partial_for_class(@block.class) %>
   <% button_bar do %>
@@ -52,8 +52,4 @@ class ArticleBlockTest &lt; Test::Unit::TestCase
     assert_nil block.article_id
   end
-  should 'be editable' do
-    assert ArticleBlock.new.editable?
-  end
-
 end
@@ -32,8 +32,20 @@ class BlockTest &lt; Test::Unit::TestCase
     assert_nil Block.new.footer
   end
-  should 'not be editable by default' do
-    assert !Block.new.editable?
+  should 'provide an empty default title' do
+    assert_equal '', Block.new.default_title
   end
+  should 'be editable by default' do
+    assert Block.new.editable?
+  end
+
+  should 'have default titles' do
+    b = Block.new
+    b.expects(:default_title).returns('my title')
+    assert_equal 'my title', b.title
+  end
+
+
+
 end
@@ -6,8 +6,8 @@ class CommunitiesBlockTest &lt; Test::Unit::TestCase
     assert_kind_of ProfileListBlock, CommunitiesBlock.new
   end
-  should 'declare its title' do
-    assert_not_equal ProfileListBlock.new.title, CommunitiesBlock.new.title
+  should 'declare its default title' do
+    assert_not_equal ProfileListBlock.new.default_title, CommunitiesBlock.new.default_title
   end
   should 'describe itself' do
@@ -6,8 +6,8 @@ class EnterprisesBlockTest &lt; Test::Unit::TestCase
     assert_kind_of ProfileListBlock, EnterprisesBlock.new
   end
-  should 'declare its title' do
-    assert_not_equal ProfileListBlock.new.title, EnterprisesBlock.new.title
+  should 'declare its default title' do
+    assert_not_equal ProfileListBlock.new.default_title, EnterprisesBlock.new.default_title
   end
   should 'describe itself' do
@@ -10,6 +10,15 @@ class EnvironmentStatisticsBlockTest &lt; Test::Unit::TestCase
     assert_not_equal Block.description, EnvironmentStatisticsBlock.description
   end
+  should 'provide a default title' do
+    owner = mock
+    owner.expects(:name).returns('my environment')
+
+    block = EnvironmentStatisticsBlock.new
+    block.expects(:owner).returns(owner)
+    assert_equal 'Statistics for my environment', block.title
+  end
+
   should 'generate statistics' do
     env = Environment.create!(:name => "My test environment")
     user1 = create_user('testuser1', :environment_id => env.id)
@@ -6,8 +6,8 @@ class FavoriteEnterprisesBlockTest &lt; ActiveSupport::TestCase
     assert_kind_of ProfileListBlock, FavoriteEnterprisesBlock.new
   end
-  should 'declare its title' do
-    assert_not_equal ProfileListBlock.new.title, FavoriteEnterprisesBlock.new.title
+  should 'declare its default title' do
+    assert_not_equal ProfileListBlock.new.default_title, FavoriteEnterprisesBlock.new.default_title
   end
   should 'describe itself' do
@@ -6,8 +6,8 @@ class FriendsBlockTest &lt; ActiveSupport::TestCase
     assert_not_equal ProfileListBlock.description, FriendsBlock.description
   end
-  should 'declare its title' do
-    assert_not_equal ProfileListBlock.new.title, FriendsBlock.new.title
+  should 'declare its default title' do
+    assert_not_equal ProfileListBlock.new.default_title, FriendsBlock.new.default_title
   end
   should 'use its own finder' do
@@ -11,4 +11,8 @@ class MainBlockTest &lt; Test::Unit::TestCase
     ok("MainBlock must not have a content") { MainBlock.new.content.blank? }
   end
+  should 'not be editable' do
+    assert !MainBlock.new.editable?
+  end
+
 end
@@ -10,6 +10,10 @@ class MembersBlockTest &lt; Test::Unit::TestCase
     assert_not_equal ProfileListBlock.description, MembersBlock.description
   end
+  should 'provide a default title' do
+    assert_not_equal ProfileListBlock.new.default_title, MembersBlock.new.default_title
+  end
+
   should 'link to "all members" page' do
     profile = create_user('mytestuser').person
     block = MembersBlock.new
@@ -6,8 +6,8 @@ class PeopleBlockTest &lt; ActiveSupport::TestCase
     assert_kind_of ProfileListBlock, PeopleBlock.new
   end
-  should 'declare its title' do
-    assert_not_equal ProfileListBlock.new.title, PeopleBlock.new.title
+  should 'declare its default title' do
+    assert_not_equal ProfileListBlock.new.default_title, PeopleBlock.new.default_title
   end
   should 'describe itself' do
@@ -11,6 +11,10 @@ class ProductsBlockTest &lt; ActiveSupport::TestCase
     assert_kind_of Block, block
   end
+  should 'provide default title' do
+    assert_not_equal Block.new.default_title, ProductsBlock.new.default_title
+  end
+
   should "list owner products" do
     enterprise = Enterprise.create!(:name => 'testenterprise', :identifier => 'testenterprise')
@@ -99,8 +103,4 @@ class ProductsBlockTest &lt; ActiveSupport::TestCase
     assert_equal [1, 2], block.product_ids
   end
-  should 'be editable' do
-    assert ProductsBlock.new.editable?
-  end
-
 end
@@ -20,5 +20,9 @@ class ProfileInfoBlockTest &lt; Test::Unit::TestCase
     self.expects(:render).with(:file => 'blocks/profile_info', :locals => { :block => block})
     instance_eval(& block.content)
   end
+
+  should 'not be editable' do
+    assert !ProfileInfoBlock.new.editable?
+  end
 end
@@ -6,6 +6,10 @@ class ProfileListBlockTest &lt; Test::Unit::TestCase
     assert_not_equal Block.description, ProfileListBlock.description
   end
+  should 'provide a default title' do
+    assert_not_equal Block.new.default_title, ProfileListBlock.new.default_title
+  end
+
   should 'accept a limit of people to be displayed (and default to 6)' do
     block = ProfileListBlock.new
     assert_equal 6, block.limit
@@ -18,6 +18,10 @@ class RecentDocumentsBlockTest &lt; Test::Unit::TestCase
     assert_not_equal Block.description, RecentDocumentsBlock.description
   end
+  should 'provide a default title' do
+    assert_not_equal Block.new.default_title, RecentDocumentsBlock.new.default_title
+  end
+
   should 'output list with links to recent documents' do
     output = block.content
@@ -17,6 +17,10 @@ class TagsBlockTest &lt; Test::Unit::TestCase
     assert_not_equal Block.description, TagsBlock.description
   end
+  should 'provide a default title' do
+    assert_not_equal Block.new.default_title, TagsBlock.new.default_title
+  end
+
   should 'generate links to tags' do
     assert_match /profile\/testinguser\/tag\/first-tag/, block.content
     assert_match /profile\/testinguser\/tag\/second-tag/, block.content
	@@ -36,8 +36,4 @@ class ArticleBlock < Block		@@ -36,8 +36,4 @@ class ArticleBlock < Block
36	@article = obj	36	@article = obj
37	end	37	end
38		38
39	- def editable?
40	- true
41	- end
42	-
43	end	39	end
	@@ -47,7 +47,7 @@ class Block < ActiveRecord::Base		@@ -47,7 +47,7 @@ class Block < ActiveRecord::Base
47		47
48	# Is this block editable? (Default to <tt>false</tt>)	48	# Is this block editable? (Default to <tt>false</tt>)
49	def editable?	49	def editable?
50	- false	50	+ true
51	end	51	end
52		52
53	# must always return false, except on MainBlock clas.	53	# must always return false, except on MainBlock clas.
	@@ -63,4 +63,16 @@ class Block < ActiveRecord::Base		@@ -63,4 +63,16 @@ class Block < ActiveRecord::Base
63	self.class.name.underscore.gsub('_', '-')	63	self.class.name.underscore.gsub('_', '-')
64	end	64	end
65		65
		66	+ def default_title
		67	+ ''
		68	+ end
		69	+
		70	+ def title
		71	+ if self[:title].blank?
		72	+ self.default_title
		73	+ else
		74	+ self[:title]
		75	+ end
		76	+ end
		77	+
66	end	78	end
	@@ -4,7 +4,7 @@ class CommunitiesBlock < ProfileListBlock		@@ -4,7 +4,7 @@ class CommunitiesBlock < ProfileListBlock
4	_('A block that displays your communities')	4	_('A block that displays your communities')
5	end	5	end
6		6
7	- def title	7	+ def default_title
8	_('Communities')	8	_('Communities')
9	end	9	end
10		10
1	class EnterprisesBlock < ProfileListBlock	1	class EnterprisesBlock < ProfileListBlock
2		2
3	- def title	3	+ def default_title
4	_('Enterprises')	4	_('Enterprises')
5	end	5	end
6		6
1	class FavoriteEnterprisesBlock < ProfileListBlock	1	class FavoriteEnterprisesBlock < ProfileListBlock
2		2
3	- def title	3	+ def default_title
4	_('Favorite Enterprises')	4	_('Favorite Enterprises')
5	end	5	end
6		6
	@@ -4,7 +4,7 @@ class FriendsBlock < ProfileListBlock		@@ -4,7 +4,7 @@ class FriendsBlock < ProfileListBlock
4	_('A block that displays your friends')	4	_('A block that displays your friends')
5	end	5	end
6		6
7	- def title	7	+ def default_title
8	_('Friends')	8	_('Friends')
9	end	9	end
10		10
	@@ -12,4 +12,8 @@ class MainBlock < Block		@@ -12,4 +12,8 @@ class MainBlock < Block
12	true	12	true
13	end	13	end
14		14
		15	+ def editable?
		16	+ false
		17	+ end
		18	+
15	end	19	end
	@@ -4,7 +4,7 @@ class MembersBlock < ProfileListBlock		@@ -4,7 +4,7 @@ class MembersBlock < ProfileListBlock
4	_('A block that displays members.')	4	_('A block that displays members.')
5	end	5	end
6		6
7	- def title	7	+ def default_title
8	_('Members')	8	_('Members')
9	end	9	end
10		10
1	class PeopleBlock < ProfileListBlock	1	class PeopleBlock < ProfileListBlock
2		2
3	- def title	3	+ def default_title
4	_('People')	4	_('People')
5	end	5	end
6		6
	@@ -15,4 +15,8 @@ class ProfileInfoBlock < Block		@@ -15,4 +15,8 @@ class ProfileInfoBlock < Block
15	end	15	end
16	end	16	end
17		17
		18	+ def editable?
		19	+ false
		20	+ end
		21	+
18	end	22	end